]> git.baikalelectronics.ru Git - kernel.git/commitdiff
i915: Fix obj size vs. alignment for drm_pci_alloc()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 7 Sep 2017 14:32:03 +0000 (17:32 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 7 Sep 2017 17:12:36 +0000 (20:12 +0300)
drm_pci_alloc() refuses to cooperate if the passed alignment exceeds the
object size. So round up the obj size to the next power of two as well
to make this actually work.

Obviously things work just fine as long as the size was a power of two
to begin with. However kms_cursor_crc doesn't always use power of two
sizes so we hit a failure when we try to allocate the phys memory.

Testcase: igt/kms_cursor_crc
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20170907143203.13055-1-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/i915_gem.c

index 4dffebae56012cfa0f981288bae6fa0f495bf9a0..822719fa1b521c350a1c0ed142ca02949ec5b82a 100644 (file)
@@ -179,7 +179,7 @@ i915_gem_object_get_pages_phys(struct drm_i915_gem_object *obj)
         * the alignment of the buddy allocation will naturally match.
         */
        phys = drm_pci_alloc(obj->base.dev,
-                            obj->base.size,
+                            roundup_pow_of_two(obj->base.size),
                             roundup_pow_of_two(obj->base.size));
        if (!phys)
                return ERR_PTR(-ENOMEM);