]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dsa: realtek-smi: move to subdirectory
authorLuiz Angelo Daros de Luca <luizluca@gmail.com>
Fri, 28 Jan 2022 06:04:58 +0000 (03:04 -0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 28 Jan 2022 15:02:49 +0000 (15:02 +0000)
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Tested-by: Arınç ÜNAL <arinc.unal@arinc9.com>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
15 files changed:
MAINTAINERS
drivers/net/dsa/Kconfig
drivers/net/dsa/Makefile
drivers/net/dsa/realtek-smi-core.c [deleted file]
drivers/net/dsa/realtek-smi-core.h [deleted file]
drivers/net/dsa/realtek/Kconfig [new file with mode: 0644]
drivers/net/dsa/realtek/Makefile [new file with mode: 0644]
drivers/net/dsa/realtek/realtek-smi-core.c [new file with mode: 0644]
drivers/net/dsa/realtek/realtek-smi-core.h [new file with mode: 0644]
drivers/net/dsa/realtek/rtl8365mb.c [new file with mode: 0644]
drivers/net/dsa/realtek/rtl8366.c [new file with mode: 0644]
drivers/net/dsa/realtek/rtl8366rb.c [new file with mode: 0644]
drivers/net/dsa/rtl8365mb.c [deleted file]
drivers/net/dsa/rtl8366.c [deleted file]
drivers/net/dsa/rtl8366rb.c [deleted file]

index f41088418aae2514ad6d54f65fb37c0bec02b190..d58180870ebc4a122bf2dd475362f20f0d3b9e51 100644 (file)
@@ -16352,8 +16352,7 @@ REALTEK RTL83xx SMI DSA ROUTER CHIPS
 M:     Linus Walleij <linus.walleij@linaro.org>
 S:     Maintained
 F:     Documentation/devicetree/bindings/net/dsa/realtek-smi.txt
-F:     drivers/net/dsa/realtek-smi*
-F:     drivers/net/dsa/rtl83*
+F:     drivers/net/dsa/realtek/*
 
 REALTEK WIRELESS DRIVER (rtlwifi family)
 M:     Ping-Ke Shih <pkshih@realtek.com>
index 7b1457a6e327b01d5415c71dcd06ed4116234706..1251caf0f6387d03567b3c56f23194c8a63e1ef8 100644 (file)
@@ -67,17 +67,7 @@ config NET_DSA_QCA8K
          This enables support for the Qualcomm Atheros QCA8K Ethernet
          switch chips.
 
-config NET_DSA_REALTEK_SMI
-       tristate "Realtek SMI Ethernet switch family support"
-       select NET_DSA_TAG_RTL4_A
-       select NET_DSA_TAG_RTL8_4
-       select FIXED_PHY
-       select IRQ_DOMAIN
-       select REALTEK_PHY
-       select REGMAP
-       help
-         This enables support for the Realtek SMI-based switch
-         chips, currently only RTL8366RB.
+source "drivers/net/dsa/realtek/Kconfig"
 
 config NET_DSA_SMSC_LAN9303
        tristate
index 8da1569a34e6edbc5abc97244fff2c42d62cd98c..e73838c122560b0c3efe7e4246b6cdda08975c17 100644 (file)
@@ -9,8 +9,6 @@ obj-$(CONFIG_NET_DSA_LANTIQ_GSWIP) += lantiq_gswip.o
 obj-$(CONFIG_NET_DSA_MT7530)   += mt7530.o
 obj-$(CONFIG_NET_DSA_MV88E6060) += mv88e6060.o
 obj-$(CONFIG_NET_DSA_QCA8K)    += qca8k.o
-obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek-smi.o
-realtek-smi-objs               := realtek-smi-core.o rtl8366.o rtl8366rb.o rtl8365mb.o
 obj-$(CONFIG_NET_DSA_SMSC_LAN9303) += lan9303-core.o
 obj-$(CONFIG_NET_DSA_SMSC_LAN9303_I2C) += lan9303_i2c.o
 obj-$(CONFIG_NET_DSA_SMSC_LAN9303_MDIO) += lan9303_mdio.o
@@ -23,5 +21,6 @@ obj-y                         += microchip/
 obj-y                          += mv88e6xxx/
 obj-y                          += ocelot/
 obj-y                          += qca/
+obj-y                          += realtek/
 obj-y                          += sja1105/
 obj-y                          += xrs700x/
diff --git a/drivers/net/dsa/realtek-smi-core.c b/drivers/net/dsa/realtek-smi-core.c
deleted file mode 100644 (file)
index aae46ad..0000000
+++ /dev/null
@@ -1,523 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/* Realtek Simple Management Interface (SMI) driver
- * It can be discussed how "simple" this interface is.
- *
- * The SMI protocol piggy-backs the MDIO MDC and MDIO signals levels
- * but the protocol is not MDIO at all. Instead it is a Realtek
- * pecularity that need to bit-bang the lines in a special way to
- * communicate with the switch.
- *
- * ASICs we intend to support with this driver:
- *
- * RTL8366   - The original version, apparently
- * RTL8369   - Similar enough to have the same datsheet as RTL8366
- * RTL8366RB - Probably reads out "RTL8366 revision B", has a quite
- *             different register layout from the other two
- * RTL8366S  - Is this "RTL8366 super"?
- * RTL8367   - Has an OpenWRT driver as well
- * RTL8368S  - Seems to be an alternative name for RTL8366RB
- * RTL8370   - Also uses SMI
- *
- * Copyright (C) 2017 Linus Walleij <linus.walleij@linaro.org>
- * Copyright (C) 2010 Antti Seppälä <a.seppala@gmail.com>
- * Copyright (C) 2010 Roman Yeryomin <roman@advem.lv>
- * Copyright (C) 2011 Colin Leitner <colin.leitner@googlemail.com>
- * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
- */
-
-#include <linux/kernel.h>
-#include <linux/module.h>
-#include <linux/device.h>
-#include <linux/spinlock.h>
-#include <linux/skbuff.h>
-#include <linux/of.h>
-#include <linux/of_device.h>
-#include <linux/of_mdio.h>
-#include <linux/delay.h>
-#include <linux/gpio/consumer.h>
-#include <linux/platform_device.h>
-#include <linux/regmap.h>
-#include <linux/bitops.h>
-#include <linux/if_bridge.h>
-
-#include "realtek-smi-core.h"
-
-#define REALTEK_SMI_ACK_RETRY_COUNT            5
-#define REALTEK_SMI_HW_STOP_DELAY              25      /* msecs */
-#define REALTEK_SMI_HW_START_DELAY             100     /* msecs */
-
-static inline void realtek_smi_clk_delay(struct realtek_smi *smi)
-{
-       ndelay(smi->clk_delay);
-}
-
-static void realtek_smi_start(struct realtek_smi *smi)
-{
-       /* Set GPIO pins to output mode, with initial state:
-        * SCK = 0, SDA = 1
-        */
-       gpiod_direction_output(smi->mdc, 0);
-       gpiod_direction_output(smi->mdio, 1);
-       realtek_smi_clk_delay(smi);
-
-       /* CLK 1: 0 -> 1, 1 -> 0 */
-       gpiod_set_value(smi->mdc, 1);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdc, 0);
-       realtek_smi_clk_delay(smi);
-
-       /* CLK 2: */
-       gpiod_set_value(smi->mdc, 1);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdio, 0);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdc, 0);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdio, 1);
-}
-
-static void realtek_smi_stop(struct realtek_smi *smi)
-{
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdio, 0);
-       gpiod_set_value(smi->mdc, 1);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdio, 1);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdc, 1);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdc, 0);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdc, 1);
-
-       /* Add a click */
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdc, 0);
-       realtek_smi_clk_delay(smi);
-       gpiod_set_value(smi->mdc, 1);
-
-       /* Set GPIO pins to input mode */
-       gpiod_direction_input(smi->mdio);
-       gpiod_direction_input(smi->mdc);
-}
-
-static void realtek_smi_write_bits(struct realtek_smi *smi, u32 data, u32 len)
-{
-       for (; len > 0; len--) {
-               realtek_smi_clk_delay(smi);
-
-               /* Prepare data */
-               gpiod_set_value(smi->mdio, !!(data & (1 << (len - 1))));
-               realtek_smi_clk_delay(smi);
-
-               /* Clocking */
-               gpiod_set_value(smi->mdc, 1);
-               realtek_smi_clk_delay(smi);
-               gpiod_set_value(smi->mdc, 0);
-       }
-}
-
-static void realtek_smi_read_bits(struct realtek_smi *smi, u32 len, u32 *data)
-{
-       gpiod_direction_input(smi->mdio);
-
-       for (*data = 0; len > 0; len--) {
-               u32 u;
-
-               realtek_smi_clk_delay(smi);
-
-               /* Clocking */
-               gpiod_set_value(smi->mdc, 1);
-               realtek_smi_clk_delay(smi);
-               u = !!gpiod_get_value(smi->mdio);
-               gpiod_set_value(smi->mdc, 0);
-
-               *data |= (u << (len - 1));
-       }
-
-       gpiod_direction_output(smi->mdio, 0);
-}
-
-static int realtek_smi_wait_for_ack(struct realtek_smi *smi)
-{
-       int retry_cnt;
-
-       retry_cnt = 0;
-       do {
-               u32 ack;
-
-               realtek_smi_read_bits(smi, 1, &ack);
-               if (ack == 0)
-                       break;
-
-               if (++retry_cnt > REALTEK_SMI_ACK_RETRY_COUNT) {
-                       dev_err(smi->dev, "ACK timeout\n");
-                       return -ETIMEDOUT;
-               }
-       } while (1);
-
-       return 0;
-}
-
-static int realtek_smi_write_byte(struct realtek_smi *smi, u8 data)
-{
-       realtek_smi_write_bits(smi, data, 8);
-       return realtek_smi_wait_for_ack(smi);
-}
-
-static int realtek_smi_write_byte_noack(struct realtek_smi *smi, u8 data)
-{
-       realtek_smi_write_bits(smi, data, 8);
-       return 0;
-}
-
-static int realtek_smi_read_byte0(struct realtek_smi *smi, u8 *data)
-{
-       u32 t;
-
-       /* Read data */
-       realtek_smi_read_bits(smi, 8, &t);
-       *data = (t & 0xff);
-
-       /* Send an ACK */
-       realtek_smi_write_bits(smi, 0x00, 1);
-
-       return 0;
-}
-
-static int realtek_smi_read_byte1(struct realtek_smi *smi, u8 *data)
-{
-       u32 t;
-
-       /* Read data */
-       realtek_smi_read_bits(smi, 8, &t);
-       *data = (t & 0xff);
-
-       /* Send an ACK */
-       realtek_smi_write_bits(smi, 0x01, 1);
-
-       return 0;
-}
-
-static int realtek_smi_read_reg(struct realtek_smi *smi, u32 addr, u32 *data)
-{
-       unsigned long flags;
-       u8 lo = 0;
-       u8 hi = 0;
-       int ret;
-
-       spin_lock_irqsave(&smi->lock, flags);
-
-       realtek_smi_start(smi);
-
-       /* Send READ command */
-       ret = realtek_smi_write_byte(smi, smi->cmd_read);
-       if (ret)
-               goto out;
-
-       /* Set ADDR[7:0] */
-       ret = realtek_smi_write_byte(smi, addr & 0xff);
-       if (ret)
-               goto out;
-
-       /* Set ADDR[15:8] */
-       ret = realtek_smi_write_byte(smi, addr >> 8);
-       if (ret)
-               goto out;
-
-       /* Read DATA[7:0] */
-       realtek_smi_read_byte0(smi, &lo);
-       /* Read DATA[15:8] */
-       realtek_smi_read_byte1(smi, &hi);
-
-       *data = ((u32)lo) | (((u32)hi) << 8);
-
-       ret = 0;
-
- out:
-       realtek_smi_stop(smi);
-       spin_unlock_irqrestore(&smi->lock, flags);
-
-       return ret;
-}
-
-static int realtek_smi_write_reg(struct realtek_smi *smi,
-                                u32 addr, u32 data, bool ack)
-{
-       unsigned long flags;
-       int ret;
-
-       spin_lock_irqsave(&smi->lock, flags);
-
-       realtek_smi_start(smi);
-
-       /* Send WRITE command */
-       ret = realtek_smi_write_byte(smi, smi->cmd_write);
-       if (ret)
-               goto out;
-
-       /* Set ADDR[7:0] */
-       ret = realtek_smi_write_byte(smi, addr & 0xff);
-       if (ret)
-               goto out;
-
-       /* Set ADDR[15:8] */
-       ret = realtek_smi_write_byte(smi, addr >> 8);
-       if (ret)
-               goto out;
-
-       /* Write DATA[7:0] */
-       ret = realtek_smi_write_byte(smi, data & 0xff);
-       if (ret)
-               goto out;
-
-       /* Write DATA[15:8] */
-       if (ack)
-               ret = realtek_smi_write_byte(smi, data >> 8);
-       else
-               ret = realtek_smi_write_byte_noack(smi, data >> 8);
-       if (ret)
-               goto out;
-
-       ret = 0;
-
- out:
-       realtek_smi_stop(smi);
-       spin_unlock_irqrestore(&smi->lock, flags);
-
-       return ret;
-}
-
-/* There is one single case when we need to use this accessor and that
- * is when issueing soft reset. Since the device reset as soon as we write
- * that bit, no ACK will come back for natural reasons.
- */
-int realtek_smi_write_reg_noack(struct realtek_smi *smi, u32 addr,
-                               u32 data)
-{
-       return realtek_smi_write_reg(smi, addr, data, false);
-}
-EXPORT_SYMBOL_GPL(realtek_smi_write_reg_noack);
-
-/* Regmap accessors */
-
-static int realtek_smi_write(void *ctx, u32 reg, u32 val)
-{
-       struct realtek_smi *smi = ctx;
-
-       return realtek_smi_write_reg(smi, reg, val, true);
-}
-
-static int realtek_smi_read(void *ctx, u32 reg, u32 *val)
-{
-       struct realtek_smi *smi = ctx;
-
-       return realtek_smi_read_reg(smi, reg, val);
-}
-
-static const struct regmap_config realtek_smi_mdio_regmap_config = {
-       .reg_bits = 10, /* A4..A0 R4..R0 */
-       .val_bits = 16,
-       .reg_stride = 1,
-       /* PHY regs are at 0x8000 */
-       .max_register = 0xffff,
-       .reg_format_endian = REGMAP_ENDIAN_BIG,
-       .reg_read = realtek_smi_read,
-       .reg_write = realtek_smi_write,
-       .cache_type = REGCACHE_NONE,
-};
-
-static int realtek_smi_mdio_read(struct mii_bus *bus, int addr, int regnum)
-{
-       struct realtek_smi *smi = bus->priv;
-
-       return smi->ops->phy_read(smi, addr, regnum);
-}
-
-static int realtek_smi_mdio_write(struct mii_bus *bus, int addr, int regnum,
-                                 u16 val)
-{
-       struct realtek_smi *smi = bus->priv;
-
-       return smi->ops->phy_write(smi, addr, regnum, val);
-}
-
-int realtek_smi_setup_mdio(struct realtek_smi *smi)
-{
-       struct device_node *mdio_np;
-       int ret;
-
-       mdio_np = of_get_compatible_child(smi->dev->of_node, "realtek,smi-mdio");
-       if (!mdio_np) {
-               dev_err(smi->dev, "no MDIO bus node\n");
-               return -ENODEV;
-       }
-
-       smi->slave_mii_bus = devm_mdiobus_alloc(smi->dev);
-       if (!smi->slave_mii_bus) {
-               ret = -ENOMEM;
-               goto err_put_node;
-       }
-       smi->slave_mii_bus->priv = smi;
-       smi->slave_mii_bus->name = "SMI slave MII";
-       smi->slave_mii_bus->read = realtek_smi_mdio_read;
-       smi->slave_mii_bus->write = realtek_smi_mdio_write;
-       snprintf(smi->slave_mii_bus->id, MII_BUS_ID_SIZE, "SMI-%d",
-                smi->ds->index);
-       smi->slave_mii_bus->dev.of_node = mdio_np;
-       smi->slave_mii_bus->parent = smi->dev;
-       smi->ds->slave_mii_bus = smi->slave_mii_bus;
-
-       ret = devm_of_mdiobus_register(smi->dev, smi->slave_mii_bus, mdio_np);
-       if (ret) {
-               dev_err(smi->dev, "unable to register MDIO bus %s\n",
-                       smi->slave_mii_bus->id);
-               goto err_put_node;
-       }
-
-       return 0;
-
-err_put_node:
-       of_node_put(mdio_np);
-
-       return ret;
-}
-
-static int realtek_smi_probe(struct platform_device *pdev)
-{
-       const struct realtek_smi_variant *var;
-       struct device *dev = &pdev->dev;
-       struct realtek_smi *smi;
-       struct device_node *np;
-       int ret;
-
-       var = of_device_get_match_data(dev);
-       np = dev->of_node;
-
-       smi = devm_kzalloc(dev, sizeof(*smi) + var->chip_data_sz, GFP_KERNEL);
-       if (!smi)
-               return -ENOMEM;
-       smi->chip_data = (void *)smi + sizeof(*smi);
-       smi->map = devm_regmap_init(dev, NULL, smi,
-                                   &realtek_smi_mdio_regmap_config);
-       if (IS_ERR(smi->map)) {
-               ret = PTR_ERR(smi->map);
-               dev_err(dev, "regmap init failed: %d\n", ret);
-               return ret;
-       }
-
-       /* Link forward and backward */
-       smi->dev = dev;
-       smi->clk_delay = var->clk_delay;
-       smi->cmd_read = var->cmd_read;
-       smi->cmd_write = var->cmd_write;
-       smi->ops = var->ops;
-
-       dev_set_drvdata(dev, smi);
-       spin_lock_init(&smi->lock);
-
-       /* TODO: if power is software controlled, set up any regulators here */
-
-       /* Assert then deassert RESET */
-       smi->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(smi->reset)) {
-               dev_err(dev, "failed to get RESET GPIO\n");
-               return PTR_ERR(smi->reset);
-       }
-       msleep(REALTEK_SMI_HW_STOP_DELAY);
-       gpiod_set_value(smi->reset, 0);
-       msleep(REALTEK_SMI_HW_START_DELAY);
-       dev_info(dev, "deasserted RESET\n");
-
-       /* Fetch MDIO pins */
-       smi->mdc = devm_gpiod_get_optional(dev, "mdc", GPIOD_OUT_LOW);
-       if (IS_ERR(smi->mdc))
-               return PTR_ERR(smi->mdc);
-       smi->mdio = devm_gpiod_get_optional(dev, "mdio", GPIOD_OUT_LOW);
-       if (IS_ERR(smi->mdio))
-               return PTR_ERR(smi->mdio);
-
-       smi->leds_disabled = of_property_read_bool(np, "realtek,disable-leds");
-
-       ret = smi->ops->detect(smi);
-       if (ret) {
-               dev_err(dev, "unable to detect switch\n");
-               return ret;
-       }
-
-       smi->ds = devm_kzalloc(dev, sizeof(*smi->ds), GFP_KERNEL);
-       if (!smi->ds)
-               return -ENOMEM;
-
-       smi->ds->dev = dev;
-       smi->ds->num_ports = smi->num_ports;
-       smi->ds->priv = smi;
-
-       smi->ds->ops = var->ds_ops;
-       ret = dsa_register_switch(smi->ds);
-       if (ret) {
-               dev_err_probe(dev, ret, "unable to register switch\n");
-               return ret;
-       }
-       return 0;
-}
-
-static int realtek_smi_remove(struct platform_device *pdev)
-{
-       struct realtek_smi *smi = platform_get_drvdata(pdev);
-
-       if (!smi)
-               return 0;
-
-       dsa_unregister_switch(smi->ds);
-       if (smi->slave_mii_bus)
-               of_node_put(smi->slave_mii_bus->dev.of_node);
-       gpiod_set_value(smi->reset, 1);
-
-       platform_set_drvdata(pdev, NULL);
-
-       return 0;
-}
-
-static void realtek_smi_shutdown(struct platform_device *pdev)
-{
-       struct realtek_smi *smi = platform_get_drvdata(pdev);
-
-       if (!smi)
-               return;
-
-       dsa_switch_shutdown(smi->ds);
-
-       platform_set_drvdata(pdev, NULL);
-}
-
-static const struct of_device_id realtek_smi_of_match[] = {
-       {
-               .compatible = "realtek,rtl8366rb",
-               .data = &rtl8366rb_variant,
-       },
-       {
-               /* FIXME: add support for RTL8366S and more */
-               .compatible = "realtek,rtl8366s",
-               .data = NULL,
-       },
-       {
-               .compatible = "realtek,rtl8365mb",
-               .data = &rtl8365mb_variant,
-       },
-       { /* sentinel */ },
-};
-MODULE_DEVICE_TABLE(of, realtek_smi_of_match);
-
-static struct platform_driver realtek_smi_driver = {
-       .driver = {
-               .name = "realtek-smi",
-               .of_match_table = of_match_ptr(realtek_smi_of_match),
-       },
-       .probe  = realtek_smi_probe,
-       .remove = realtek_smi_remove,
-       .shutdown = realtek_smi_shutdown,
-};
-module_platform_driver(realtek_smi_driver);
-
-MODULE_LICENSE("GPL");
diff --git a/drivers/net/dsa/realtek-smi-core.h b/drivers/net/dsa/realtek-smi-core.h
deleted file mode 100644 (file)
index faed387..0000000
+++ /dev/null
@@ -1,145 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/* Realtek SMI interface driver defines
- *
- * Copyright (C) 2017 Linus Walleij <linus.walleij@linaro.org>
- * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
- */
-
-#ifndef _REALTEK_SMI_H
-#define _REALTEK_SMI_H
-
-#include <linux/phy.h>
-#include <linux/platform_device.h>
-#include <linux/gpio/consumer.h>
-#include <net/dsa.h>
-
-struct realtek_smi_ops;
-struct dentry;
-struct inode;
-struct file;
-
-struct rtl8366_mib_counter {
-       unsigned int    base;
-       unsigned int    offset;
-       unsigned int    length;
-       const char      *name;
-};
-
-/*
- * struct rtl8366_vlan_mc - Virtual LAN member configuration
- */
-struct rtl8366_vlan_mc {
-       u16     vid;
-       u16     untag;
-       u16     member;
-       u8      fid;
-       u8      priority;
-};
-
-struct rtl8366_vlan_4k {
-       u16     vid;
-       u16     untag;
-       u16     member;
-       u8      fid;
-};
-
-struct realtek_smi {
-       struct device           *dev;
-       struct gpio_desc        *reset;
-       struct gpio_desc        *mdc;
-       struct gpio_desc        *mdio;
-       struct regmap           *map;
-       struct mii_bus          *slave_mii_bus;
-
-       unsigned int            clk_delay;
-       u8                      cmd_read;
-       u8                      cmd_write;
-       spinlock_t              lock; /* Locks around command writes */
-       struct dsa_switch       *ds;
-       struct irq_domain       *irqdomain;
-       bool                    leds_disabled;
-
-       unsigned int            cpu_port;
-       unsigned int            num_ports;
-       unsigned int            num_vlan_mc;
-       unsigned int            num_mib_counters;
-       struct rtl8366_mib_counter *mib_counters;
-
-       const struct realtek_smi_ops *ops;
-
-       int                     vlan_enabled;
-       int                     vlan4k_enabled;
-
-       char                    buf[4096];
-       void                    *chip_data; /* Per-chip extra variant data */
-};
-
-/*
- * struct realtek_smi_ops - vtable for the per-SMI-chiptype operations
- * @detect: detects the chiptype
- */
-struct realtek_smi_ops {
-       int     (*detect)(struct realtek_smi *smi);
-       int     (*reset_chip)(struct realtek_smi *smi);
-       int     (*setup)(struct realtek_smi *smi);
-       void    (*cleanup)(struct realtek_smi *smi);
-       int     (*get_mib_counter)(struct realtek_smi *smi,
-                                  int port,
-                                  struct rtl8366_mib_counter *mib,
-                                  u64 *mibvalue);
-       int     (*get_vlan_mc)(struct realtek_smi *smi, u32 index,
-                              struct rtl8366_vlan_mc *vlanmc);
-       int     (*set_vlan_mc)(struct realtek_smi *smi, u32 index,
-                              const struct rtl8366_vlan_mc *vlanmc);
-       int     (*get_vlan_4k)(struct realtek_smi *smi, u32 vid,
-                              struct rtl8366_vlan_4k *vlan4k);
-       int     (*set_vlan_4k)(struct realtek_smi *smi,
-                              const struct rtl8366_vlan_4k *vlan4k);
-       int     (*get_mc_index)(struct realtek_smi *smi, int port, int *val);
-       int     (*set_mc_index)(struct realtek_smi *smi, int port, int index);
-       bool    (*is_vlan_valid)(struct realtek_smi *smi, unsigned int vlan);
-       int     (*enable_vlan)(struct realtek_smi *smi, bool enable);
-       int     (*enable_vlan4k)(struct realtek_smi *smi, bool enable);
-       int     (*enable_port)(struct realtek_smi *smi, int port, bool enable);
-       int     (*phy_read)(struct realtek_smi *smi, int phy, int regnum);
-       int     (*phy_write)(struct realtek_smi *smi, int phy, int regnum,
-                            u16 val);
-};
-
-struct realtek_smi_variant {
-       const struct dsa_switch_ops *ds_ops;
-       const struct realtek_smi_ops *ops;
-       unsigned int clk_delay;
-       u8 cmd_read;
-       u8 cmd_write;
-       size_t chip_data_sz;
-};
-
-/* SMI core calls */
-int realtek_smi_write_reg_noack(struct realtek_smi *smi, u32 addr,
-                               u32 data);
-int realtek_smi_setup_mdio(struct realtek_smi *smi);
-
-/* RTL8366 library helpers */
-int rtl8366_mc_is_used(struct realtek_smi *smi, int mc_index, int *used);
-int rtl8366_set_vlan(struct realtek_smi *smi, int vid, u32 member,
-                    u32 untag, u32 fid);
-int rtl8366_set_pvid(struct realtek_smi *smi, unsigned int port,
-                    unsigned int vid);
-int rtl8366_enable_vlan4k(struct realtek_smi *smi, bool enable);
-int rtl8366_enable_vlan(struct realtek_smi *smi, bool enable);
-int rtl8366_reset_vlan(struct realtek_smi *smi);
-int rtl8366_vlan_add(struct dsa_switch *ds, int port,
-                    const struct switchdev_obj_port_vlan *vlan,
-                    struct netlink_ext_ack *extack);
-int rtl8366_vlan_del(struct dsa_switch *ds, int port,
-                    const struct switchdev_obj_port_vlan *vlan);
-void rtl8366_get_strings(struct dsa_switch *ds, int port, u32 stringset,
-                        uint8_t *data);
-int rtl8366_get_sset_count(struct dsa_switch *ds, int port, int sset);
-void rtl8366_get_ethtool_stats(struct dsa_switch *ds, int port, uint64_t *data);
-
-extern const struct realtek_smi_variant rtl8366rb_variant;
-extern const struct realtek_smi_variant rtl8365mb_variant;
-
-#endif /*  _REALTEK_SMI_H */
diff --git a/drivers/net/dsa/realtek/Kconfig b/drivers/net/dsa/realtek/Kconfig
new file mode 100644 (file)
index 0000000..1c62212
--- /dev/null
@@ -0,0 +1,20 @@
+# SPDX-License-Identifier: GPL-2.0-only
+menuconfig NET_DSA_REALTEK
+       tristate "Realtek Ethernet switch family support"
+       depends on NET_DSA
+       select NET_DSA_TAG_RTL4_A
+       select NET_DSA_TAG_RTL8_4
+       select FIXED_PHY
+       select IRQ_DOMAIN
+       select REALTEK_PHY
+       select REGMAP
+       help
+         Select to enable support for Realtek Ethernet switch chips.
+
+config NET_DSA_REALTEK_SMI
+       tristate "Realtek SMI connected switch driver"
+       depends on NET_DSA_REALTEK
+       default y
+       help
+         Select to enable support for registering switches connected
+         through SMI.
diff --git a/drivers/net/dsa/realtek/Makefile b/drivers/net/dsa/realtek/Makefile
new file mode 100644 (file)
index 0000000..323b921
--- /dev/null
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+obj-$(CONFIG_NET_DSA_REALTEK_SMI)      += realtek-smi.o
+realtek-smi-objs                       := realtek-smi-core.o rtl8366.o rtl8366rb.o rtl8365mb.o
diff --git a/drivers/net/dsa/realtek/realtek-smi-core.c b/drivers/net/dsa/realtek/realtek-smi-core.c
new file mode 100644 (file)
index 0000000..aae46ad
--- /dev/null
@@ -0,0 +1,523 @@
+// SPDX-License-Identifier: GPL-2.0+
+/* Realtek Simple Management Interface (SMI) driver
+ * It can be discussed how "simple" this interface is.
+ *
+ * The SMI protocol piggy-backs the MDIO MDC and MDIO signals levels
+ * but the protocol is not MDIO at all. Instead it is a Realtek
+ * pecularity that need to bit-bang the lines in a special way to
+ * communicate with the switch.
+ *
+ * ASICs we intend to support with this driver:
+ *
+ * RTL8366   - The original version, apparently
+ * RTL8369   - Similar enough to have the same datsheet as RTL8366
+ * RTL8366RB - Probably reads out "RTL8366 revision B", has a quite
+ *             different register layout from the other two
+ * RTL8366S  - Is this "RTL8366 super"?
+ * RTL8367   - Has an OpenWRT driver as well
+ * RTL8368S  - Seems to be an alternative name for RTL8366RB
+ * RTL8370   - Also uses SMI
+ *
+ * Copyright (C) 2017 Linus Walleij <linus.walleij@linaro.org>
+ * Copyright (C) 2010 Antti Seppälä <a.seppala@gmail.com>
+ * Copyright (C) 2010 Roman Yeryomin <roman@advem.lv>
+ * Copyright (C) 2011 Colin Leitner <colin.leitner@googlemail.com>
+ * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
+ */
+
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/device.h>
+#include <linux/spinlock.h>
+#include <linux/skbuff.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/of_mdio.h>
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/bitops.h>
+#include <linux/if_bridge.h>
+
+#include "realtek-smi-core.h"
+
+#define REALTEK_SMI_ACK_RETRY_COUNT            5
+#define REALTEK_SMI_HW_STOP_DELAY              25      /* msecs */
+#define REALTEK_SMI_HW_START_DELAY             100     /* msecs */
+
+static inline void realtek_smi_clk_delay(struct realtek_smi *smi)
+{
+       ndelay(smi->clk_delay);
+}
+
+static void realtek_smi_start(struct realtek_smi *smi)
+{
+       /* Set GPIO pins to output mode, with initial state:
+        * SCK = 0, SDA = 1
+        */
+       gpiod_direction_output(smi->mdc, 0);
+       gpiod_direction_output(smi->mdio, 1);
+       realtek_smi_clk_delay(smi);
+
+       /* CLK 1: 0 -> 1, 1 -> 0 */
+       gpiod_set_value(smi->mdc, 1);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdc, 0);
+       realtek_smi_clk_delay(smi);
+
+       /* CLK 2: */
+       gpiod_set_value(smi->mdc, 1);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdio, 0);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdc, 0);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdio, 1);
+}
+
+static void realtek_smi_stop(struct realtek_smi *smi)
+{
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdio, 0);
+       gpiod_set_value(smi->mdc, 1);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdio, 1);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdc, 1);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdc, 0);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdc, 1);
+
+       /* Add a click */
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdc, 0);
+       realtek_smi_clk_delay(smi);
+       gpiod_set_value(smi->mdc, 1);
+
+       /* Set GPIO pins to input mode */
+       gpiod_direction_input(smi->mdio);
+       gpiod_direction_input(smi->mdc);
+}
+
+static void realtek_smi_write_bits(struct realtek_smi *smi, u32 data, u32 len)
+{
+       for (; len > 0; len--) {
+               realtek_smi_clk_delay(smi);
+
+               /* Prepare data */
+               gpiod_set_value(smi->mdio, !!(data & (1 << (len - 1))));
+               realtek_smi_clk_delay(smi);
+
+               /* Clocking */
+               gpiod_set_value(smi->mdc, 1);
+               realtek_smi_clk_delay(smi);
+               gpiod_set_value(smi->mdc, 0);
+       }
+}
+
+static void realtek_smi_read_bits(struct realtek_smi *smi, u32 len, u32 *data)
+{
+       gpiod_direction_input(smi->mdio);
+
+       for (*data = 0; len > 0; len--) {
+               u32 u;
+
+               realtek_smi_clk_delay(smi);
+
+               /* Clocking */
+               gpiod_set_value(smi->mdc, 1);
+               realtek_smi_clk_delay(smi);
+               u = !!gpiod_get_value(smi->mdio);
+               gpiod_set_value(smi->mdc, 0);
+
+               *data |= (u << (len - 1));
+       }
+
+       gpiod_direction_output(smi->mdio, 0);
+}
+
+static int realtek_smi_wait_for_ack(struct realtek_smi *smi)
+{
+       int retry_cnt;
+
+       retry_cnt = 0;
+       do {
+               u32 ack;
+
+               realtek_smi_read_bits(smi, 1, &ack);
+               if (ack == 0)
+                       break;
+
+               if (++retry_cnt > REALTEK_SMI_ACK_RETRY_COUNT) {
+                       dev_err(smi->dev, "ACK timeout\n");
+                       return -ETIMEDOUT;
+               }
+       } while (1);
+
+       return 0;
+}
+
+static int realtek_smi_write_byte(struct realtek_smi *smi, u8 data)
+{
+       realtek_smi_write_bits(smi, data, 8);
+       return realtek_smi_wait_for_ack(smi);
+}
+
+static int realtek_smi_write_byte_noack(struct realtek_smi *smi, u8 data)
+{
+       realtek_smi_write_bits(smi, data, 8);
+       return 0;
+}
+
+static int realtek_smi_read_byte0(struct realtek_smi *smi, u8 *data)
+{
+       u32 t;
+
+       /* Read data */
+       realtek_smi_read_bits(smi, 8, &t);
+       *data = (t & 0xff);
+
+       /* Send an ACK */
+       realtek_smi_write_bits(smi, 0x00, 1);
+
+       return 0;
+}
+
+static int realtek_smi_read_byte1(struct realtek_smi *smi, u8 *data)
+{
+       u32 t;
+
+       /* Read data */
+       realtek_smi_read_bits(smi, 8, &t);
+       *data = (t & 0xff);
+
+       /* Send an ACK */
+       realtek_smi_write_bits(smi, 0x01, 1);
+
+       return 0;
+}
+
+static int realtek_smi_read_reg(struct realtek_smi *smi, u32 addr, u32 *data)
+{
+       unsigned long flags;
+       u8 lo = 0;
+       u8 hi = 0;
+       int ret;
+
+       spin_lock_irqsave(&smi->lock, flags);
+
+       realtek_smi_start(smi);
+
+       /* Send READ command */
+       ret = realtek_smi_write_byte(smi, smi->cmd_read);
+       if (ret)
+               goto out;
+
+       /* Set ADDR[7:0] */
+       ret = realtek_smi_write_byte(smi, addr & 0xff);
+       if (ret)
+               goto out;
+
+       /* Set ADDR[15:8] */
+       ret = realtek_smi_write_byte(smi, addr >> 8);
+       if (ret)
+               goto out;
+
+       /* Read DATA[7:0] */
+       realtek_smi_read_byte0(smi, &lo);
+       /* Read DATA[15:8] */
+       realtek_smi_read_byte1(smi, &hi);
+
+       *data = ((u32)lo) | (((u32)hi) << 8);
+
+       ret = 0;
+
+ out:
+       realtek_smi_stop(smi);
+       spin_unlock_irqrestore(&smi->lock, flags);
+
+       return ret;
+}
+
+static int realtek_smi_write_reg(struct realtek_smi *smi,
+                                u32 addr, u32 data, bool ack)
+{
+       unsigned long flags;
+       int ret;
+
+       spin_lock_irqsave(&smi->lock, flags);
+
+       realtek_smi_start(smi);
+
+       /* Send WRITE command */
+       ret = realtek_smi_write_byte(smi, smi->cmd_write);
+       if (ret)
+               goto out;
+
+       /* Set ADDR[7:0] */
+       ret = realtek_smi_write_byte(smi, addr & 0xff);
+       if (ret)
+               goto out;
+
+       /* Set ADDR[15:8] */
+       ret = realtek_smi_write_byte(smi, addr >> 8);
+       if (ret)
+               goto out;
+
+       /* Write DATA[7:0] */
+       ret = realtek_smi_write_byte(smi, data & 0xff);
+       if (ret)
+               goto out;
+
+       /* Write DATA[15:8] */
+       if (ack)
+               ret = realtek_smi_write_byte(smi, data >> 8);
+       else
+               ret = realtek_smi_write_byte_noack(smi, data >> 8);
+       if (ret)
+               goto out;
+
+       ret = 0;
+
+ out:
+       realtek_smi_stop(smi);
+       spin_unlock_irqrestore(&smi->lock, flags);
+
+       return ret;
+}
+
+/* There is one single case when we need to use this accessor and that
+ * is when issueing soft reset. Since the device reset as soon as we write
+ * that bit, no ACK will come back for natural reasons.
+ */
+int realtek_smi_write_reg_noack(struct realtek_smi *smi, u32 addr,
+                               u32 data)
+{
+       return realtek_smi_write_reg(smi, addr, data, false);
+}
+EXPORT_SYMBOL_GPL(realtek_smi_write_reg_noack);
+
+/* Regmap accessors */
+
+static int realtek_smi_write(void *ctx, u32 reg, u32 val)
+{
+       struct realtek_smi *smi = ctx;
+
+       return realtek_smi_write_reg(smi, reg, val, true);
+}
+
+static int realtek_smi_read(void *ctx, u32 reg, u32 *val)
+{
+       struct realtek_smi *smi = ctx;
+
+       return realtek_smi_read_reg(smi, reg, val);
+}
+
+static const struct regmap_config realtek_smi_mdio_regmap_config = {
+       .reg_bits = 10, /* A4..A0 R4..R0 */
+       .val_bits = 16,
+       .reg_stride = 1,
+       /* PHY regs are at 0x8000 */
+       .max_register = 0xffff,
+       .reg_format_endian = REGMAP_ENDIAN_BIG,
+       .reg_read = realtek_smi_read,
+       .reg_write = realtek_smi_write,
+       .cache_type = REGCACHE_NONE,
+};
+
+static int realtek_smi_mdio_read(struct mii_bus *bus, int addr, int regnum)
+{
+       struct realtek_smi *smi = bus->priv;
+
+       return smi->ops->phy_read(smi, addr, regnum);
+}
+
+static int realtek_smi_mdio_write(struct mii_bus *bus, int addr, int regnum,
+                                 u16 val)
+{
+       struct realtek_smi *smi = bus->priv;
+
+       return smi->ops->phy_write(smi, addr, regnum, val);
+}
+
+int realtek_smi_setup_mdio(struct realtek_smi *smi)
+{
+       struct device_node *mdio_np;
+       int ret;
+
+       mdio_np = of_get_compatible_child(smi->dev->of_node, "realtek,smi-mdio");
+       if (!mdio_np) {
+               dev_err(smi->dev, "no MDIO bus node\n");
+               return -ENODEV;
+       }
+
+       smi->slave_mii_bus = devm_mdiobus_alloc(smi->dev);
+       if (!smi->slave_mii_bus) {
+               ret = -ENOMEM;
+               goto err_put_node;
+       }
+       smi->slave_mii_bus->priv = smi;
+       smi->slave_mii_bus->name = "SMI slave MII";
+       smi->slave_mii_bus->read = realtek_smi_mdio_read;
+       smi->slave_mii_bus->write = realtek_smi_mdio_write;
+       snprintf(smi->slave_mii_bus->id, MII_BUS_ID_SIZE, "SMI-%d",
+                smi->ds->index);
+       smi->slave_mii_bus->dev.of_node = mdio_np;
+       smi->slave_mii_bus->parent = smi->dev;
+       smi->ds->slave_mii_bus = smi->slave_mii_bus;
+
+       ret = devm_of_mdiobus_register(smi->dev, smi->slave_mii_bus, mdio_np);
+       if (ret) {
+               dev_err(smi->dev, "unable to register MDIO bus %s\n",
+                       smi->slave_mii_bus->id);
+               goto err_put_node;
+       }
+
+       return 0;
+
+err_put_node:
+       of_node_put(mdio_np);
+
+       return ret;
+}
+
+static int realtek_smi_probe(struct platform_device *pdev)
+{
+       const struct realtek_smi_variant *var;
+       struct device *dev = &pdev->dev;
+       struct realtek_smi *smi;
+       struct device_node *np;
+       int ret;
+
+       var = of_device_get_match_data(dev);
+       np = dev->of_node;
+
+       smi = devm_kzalloc(dev, sizeof(*smi) + var->chip_data_sz, GFP_KERNEL);
+       if (!smi)
+               return -ENOMEM;
+       smi->chip_data = (void *)smi + sizeof(*smi);
+       smi->map = devm_regmap_init(dev, NULL, smi,
+                                   &realtek_smi_mdio_regmap_config);
+       if (IS_ERR(smi->map)) {
+               ret = PTR_ERR(smi->map);
+               dev_err(dev, "regmap init failed: %d\n", ret);
+               return ret;
+       }
+
+       /* Link forward and backward */
+       smi->dev = dev;
+       smi->clk_delay = var->clk_delay;
+       smi->cmd_read = var->cmd_read;
+       smi->cmd_write = var->cmd_write;
+       smi->ops = var->ops;
+
+       dev_set_drvdata(dev, smi);
+       spin_lock_init(&smi->lock);
+
+       /* TODO: if power is software controlled, set up any regulators here */
+
+       /* Assert then deassert RESET */
+       smi->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
+       if (IS_ERR(smi->reset)) {
+               dev_err(dev, "failed to get RESET GPIO\n");
+               return PTR_ERR(smi->reset);
+       }
+       msleep(REALTEK_SMI_HW_STOP_DELAY);
+       gpiod_set_value(smi->reset, 0);
+       msleep(REALTEK_SMI_HW_START_DELAY);
+       dev_info(dev, "deasserted RESET\n");
+
+       /* Fetch MDIO pins */
+       smi->mdc = devm_gpiod_get_optional(dev, "mdc", GPIOD_OUT_LOW);
+       if (IS_ERR(smi->mdc))
+               return PTR_ERR(smi->mdc);
+       smi->mdio = devm_gpiod_get_optional(dev, "mdio", GPIOD_OUT_LOW);
+       if (IS_ERR(smi->mdio))
+               return PTR_ERR(smi->mdio);
+
+       smi->leds_disabled = of_property_read_bool(np, "realtek,disable-leds");
+
+       ret = smi->ops->detect(smi);
+       if (ret) {
+               dev_err(dev, "unable to detect switch\n");
+               return ret;
+       }
+
+       smi->ds = devm_kzalloc(dev, sizeof(*smi->ds), GFP_KERNEL);
+       if (!smi->ds)
+               return -ENOMEM;
+
+       smi->ds->dev = dev;
+       smi->ds->num_ports = smi->num_ports;
+       smi->ds->priv = smi;
+
+       smi->ds->ops = var->ds_ops;
+       ret = dsa_register_switch(smi->ds);
+       if (ret) {
+               dev_err_probe(dev, ret, "unable to register switch\n");
+               return ret;
+       }
+       return 0;
+}
+
+static int realtek_smi_remove(struct platform_device *pdev)
+{
+       struct realtek_smi *smi = platform_get_drvdata(pdev);
+
+       if (!smi)
+               return 0;
+
+       dsa_unregister_switch(smi->ds);
+       if (smi->slave_mii_bus)
+               of_node_put(smi->slave_mii_bus->dev.of_node);
+       gpiod_set_value(smi->reset, 1);
+
+       platform_set_drvdata(pdev, NULL);
+
+       return 0;
+}
+
+static void realtek_smi_shutdown(struct platform_device *pdev)
+{
+       struct realtek_smi *smi = platform_get_drvdata(pdev);
+
+       if (!smi)
+               return;
+
+       dsa_switch_shutdown(smi->ds);
+
+       platform_set_drvdata(pdev, NULL);
+}
+
+static const struct of_device_id realtek_smi_of_match[] = {
+       {
+               .compatible = "realtek,rtl8366rb",
+               .data = &rtl8366rb_variant,
+       },
+       {
+               /* FIXME: add support for RTL8366S and more */
+               .compatible = "realtek,rtl8366s",
+               .data = NULL,
+       },
+       {
+               .compatible = "realtek,rtl8365mb",
+               .data = &rtl8365mb_variant,
+       },
+       { /* sentinel */ },
+};
+MODULE_DEVICE_TABLE(of, realtek_smi_of_match);
+
+static struct platform_driver realtek_smi_driver = {
+       .driver = {
+               .name = "realtek-smi",
+               .of_match_table = of_match_ptr(realtek_smi_of_match),
+       },
+       .probe  = realtek_smi_probe,
+       .remove = realtek_smi_remove,
+       .shutdown = realtek_smi_shutdown,
+};
+module_platform_driver(realtek_smi_driver);
+
+MODULE_LICENSE("GPL");
diff --git a/drivers/net/dsa/realtek/realtek-smi-core.h b/drivers/net/dsa/realtek/realtek-smi-core.h
new file mode 100644 (file)
index 0000000..faed387
--- /dev/null
@@ -0,0 +1,145 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/* Realtek SMI interface driver defines
+ *
+ * Copyright (C) 2017 Linus Walleij <linus.walleij@linaro.org>
+ * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
+ */
+
+#ifndef _REALTEK_SMI_H
+#define _REALTEK_SMI_H
+
+#include <linux/phy.h>
+#include <linux/platform_device.h>
+#include <linux/gpio/consumer.h>
+#include <net/dsa.h>
+
+struct realtek_smi_ops;
+struct dentry;
+struct inode;
+struct file;
+
+struct rtl8366_mib_counter {
+       unsigned int    base;
+       unsigned int    offset;
+       unsigned int    length;
+       const char      *name;
+};
+
+/*
+ * struct rtl8366_vlan_mc - Virtual LAN member configuration
+ */
+struct rtl8366_vlan_mc {
+       u16     vid;
+       u16     untag;
+       u16     member;
+       u8      fid;
+       u8      priority;
+};
+
+struct rtl8366_vlan_4k {
+       u16     vid;
+       u16     untag;
+       u16     member;
+       u8      fid;
+};
+
+struct realtek_smi {
+       struct device           *dev;
+       struct gpio_desc        *reset;
+       struct gpio_desc        *mdc;
+       struct gpio_desc        *mdio;
+       struct regmap           *map;
+       struct mii_bus          *slave_mii_bus;
+
+       unsigned int            clk_delay;
+       u8                      cmd_read;
+       u8                      cmd_write;
+       spinlock_t              lock; /* Locks around command writes */
+       struct dsa_switch       *ds;
+       struct irq_domain       *irqdomain;
+       bool                    leds_disabled;
+
+       unsigned int            cpu_port;
+       unsigned int            num_ports;
+       unsigned int            num_vlan_mc;
+       unsigned int            num_mib_counters;
+       struct rtl8366_mib_counter *mib_counters;
+
+       const struct realtek_smi_ops *ops;
+
+       int                     vlan_enabled;
+       int                     vlan4k_enabled;
+
+       char                    buf[4096];
+       void                    *chip_data; /* Per-chip extra variant data */
+};
+
+/*
+ * struct realtek_smi_ops - vtable for the per-SMI-chiptype operations
+ * @detect: detects the chiptype
+ */
+struct realtek_smi_ops {
+       int     (*detect)(struct realtek_smi *smi);
+       int     (*reset_chip)(struct realtek_smi *smi);
+       int     (*setup)(struct realtek_smi *smi);
+       void    (*cleanup)(struct realtek_smi *smi);
+       int     (*get_mib_counter)(struct realtek_smi *smi,
+                                  int port,
+                                  struct rtl8366_mib_counter *mib,
+                                  u64 *mibvalue);
+       int     (*get_vlan_mc)(struct realtek_smi *smi, u32 index,
+                              struct rtl8366_vlan_mc *vlanmc);
+       int     (*set_vlan_mc)(struct realtek_smi *smi, u32 index,
+                              const struct rtl8366_vlan_mc *vlanmc);
+       int     (*get_vlan_4k)(struct realtek_smi *smi, u32 vid,
+                              struct rtl8366_vlan_4k *vlan4k);
+       int     (*set_vlan_4k)(struct realtek_smi *smi,
+                              const struct rtl8366_vlan_4k *vlan4k);
+       int     (*get_mc_index)(struct realtek_smi *smi, int port, int *val);
+       int     (*set_mc_index)(struct realtek_smi *smi, int port, int index);
+       bool    (*is_vlan_valid)(struct realtek_smi *smi, unsigned int vlan);
+       int     (*enable_vlan)(struct realtek_smi *smi, bool enable);
+       int     (*enable_vlan4k)(struct realtek_smi *smi, bool enable);
+       int     (*enable_port)(struct realtek_smi *smi, int port, bool enable);
+       int     (*phy_read)(struct realtek_smi *smi, int phy, int regnum);
+       int     (*phy_write)(struct realtek_smi *smi, int phy, int regnum,
+                            u16 val);
+};
+
+struct realtek_smi_variant {
+       const struct dsa_switch_ops *ds_ops;
+       const struct realtek_smi_ops *ops;
+       unsigned int clk_delay;
+       u8 cmd_read;
+       u8 cmd_write;
+       size_t chip_data_sz;
+};
+
+/* SMI core calls */
+int realtek_smi_write_reg_noack(struct realtek_smi *smi, u32 addr,
+                               u32 data);
+int realtek_smi_setup_mdio(struct realtek_smi *smi);
+
+/* RTL8366 library helpers */
+int rtl8366_mc_is_used(struct realtek_smi *smi, int mc_index, int *used);
+int rtl8366_set_vlan(struct realtek_smi *smi, int vid, u32 member,
+                    u32 untag, u32 fid);
+int rtl8366_set_pvid(struct realtek_smi *smi, unsigned int port,
+                    unsigned int vid);
+int rtl8366_enable_vlan4k(struct realtek_smi *smi, bool enable);
+int rtl8366_enable_vlan(struct realtek_smi *smi, bool enable);
+int rtl8366_reset_vlan(struct realtek_smi *smi);
+int rtl8366_vlan_add(struct dsa_switch *ds, int port,
+                    const struct switchdev_obj_port_vlan *vlan,
+                    struct netlink_ext_ack *extack);
+int rtl8366_vlan_del(struct dsa_switch *ds, int port,
+                    const struct switchdev_obj_port_vlan *vlan);
+void rtl8366_get_strings(struct dsa_switch *ds, int port, u32 stringset,
+                        uint8_t *data);
+int rtl8366_get_sset_count(struct dsa_switch *ds, int port, int sset);
+void rtl8366_get_ethtool_stats(struct dsa_switch *ds, int port, uint64_t *data);
+
+extern const struct realtek_smi_variant rtl8366rb_variant;
+extern const struct realtek_smi_variant rtl8365mb_variant;
+
+#endif /*  _REALTEK_SMI_H */
diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
new file mode 100644 (file)
index 0000000..3b72954
--- /dev/null
@@ -0,0 +1,1987 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Realtek SMI subdriver for the Realtek RTL8365MB-VC ethernet switch.
+ *
+ * Copyright (C) 2021 Alvin Šipraga <alsi@bang-olufsen.dk>
+ * Copyright (C) 2021 Michael Rasmussen <mir@bang-olufsen.dk>
+ *
+ * The RTL8365MB-VC is a 4+1 port 10/100/1000M switch controller. It includes 4
+ * integrated PHYs for the user facing ports, and an extension interface which
+ * can be connected to the CPU - or another PHY - via either MII, RMII, or
+ * RGMII. The switch is configured via the Realtek Simple Management Interface
+ * (SMI), which uses the MDIO/MDC lines.
+ *
+ * Below is a simplified block diagram of the chip and its relevant interfaces.
+ *
+ *                          .-----------------------------------.
+ *                          |                                   |
+ *         UTP <---------------> Giga PHY <-> PCS <-> P0 GMAC   |
+ *         UTP <---------------> Giga PHY <-> PCS <-> P1 GMAC   |
+ *         UTP <---------------> Giga PHY <-> PCS <-> P2 GMAC   |
+ *         UTP <---------------> Giga PHY <-> PCS <-> P3 GMAC   |
+ *                          |                                   |
+ *     CPU/PHY <-MII/RMII/RGMII--->  Extension  <---> Extension |
+ *                          |       interface 1        GMAC 1   |
+ *                          |                                   |
+ *     SMI driver/ <-MDC/SCL---> Management    ~~~~~~~~~~~~~~   |
+ *        EEPROM   <-MDIO/SDA--> interface     ~REALTEK ~~~~~   |
+ *                          |                  ~RTL8365MB ~~~   |
+ *                          |                  ~GXXXC TAIWAN~   |
+ *        GPIO <--------------> Reset          ~~~~~~~~~~~~~~   |
+ *                          |                                   |
+ *      Interrupt  <----------> Link UP/DOWN events             |
+ *      controller          |                                   |
+ *                          '-----------------------------------'
+ *
+ * The driver uses DSA to integrate the 4 user and 1 extension ports into the
+ * kernel. Netdevices are created for the user ports, as are PHY devices for
+ * their integrated PHYs. The device tree firmware should also specify the link
+ * partner of the extension port - either via a fixed-link or other phy-handle.
+ * See the device tree bindings for more detailed information. Note that the
+ * driver has only been tested with a fixed-link, but in principle it should not
+ * matter.
+ *
+ * NOTE: Currently, only the RGMII interface is implemented in this driver.
+ *
+ * The interrupt line is asserted on link UP/DOWN events. The driver creates a
+ * custom irqchip to handle this interrupt and demultiplex the events by reading
+ * the status registers via SMI. Interrupts are then propagated to the relevant
+ * PHY device.
+ *
+ * The EEPROM contains initial register values which the chip will read over I2C
+ * upon hardware reset. It is also possible to omit the EEPROM. In both cases,
+ * the driver will manually reprogram some registers using jam tables to reach
+ * an initial state defined by the vendor driver.
+ *
+ * This Linux driver is written based on an OS-agnostic vendor driver from
+ * Realtek. The reference GPL-licensed sources can be found in the OpenWrt
+ * source tree under the name rtl8367c. The vendor driver claims to support a
+ * number of similar switch controllers from Realtek, but the only hardware we
+ * have is the RTL8365MB-VC. Moreover, there does not seem to be any chip under
+ * the name RTL8367C. Although one wishes that the 'C' stood for some kind of
+ * common hardware revision, there exist examples of chips with the suffix -VC
+ * which are explicitly not supported by the rtl8367c driver and which instead
+ * require the rtl8367d vendor driver. With all this uncertainty, the driver has
+ * been modestly named rtl8365mb. Future implementors may wish to rename things
+ * accordingly.
+ *
+ * In the same family of chips, some carry up to 8 user ports and up to 2
+ * extension ports. Where possible this driver tries to make things generic, but
+ * more work must be done to support these configurations. According to
+ * documentation from Realtek, the family should include the following chips:
+ *
+ *  - RTL8363NB
+ *  - RTL8363NB-VB
+ *  - RTL8363SC
+ *  - RTL8363SC-VB
+ *  - RTL8364NB
+ *  - RTL8364NB-VB
+ *  - RTL8365MB-VC
+ *  - RTL8366SC
+ *  - RTL8367RB-VB
+ *  - RTL8367SB
+ *  - RTL8367S
+ *  - RTL8370MB
+ *  - RTL8310SR
+ *
+ * Some of the register logic for these additional chips has been skipped over
+ * while implementing this driver. It is therefore not possible to assume that
+ * things will work out-of-the-box for other chips, and a careful review of the
+ * vendor driver may be needed to expand support. The RTL8365MB-VC seems to be
+ * one of the simpler chips.
+ */
+
+#include <linux/bitfield.h>
+#include <linux/bitops.h>
+#include <linux/interrupt.h>
+#include <linux/irqdomain.h>
+#include <linux/mutex.h>
+#include <linux/of_irq.h>
+#include <linux/regmap.h>
+#include <linux/if_bridge.h>
+
+#include "realtek-smi-core.h"
+
+/* Chip-specific data and limits */
+#define RTL8365MB_CHIP_ID_8365MB_VC            0x6367
+#define RTL8365MB_CPU_PORT_NUM_8365MB_VC       6
+#define RTL8365MB_LEARN_LIMIT_MAX_8365MB_VC    2112
+
+/* Family-specific data and limits */
+#define RTL8365MB_PHYADDRMAX   7
+#define RTL8365MB_NUM_PHYREGS  32
+#define RTL8365MB_PHYREGMAX    (RTL8365MB_NUM_PHYREGS - 1)
+#define RTL8365MB_MAX_NUM_PORTS        (RTL8365MB_CPU_PORT_NUM_8365MB_VC + 1)
+
+/* Chip identification registers */
+#define RTL8365MB_CHIP_ID_REG          0x1300
+
+#define RTL8365MB_CHIP_VER_REG         0x1301
+
+#define RTL8365MB_MAGIC_REG            0x13C2
+#define   RTL8365MB_MAGIC_VALUE                0x0249
+
+/* Chip reset register */
+#define RTL8365MB_CHIP_RESET_REG       0x1322
+#define RTL8365MB_CHIP_RESET_SW_MASK   0x0002
+#define RTL8365MB_CHIP_RESET_HW_MASK   0x0001
+
+/* Interrupt polarity register */
+#define RTL8365MB_INTR_POLARITY_REG    0x1100
+#define   RTL8365MB_INTR_POLARITY_MASK 0x0001
+#define   RTL8365MB_INTR_POLARITY_HIGH 0
+#define   RTL8365MB_INTR_POLARITY_LOW  1
+
+/* Interrupt control/status register - enable/check specific interrupt types */
+#define RTL8365MB_INTR_CTRL_REG                        0x1101
+#define RTL8365MB_INTR_STATUS_REG              0x1102
+#define   RTL8365MB_INTR_SLIENT_START_2_MASK   0x1000
+#define   RTL8365MB_INTR_SLIENT_START_MASK     0x0800
+#define   RTL8365MB_INTR_ACL_ACTION_MASK       0x0200
+#define   RTL8365MB_INTR_CABLE_DIAG_FIN_MASK   0x0100
+#define   RTL8365MB_INTR_INTERRUPT_8051_MASK   0x0080
+#define   RTL8365MB_INTR_LOOP_DETECTION_MASK   0x0040
+#define   RTL8365MB_INTR_GREEN_TIMER_MASK      0x0020
+#define   RTL8365MB_INTR_SPECIAL_CONGEST_MASK  0x0010
+#define   RTL8365MB_INTR_SPEED_CHANGE_MASK     0x0008
+#define   RTL8365MB_INTR_LEARN_OVER_MASK       0x0004
+#define   RTL8365MB_INTR_METER_EXCEEDED_MASK   0x0002
+#define   RTL8365MB_INTR_LINK_CHANGE_MASK      0x0001
+#define   RTL8365MB_INTR_ALL_MASK                      \
+               (RTL8365MB_INTR_SLIENT_START_2_MASK |  \
+                RTL8365MB_INTR_SLIENT_START_MASK |    \
+                RTL8365MB_INTR_ACL_ACTION_MASK |      \
+                RTL8365MB_INTR_CABLE_DIAG_FIN_MASK |  \
+                RTL8365MB_INTR_INTERRUPT_8051_MASK |  \
+                RTL8365MB_INTR_LOOP_DETECTION_MASK |  \
+                RTL8365MB_INTR_GREEN_TIMER_MASK |     \
+                RTL8365MB_INTR_SPECIAL_CONGEST_MASK | \
+                RTL8365MB_INTR_SPEED_CHANGE_MASK |    \
+                RTL8365MB_INTR_LEARN_OVER_MASK |      \
+                RTL8365MB_INTR_METER_EXCEEDED_MASK |  \
+                RTL8365MB_INTR_LINK_CHANGE_MASK)
+
+/* Per-port interrupt type status registers */
+#define RTL8365MB_PORT_LINKDOWN_IND_REG                0x1106
+#define   RTL8365MB_PORT_LINKDOWN_IND_MASK     0x07FF
+
+#define RTL8365MB_PORT_LINKUP_IND_REG          0x1107
+#define   RTL8365MB_PORT_LINKUP_IND_MASK       0x07FF
+
+/* PHY indirect access registers */
+#define RTL8365MB_INDIRECT_ACCESS_CTRL_REG                     0x1F00
+#define   RTL8365MB_INDIRECT_ACCESS_CTRL_RW_MASK               0x0002
+#define   RTL8365MB_INDIRECT_ACCESS_CTRL_RW_READ               0
+#define   RTL8365MB_INDIRECT_ACCESS_CTRL_RW_WRITE              1
+#define   RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_MASK              0x0001
+#define   RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_VALUE             1
+#define RTL8365MB_INDIRECT_ACCESS_STATUS_REG                   0x1F01
+#define RTL8365MB_INDIRECT_ACCESS_ADDRESS_REG                  0x1F02
+#define   RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_5_1_MASK    GENMASK(4, 0)
+#define   RTL8365MB_INDIRECT_ACCESS_ADDRESS_PHYNUM_MASK                GENMASK(7, 5)
+#define   RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_9_6_MASK    GENMASK(11, 8)
+#define   RTL8365MB_PHY_BASE                                   0x2000
+#define RTL8365MB_INDIRECT_ACCESS_WRITE_DATA_REG               0x1F03
+#define RTL8365MB_INDIRECT_ACCESS_READ_DATA_REG                        0x1F04
+
+/* PHY OCP address prefix register */
+#define RTL8365MB_GPHY_OCP_MSB_0_REG                   0x1D15
+#define   RTL8365MB_GPHY_OCP_MSB_0_CFG_CPU_OCPADR_MASK 0x0FC0
+#define RTL8365MB_PHY_OCP_ADDR_PREFIX_MASK             0xFC00
+
+/* The PHY OCP addresses of PHY registers 0~31 start here */
+#define RTL8365MB_PHY_OCP_ADDR_PHYREG_BASE             0xA400
+
+/* EXT port interface mode values - used in DIGITAL_INTERFACE_SELECT */
+#define RTL8365MB_EXT_PORT_MODE_DISABLE                0
+#define RTL8365MB_EXT_PORT_MODE_RGMII          1
+#define RTL8365MB_EXT_PORT_MODE_MII_MAC                2
+#define RTL8365MB_EXT_PORT_MODE_MII_PHY                3
+#define RTL8365MB_EXT_PORT_MODE_TMII_MAC       4
+#define RTL8365MB_EXT_PORT_MODE_TMII_PHY       5
+#define RTL8365MB_EXT_PORT_MODE_GMII           6
+#define RTL8365MB_EXT_PORT_MODE_RMII_MAC       7
+#define RTL8365MB_EXT_PORT_MODE_RMII_PHY       8
+#define RTL8365MB_EXT_PORT_MODE_SGMII          9
+#define RTL8365MB_EXT_PORT_MODE_HSGMII         10
+#define RTL8365MB_EXT_PORT_MODE_1000X_100FX    11
+#define RTL8365MB_EXT_PORT_MODE_1000X          12
+#define RTL8365MB_EXT_PORT_MODE_100FX          13
+
+/* EXT port interface mode configuration registers 0~1 */
+#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0                0x1305
+#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1                0x13C3
+#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(_extport)   \
+               (RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 + \
+                ((_extport) >> 1) * (0x13C3 - 0x1305))
+#define   RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(_extport) \
+               (0xF << (((_extport) % 2)))
+#define   RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_OFFSET(_extport) \
+               (((_extport) % 2) * 4)
+
+/* EXT port RGMII TX/RX delay configuration registers 1~2 */
+#define RTL8365MB_EXT_RGMXF_REG1               0x1307
+#define RTL8365MB_EXT_RGMXF_REG2               0x13C5
+#define RTL8365MB_EXT_RGMXF_REG(_extport)   \
+               (RTL8365MB_EXT_RGMXF_REG1 + \
+                (((_extport) >> 1) * (0x13C5 - 0x1307)))
+#define   RTL8365MB_EXT_RGMXF_RXDELAY_MASK     0x0007
+#define   RTL8365MB_EXT_RGMXF_TXDELAY_MASK     0x0008
+
+/* External port speed values - used in DIGITAL_INTERFACE_FORCE */
+#define RTL8365MB_PORT_SPEED_10M       0
+#define RTL8365MB_PORT_SPEED_100M      1
+#define RTL8365MB_PORT_SPEED_1000M     2
+
+/* EXT port force configuration registers 0~2 */
+#define RTL8365MB_DIGITAL_INTERFACE_FORCE_REG0                 0x1310
+#define RTL8365MB_DIGITAL_INTERFACE_FORCE_REG1                 0x1311
+#define RTL8365MB_DIGITAL_INTERFACE_FORCE_REG2                 0x13C4
+#define RTL8365MB_DIGITAL_INTERFACE_FORCE_REG(_extport)   \
+               (RTL8365MB_DIGITAL_INTERFACE_FORCE_REG0 + \
+                ((_extport) & 0x1) +                     \
+                ((((_extport) >> 1) & 0x1) * (0x13C4 - 0x1310)))
+#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_EN_MASK            0x1000
+#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_NWAY_MASK          0x0080
+#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_TXPAUSE_MASK       0x0040
+#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_RXPAUSE_MASK       0x0020
+#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_LINK_MASK          0x0010
+#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_DUPLEX_MASK                0x0004
+#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_SPEED_MASK         0x0003
+
+/* CPU port mask register - controls which ports are treated as CPU ports */
+#define RTL8365MB_CPU_PORT_MASK_REG    0x1219
+#define   RTL8365MB_CPU_PORT_MASK_MASK 0x07FF
+
+/* CPU control register */
+#define RTL8365MB_CPU_CTRL_REG                 0x121A
+#define   RTL8365MB_CPU_CTRL_TRAP_PORT_EXT_MASK        0x0400
+#define   RTL8365MB_CPU_CTRL_TAG_FORMAT_MASK   0x0200
+#define   RTL8365MB_CPU_CTRL_RXBYTECOUNT_MASK  0x0080
+#define   RTL8365MB_CPU_CTRL_TAG_POSITION_MASK 0x0040
+#define   RTL8365MB_CPU_CTRL_TRAP_PORT_MASK    0x0038
+#define   RTL8365MB_CPU_CTRL_INSERTMODE_MASK   0x0006
+#define   RTL8365MB_CPU_CTRL_EN_MASK           0x0001
+
+/* Maximum packet length register */
+#define RTL8365MB_CFG0_MAX_LEN_REG     0x088C
+#define   RTL8365MB_CFG0_MAX_LEN_MASK  0x3FFF
+
+/* Port learning limit registers */
+#define RTL8365MB_LUT_PORT_LEARN_LIMIT_BASE            0x0A20
+#define RTL8365MB_LUT_PORT_LEARN_LIMIT_REG(_physport) \
+               (RTL8365MB_LUT_PORT_LEARN_LIMIT_BASE + (_physport))
+
+/* Port isolation (forwarding mask) registers */
+#define RTL8365MB_PORT_ISOLATION_REG_BASE              0x08A2
+#define RTL8365MB_PORT_ISOLATION_REG(_physport) \
+               (RTL8365MB_PORT_ISOLATION_REG_BASE + (_physport))
+#define   RTL8365MB_PORT_ISOLATION_MASK                        0x07FF
+
+/* MSTP port state registers - indexed by tree instance */
+#define RTL8365MB_MSTI_CTRL_BASE                       0x0A00
+#define RTL8365MB_MSTI_CTRL_REG(_msti, _physport) \
+               (RTL8365MB_MSTI_CTRL_BASE + ((_msti) << 1) + ((_physport) >> 3))
+#define   RTL8365MB_MSTI_CTRL_PORT_STATE_OFFSET(_physport) ((_physport) << 1)
+#define   RTL8365MB_MSTI_CTRL_PORT_STATE_MASK(_physport) \
+               (0x3 << RTL8365MB_MSTI_CTRL_PORT_STATE_OFFSET((_physport)))
+
+/* MIB counter value registers */
+#define RTL8365MB_MIB_COUNTER_BASE     0x1000
+#define RTL8365MB_MIB_COUNTER_REG(_x)  (RTL8365MB_MIB_COUNTER_BASE + (_x))
+
+/* MIB counter address register */
+#define RTL8365MB_MIB_ADDRESS_REG              0x1004
+#define   RTL8365MB_MIB_ADDRESS_PORT_OFFSET    0x007C
+#define   RTL8365MB_MIB_ADDRESS(_p, _x) \
+               (((RTL8365MB_MIB_ADDRESS_PORT_OFFSET) * (_p) + (_x)) >> 2)
+
+#define RTL8365MB_MIB_CTRL0_REG                        0x1005
+#define   RTL8365MB_MIB_CTRL0_RESET_MASK       0x0002
+#define   RTL8365MB_MIB_CTRL0_BUSY_MASK                0x0001
+
+/* The DSA callback .get_stats64 runs in atomic context, so we are not allowed
+ * to block. On the other hand, accessing MIB counters absolutely requires us to
+ * block. The solution is thus to schedule work which polls the MIB counters
+ * asynchronously and updates some private data, which the callback can then
+ * fetch atomically. Three seconds should be a good enough polling interval.
+ */
+#define RTL8365MB_STATS_INTERVAL_JIFFIES       (3 * HZ)
+
+enum rtl8365mb_mib_counter_index {
+       RTL8365MB_MIB_ifInOctets,
+       RTL8365MB_MIB_dot3StatsFCSErrors,
+       RTL8365MB_MIB_dot3StatsSymbolErrors,
+       RTL8365MB_MIB_dot3InPauseFrames,
+       RTL8365MB_MIB_dot3ControlInUnknownOpcodes,
+       RTL8365MB_MIB_etherStatsFragments,
+       RTL8365MB_MIB_etherStatsJabbers,
+       RTL8365MB_MIB_ifInUcastPkts,
+       RTL8365MB_MIB_etherStatsDropEvents,
+       RTL8365MB_MIB_ifInMulticastPkts,
+       RTL8365MB_MIB_ifInBroadcastPkts,
+       RTL8365MB_MIB_inMldChecksumError,
+       RTL8365MB_MIB_inIgmpChecksumError,
+       RTL8365MB_MIB_inMldSpecificQuery,
+       RTL8365MB_MIB_inMldGeneralQuery,
+       RTL8365MB_MIB_inIgmpSpecificQuery,
+       RTL8365MB_MIB_inIgmpGeneralQuery,
+       RTL8365MB_MIB_inMldLeaves,
+       RTL8365MB_MIB_inIgmpLeaves,
+       RTL8365MB_MIB_etherStatsOctets,
+       RTL8365MB_MIB_etherStatsUnderSizePkts,
+       RTL8365MB_MIB_etherOversizeStats,
+       RTL8365MB_MIB_etherStatsPkts64Octets,
+       RTL8365MB_MIB_etherStatsPkts65to127Octets,
+       RTL8365MB_MIB_etherStatsPkts128to255Octets,
+       RTL8365MB_MIB_etherStatsPkts256to511Octets,
+       RTL8365MB_MIB_etherStatsPkts512to1023Octets,
+       RTL8365MB_MIB_etherStatsPkts1024to1518Octets,
+       RTL8365MB_MIB_ifOutOctets,
+       RTL8365MB_MIB_dot3StatsSingleCollisionFrames,
+       RTL8365MB_MIB_dot3StatsMultipleCollisionFrames,
+       RTL8365MB_MIB_dot3StatsDeferredTransmissions,
+       RTL8365MB_MIB_dot3StatsLateCollisions,
+       RTL8365MB_MIB_etherStatsCollisions,
+       RTL8365MB_MIB_dot3StatsExcessiveCollisions,
+       RTL8365MB_MIB_dot3OutPauseFrames,
+       RTL8365MB_MIB_ifOutDiscards,
+       RTL8365MB_MIB_dot1dTpPortInDiscards,
+       RTL8365MB_MIB_ifOutUcastPkts,
+       RTL8365MB_MIB_ifOutMulticastPkts,
+       RTL8365MB_MIB_ifOutBroadcastPkts,
+       RTL8365MB_MIB_outOampduPkts,
+       RTL8365MB_MIB_inOampduPkts,
+       RTL8365MB_MIB_inIgmpJoinsSuccess,
+       RTL8365MB_MIB_inIgmpJoinsFail,
+       RTL8365MB_MIB_inMldJoinsSuccess,
+       RTL8365MB_MIB_inMldJoinsFail,
+       RTL8365MB_MIB_inReportSuppressionDrop,
+       RTL8365MB_MIB_inLeaveSuppressionDrop,
+       RTL8365MB_MIB_outIgmpReports,
+       RTL8365MB_MIB_outIgmpLeaves,
+       RTL8365MB_MIB_outIgmpGeneralQuery,
+       RTL8365MB_MIB_outIgmpSpecificQuery,
+       RTL8365MB_MIB_outMldReports,
+       RTL8365MB_MIB_outMldLeaves,
+       RTL8365MB_MIB_outMldGeneralQuery,
+       RTL8365MB_MIB_outMldSpecificQuery,
+       RTL8365MB_MIB_inKnownMulticastPkts,
+       RTL8365MB_MIB_END,
+};
+
+struct rtl8365mb_mib_counter {
+       u32 offset;
+       u32 length;
+       const char *name;
+};
+
+#define RTL8365MB_MAKE_MIB_COUNTER(_offset, _length, _name) \
+               [RTL8365MB_MIB_ ## _name] = { _offset, _length, #_name }
+
+static struct rtl8365mb_mib_counter rtl8365mb_mib_counters[] = {
+       RTL8365MB_MAKE_MIB_COUNTER(0, 4, ifInOctets),
+       RTL8365MB_MAKE_MIB_COUNTER(4, 2, dot3StatsFCSErrors),
+       RTL8365MB_MAKE_MIB_COUNTER(6, 2, dot3StatsSymbolErrors),
+       RTL8365MB_MAKE_MIB_COUNTER(8, 2, dot3InPauseFrames),
+       RTL8365MB_MAKE_MIB_COUNTER(10, 2, dot3ControlInUnknownOpcodes),
+       RTL8365MB_MAKE_MIB_COUNTER(12, 2, etherStatsFragments),
+       RTL8365MB_MAKE_MIB_COUNTER(14, 2, etherStatsJabbers),
+       RTL8365MB_MAKE_MIB_COUNTER(16, 2, ifInUcastPkts),
+       RTL8365MB_MAKE_MIB_COUNTER(18, 2, etherStatsDropEvents),
+       RTL8365MB_MAKE_MIB_COUNTER(20, 2, ifInMulticastPkts),
+       RTL8365MB_MAKE_MIB_COUNTER(22, 2, ifInBroadcastPkts),
+       RTL8365MB_MAKE_MIB_COUNTER(24, 2, inMldChecksumError),
+       RTL8365MB_MAKE_MIB_COUNTER(26, 2, inIgmpChecksumError),
+       RTL8365MB_MAKE_MIB_COUNTER(28, 2, inMldSpecificQuery),
+       RTL8365MB_MAKE_MIB_COUNTER(30, 2, inMldGeneralQuery),
+       RTL8365MB_MAKE_MIB_COUNTER(32, 2, inIgmpSpecificQuery),
+       RTL8365MB_MAKE_MIB_COUNTER(34, 2, inIgmpGeneralQuery),
+       RTL8365MB_MAKE_MIB_COUNTER(36, 2, inMldLeaves),
+       RTL8365MB_MAKE_MIB_COUNTER(38, 2, inIgmpLeaves),
+       RTL8365MB_MAKE_MIB_COUNTER(40, 4, etherStatsOctets),
+       RTL8365MB_MAKE_MIB_COUNTER(44, 2, etherStatsUnderSizePkts),
+       RTL8365MB_MAKE_MIB_COUNTER(46, 2, etherOversizeStats),
+       RTL8365MB_MAKE_MIB_COUNTER(48, 2, etherStatsPkts64Octets),
+       RTL8365MB_MAKE_MIB_COUNTER(50, 2, etherStatsPkts65to127Octets),
+       RTL8365MB_MAKE_MIB_COUNTER(52, 2, etherStatsPkts128to255Octets),
+       RTL8365MB_MAKE_MIB_COUNTER(54, 2, etherStatsPkts256to511Octets),
+       RTL8365MB_MAKE_MIB_COUNTER(56, 2, etherStatsPkts512to1023Octets),
+       RTL8365MB_MAKE_MIB_COUNTER(58, 2, etherStatsPkts1024to1518Octets),
+       RTL8365MB_MAKE_MIB_COUNTER(60, 4, ifOutOctets),
+       RTL8365MB_MAKE_MIB_COUNTER(64, 2, dot3StatsSingleCollisionFrames),
+       RTL8365MB_MAKE_MIB_COUNTER(66, 2, dot3StatsMultipleCollisionFrames),
+       RTL8365MB_MAKE_MIB_COUNTER(68, 2, dot3StatsDeferredTransmissions),
+       RTL8365MB_MAKE_MIB_COUNTER(70, 2, dot3StatsLateCollisions),
+       RTL8365MB_MAKE_MIB_COUNTER(72, 2, etherStatsCollisions),
+       RTL8365MB_MAKE_MIB_COUNTER(74, 2, dot3StatsExcessiveCollisions),
+       RTL8365MB_MAKE_MIB_COUNTER(76, 2, dot3OutPauseFrames),
+       RTL8365MB_MAKE_MIB_COUNTER(78, 2, ifOutDiscards),
+       RTL8365MB_MAKE_MIB_COUNTER(80, 2, dot1dTpPortInDiscards),
+       RTL8365MB_MAKE_MIB_COUNTER(82, 2, ifOutUcastPkts),
+       RTL8365MB_MAKE_MIB_COUNTER(84, 2, ifOutMulticastPkts),
+       RTL8365MB_MAKE_MIB_COUNTER(86, 2, ifOutBroadcastPkts),
+       RTL8365MB_MAKE_MIB_COUNTER(88, 2, outOampduPkts),
+       RTL8365MB_MAKE_MIB_COUNTER(90, 2, inOampduPkts),
+       RTL8365MB_MAKE_MIB_COUNTER(92, 4, inIgmpJoinsSuccess),
+       RTL8365MB_MAKE_MIB_COUNTER(96, 2, inIgmpJoinsFail),
+       RTL8365MB_MAKE_MIB_COUNTER(98, 2, inMldJoinsSuccess),
+       RTL8365MB_MAKE_MIB_COUNTER(100, 2, inMldJoinsFail),
+       RTL8365MB_MAKE_MIB_COUNTER(102, 2, inReportSuppressionDrop),
+       RTL8365MB_MAKE_MIB_COUNTER(104, 2, inLeaveSuppressionDrop),
+       RTL8365MB_MAKE_MIB_COUNTER(106, 2, outIgmpReports),
+       RTL8365MB_MAKE_MIB_COUNTER(108, 2, outIgmpLeaves),
+       RTL8365MB_MAKE_MIB_COUNTER(110, 2, outIgmpGeneralQuery),
+       RTL8365MB_MAKE_MIB_COUNTER(112, 2, outIgmpSpecificQuery),
+       RTL8365MB_MAKE_MIB_COUNTER(114, 2, outMldReports),
+       RTL8365MB_MAKE_MIB_COUNTER(116, 2, outMldLeaves),
+       RTL8365MB_MAKE_MIB_COUNTER(118, 2, outMldGeneralQuery),
+       RTL8365MB_MAKE_MIB_COUNTER(120, 2, outMldSpecificQuery),
+       RTL8365MB_MAKE_MIB_COUNTER(122, 2, inKnownMulticastPkts),
+};
+
+static_assert(ARRAY_SIZE(rtl8365mb_mib_counters) == RTL8365MB_MIB_END);
+
+struct rtl8365mb_jam_tbl_entry {
+       u16 reg;
+       u16 val;
+};
+
+/* Lifted from the vendor driver sources */
+static const struct rtl8365mb_jam_tbl_entry rtl8365mb_init_jam_8365mb_vc[] = {
+       { 0x13EB, 0x15BB }, { 0x1303, 0x06D6 }, { 0x1304, 0x0700 },
+       { 0x13E2, 0x003F }, { 0x13F9, 0x0090 }, { 0x121E, 0x03CA },
+       { 0x1233, 0x0352 }, { 0x1237, 0x00A0 }, { 0x123A, 0x0030 },
+       { 0x1239, 0x0084 }, { 0x0301, 0x1000 }, { 0x1349, 0x001F },
+       { 0x18E0, 0x4004 }, { 0x122B, 0x241C }, { 0x1305, 0xC000 },
+       { 0x13F0, 0x0000 },
+};
+
+static const struct rtl8365mb_jam_tbl_entry rtl8365mb_init_jam_common[] = {
+       { 0x1200, 0x7FCB }, { 0x0884, 0x0003 }, { 0x06EB, 0x0001 },
+       { 0x03Fa, 0x0007 }, { 0x08C8, 0x00C0 }, { 0x0A30, 0x020E },
+       { 0x0800, 0x0000 }, { 0x0802, 0x0000 }, { 0x09DA, 0x0013 },
+       { 0x1D32, 0x0002 },
+};
+
+enum rtl8365mb_stp_state {
+       RTL8365MB_STP_STATE_DISABLED = 0,
+       RTL8365MB_STP_STATE_BLOCKING = 1,
+       RTL8365MB_STP_STATE_LEARNING = 2,
+       RTL8365MB_STP_STATE_FORWARDING = 3,
+};
+
+enum rtl8365mb_cpu_insert {
+       RTL8365MB_CPU_INSERT_TO_ALL = 0,
+       RTL8365MB_CPU_INSERT_TO_TRAPPING = 1,
+       RTL8365MB_CPU_INSERT_TO_NONE = 2,
+};
+
+enum rtl8365mb_cpu_position {
+       RTL8365MB_CPU_POS_AFTER_SA = 0,
+       RTL8365MB_CPU_POS_BEFORE_CRC = 1,
+};
+
+enum rtl8365mb_cpu_format {
+       RTL8365MB_CPU_FORMAT_8BYTES = 0,
+       RTL8365MB_CPU_FORMAT_4BYTES = 1,
+};
+
+enum rtl8365mb_cpu_rxlen {
+       RTL8365MB_CPU_RXLEN_72BYTES = 0,
+       RTL8365MB_CPU_RXLEN_64BYTES = 1,
+};
+
+/**
+ * struct rtl8365mb_cpu - CPU port configuration
+ * @enable: enable/disable hardware insertion of CPU tag in switch->CPU frames
+ * @mask: port mask of ports that parse should parse CPU tags
+ * @trap_port: forward trapped frames to this port
+ * @insert: CPU tag insertion mode in switch->CPU frames
+ * @position: position of CPU tag in frame
+ * @rx_length: minimum CPU RX length
+ * @format: CPU tag format
+ *
+ * Represents the CPU tagging and CPU port configuration of the switch. These
+ * settings are configurable at runtime.
+ */
+struct rtl8365mb_cpu {
+       bool enable;
+       u32 mask;
+       u32 trap_port;
+       enum rtl8365mb_cpu_insert insert;
+       enum rtl8365mb_cpu_position position;
+       enum rtl8365mb_cpu_rxlen rx_length;
+       enum rtl8365mb_cpu_format format;
+};
+
+/**
+ * struct rtl8365mb_port - private per-port data
+ * @smi: pointer to parent realtek_smi data
+ * @index: DSA port index, same as dsa_port::index
+ * @stats: link statistics populated by rtl8365mb_stats_poll, ready for atomic
+ *         access via rtl8365mb_get_stats64
+ * @stats_lock: protect the stats structure during read/update
+ * @mib_work: delayed work for polling MIB counters
+ */
+struct rtl8365mb_port {
+       struct realtek_smi *smi;
+       unsigned int index;
+       struct rtnl_link_stats64 stats;
+       spinlock_t stats_lock;
+       struct delayed_work mib_work;
+};
+
+/**
+ * struct rtl8365mb - private chip-specific driver data
+ * @smi: pointer to parent realtek_smi data
+ * @irq: registered IRQ or zero
+ * @chip_id: chip identifier
+ * @chip_ver: chip silicon revision
+ * @port_mask: mask of all ports
+ * @learn_limit_max: maximum number of L2 addresses the chip can learn
+ * @cpu: CPU tagging and CPU port configuration for this chip
+ * @mib_lock: prevent concurrent reads of MIB counters
+ * @ports: per-port data
+ * @jam_table: chip-specific initialization jam table
+ * @jam_size: size of the chip's jam table
+ *
+ * Private data for this driver.
+ */
+struct rtl8365mb {
+       struct realtek_smi *smi;
+       int irq;
+       u32 chip_id;
+       u32 chip_ver;
+       u32 port_mask;
+       u32 learn_limit_max;
+       struct rtl8365mb_cpu cpu;
+       struct mutex mib_lock;
+       struct rtl8365mb_port ports[RTL8365MB_MAX_NUM_PORTS];
+       const struct rtl8365mb_jam_tbl_entry *jam_table;
+       size_t jam_size;
+};
+
+static int rtl8365mb_phy_poll_busy(struct realtek_smi *smi)
+{
+       u32 val;
+
+       return regmap_read_poll_timeout(smi->map,
+                                       RTL8365MB_INDIRECT_ACCESS_STATUS_REG,
+                                       val, !val, 10, 100);
+}
+
+static int rtl8365mb_phy_ocp_prepare(struct realtek_smi *smi, int phy,
+                                    u32 ocp_addr)
+{
+       u32 val;
+       int ret;
+
+       /* Set OCP prefix */
+       val = FIELD_GET(RTL8365MB_PHY_OCP_ADDR_PREFIX_MASK, ocp_addr);
+       ret = regmap_update_bits(
+               smi->map, RTL8365MB_GPHY_OCP_MSB_0_REG,
+               RTL8365MB_GPHY_OCP_MSB_0_CFG_CPU_OCPADR_MASK,
+               FIELD_PREP(RTL8365MB_GPHY_OCP_MSB_0_CFG_CPU_OCPADR_MASK, val));
+       if (ret)
+               return ret;
+
+       /* Set PHY register address */
+       val = RTL8365MB_PHY_BASE;
+       val |= FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_ADDRESS_PHYNUM_MASK, phy);
+       val |= FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_5_1_MASK,
+                         ocp_addr >> 1);
+       val |= FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_9_6_MASK,
+                         ocp_addr >> 6);
+       ret = regmap_write(smi->map, RTL8365MB_INDIRECT_ACCESS_ADDRESS_REG,
+                          val);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+static int rtl8365mb_phy_ocp_read(struct realtek_smi *smi, int phy,
+                                 u32 ocp_addr, u16 *data)
+{
+       u32 val;
+       int ret;
+
+       ret = rtl8365mb_phy_poll_busy(smi);
+       if (ret)
+               return ret;
+
+       ret = rtl8365mb_phy_ocp_prepare(smi, phy, ocp_addr);
+       if (ret)
+               return ret;
+
+       /* Execute read operation */
+       val = FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_MASK,
+                        RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_VALUE) |
+             FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_CTRL_RW_MASK,
+                        RTL8365MB_INDIRECT_ACCESS_CTRL_RW_READ);
+       ret = regmap_write(smi->map, RTL8365MB_INDIRECT_ACCESS_CTRL_REG, val);
+       if (ret)
+               return ret;
+
+       ret = rtl8365mb_phy_poll_busy(smi);
+       if (ret)
+               return ret;
+
+       /* Get PHY register data */
+       ret = regmap_read(smi->map, RTL8365MB_INDIRECT_ACCESS_READ_DATA_REG,
+                         &val);
+       if (ret)
+               return ret;
+
+       *data = val & 0xFFFF;
+
+       return 0;
+}
+
+static int rtl8365mb_phy_ocp_write(struct realtek_smi *smi, int phy,
+                                  u32 ocp_addr, u16 data)
+{
+       u32 val;
+       int ret;
+
+       ret = rtl8365mb_phy_poll_busy(smi);
+       if (ret)
+               return ret;
+
+       ret = rtl8365mb_phy_ocp_prepare(smi, phy, ocp_addr);
+       if (ret)
+               return ret;
+
+       /* Set PHY register data */
+       ret = regmap_write(smi->map, RTL8365MB_INDIRECT_ACCESS_WRITE_DATA_REG,
+                          data);
+       if (ret)
+               return ret;
+
+       /* Execute write operation */
+       val = FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_MASK,
+                        RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_VALUE) |
+             FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_CTRL_RW_MASK,
+                        RTL8365MB_INDIRECT_ACCESS_CTRL_RW_WRITE);
+       ret = regmap_write(smi->map, RTL8365MB_INDIRECT_ACCESS_CTRL_REG, val);
+       if (ret)
+               return ret;
+
+       ret = rtl8365mb_phy_poll_busy(smi);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+static int rtl8365mb_phy_read(struct realtek_smi *smi, int phy, int regnum)
+{
+       u32 ocp_addr;
+       u16 val;
+       int ret;
+
+       if (phy > RTL8365MB_PHYADDRMAX)
+               return -EINVAL;
+
+       if (regnum > RTL8365MB_PHYREGMAX)
+               return -EINVAL;
+
+       ocp_addr = RTL8365MB_PHY_OCP_ADDR_PHYREG_BASE + regnum * 2;
+
+       ret = rtl8365mb_phy_ocp_read(smi, phy, ocp_addr, &val);
+       if (ret) {
+               dev_err(smi->dev,
+                       "failed to read PHY%d reg %02x @ %04x, ret %d\n", phy,
+                       regnum, ocp_addr, ret);
+               return ret;
+       }
+
+       dev_dbg(smi->dev, "read PHY%d register 0x%02x @ %04x, val <- %04x\n",
+               phy, regnum, ocp_addr, val);
+
+       return val;
+}
+
+static int rtl8365mb_phy_write(struct realtek_smi *smi, int phy, int regnum,
+                              u16 val)
+{
+       u32 ocp_addr;
+       int ret;
+
+       if (phy > RTL8365MB_PHYADDRMAX)
+               return -EINVAL;
+
+       if (regnum > RTL8365MB_PHYREGMAX)
+               return -EINVAL;
+
+       ocp_addr = RTL8365MB_PHY_OCP_ADDR_PHYREG_BASE + regnum * 2;
+
+       ret = rtl8365mb_phy_ocp_write(smi, phy, ocp_addr, val);
+       if (ret) {
+               dev_err(smi->dev,
+                       "failed to write PHY%d reg %02x @ %04x, ret %d\n", phy,
+                       regnum, ocp_addr, ret);
+               return ret;
+       }
+
+       dev_dbg(smi->dev, "write PHY%d register 0x%02x @ %04x, val -> %04x\n",
+               phy, regnum, ocp_addr, val);
+
+       return 0;
+}
+
+static enum dsa_tag_protocol
+rtl8365mb_get_tag_protocol(struct dsa_switch *ds, int port,
+                          enum dsa_tag_protocol mp)
+{
+       return DSA_TAG_PROTO_RTL8_4;
+}
+
+static int rtl8365mb_ext_config_rgmii(struct realtek_smi *smi, int port,
+                                     phy_interface_t interface)
+{
+       struct device_node *dn;
+       struct dsa_port *dp;
+       int tx_delay = 0;
+       int rx_delay = 0;
+       int ext_port;
+       u32 val;
+       int ret;
+
+       if (port == smi->cpu_port) {
+               ext_port = 1;
+       } else {
+               dev_err(smi->dev, "only one EXT port is currently supported\n");
+               return -EINVAL;
+       }
+
+       dp = dsa_to_port(smi->ds, port);
+       dn = dp->dn;
+
+       /* Set the RGMII TX/RX delay
+        *
+        * The Realtek vendor driver indicates the following possible
+        * configuration settings:
+        *
+        *   TX delay:
+        *     0 = no delay, 1 = 2 ns delay
+        *   RX delay:
+        *     0 = no delay, 7 = maximum delay
+        *     Each step is approximately 0.3 ns, so the maximum delay is about
+        *     2.1 ns.
+        *
+        * The vendor driver also states that this must be configured *before*
+        * forcing the external interface into a particular mode, which is done
+        * in the rtl8365mb_phylink_mac_link_{up,down} functions.
+        *
+        * Only configure an RGMII TX (resp. RX) delay if the
+        * tx-internal-delay-ps (resp. rx-internal-delay-ps) OF property is
+        * specified. We ignore the detail of the RGMII interface mode
+        * (RGMII_{RXID, TXID, etc.}), as this is considered to be a PHY-only
+        * property.
+        */
+       if (!of_property_read_u32(dn, "tx-internal-delay-ps", &val)) {
+               val = val / 1000; /* convert to ns */
+
+               if (val == 0 || val == 2)
+                       tx_delay = val / 2;
+               else
+                       dev_warn(smi->dev,
+                                "EXT port TX delay must be 0 or 2 ns\n");
+       }
+
+       if (!of_property_read_u32(dn, "rx-internal-delay-ps", &val)) {
+               val = DIV_ROUND_CLOSEST(val, 300); /* convert to 0.3 ns step */
+
+               if (val <= 7)
+                       rx_delay = val;
+               else
+                       dev_warn(smi->dev,
+                                "EXT port RX delay must be 0 to 2.1 ns\n");
+       }
+
+       ret = regmap_update_bits(
+               smi->map, RTL8365MB_EXT_RGMXF_REG(ext_port),
+               RTL8365MB_EXT_RGMXF_TXDELAY_MASK |
+                       RTL8365MB_EXT_RGMXF_RXDELAY_MASK,
+               FIELD_PREP(RTL8365MB_EXT_RGMXF_TXDELAY_MASK, tx_delay) |
+                       FIELD_PREP(RTL8365MB_EXT_RGMXF_RXDELAY_MASK, rx_delay));
+       if (ret)
+               return ret;
+
+       ret = regmap_update_bits(
+               smi->map, RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(ext_port),
+               RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(ext_port),
+               RTL8365MB_EXT_PORT_MODE_RGMII
+                       << RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_OFFSET(
+                                  ext_port));
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+static int rtl8365mb_ext_config_forcemode(struct realtek_smi *smi, int port,
+                                         bool link, int speed, int duplex,
+                                         bool tx_pause, bool rx_pause)
+{
+       u32 r_tx_pause;
+       u32 r_rx_pause;
+       u32 r_duplex;
+       u32 r_speed;
+       u32 r_link;
+       int ext_port;
+       int val;
+       int ret;
+
+       if (port == smi->cpu_port) {
+               ext_port = 1;
+       } else {
+               dev_err(smi->dev, "only one EXT port is currently supported\n");
+               return -EINVAL;
+       }
+
+       if (link) {
+               /* Force the link up with the desired configuration */
+               r_link = 1;
+               r_rx_pause = rx_pause ? 1 : 0;
+               r_tx_pause = tx_pause ? 1 : 0;
+
+               if (speed == SPEED_1000) {
+                       r_speed = RTL8365MB_PORT_SPEED_1000M;
+               } else if (speed == SPEED_100) {
+                       r_speed = RTL8365MB_PORT_SPEED_100M;
+               } else if (speed == SPEED_10) {
+                       r_speed = RTL8365MB_PORT_SPEED_10M;
+               } else {
+                       dev_err(smi->dev, "unsupported port speed %s\n",
+                               phy_speed_to_str(speed));
+                       return -EINVAL;
+               }
+
+               if (duplex == DUPLEX_FULL) {
+                       r_duplex = 1;
+               } else if (duplex == DUPLEX_HALF) {
+                       r_duplex = 0;
+               } else {
+                       dev_err(smi->dev, "unsupported duplex %s\n",
+                               phy_duplex_to_str(duplex));
+                       return -EINVAL;
+               }
+       } else {
+               /* Force the link down and reset any programmed configuration */
+               r_link = 0;
+               r_tx_pause = 0;
+               r_rx_pause = 0;
+               r_speed = 0;
+               r_duplex = 0;
+       }
+
+       val = FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_EN_MASK, 1) |
+             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_TXPAUSE_MASK,
+                        r_tx_pause) |
+             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_RXPAUSE_MASK,
+                        r_rx_pause) |
+             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_LINK_MASK, r_link) |
+             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_DUPLEX_MASK,
+                        r_duplex) |
+             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_SPEED_MASK, r_speed);
+       ret = regmap_write(smi->map,
+                          RTL8365MB_DIGITAL_INTERFACE_FORCE_REG(ext_port),
+                          val);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+static bool rtl8365mb_phy_mode_supported(struct dsa_switch *ds, int port,
+                                        phy_interface_t interface)
+{
+       if (dsa_is_user_port(ds, port) &&
+           (interface == PHY_INTERFACE_MODE_NA ||
+            interface == PHY_INTERFACE_MODE_INTERNAL ||
+            interface == PHY_INTERFACE_MODE_GMII))
+               /* Internal PHY */
+               return true;
+       else if (dsa_is_cpu_port(ds, port) &&
+                phy_interface_mode_is_rgmii(interface))
+               /* Extension MAC */
+               return true;
+
+       return false;
+}
+
+static void rtl8365mb_phylink_validate(struct dsa_switch *ds, int port,
+                                      unsigned long *supported,
+                                      struct phylink_link_state *state)
+{
+       struct realtek_smi *smi = ds->priv;
+       __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0 };
+
+       /* include/linux/phylink.h says:
+        *     When @state->interface is %PHY_INTERFACE_MODE_NA, phylink
+        *     expects the MAC driver to return all supported link modes.
+        */
+       if (state->interface != PHY_INTERFACE_MODE_NA &&
+           !rtl8365mb_phy_mode_supported(ds, port, state->interface)) {
+               dev_err(smi->dev, "phy mode %s is unsupported on port %d\n",
+                       phy_modes(state->interface), port);
+               linkmode_zero(supported);
+               return;
+       }
+
+       phylink_set_port_modes(mask);
+
+       phylink_set(mask, Autoneg);
+       phylink_set(mask, Pause);
+       phylink_set(mask, Asym_Pause);
+
+       phylink_set(mask, 10baseT_Half);
+       phylink_set(mask, 10baseT_Full);
+       phylink_set(mask, 100baseT_Half);
+       phylink_set(mask, 100baseT_Full);
+       phylink_set(mask, 1000baseT_Full);
+
+       linkmode_and(supported, supported, mask);
+       linkmode_and(state->advertising, state->advertising, mask);
+}
+
+static void rtl8365mb_phylink_mac_config(struct dsa_switch *ds, int port,
+                                        unsigned int mode,
+                                        const struct phylink_link_state *state)
+{
+       struct realtek_smi *smi = ds->priv;
+       int ret;
+
+       if (!rtl8365mb_phy_mode_supported(ds, port, state->interface)) {
+               dev_err(smi->dev, "phy mode %s is unsupported on port %d\n",
+                       phy_modes(state->interface), port);
+               return;
+       }
+
+       if (mode != MLO_AN_PHY && mode != MLO_AN_FIXED) {
+               dev_err(smi->dev,
+                       "port %d supports only conventional PHY or fixed-link\n",
+                       port);
+               return;
+       }
+
+       if (phy_interface_mode_is_rgmii(state->interface)) {
+               ret = rtl8365mb_ext_config_rgmii(smi, port, state->interface);
+               if (ret)
+                       dev_err(smi->dev,
+                               "failed to configure RGMII mode on port %d: %d\n",
+                               port, ret);
+               return;
+       }
+
+       /* TODO: Implement MII and RMII modes, which the RTL8365MB-VC also
+        * supports
+        */
+}
+
+static void rtl8365mb_phylink_mac_link_down(struct dsa_switch *ds, int port,
+                                           unsigned int mode,
+                                           phy_interface_t interface)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8365mb_port *p;
+       struct rtl8365mb *mb;
+       int ret;
+
+       mb = smi->chip_data;
+       p = &mb->ports[port];
+       cancel_delayed_work_sync(&p->mib_work);
+
+       if (phy_interface_mode_is_rgmii(interface)) {
+               ret = rtl8365mb_ext_config_forcemode(smi, port, false, 0, 0,
+                                                    false, false);
+               if (ret)
+                       dev_err(smi->dev,
+                               "failed to reset forced mode on port %d: %d\n",
+                               port, ret);
+
+               return;
+       }
+}
+
+static void rtl8365mb_phylink_mac_link_up(struct dsa_switch *ds, int port,
+                                         unsigned int mode,
+                                         phy_interface_t interface,
+                                         struct phy_device *phydev, int speed,
+                                         int duplex, bool tx_pause,
+                                         bool rx_pause)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8365mb_port *p;
+       struct rtl8365mb *mb;
+       int ret;
+
+       mb = smi->chip_data;
+       p = &mb->ports[port];
+       schedule_delayed_work(&p->mib_work, 0);
+
+       if (phy_interface_mode_is_rgmii(interface)) {
+               ret = rtl8365mb_ext_config_forcemode(smi, port, true, speed,
+                                                    duplex, tx_pause,
+                                                    rx_pause);
+               if (ret)
+                       dev_err(smi->dev,
+                               "failed to force mode on port %d: %d\n", port,
+                               ret);
+
+               return;
+       }
+}
+
+static void rtl8365mb_port_stp_state_set(struct dsa_switch *ds, int port,
+                                        u8 state)
+{
+       struct realtek_smi *smi = ds->priv;
+       enum rtl8365mb_stp_state val;
+       int msti = 0;
+
+       switch (state) {
+       case BR_STATE_DISABLED:
+               val = RTL8365MB_STP_STATE_DISABLED;
+               break;
+       case BR_STATE_BLOCKING:
+       case BR_STATE_LISTENING:
+               val = RTL8365MB_STP_STATE_BLOCKING;
+               break;
+       case BR_STATE_LEARNING:
+               val = RTL8365MB_STP_STATE_LEARNING;
+               break;
+       case BR_STATE_FORWARDING:
+               val = RTL8365MB_STP_STATE_FORWARDING;
+               break;
+       default:
+               dev_err(smi->dev, "invalid STP state: %u\n", state);
+               return;
+       }
+
+       regmap_update_bits(smi->map, RTL8365MB_MSTI_CTRL_REG(msti, port),
+                          RTL8365MB_MSTI_CTRL_PORT_STATE_MASK(port),
+                          val << RTL8365MB_MSTI_CTRL_PORT_STATE_OFFSET(port));
+}
+
+static int rtl8365mb_port_set_learning(struct realtek_smi *smi, int port,
+                                      bool enable)
+{
+       struct rtl8365mb *mb = smi->chip_data;
+
+       /* Enable/disable learning by limiting the number of L2 addresses the
+        * port can learn. Realtek documentation states that a limit of zero
+        * disables learning. When enabling learning, set it to the chip's
+        * maximum.
+        */
+       return regmap_write(smi->map, RTL8365MB_LUT_PORT_LEARN_LIMIT_REG(port),
+                           enable ? mb->learn_limit_max : 0);
+}
+
+static int rtl8365mb_port_set_isolation(struct realtek_smi *smi, int port,
+                                       u32 mask)
+{
+       return regmap_write(smi->map, RTL8365MB_PORT_ISOLATION_REG(port), mask);
+}
+
+static int rtl8365mb_mib_counter_read(struct realtek_smi *smi, int port,
+                                     u32 offset, u32 length, u64 *mibvalue)
+{
+       u64 tmpvalue = 0;
+       u32 val;
+       int ret;
+       int i;
+
+       /* The MIB address is an SRAM address. We request a particular address
+        * and then poll the control register before reading the value from some
+        * counter registers.
+        */
+       ret = regmap_write(smi->map, RTL8365MB_MIB_ADDRESS_REG,
+                          RTL8365MB_MIB_ADDRESS(port, offset));
+       if (ret)
+               return ret;
+
+       /* Poll for completion */
+       ret = regmap_read_poll_timeout(smi->map, RTL8365MB_MIB_CTRL0_REG, val,
+                                      !(val & RTL8365MB_MIB_CTRL0_BUSY_MASK),
+                                      10, 100);
+       if (ret)
+               return ret;
+
+       /* Presumably this indicates a MIB counter read failure */
+       if (val & RTL8365MB_MIB_CTRL0_RESET_MASK)
+               return -EIO;
+
+       /* There are four MIB counter registers each holding a 16 bit word of a
+        * MIB counter. Depending on the offset, we should read from the upper
+        * two or lower two registers. In case the MIB counter is 4 words, we
+        * read from all four registers.
+        */
+       if (length == 4)
+               offset = 3;
+       else
+               offset = (offset + 1) % 4;
+
+       /* Read the MIB counter 16 bits at a time */
+       for (i = 0; i < length; i++) {
+               ret = regmap_read(smi->map,
+                                 RTL8365MB_MIB_COUNTER_REG(offset - i), &val);
+               if (ret)
+                       return ret;
+
+               tmpvalue = ((tmpvalue) << 16) | (val & 0xFFFF);
+       }
+
+       /* Only commit the result if no error occurred */
+       *mibvalue = tmpvalue;
+
+       return 0;
+}
+
+static void rtl8365mb_get_ethtool_stats(struct dsa_switch *ds, int port, u64 *data)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8365mb *mb;
+       int ret;
+       int i;
+
+       mb = smi->chip_data;
+
+       mutex_lock(&mb->mib_lock);
+       for (i = 0; i < RTL8365MB_MIB_END; i++) {
+               struct rtl8365mb_mib_counter *mib = &rtl8365mb_mib_counters[i];
+
+               ret = rtl8365mb_mib_counter_read(smi, port, mib->offset,
+                                                mib->length, &data[i]);
+               if (ret) {
+                       dev_err(smi->dev,
+                               "failed to read port %d counters: %d\n", port,
+                               ret);
+                       break;
+               }
+       }
+       mutex_unlock(&mb->mib_lock);
+}
+
+static void rtl8365mb_get_strings(struct dsa_switch *ds, int port, u32 stringset, u8 *data)
+{
+       int i;
+
+       if (stringset != ETH_SS_STATS)
+               return;
+
+       for (i = 0; i < RTL8365MB_MIB_END; i++) {
+               struct rtl8365mb_mib_counter *mib = &rtl8365mb_mib_counters[i];
+
+               strncpy(data + i * ETH_GSTRING_LEN, mib->name, ETH_GSTRING_LEN);
+       }
+}
+
+static int rtl8365mb_get_sset_count(struct dsa_switch *ds, int port, int sset)
+{
+       if (sset != ETH_SS_STATS)
+               return -EOPNOTSUPP;
+
+       return RTL8365MB_MIB_END;
+}
+
+static void rtl8365mb_get_phy_stats(struct dsa_switch *ds, int port,
+                                   struct ethtool_eth_phy_stats *phy_stats)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8365mb_mib_counter *mib;
+       struct rtl8365mb *mb;
+
+       mb = smi->chip_data;
+       mib = &rtl8365mb_mib_counters[RTL8365MB_MIB_dot3StatsSymbolErrors];
+
+       mutex_lock(&mb->mib_lock);
+       rtl8365mb_mib_counter_read(smi, port, mib->offset, mib->length,
+                                  &phy_stats->SymbolErrorDuringCarrier);
+       mutex_unlock(&mb->mib_lock);
+}
+
+static void rtl8365mb_get_mac_stats(struct dsa_switch *ds, int port,
+                                   struct ethtool_eth_mac_stats *mac_stats)
+{
+       u64 cnt[RTL8365MB_MIB_END] = {
+               [RTL8365MB_MIB_ifOutOctets] = 1,
+               [RTL8365MB_MIB_ifOutUcastPkts] = 1,
+               [RTL8365MB_MIB_ifOutMulticastPkts] = 1,
+               [RTL8365MB_MIB_ifOutBroadcastPkts] = 1,
+               [RTL8365MB_MIB_dot3OutPauseFrames] = 1,
+               [RTL8365MB_MIB_ifOutDiscards] = 1,
+               [RTL8365MB_MIB_ifInOctets] = 1,
+               [RTL8365MB_MIB_ifInUcastPkts] = 1,
+               [RTL8365MB_MIB_ifInMulticastPkts] = 1,
+               [RTL8365MB_MIB_ifInBroadcastPkts] = 1,
+               [RTL8365MB_MIB_dot3InPauseFrames] = 1,
+               [RTL8365MB_MIB_dot3StatsSingleCollisionFrames] = 1,
+               [RTL8365MB_MIB_dot3StatsMultipleCollisionFrames] = 1,
+               [RTL8365MB_MIB_dot3StatsFCSErrors] = 1,
+               [RTL8365MB_MIB_dot3StatsDeferredTransmissions] = 1,
+               [RTL8365MB_MIB_dot3StatsLateCollisions] = 1,
+               [RTL8365MB_MIB_dot3StatsExcessiveCollisions] = 1,
+
+       };
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8365mb *mb;
+       int ret;
+       int i;
+
+       mb = smi->chip_data;
+
+       mutex_lock(&mb->mib_lock);
+       for (i = 0; i < RTL8365MB_MIB_END; i++) {
+               struct rtl8365mb_mib_counter *mib = &rtl8365mb_mib_counters[i];
+
+               /* Only fetch required MIB counters (marked = 1 above) */
+               if (!cnt[i])
+                       continue;
+
+               ret = rtl8365mb_mib_counter_read(smi, port, mib->offset,
+                                                mib->length, &cnt[i]);
+               if (ret)
+                       break;
+       }
+       mutex_unlock(&mb->mib_lock);
+
+       /* The RTL8365MB-VC exposes MIB objects, which we have to translate into
+        * IEEE 802.3 Managed Objects. This is not always completely faithful,
+        * but we try out best. See RFC 3635 for a detailed treatment of the
+        * subject.
+        */
+
+       mac_stats->FramesTransmittedOK = cnt[RTL8365MB_MIB_ifOutUcastPkts] +
+                                        cnt[RTL8365MB_MIB_ifOutMulticastPkts] +
+                                        cnt[RTL8365MB_MIB_ifOutBroadcastPkts] +
+                                        cnt[RTL8365MB_MIB_dot3OutPauseFrames] -
+                                        cnt[RTL8365MB_MIB_ifOutDiscards];
+       mac_stats->SingleCollisionFrames =
+               cnt[RTL8365MB_MIB_dot3StatsSingleCollisionFrames];
+       mac_stats->MultipleCollisionFrames =
+               cnt[RTL8365MB_MIB_dot3StatsMultipleCollisionFrames];
+       mac_stats->FramesReceivedOK = cnt[RTL8365MB_MIB_ifInUcastPkts] +
+                                     cnt[RTL8365MB_MIB_ifInMulticastPkts] +
+                                     cnt[RTL8365MB_MIB_ifInBroadcastPkts] +
+                                     cnt[RTL8365MB_MIB_dot3InPauseFrames];
+       mac_stats->FrameCheckSequenceErrors =
+               cnt[RTL8365MB_MIB_dot3StatsFCSErrors];
+       mac_stats->OctetsTransmittedOK = cnt[RTL8365MB_MIB_ifOutOctets] -
+                                        18 * mac_stats->FramesTransmittedOK;
+       mac_stats->FramesWithDeferredXmissions =
+               cnt[RTL8365MB_MIB_dot3StatsDeferredTransmissions];
+       mac_stats->LateCollisions = cnt[RTL8365MB_MIB_dot3StatsLateCollisions];
+       mac_stats->FramesAbortedDueToXSColls =
+               cnt[RTL8365MB_MIB_dot3StatsExcessiveCollisions];
+       mac_stats->OctetsReceivedOK = cnt[RTL8365MB_MIB_ifInOctets] -
+                                     18 * mac_stats->FramesReceivedOK;
+       mac_stats->MulticastFramesXmittedOK =
+               cnt[RTL8365MB_MIB_ifOutMulticastPkts];
+       mac_stats->BroadcastFramesXmittedOK =
+               cnt[RTL8365MB_MIB_ifOutBroadcastPkts];
+       mac_stats->MulticastFramesReceivedOK =
+               cnt[RTL8365MB_MIB_ifInMulticastPkts];
+       mac_stats->BroadcastFramesReceivedOK =
+               cnt[RTL8365MB_MIB_ifInBroadcastPkts];
+}
+
+static void rtl8365mb_get_ctrl_stats(struct dsa_switch *ds, int port,
+                                    struct ethtool_eth_ctrl_stats *ctrl_stats)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8365mb_mib_counter *mib;
+       struct rtl8365mb *mb;
+
+       mb = smi->chip_data;
+       mib = &rtl8365mb_mib_counters[RTL8365MB_MIB_dot3ControlInUnknownOpcodes];
+
+       mutex_lock(&mb->mib_lock);
+       rtl8365mb_mib_counter_read(smi, port, mib->offset, mib->length,
+                                  &ctrl_stats->UnsupportedOpcodesReceived);
+       mutex_unlock(&mb->mib_lock);
+}
+
+static void rtl8365mb_stats_update(struct realtek_smi *smi, int port)
+{
+       u64 cnt[RTL8365MB_MIB_END] = {
+               [RTL8365MB_MIB_ifOutOctets] = 1,
+               [RTL8365MB_MIB_ifOutUcastPkts] = 1,
+               [RTL8365MB_MIB_ifOutMulticastPkts] = 1,
+               [RTL8365MB_MIB_ifOutBroadcastPkts] = 1,
+               [RTL8365MB_MIB_ifOutDiscards] = 1,
+               [RTL8365MB_MIB_ifInOctets] = 1,
+               [RTL8365MB_MIB_ifInUcastPkts] = 1,
+               [RTL8365MB_MIB_ifInMulticastPkts] = 1,
+               [RTL8365MB_MIB_ifInBroadcastPkts] = 1,
+               [RTL8365MB_MIB_etherStatsDropEvents] = 1,
+               [RTL8365MB_MIB_etherStatsCollisions] = 1,
+               [RTL8365MB_MIB_etherStatsFragments] = 1,
+               [RTL8365MB_MIB_etherStatsJabbers] = 1,
+               [RTL8365MB_MIB_dot3StatsFCSErrors] = 1,
+               [RTL8365MB_MIB_dot3StatsLateCollisions] = 1,
+       };
+       struct rtl8365mb *mb = smi->chip_data;
+       struct rtnl_link_stats64 *stats;
+       int ret;
+       int i;
+
+       stats = &mb->ports[port].stats;
+
+       mutex_lock(&mb->mib_lock);
+       for (i = 0; i < RTL8365MB_MIB_END; i++) {
+               struct rtl8365mb_mib_counter *c = &rtl8365mb_mib_counters[i];
+
+               /* Only fetch required MIB counters (marked = 1 above) */
+               if (!cnt[i])
+                       continue;
+
+               ret = rtl8365mb_mib_counter_read(smi, port, c->offset,
+                                                c->length, &cnt[i]);
+               if (ret)
+                       break;
+       }
+       mutex_unlock(&mb->mib_lock);
+
+       /* Don't update statistics if there was an error reading the counters */
+       if (ret)
+               return;
+
+       spin_lock(&mb->ports[port].stats_lock);
+
+       stats->rx_packets = cnt[RTL8365MB_MIB_ifInUcastPkts] +
+                           cnt[RTL8365MB_MIB_ifInMulticastPkts] +
+                           cnt[RTL8365MB_MIB_ifInBroadcastPkts] -
+                           cnt[RTL8365MB_MIB_ifOutDiscards];
+
+       stats->tx_packets = cnt[RTL8365MB_MIB_ifOutUcastPkts] +
+                           cnt[RTL8365MB_MIB_ifOutMulticastPkts] +
+                           cnt[RTL8365MB_MIB_ifOutBroadcastPkts];
+
+       /* if{In,Out}Octets includes FCS - remove it */
+       stats->rx_bytes = cnt[RTL8365MB_MIB_ifInOctets] - 4 * stats->rx_packets;
+       stats->tx_bytes =
+               cnt[RTL8365MB_MIB_ifOutOctets] - 4 * stats->tx_packets;
+
+       stats->rx_dropped = cnt[RTL8365MB_MIB_etherStatsDropEvents];
+       stats->tx_dropped = cnt[RTL8365MB_MIB_ifOutDiscards];
+
+       stats->multicast = cnt[RTL8365MB_MIB_ifInMulticastPkts];
+       stats->collisions = cnt[RTL8365MB_MIB_etherStatsCollisions];
+
+       stats->rx_length_errors = cnt[RTL8365MB_MIB_etherStatsFragments] +
+                                 cnt[RTL8365MB_MIB_etherStatsJabbers];
+       stats->rx_crc_errors = cnt[RTL8365MB_MIB_dot3StatsFCSErrors];
+       stats->rx_errors = stats->rx_length_errors + stats->rx_crc_errors;
+
+       stats->tx_aborted_errors = cnt[RTL8365MB_MIB_ifOutDiscards];
+       stats->tx_window_errors = cnt[RTL8365MB_MIB_dot3StatsLateCollisions];
+       stats->tx_errors = stats->tx_aborted_errors + stats->tx_window_errors;
+
+       spin_unlock(&mb->ports[port].stats_lock);
+}
+
+static void rtl8365mb_stats_poll(struct work_struct *work)
+{
+       struct rtl8365mb_port *p = container_of(to_delayed_work(work),
+                                               struct rtl8365mb_port,
+                                               mib_work);
+       struct realtek_smi *smi = p->smi;
+
+       rtl8365mb_stats_update(smi, p->index);
+
+       schedule_delayed_work(&p->mib_work, RTL8365MB_STATS_INTERVAL_JIFFIES);
+}
+
+static void rtl8365mb_get_stats64(struct dsa_switch *ds, int port,
+                                 struct rtnl_link_stats64 *s)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8365mb_port *p;
+       struct rtl8365mb *mb;
+
+       mb = smi->chip_data;
+       p = &mb->ports[port];
+
+       spin_lock(&p->stats_lock);
+       memcpy(s, &p->stats, sizeof(*s));
+       spin_unlock(&p->stats_lock);
+}
+
+static void rtl8365mb_stats_setup(struct realtek_smi *smi)
+{
+       struct rtl8365mb *mb = smi->chip_data;
+       int i;
+
+       /* Per-chip global mutex to protect MIB counter access, since doing
+        * so requires accessing a series of registers in a particular order.
+        */
+       mutex_init(&mb->mib_lock);
+
+       for (i = 0; i < smi->num_ports; i++) {
+               struct rtl8365mb_port *p = &mb->ports[i];
+
+               if (dsa_is_unused_port(smi->ds, i))
+                       continue;
+
+               /* Per-port spinlock to protect the stats64 data */
+               spin_lock_init(&p->stats_lock);
+
+               /* This work polls the MIB counters and keeps the stats64 data
+                * up-to-date.
+                */
+               INIT_DELAYED_WORK(&p->mib_work, rtl8365mb_stats_poll);
+       }
+}
+
+static void rtl8365mb_stats_teardown(struct realtek_smi *smi)
+{
+       struct rtl8365mb *mb = smi->chip_data;
+       int i;
+
+       for (i = 0; i < smi->num_ports; i++) {
+               struct rtl8365mb_port *p = &mb->ports[i];
+
+               if (dsa_is_unused_port(smi->ds, i))
+                       continue;
+
+               cancel_delayed_work_sync(&p->mib_work);
+       }
+}
+
+static int rtl8365mb_get_and_clear_status_reg(struct realtek_smi *smi, u32 reg,
+                                             u32 *val)
+{
+       int ret;
+
+       ret = regmap_read(smi->map, reg, val);
+       if (ret)
+               return ret;
+
+       return regmap_write(smi->map, reg, *val);
+}
+
+static irqreturn_t rtl8365mb_irq(int irq, void *data)
+{
+       struct realtek_smi *smi = data;
+       unsigned long line_changes = 0;
+       struct rtl8365mb *mb;
+       u32 stat;
+       int line;
+       int ret;
+
+       mb = smi->chip_data;
+
+       ret = rtl8365mb_get_and_clear_status_reg(smi, RTL8365MB_INTR_STATUS_REG,
+                                                &stat);
+       if (ret)
+               goto out_error;
+
+       if (stat & RTL8365MB_INTR_LINK_CHANGE_MASK) {
+               u32 linkdown_ind;
+               u32 linkup_ind;
+               u32 val;
+
+               ret = rtl8365mb_get_and_clear_status_reg(
+                       smi, RTL8365MB_PORT_LINKUP_IND_REG, &val);
+               if (ret)
+                       goto out_error;
+
+               linkup_ind = FIELD_GET(RTL8365MB_PORT_LINKUP_IND_MASK, val);
+
+               ret = rtl8365mb_get_and_clear_status_reg(
+                       smi, RTL8365MB_PORT_LINKDOWN_IND_REG, &val);
+               if (ret)
+                       goto out_error;
+
+               linkdown_ind = FIELD_GET(RTL8365MB_PORT_LINKDOWN_IND_MASK, val);
+
+               line_changes = (linkup_ind | linkdown_ind) & mb->port_mask;
+       }
+
+       if (!line_changes)
+               goto out_none;
+
+       for_each_set_bit(line, &line_changes, smi->num_ports) {
+               int child_irq = irq_find_mapping(smi->irqdomain, line);
+
+               handle_nested_irq(child_irq);
+       }
+
+       return IRQ_HANDLED;
+
+out_error:
+       dev_err(smi->dev, "failed to read interrupt status: %d\n", ret);
+
+out_none:
+       return IRQ_NONE;
+}
+
+static struct irq_chip rtl8365mb_irq_chip = {
+       .name = "rtl8365mb",
+       /* The hardware doesn't support masking IRQs on a per-port basis */
+};
+
+static int rtl8365mb_irq_map(struct irq_domain *domain, unsigned int irq,
+                            irq_hw_number_t hwirq)
+{
+       irq_set_chip_data(irq, domain->host_data);
+       irq_set_chip_and_handler(irq, &rtl8365mb_irq_chip, handle_simple_irq);
+       irq_set_nested_thread(irq, 1);
+       irq_set_noprobe(irq);
+
+       return 0;
+}
+
+static void rtl8365mb_irq_unmap(struct irq_domain *d, unsigned int irq)
+{
+       irq_set_nested_thread(irq, 0);
+       irq_set_chip_and_handler(irq, NULL, NULL);
+       irq_set_chip_data(irq, NULL);
+}
+
+static const struct irq_domain_ops rtl8365mb_irqdomain_ops = {
+       .map = rtl8365mb_irq_map,
+       .unmap = rtl8365mb_irq_unmap,
+       .xlate = irq_domain_xlate_onecell,
+};
+
+static int rtl8365mb_set_irq_enable(struct realtek_smi *smi, bool enable)
+{
+       return regmap_update_bits(smi->map, RTL8365MB_INTR_CTRL_REG,
+                                 RTL8365MB_INTR_LINK_CHANGE_MASK,
+                                 FIELD_PREP(RTL8365MB_INTR_LINK_CHANGE_MASK,
+                                            enable ? 1 : 0));
+}
+
+static int rtl8365mb_irq_enable(struct realtek_smi *smi)
+{
+       return rtl8365mb_set_irq_enable(smi, true);
+}
+
+static int rtl8365mb_irq_disable(struct realtek_smi *smi)
+{
+       return rtl8365mb_set_irq_enable(smi, false);
+}
+
+static int rtl8365mb_irq_setup(struct realtek_smi *smi)
+{
+       struct rtl8365mb *mb = smi->chip_data;
+       struct device_node *intc;
+       u32 irq_trig;
+       int virq;
+       int irq;
+       u32 val;
+       int ret;
+       int i;
+
+       intc = of_get_child_by_name(smi->dev->of_node, "interrupt-controller");
+       if (!intc) {
+               dev_err(smi->dev, "missing child interrupt-controller node\n");
+               return -EINVAL;
+       }
+
+       /* rtl8365mb IRQs cascade off this one */
+       irq = of_irq_get(intc, 0);
+       if (irq <= 0) {
+               if (irq != -EPROBE_DEFER)
+                       dev_err(smi->dev, "failed to get parent irq: %d\n",
+                               irq);
+               ret = irq ? irq : -EINVAL;
+               goto out_put_node;
+       }
+
+       smi->irqdomain = irq_domain_add_linear(intc, smi->num_ports,
+                                              &rtl8365mb_irqdomain_ops, smi);
+       if (!smi->irqdomain) {
+               dev_err(smi->dev, "failed to add irq domain\n");
+               ret = -ENOMEM;
+               goto out_put_node;
+       }
+
+       for (i = 0; i < smi->num_ports; i++) {
+               virq = irq_create_mapping(smi->irqdomain, i);
+               if (!virq) {
+                       dev_err(smi->dev,
+                               "failed to create irq domain mapping\n");
+                       ret = -EINVAL;
+                       goto out_remove_irqdomain;
+               }
+
+               irq_set_parent(virq, irq);
+       }
+
+       /* Configure chip interrupt signal polarity */
+       irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
+       switch (irq_trig) {
+       case IRQF_TRIGGER_RISING:
+       case IRQF_TRIGGER_HIGH:
+               val = RTL8365MB_INTR_POLARITY_HIGH;
+               break;
+       case IRQF_TRIGGER_FALLING:
+       case IRQF_TRIGGER_LOW:
+               val = RTL8365MB_INTR_POLARITY_LOW;
+               break;
+       default:
+               dev_err(smi->dev, "unsupported irq trigger type %u\n",
+                       irq_trig);
+               ret = -EINVAL;
+               goto out_remove_irqdomain;
+       }
+
+       ret = regmap_update_bits(smi->map, RTL8365MB_INTR_POLARITY_REG,
+                                RTL8365MB_INTR_POLARITY_MASK,
+                                FIELD_PREP(RTL8365MB_INTR_POLARITY_MASK, val));
+       if (ret)
+               goto out_remove_irqdomain;
+
+       /* Disable the interrupt in case the chip has it enabled on reset */
+       ret = rtl8365mb_irq_disable(smi);
+       if (ret)
+               goto out_remove_irqdomain;
+
+       /* Clear the interrupt status register */
+       ret = regmap_write(smi->map, RTL8365MB_INTR_STATUS_REG,
+                          RTL8365MB_INTR_ALL_MASK);
+       if (ret)
+               goto out_remove_irqdomain;
+
+       ret = request_threaded_irq(irq, NULL, rtl8365mb_irq, IRQF_ONESHOT,
+                                  "rtl8365mb", smi);
+       if (ret) {
+               dev_err(smi->dev, "failed to request irq: %d\n", ret);
+               goto out_remove_irqdomain;
+       }
+
+       /* Store the irq so that we know to free it during teardown */
+       mb->irq = irq;
+
+       ret = rtl8365mb_irq_enable(smi);
+       if (ret)
+               goto out_free_irq;
+
+       of_node_put(intc);
+
+       return 0;
+
+out_free_irq:
+       free_irq(mb->irq, smi);
+       mb->irq = 0;
+
+out_remove_irqdomain:
+       for (i = 0; i < smi->num_ports; i++) {
+               virq = irq_find_mapping(smi->irqdomain, i);
+               irq_dispose_mapping(virq);
+       }
+
+       irq_domain_remove(smi->irqdomain);
+       smi->irqdomain = NULL;
+
+out_put_node:
+       of_node_put(intc);
+
+       return ret;
+}
+
+static void rtl8365mb_irq_teardown(struct realtek_smi *smi)
+{
+       struct rtl8365mb *mb = smi->chip_data;
+       int virq;
+       int i;
+
+       if (mb->irq) {
+               free_irq(mb->irq, smi);
+               mb->irq = 0;
+       }
+
+       if (smi->irqdomain) {
+               for (i = 0; i < smi->num_ports; i++) {
+                       virq = irq_find_mapping(smi->irqdomain, i);
+                       irq_dispose_mapping(virq);
+               }
+
+               irq_domain_remove(smi->irqdomain);
+               smi->irqdomain = NULL;
+       }
+}
+
+static int rtl8365mb_cpu_config(struct realtek_smi *smi)
+{
+       struct rtl8365mb *mb = smi->chip_data;
+       struct rtl8365mb_cpu *cpu = &mb->cpu;
+       u32 val;
+       int ret;
+
+       ret = regmap_update_bits(smi->map, RTL8365MB_CPU_PORT_MASK_REG,
+                                RTL8365MB_CPU_PORT_MASK_MASK,
+                                FIELD_PREP(RTL8365MB_CPU_PORT_MASK_MASK,
+                                           cpu->mask));
+       if (ret)
+               return ret;
+
+       val = FIELD_PREP(RTL8365MB_CPU_CTRL_EN_MASK, cpu->enable ? 1 : 0) |
+             FIELD_PREP(RTL8365MB_CPU_CTRL_INSERTMODE_MASK, cpu->insert) |
+             FIELD_PREP(RTL8365MB_CPU_CTRL_TAG_POSITION_MASK, cpu->position) |
+             FIELD_PREP(RTL8365MB_CPU_CTRL_RXBYTECOUNT_MASK, cpu->rx_length) |
+             FIELD_PREP(RTL8365MB_CPU_CTRL_TAG_FORMAT_MASK, cpu->format) |
+             FIELD_PREP(RTL8365MB_CPU_CTRL_TRAP_PORT_MASK, cpu->trap_port) |
+             FIELD_PREP(RTL8365MB_CPU_CTRL_TRAP_PORT_EXT_MASK,
+                        cpu->trap_port >> 3);
+       ret = regmap_write(smi->map, RTL8365MB_CPU_CTRL_REG, val);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+static int rtl8365mb_switch_init(struct realtek_smi *smi)
+{
+       struct rtl8365mb *mb = smi->chip_data;
+       int ret;
+       int i;
+
+       /* Do any chip-specific init jam before getting to the common stuff */
+       if (mb->jam_table) {
+               for (i = 0; i < mb->jam_size; i++) {
+                       ret = regmap_write(smi->map, mb->jam_table[i].reg,
+                                          mb->jam_table[i].val);
+                       if (ret)
+                               return ret;
+               }
+       }
+
+       /* Common init jam */
+       for (i = 0; i < ARRAY_SIZE(rtl8365mb_init_jam_common); i++) {
+               ret = regmap_write(smi->map, rtl8365mb_init_jam_common[i].reg,
+                                  rtl8365mb_init_jam_common[i].val);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+
+static int rtl8365mb_reset_chip(struct realtek_smi *smi)
+{
+       u32 val;
+
+       realtek_smi_write_reg_noack(smi, RTL8365MB_CHIP_RESET_REG,
+                                   FIELD_PREP(RTL8365MB_CHIP_RESET_HW_MASK,
+                                              1));
+
+       /* Realtek documentation says the chip needs 1 second to reset. Sleep
+        * for 100 ms before accessing any registers to prevent ACK timeouts.
+        */
+       msleep(100);
+       return regmap_read_poll_timeout(smi->map, RTL8365MB_CHIP_RESET_REG, val,
+                                       !(val & RTL8365MB_CHIP_RESET_HW_MASK),
+                                       20000, 1e6);
+}
+
+static int rtl8365mb_setup(struct dsa_switch *ds)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8365mb *mb;
+       int ret;
+       int i;
+
+       mb = smi->chip_data;
+
+       ret = rtl8365mb_reset_chip(smi);
+       if (ret) {
+               dev_err(smi->dev, "failed to reset chip: %d\n", ret);
+               goto out_error;
+       }
+
+       /* Configure switch to vendor-defined initial state */
+       ret = rtl8365mb_switch_init(smi);
+       if (ret) {
+               dev_err(smi->dev, "failed to initialize switch: %d\n", ret);
+               goto out_error;
+       }
+
+       /* Set up cascading IRQs */
+       ret = rtl8365mb_irq_setup(smi);
+       if (ret == -EPROBE_DEFER)
+               return ret;
+       else if (ret)
+               dev_info(smi->dev, "no interrupt support\n");
+
+       /* Configure CPU tagging */
+       ret = rtl8365mb_cpu_config(smi);
+       if (ret)
+               goto out_teardown_irq;
+
+       /* Configure ports */
+       for (i = 0; i < smi->num_ports; i++) {
+               struct rtl8365mb_port *p = &mb->ports[i];
+
+               if (dsa_is_unused_port(smi->ds, i))
+                       continue;
+
+               /* Set up per-port private data */
+               p->smi = smi;
+               p->index = i;
+
+               /* Forward only to the CPU */
+               ret = rtl8365mb_port_set_isolation(smi, i, BIT(smi->cpu_port));
+               if (ret)
+                       goto out_teardown_irq;
+
+               /* Disable learning */
+               ret = rtl8365mb_port_set_learning(smi, i, false);
+               if (ret)
+                       goto out_teardown_irq;
+
+               /* Set the initial STP state of all ports to DISABLED, otherwise
+                * ports will still forward frames to the CPU despite being
+                * administratively down by default.
+                */
+               rtl8365mb_port_stp_state_set(smi->ds, i, BR_STATE_DISABLED);
+       }
+
+       /* Set maximum packet length to 1536 bytes */
+       ret = regmap_update_bits(smi->map, RTL8365MB_CFG0_MAX_LEN_REG,
+                                RTL8365MB_CFG0_MAX_LEN_MASK,
+                                FIELD_PREP(RTL8365MB_CFG0_MAX_LEN_MASK, 1536));
+       if (ret)
+               goto out_teardown_irq;
+
+       ret = realtek_smi_setup_mdio(smi);
+       if (ret) {
+               dev_err(smi->dev, "could not set up MDIO bus\n");
+               goto out_teardown_irq;
+       }
+
+       /* Start statistics counter polling */
+       rtl8365mb_stats_setup(smi);
+
+       return 0;
+
+out_teardown_irq:
+       rtl8365mb_irq_teardown(smi);
+
+out_error:
+       return ret;
+}
+
+static void rtl8365mb_teardown(struct dsa_switch *ds)
+{
+       struct realtek_smi *smi = ds->priv;
+
+       rtl8365mb_stats_teardown(smi);
+       rtl8365mb_irq_teardown(smi);
+}
+
+static int rtl8365mb_get_chip_id_and_ver(struct regmap *map, u32 *id, u32 *ver)
+{
+       int ret;
+
+       /* For some reason we have to write a magic value to an arbitrary
+        * register whenever accessing the chip ID/version registers.
+        */
+       ret = regmap_write(map, RTL8365MB_MAGIC_REG, RTL8365MB_MAGIC_VALUE);
+       if (ret)
+               return ret;
+
+       ret = regmap_read(map, RTL8365MB_CHIP_ID_REG, id);
+       if (ret)
+               return ret;
+
+       ret = regmap_read(map, RTL8365MB_CHIP_VER_REG, ver);
+       if (ret)
+               return ret;
+
+       /* Reset magic register */
+       ret = regmap_write(map, RTL8365MB_MAGIC_REG, 0);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+static int rtl8365mb_detect(struct realtek_smi *smi)
+{
+       struct rtl8365mb *mb = smi->chip_data;
+       u32 chip_id;
+       u32 chip_ver;
+       int ret;
+
+       ret = rtl8365mb_get_chip_id_and_ver(smi->map, &chip_id, &chip_ver);
+       if (ret) {
+               dev_err(smi->dev, "failed to read chip id and version: %d\n",
+                       ret);
+               return ret;
+       }
+
+       switch (chip_id) {
+       case RTL8365MB_CHIP_ID_8365MB_VC:
+               dev_info(smi->dev,
+                        "found an RTL8365MB-VC switch (ver=0x%04x)\n",
+                        chip_ver);
+
+               smi->cpu_port = RTL8365MB_CPU_PORT_NUM_8365MB_VC;
+               smi->num_ports = smi->cpu_port + 1;
+
+               mb->smi = smi;
+               mb->chip_id = chip_id;
+               mb->chip_ver = chip_ver;
+               mb->port_mask = BIT(smi->num_ports) - 1;
+               mb->learn_limit_max = RTL8365MB_LEARN_LIMIT_MAX_8365MB_VC;
+               mb->jam_table = rtl8365mb_init_jam_8365mb_vc;
+               mb->jam_size = ARRAY_SIZE(rtl8365mb_init_jam_8365mb_vc);
+
+               mb->cpu.enable = 1;
+               mb->cpu.mask = BIT(smi->cpu_port);
+               mb->cpu.trap_port = smi->cpu_port;
+               mb->cpu.insert = RTL8365MB_CPU_INSERT_TO_ALL;
+               mb->cpu.position = RTL8365MB_CPU_POS_AFTER_SA;
+               mb->cpu.rx_length = RTL8365MB_CPU_RXLEN_64BYTES;
+               mb->cpu.format = RTL8365MB_CPU_FORMAT_8BYTES;
+
+               break;
+       default:
+               dev_err(smi->dev,
+                       "found an unknown Realtek switch (id=0x%04x, ver=0x%04x)\n",
+                       chip_id, chip_ver);
+               return -ENODEV;
+       }
+
+       return 0;
+}
+
+static const struct dsa_switch_ops rtl8365mb_switch_ops = {
+       .get_tag_protocol = rtl8365mb_get_tag_protocol,
+       .setup = rtl8365mb_setup,
+       .teardown = rtl8365mb_teardown,
+       .phylink_validate = rtl8365mb_phylink_validate,
+       .phylink_mac_config = rtl8365mb_phylink_mac_config,
+       .phylink_mac_link_down = rtl8365mb_phylink_mac_link_down,
+       .phylink_mac_link_up = rtl8365mb_phylink_mac_link_up,
+       .port_stp_state_set = rtl8365mb_port_stp_state_set,
+       .get_strings = rtl8365mb_get_strings,
+       .get_ethtool_stats = rtl8365mb_get_ethtool_stats,
+       .get_sset_count = rtl8365mb_get_sset_count,
+       .get_eth_phy_stats = rtl8365mb_get_phy_stats,
+       .get_eth_mac_stats = rtl8365mb_get_mac_stats,
+       .get_eth_ctrl_stats = rtl8365mb_get_ctrl_stats,
+       .get_stats64 = rtl8365mb_get_stats64,
+};
+
+static const struct realtek_smi_ops rtl8365mb_smi_ops = {
+       .detect = rtl8365mb_detect,
+       .phy_read = rtl8365mb_phy_read,
+       .phy_write = rtl8365mb_phy_write,
+};
+
+const struct realtek_smi_variant rtl8365mb_variant = {
+       .ds_ops = &rtl8365mb_switch_ops,
+       .ops = &rtl8365mb_smi_ops,
+       .clk_delay = 10,
+       .cmd_read = 0xb9,
+       .cmd_write = 0xb8,
+       .chip_data_sz = sizeof(struct rtl8365mb),
+};
+EXPORT_SYMBOL_GPL(rtl8365mb_variant);
diff --git a/drivers/net/dsa/realtek/rtl8366.c b/drivers/net/dsa/realtek/rtl8366.c
new file mode 100644 (file)
index 0000000..bdb8d8d
--- /dev/null
@@ -0,0 +1,448 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Realtek SMI library helpers for the RTL8366x variants
+ * RTL8366RB and RTL8366S
+ *
+ * Copyright (C) 2017 Linus Walleij <linus.walleij@linaro.org>
+ * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
+ * Copyright (C) 2010 Antti Seppälä <a.seppala@gmail.com>
+ * Copyright (C) 2010 Roman Yeryomin <roman@advem.lv>
+ * Copyright (C) 2011 Colin Leitner <colin.leitner@googlemail.com>
+ */
+#include <linux/if_bridge.h>
+#include <net/dsa.h>
+
+#include "realtek-smi-core.h"
+
+int rtl8366_mc_is_used(struct realtek_smi *smi, int mc_index, int *used)
+{
+       int ret;
+       int i;
+
+       *used = 0;
+       for (i = 0; i < smi->num_ports; i++) {
+               int index = 0;
+
+               ret = smi->ops->get_mc_index(smi, i, &index);
+               if (ret)
+                       return ret;
+
+               if (mc_index == index) {
+                       *used = 1;
+                       break;
+               }
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(rtl8366_mc_is_used);
+
+/**
+ * rtl8366_obtain_mc() - retrieve or allocate a VLAN member configuration
+ * @smi: the Realtek SMI device instance
+ * @vid: the VLAN ID to look up or allocate
+ * @vlanmc: the pointer will be assigned to a pointer to a valid member config
+ * if successful
+ * @return: index of a new member config or negative error number
+ */
+static int rtl8366_obtain_mc(struct realtek_smi *smi, int vid,
+                            struct rtl8366_vlan_mc *vlanmc)
+{
+       struct rtl8366_vlan_4k vlan4k;
+       int ret;
+       int i;
+
+       /* Try to find an existing member config entry for this VID */
+       for (i = 0; i < smi->num_vlan_mc; i++) {
+               ret = smi->ops->get_vlan_mc(smi, i, vlanmc);
+               if (ret) {
+                       dev_err(smi->dev, "error searching for VLAN MC %d for VID %d\n",
+                               i, vid);
+                       return ret;
+               }
+
+               if (vid == vlanmc->vid)
+                       return i;
+       }
+
+       /* We have no MC entry for this VID, try to find an empty one */
+       for (i = 0; i < smi->num_vlan_mc; i++) {
+               ret = smi->ops->get_vlan_mc(smi, i, vlanmc);
+               if (ret) {
+                       dev_err(smi->dev, "error searching for VLAN MC %d for VID %d\n",
+                               i, vid);
+                       return ret;
+               }
+
+               if (vlanmc->vid == 0 && vlanmc->member == 0) {
+                       /* Update the entry from the 4K table */
+                       ret = smi->ops->get_vlan_4k(smi, vid, &vlan4k);
+                       if (ret) {
+                               dev_err(smi->dev, "error looking for 4K VLAN MC %d for VID %d\n",
+                                       i, vid);
+                               return ret;
+                       }
+
+                       vlanmc->vid = vid;
+                       vlanmc->member = vlan4k.member;
+                       vlanmc->untag = vlan4k.untag;
+                       vlanmc->fid = vlan4k.fid;
+                       ret = smi->ops->set_vlan_mc(smi, i, vlanmc);
+                       if (ret) {
+                               dev_err(smi->dev, "unable to set/update VLAN MC %d for VID %d\n",
+                                       i, vid);
+                               return ret;
+                       }
+
+                       dev_dbg(smi->dev, "created new MC at index %d for VID %d\n",
+                               i, vid);
+                       return i;
+               }
+       }
+
+       /* MC table is full, try to find an unused entry and replace it */
+       for (i = 0; i < smi->num_vlan_mc; i++) {
+               int used;
+
+               ret = rtl8366_mc_is_used(smi, i, &used);
+               if (ret)
+                       return ret;
+
+               if (!used) {
+                       /* Update the entry from the 4K table */
+                       ret = smi->ops->get_vlan_4k(smi, vid, &vlan4k);
+                       if (ret)
+                               return ret;
+
+                       vlanmc->vid = vid;
+                       vlanmc->member = vlan4k.member;
+                       vlanmc->untag = vlan4k.untag;
+                       vlanmc->fid = vlan4k.fid;
+                       ret = smi->ops->set_vlan_mc(smi, i, vlanmc);
+                       if (ret) {
+                               dev_err(smi->dev, "unable to set/update VLAN MC %d for VID %d\n",
+                                       i, vid);
+                               return ret;
+                       }
+                       dev_dbg(smi->dev, "recycled MC at index %i for VID %d\n",
+                               i, vid);
+                       return i;
+               }
+       }
+
+       dev_err(smi->dev, "all VLAN member configurations are in use\n");
+       return -ENOSPC;
+}
+
+int rtl8366_set_vlan(struct realtek_smi *smi, int vid, u32 member,
+                    u32 untag, u32 fid)
+{
+       struct rtl8366_vlan_mc vlanmc;
+       struct rtl8366_vlan_4k vlan4k;
+       int mc;
+       int ret;
+
+       if (!smi->ops->is_vlan_valid(smi, vid))
+               return -EINVAL;
+
+       dev_dbg(smi->dev,
+               "setting VLAN%d 4k members: 0x%02x, untagged: 0x%02x\n",
+               vid, member, untag);
+
+       /* Update the 4K table */
+       ret = smi->ops->get_vlan_4k(smi, vid, &vlan4k);
+       if (ret)
+               return ret;
+
+       vlan4k.member |= member;
+       vlan4k.untag |= untag;
+       vlan4k.fid = fid;
+       ret = smi->ops->set_vlan_4k(smi, &vlan4k);
+       if (ret)
+               return ret;
+
+       dev_dbg(smi->dev,
+               "resulting VLAN%d 4k members: 0x%02x, untagged: 0x%02x\n",
+               vid, vlan4k.member, vlan4k.untag);
+
+       /* Find or allocate a member config for this VID */
+       ret = rtl8366_obtain_mc(smi, vid, &vlanmc);
+       if (ret < 0)
+               return ret;
+       mc = ret;
+
+       /* Update the MC entry */
+       vlanmc.member |= member;
+       vlanmc.untag |= untag;
+       vlanmc.fid = fid;
+
+       /* Commit updates to the MC entry */
+       ret = smi->ops->set_vlan_mc(smi, mc, &vlanmc);
+       if (ret)
+               dev_err(smi->dev, "failed to commit changes to VLAN MC index %d for VID %d\n",
+                       mc, vid);
+       else
+               dev_dbg(smi->dev,
+                       "resulting VLAN%d MC members: 0x%02x, untagged: 0x%02x\n",
+                       vid, vlanmc.member, vlanmc.untag);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(rtl8366_set_vlan);
+
+int rtl8366_set_pvid(struct realtek_smi *smi, unsigned int port,
+                    unsigned int vid)
+{
+       struct rtl8366_vlan_mc vlanmc;
+       int mc;
+       int ret;
+
+       if (!smi->ops->is_vlan_valid(smi, vid))
+               return -EINVAL;
+
+       /* Find or allocate a member config for this VID */
+       ret = rtl8366_obtain_mc(smi, vid, &vlanmc);
+       if (ret < 0)
+               return ret;
+       mc = ret;
+
+       ret = smi->ops->set_mc_index(smi, port, mc);
+       if (ret) {
+               dev_err(smi->dev, "set PVID: failed to set MC index %d for port %d\n",
+                       mc, port);
+               return ret;
+       }
+
+       dev_dbg(smi->dev, "set PVID: the PVID for port %d set to %d using existing MC index %d\n",
+               port, vid, mc);
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(rtl8366_set_pvid);
+
+int rtl8366_enable_vlan4k(struct realtek_smi *smi, bool enable)
+{
+       int ret;
+
+       /* To enable 4k VLAN, ordinary VLAN must be enabled first,
+        * but if we disable 4k VLAN it is fine to leave ordinary
+        * VLAN enabled.
+        */
+       if (enable) {
+               /* Make sure VLAN is ON */
+               ret = smi->ops->enable_vlan(smi, true);
+               if (ret)
+                       return ret;
+
+               smi->vlan_enabled = true;
+       }
+
+       ret = smi->ops->enable_vlan4k(smi, enable);
+       if (ret)
+               return ret;
+
+       smi->vlan4k_enabled = enable;
+       return 0;
+}
+EXPORT_SYMBOL_GPL(rtl8366_enable_vlan4k);
+
+int rtl8366_enable_vlan(struct realtek_smi *smi, bool enable)
+{
+       int ret;
+
+       ret = smi->ops->enable_vlan(smi, enable);
+       if (ret)
+               return ret;
+
+       smi->vlan_enabled = enable;
+
+       /* If we turn VLAN off, make sure that we turn off
+        * 4k VLAN as well, if that happened to be on.
+        */
+       if (!enable) {
+               smi->vlan4k_enabled = false;
+               ret = smi->ops->enable_vlan4k(smi, false);
+       }
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(rtl8366_enable_vlan);
+
+int rtl8366_reset_vlan(struct realtek_smi *smi)
+{
+       struct rtl8366_vlan_mc vlanmc;
+       int ret;
+       int i;
+
+       rtl8366_enable_vlan(smi, false);
+       rtl8366_enable_vlan4k(smi, false);
+
+       /* Clear the 16 VLAN member configurations */
+       vlanmc.vid = 0;
+       vlanmc.priority = 0;
+       vlanmc.member = 0;
+       vlanmc.untag = 0;
+       vlanmc.fid = 0;
+       for (i = 0; i < smi->num_vlan_mc; i++) {
+               ret = smi->ops->set_vlan_mc(smi, i, &vlanmc);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(rtl8366_reset_vlan);
+
+int rtl8366_vlan_add(struct dsa_switch *ds, int port,
+                    const struct switchdev_obj_port_vlan *vlan,
+                    struct netlink_ext_ack *extack)
+{
+       bool untagged = !!(vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED);
+       bool pvid = !!(vlan->flags & BRIDGE_VLAN_INFO_PVID);
+       struct realtek_smi *smi = ds->priv;
+       u32 member = 0;
+       u32 untag = 0;
+       int ret;
+
+       if (!smi->ops->is_vlan_valid(smi, vlan->vid)) {
+               NL_SET_ERR_MSG_MOD(extack, "VLAN ID not valid");
+               return -EINVAL;
+       }
+
+       /* Enable VLAN in the hardware
+        * FIXME: what's with this 4k business?
+        * Just rtl8366_enable_vlan() seems inconclusive.
+        */
+       ret = rtl8366_enable_vlan4k(smi, true);
+       if (ret) {
+               NL_SET_ERR_MSG_MOD(extack, "Failed to enable VLAN 4K");
+               return ret;
+       }
+
+       dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",
+               vlan->vid, port, untagged ? "untagged" : "tagged",
+               pvid ? "PVID" : "no PVID");
+
+       member |= BIT(port);
+
+       if (untagged)
+               untag |= BIT(port);
+
+       ret = rtl8366_set_vlan(smi, vlan->vid, member, untag, 0);
+       if (ret) {
+               dev_err(smi->dev, "failed to set up VLAN %04x", vlan->vid);
+               return ret;
+       }
+
+       if (!pvid)
+               return 0;
+
+       ret = rtl8366_set_pvid(smi, port, vlan->vid);
+       if (ret) {
+               dev_err(smi->dev, "failed to set PVID on port %d to VLAN %04x",
+                       port, vlan->vid);
+               return ret;
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(rtl8366_vlan_add);
+
+int rtl8366_vlan_del(struct dsa_switch *ds, int port,
+                    const struct switchdev_obj_port_vlan *vlan)
+{
+       struct realtek_smi *smi = ds->priv;
+       int ret, i;
+
+       dev_dbg(smi->dev, "del VLAN %d on port %d\n", vlan->vid, port);
+
+       for (i = 0; i < smi->num_vlan_mc; i++) {
+               struct rtl8366_vlan_mc vlanmc;
+
+               ret = smi->ops->get_vlan_mc(smi, i, &vlanmc);
+               if (ret)
+                       return ret;
+
+               if (vlan->vid == vlanmc.vid) {
+                       /* Remove this port from the VLAN */
+                       vlanmc.member &= ~BIT(port);
+                       vlanmc.untag &= ~BIT(port);
+                       /*
+                        * If no ports are members of this VLAN
+                        * anymore then clear the whole member
+                        * config so it can be reused.
+                        */
+                       if (!vlanmc.member) {
+                               vlanmc.vid = 0;
+                               vlanmc.priority = 0;
+                               vlanmc.fid = 0;
+                       }
+                       ret = smi->ops->set_vlan_mc(smi, i, &vlanmc);
+                       if (ret) {
+                               dev_err(smi->dev,
+                                       "failed to remove VLAN %04x\n",
+                                       vlan->vid);
+                               return ret;
+                       }
+                       break;
+               }
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(rtl8366_vlan_del);
+
+void rtl8366_get_strings(struct dsa_switch *ds, int port, u32 stringset,
+                        uint8_t *data)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8366_mib_counter *mib;
+       int i;
+
+       if (port >= smi->num_ports)
+               return;
+
+       for (i = 0; i < smi->num_mib_counters; i++) {
+               mib = &smi->mib_counters[i];
+               strncpy(data + i * ETH_GSTRING_LEN,
+                       mib->name, ETH_GSTRING_LEN);
+       }
+}
+EXPORT_SYMBOL_GPL(rtl8366_get_strings);
+
+int rtl8366_get_sset_count(struct dsa_switch *ds, int port, int sset)
+{
+       struct realtek_smi *smi = ds->priv;
+
+       /* We only support SS_STATS */
+       if (sset != ETH_SS_STATS)
+               return 0;
+       if (port >= smi->num_ports)
+               return -EINVAL;
+
+       return smi->num_mib_counters;
+}
+EXPORT_SYMBOL_GPL(rtl8366_get_sset_count);
+
+void rtl8366_get_ethtool_stats(struct dsa_switch *ds, int port, uint64_t *data)
+{
+       struct realtek_smi *smi = ds->priv;
+       int i;
+       int ret;
+
+       if (port >= smi->num_ports)
+               return;
+
+       for (i = 0; i < smi->num_mib_counters; i++) {
+               struct rtl8366_mib_counter *mib;
+               u64 mibvalue = 0;
+
+               mib = &smi->mib_counters[i];
+               ret = smi->ops->get_mib_counter(smi, port, mib, &mibvalue);
+               if (ret) {
+                       dev_err(smi->dev, "error reading MIB counter %s\n",
+                               mib->name);
+               }
+               data[i] = mibvalue;
+       }
+}
+EXPORT_SYMBOL_GPL(rtl8366_get_ethtool_stats);
diff --git a/drivers/net/dsa/realtek/rtl8366rb.c b/drivers/net/dsa/realtek/rtl8366rb.c
new file mode 100644 (file)
index 0000000..4f8c06d
--- /dev/null
@@ -0,0 +1,1816 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Realtek SMI subdriver for the Realtek RTL8366RB ethernet switch
+ *
+ * This is a sparsely documented chip, the only viable documentation seems
+ * to be a patched up code drop from the vendor that appear in various
+ * GPL source trees.
+ *
+ * Copyright (C) 2017 Linus Walleij <linus.walleij@linaro.org>
+ * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
+ * Copyright (C) 2010 Antti Seppälä <a.seppala@gmail.com>
+ * Copyright (C) 2010 Roman Yeryomin <roman@advem.lv>
+ * Copyright (C) 2011 Colin Leitner <colin.leitner@googlemail.com>
+ */
+
+#include <linux/bitops.h>
+#include <linux/etherdevice.h>
+#include <linux/if_bridge.h>
+#include <linux/interrupt.h>
+#include <linux/irqdomain.h>
+#include <linux/irqchip/chained_irq.h>
+#include <linux/of_irq.h>
+#include <linux/regmap.h>
+
+#include "realtek-smi-core.h"
+
+#define RTL8366RB_PORT_NUM_CPU         5
+#define RTL8366RB_NUM_PORTS            6
+#define RTL8366RB_PHY_NO_MAX           4
+#define RTL8366RB_PHY_ADDR_MAX         31
+
+/* Switch Global Configuration register */
+#define RTL8366RB_SGCR                         0x0000
+#define RTL8366RB_SGCR_EN_BC_STORM_CTRL                BIT(0)
+#define RTL8366RB_SGCR_MAX_LENGTH(a)           ((a) << 4)
+#define RTL8366RB_SGCR_MAX_LENGTH_MASK         RTL8366RB_SGCR_MAX_LENGTH(0x3)
+#define RTL8366RB_SGCR_MAX_LENGTH_1522         RTL8366RB_SGCR_MAX_LENGTH(0x0)
+#define RTL8366RB_SGCR_MAX_LENGTH_1536         RTL8366RB_SGCR_MAX_LENGTH(0x1)
+#define RTL8366RB_SGCR_MAX_LENGTH_1552         RTL8366RB_SGCR_MAX_LENGTH(0x2)
+#define RTL8366RB_SGCR_MAX_LENGTH_16000                RTL8366RB_SGCR_MAX_LENGTH(0x3)
+#define RTL8366RB_SGCR_EN_VLAN                 BIT(13)
+#define RTL8366RB_SGCR_EN_VLAN_4KTB            BIT(14)
+
+/* Port Enable Control register */
+#define RTL8366RB_PECR                         0x0001
+
+/* Switch per-port learning disablement register */
+#define RTL8366RB_PORT_LEARNDIS_CTRL           0x0002
+
+/* Security control, actually aging register */
+#define RTL8366RB_SECURITY_CTRL                        0x0003
+
+#define RTL8366RB_SSCR2                                0x0004
+#define RTL8366RB_SSCR2_DROP_UNKNOWN_DA                BIT(0)
+
+/* Port Mode Control registers */
+#define RTL8366RB_PMC0                         0x0005
+#define RTL8366RB_PMC0_SPI                     BIT(0)
+#define RTL8366RB_PMC0_EN_AUTOLOAD             BIT(1)
+#define RTL8366RB_PMC0_PROBE                   BIT(2)
+#define RTL8366RB_PMC0_DIS_BISR                        BIT(3)
+#define RTL8366RB_PMC0_ADCTEST                 BIT(4)
+#define RTL8366RB_PMC0_SRAM_DIAG               BIT(5)
+#define RTL8366RB_PMC0_EN_SCAN                 BIT(6)
+#define RTL8366RB_PMC0_P4_IOMODE_SHIFT         7
+#define RTL8366RB_PMC0_P4_IOMODE_MASK          GENMASK(9, 7)
+#define RTL8366RB_PMC0_P5_IOMODE_SHIFT         10
+#define RTL8366RB_PMC0_P5_IOMODE_MASK          GENMASK(12, 10)
+#define RTL8366RB_PMC0_SDSMODE_SHIFT           13
+#define RTL8366RB_PMC0_SDSMODE_MASK            GENMASK(15, 13)
+#define RTL8366RB_PMC1                         0x0006
+
+/* Port Mirror Control Register */
+#define RTL8366RB_PMCR                         0x0007
+#define RTL8366RB_PMCR_SOURCE_PORT(a)          (a)
+#define RTL8366RB_PMCR_SOURCE_PORT_MASK                0x000f
+#define RTL8366RB_PMCR_MONITOR_PORT(a)         ((a) << 4)
+#define RTL8366RB_PMCR_MONITOR_PORT_MASK       0x00f0
+#define RTL8366RB_PMCR_MIRROR_RX               BIT(8)
+#define RTL8366RB_PMCR_MIRROR_TX               BIT(9)
+#define RTL8366RB_PMCR_MIRROR_SPC              BIT(10)
+#define RTL8366RB_PMCR_MIRROR_ISO              BIT(11)
+
+/* bits 0..7 = port 0, bits 8..15 = port 1 */
+#define RTL8366RB_PAACR0               0x0010
+/* bits 0..7 = port 2, bits 8..15 = port 3 */
+#define RTL8366RB_PAACR1               0x0011
+/* bits 0..7 = port 4, bits 8..15 = port 5 */
+#define RTL8366RB_PAACR2               0x0012
+#define RTL8366RB_PAACR_SPEED_10M      0
+#define RTL8366RB_PAACR_SPEED_100M     1
+#define RTL8366RB_PAACR_SPEED_1000M    2
+#define RTL8366RB_PAACR_FULL_DUPLEX    BIT(2)
+#define RTL8366RB_PAACR_LINK_UP                BIT(4)
+#define RTL8366RB_PAACR_TX_PAUSE       BIT(5)
+#define RTL8366RB_PAACR_RX_PAUSE       BIT(6)
+#define RTL8366RB_PAACR_AN             BIT(7)
+
+#define RTL8366RB_PAACR_CPU_PORT       (RTL8366RB_PAACR_SPEED_1000M | \
+                                        RTL8366RB_PAACR_FULL_DUPLEX | \
+                                        RTL8366RB_PAACR_LINK_UP | \
+                                        RTL8366RB_PAACR_TX_PAUSE | \
+                                        RTL8366RB_PAACR_RX_PAUSE)
+
+/* bits 0..7 = port 0, bits 8..15 = port 1 */
+#define RTL8366RB_PSTAT0               0x0014
+/* bits 0..7 = port 2, bits 8..15 = port 3 */
+#define RTL8366RB_PSTAT1               0x0015
+/* bits 0..7 = port 4, bits 8..15 = port 5 */
+#define RTL8366RB_PSTAT2               0x0016
+
+#define RTL8366RB_POWER_SAVING_REG     0x0021
+
+/* Spanning tree status (STP) control, two bits per port per FID */
+#define RTL8366RB_STP_STATE_BASE       0x0050 /* 0x0050..0x0057 */
+#define RTL8366RB_STP_STATE_DISABLED   0x0
+#define RTL8366RB_STP_STATE_BLOCKING   0x1
+#define RTL8366RB_STP_STATE_LEARNING   0x2
+#define RTL8366RB_STP_STATE_FORWARDING 0x3
+#define RTL8366RB_STP_MASK             GENMASK(1, 0)
+#define RTL8366RB_STP_STATE(port, state) \
+       ((state) << ((port) * 2))
+#define RTL8366RB_STP_STATE_MASK(port) \
+       RTL8366RB_STP_STATE((port), RTL8366RB_STP_MASK)
+
+/* CPU port control reg */
+#define RTL8368RB_CPU_CTRL_REG         0x0061
+#define RTL8368RB_CPU_PORTS_MSK                0x00FF
+/* Disables inserting custom tag length/type 0x8899 */
+#define RTL8368RB_CPU_NO_TAG           BIT(15)
+
+#define RTL8366RB_SMAR0                        0x0070 /* bits 0..15 */
+#define RTL8366RB_SMAR1                        0x0071 /* bits 16..31 */
+#define RTL8366RB_SMAR2                        0x0072 /* bits 32..47 */
+
+#define RTL8366RB_RESET_CTRL_REG               0x0100
+#define RTL8366RB_CHIP_CTRL_RESET_HW           BIT(0)
+#define RTL8366RB_CHIP_CTRL_RESET_SW           BIT(1)
+
+#define RTL8366RB_CHIP_ID_REG                  0x0509
+#define RTL8366RB_CHIP_ID_8366                 0x5937
+#define RTL8366RB_CHIP_VERSION_CTRL_REG                0x050A
+#define RTL8366RB_CHIP_VERSION_MASK            0xf
+
+/* PHY registers control */
+#define RTL8366RB_PHY_ACCESS_CTRL_REG          0x8000
+#define RTL8366RB_PHY_CTRL_READ                        BIT(0)
+#define RTL8366RB_PHY_CTRL_WRITE               0
+#define RTL8366RB_PHY_ACCESS_BUSY_REG          0x8001
+#define RTL8366RB_PHY_INT_BUSY                 BIT(0)
+#define RTL8366RB_PHY_EXT_BUSY                 BIT(4)
+#define RTL8366RB_PHY_ACCESS_DATA_REG          0x8002
+#define RTL8366RB_PHY_EXT_CTRL_REG             0x8010
+#define RTL8366RB_PHY_EXT_WRDATA_REG           0x8011
+#define RTL8366RB_PHY_EXT_RDDATA_REG           0x8012
+
+#define RTL8366RB_PHY_REG_MASK                 0x1f
+#define RTL8366RB_PHY_PAGE_OFFSET              5
+#define RTL8366RB_PHY_PAGE_MASK                        (0xf << 5)
+#define RTL8366RB_PHY_NO_OFFSET                        9
+#define RTL8366RB_PHY_NO_MASK                  (0x1f << 9)
+
+/* VLAN Ingress Control Register 1, one bit per port.
+ * bit 0 .. 5 will make the switch drop ingress frames without
+ * VID such as untagged or priority-tagged frames for respective
+ * port.
+ * bit 6 .. 11 will make the switch drop ingress frames carrying
+ * a C-tag with VID != 0 for respective port.
+ */
+#define RTL8366RB_VLAN_INGRESS_CTRL1_REG       0x037E
+#define RTL8366RB_VLAN_INGRESS_CTRL1_DROP(port)        (BIT((port)) | BIT((port) + 6))
+
+/* VLAN Ingress Control Register 2, one bit per port.
+ * bit0 .. bit5 will make the switch drop all ingress frames with
+ * a VLAN classification that does not include the port is in its
+ * member set.
+ */
+#define RTL8366RB_VLAN_INGRESS_CTRL2_REG       0x037f
+
+/* LED control registers */
+#define RTL8366RB_LED_BLINKRATE_REG            0x0430
+#define RTL8366RB_LED_BLINKRATE_MASK           0x0007
+#define RTL8366RB_LED_BLINKRATE_28MS           0x0000
+#define RTL8366RB_LED_BLINKRATE_56MS           0x0001
+#define RTL8366RB_LED_BLINKRATE_84MS           0x0002
+#define RTL8366RB_LED_BLINKRATE_111MS          0x0003
+#define RTL8366RB_LED_BLINKRATE_222MS          0x0004
+#define RTL8366RB_LED_BLINKRATE_446MS          0x0005
+
+#define RTL8366RB_LED_CTRL_REG                 0x0431
+#define RTL8366RB_LED_OFF                      0x0
+#define RTL8366RB_LED_DUP_COL                  0x1
+#define RTL8366RB_LED_LINK_ACT                 0x2
+#define RTL8366RB_LED_SPD1000                  0x3
+#define RTL8366RB_LED_SPD100                   0x4
+#define RTL8366RB_LED_SPD10                    0x5
+#define RTL8366RB_LED_SPD1000_ACT              0x6
+#define RTL8366RB_LED_SPD100_ACT               0x7
+#define RTL8366RB_LED_SPD10_ACT                        0x8
+#define RTL8366RB_LED_SPD100_10_ACT            0x9
+#define RTL8366RB_LED_FIBER                    0xa
+#define RTL8366RB_LED_AN_FAULT                 0xb
+#define RTL8366RB_LED_LINK_RX                  0xc
+#define RTL8366RB_LED_LINK_TX                  0xd
+#define RTL8366RB_LED_MASTER                   0xe
+#define RTL8366RB_LED_FORCE                    0xf
+#define RTL8366RB_LED_0_1_CTRL_REG             0x0432
+#define RTL8366RB_LED_1_OFFSET                 6
+#define RTL8366RB_LED_2_3_CTRL_REG             0x0433
+#define RTL8366RB_LED_3_OFFSET                 6
+
+#define RTL8366RB_MIB_COUNT                    33
+#define RTL8366RB_GLOBAL_MIB_COUNT             1
+#define RTL8366RB_MIB_COUNTER_PORT_OFFSET      0x0050
+#define RTL8366RB_MIB_COUNTER_BASE             0x1000
+#define RTL8366RB_MIB_CTRL_REG                 0x13F0
+#define RTL8366RB_MIB_CTRL_USER_MASK           0x0FFC
+#define RTL8366RB_MIB_CTRL_BUSY_MASK           BIT(0)
+#define RTL8366RB_MIB_CTRL_RESET_MASK          BIT(1)
+#define RTL8366RB_MIB_CTRL_PORT_RESET(_p)      BIT(2 + (_p))
+#define RTL8366RB_MIB_CTRL_GLOBAL_RESET                BIT(11)
+
+#define RTL8366RB_PORT_VLAN_CTRL_BASE          0x0063
+#define RTL8366RB_PORT_VLAN_CTRL_REG(_p)  \
+               (RTL8366RB_PORT_VLAN_CTRL_BASE + (_p) / 4)
+#define RTL8366RB_PORT_VLAN_CTRL_MASK          0xf
+#define RTL8366RB_PORT_VLAN_CTRL_SHIFT(_p)     (4 * ((_p) % 4))
+
+#define RTL8366RB_VLAN_TABLE_READ_BASE         0x018C
+#define RTL8366RB_VLAN_TABLE_WRITE_BASE                0x0185
+
+#define RTL8366RB_TABLE_ACCESS_CTRL_REG                0x0180
+#define RTL8366RB_TABLE_VLAN_READ_CTRL         0x0E01
+#define RTL8366RB_TABLE_VLAN_WRITE_CTRL                0x0F01
+
+#define RTL8366RB_VLAN_MC_BASE(_x)             (0x0020 + (_x) * 3)
+
+#define RTL8366RB_PORT_LINK_STATUS_BASE                0x0014
+#define RTL8366RB_PORT_STATUS_SPEED_MASK       0x0003
+#define RTL8366RB_PORT_STATUS_DUPLEX_MASK      0x0004
+#define RTL8366RB_PORT_STATUS_LINK_MASK                0x0010
+#define RTL8366RB_PORT_STATUS_TXPAUSE_MASK     0x0020
+#define RTL8366RB_PORT_STATUS_RXPAUSE_MASK     0x0040
+#define RTL8366RB_PORT_STATUS_AN_MASK          0x0080
+
+#define RTL8366RB_NUM_VLANS            16
+#define RTL8366RB_NUM_LEDGROUPS                4
+#define RTL8366RB_NUM_VIDS             4096
+#define RTL8366RB_PRIORITYMAX          7
+#define RTL8366RB_NUM_FIDS             8
+#define RTL8366RB_FIDMAX               7
+
+#define RTL8366RB_PORT_1               BIT(0) /* In userspace port 0 */
+#define RTL8366RB_PORT_2               BIT(1) /* In userspace port 1 */
+#define RTL8366RB_PORT_3               BIT(2) /* In userspace port 2 */
+#define RTL8366RB_PORT_4               BIT(3) /* In userspace port 3 */
+#define RTL8366RB_PORT_5               BIT(4) /* In userspace port 4 */
+
+#define RTL8366RB_PORT_CPU             BIT(5) /* CPU port */
+
+#define RTL8366RB_PORT_ALL             (RTL8366RB_PORT_1 |     \
+                                        RTL8366RB_PORT_2 |     \
+                                        RTL8366RB_PORT_3 |     \
+                                        RTL8366RB_PORT_4 |     \
+                                        RTL8366RB_PORT_5 |     \
+                                        RTL8366RB_PORT_CPU)
+
+#define RTL8366RB_PORT_ALL_BUT_CPU     (RTL8366RB_PORT_1 |     \
+                                        RTL8366RB_PORT_2 |     \
+                                        RTL8366RB_PORT_3 |     \
+                                        RTL8366RB_PORT_4 |     \
+                                        RTL8366RB_PORT_5)
+
+#define RTL8366RB_PORT_ALL_EXTERNAL    (RTL8366RB_PORT_1 |     \
+                                        RTL8366RB_PORT_2 |     \
+                                        RTL8366RB_PORT_3 |     \
+                                        RTL8366RB_PORT_4)
+
+#define RTL8366RB_PORT_ALL_INTERNAL     RTL8366RB_PORT_CPU
+
+/* First configuration word per member config, VID and prio */
+#define RTL8366RB_VLAN_VID_MASK                0xfff
+#define RTL8366RB_VLAN_PRIORITY_SHIFT  12
+#define RTL8366RB_VLAN_PRIORITY_MASK   0x7
+/* Second configuration word per member config, member and untagged */
+#define RTL8366RB_VLAN_UNTAG_SHIFT     8
+#define RTL8366RB_VLAN_UNTAG_MASK      0xff
+#define RTL8366RB_VLAN_MEMBER_MASK     0xff
+/* Third config word per member config, STAG currently unused */
+#define RTL8366RB_VLAN_STAG_MBR_MASK   0xff
+#define RTL8366RB_VLAN_STAG_MBR_SHIFT  8
+#define RTL8366RB_VLAN_STAG_IDX_MASK   0x7
+#define RTL8366RB_VLAN_STAG_IDX_SHIFT  5
+#define RTL8366RB_VLAN_FID_MASK                0x7
+
+/* Port ingress bandwidth control */
+#define RTL8366RB_IB_BASE              0x0200
+#define RTL8366RB_IB_REG(pnum)         (RTL8366RB_IB_BASE + (pnum))
+#define RTL8366RB_IB_BDTH_MASK         0x3fff
+#define RTL8366RB_IB_PREIFG            BIT(14)
+
+/* Port egress bandwidth control */
+#define RTL8366RB_EB_BASE              0x02d1
+#define RTL8366RB_EB_REG(pnum)         (RTL8366RB_EB_BASE + (pnum))
+#define RTL8366RB_EB_BDTH_MASK         0x3fff
+#define RTL8366RB_EB_PREIFG_REG                0x02f8
+#define RTL8366RB_EB_PREIFG            BIT(9)
+
+#define RTL8366RB_BDTH_SW_MAX          1048512 /* 1048576? */
+#define RTL8366RB_BDTH_UNIT            64
+#define RTL8366RB_BDTH_REG_DEFAULT     16383
+
+/* QOS */
+#define RTL8366RB_QOS                  BIT(15)
+/* Include/Exclude Preamble and IFG (20 bytes). 0:Exclude, 1:Include. */
+#define RTL8366RB_QOS_DEFAULT_PREIFG   1
+
+/* Interrupt handling */
+#define RTL8366RB_INTERRUPT_CONTROL_REG        0x0440
+#define RTL8366RB_INTERRUPT_POLARITY   BIT(0)
+#define RTL8366RB_P4_RGMII_LED         BIT(2)
+#define RTL8366RB_INTERRUPT_MASK_REG   0x0441
+#define RTL8366RB_INTERRUPT_LINK_CHGALL        GENMASK(11, 0)
+#define RTL8366RB_INTERRUPT_ACLEXCEED  BIT(8)
+#define RTL8366RB_INTERRUPT_STORMEXCEED        BIT(9)
+#define RTL8366RB_INTERRUPT_P4_FIBER   BIT(12)
+#define RTL8366RB_INTERRUPT_P4_UTP     BIT(13)
+#define RTL8366RB_INTERRUPT_VALID      (RTL8366RB_INTERRUPT_LINK_CHGALL | \
+                                        RTL8366RB_INTERRUPT_ACLEXCEED | \
+                                        RTL8366RB_INTERRUPT_STORMEXCEED | \
+                                        RTL8366RB_INTERRUPT_P4_FIBER | \
+                                        RTL8366RB_INTERRUPT_P4_UTP)
+#define RTL8366RB_INTERRUPT_STATUS_REG 0x0442
+#define RTL8366RB_NUM_INTERRUPT                14 /* 0..13 */
+
+/* Port isolation registers */
+#define RTL8366RB_PORT_ISO_BASE                0x0F08
+#define RTL8366RB_PORT_ISO(pnum)       (RTL8366RB_PORT_ISO_BASE + (pnum))
+#define RTL8366RB_PORT_ISO_EN          BIT(0)
+#define RTL8366RB_PORT_ISO_PORTS_MASK  GENMASK(7, 1)
+#define RTL8366RB_PORT_ISO_PORTS(pmask)        ((pmask) << 1)
+
+/* bits 0..5 enable force when cleared */
+#define RTL8366RB_MAC_FORCE_CTRL_REG   0x0F11
+
+#define RTL8366RB_OAM_PARSER_REG       0x0F14
+#define RTL8366RB_OAM_MULTIPLEXER_REG  0x0F15
+
+#define RTL8366RB_GREEN_FEATURE_REG    0x0F51
+#define RTL8366RB_GREEN_FEATURE_MSK    0x0007
+#define RTL8366RB_GREEN_FEATURE_TX     BIT(0)
+#define RTL8366RB_GREEN_FEATURE_RX     BIT(2)
+
+/**
+ * struct rtl8366rb - RTL8366RB-specific data
+ * @max_mtu: per-port max MTU setting
+ * @pvid_enabled: if PVID is set for respective port
+ */
+struct rtl8366rb {
+       unsigned int max_mtu[RTL8366RB_NUM_PORTS];
+       bool pvid_enabled[RTL8366RB_NUM_PORTS];
+};
+
+static struct rtl8366_mib_counter rtl8366rb_mib_counters[] = {
+       { 0,  0, 4, "IfInOctets"                                },
+       { 0,  4, 4, "EtherStatsOctets"                          },
+       { 0,  8, 2, "EtherStatsUnderSizePkts"                   },
+       { 0, 10, 2, "EtherFragments"                            },
+       { 0, 12, 2, "EtherStatsPkts64Octets"                    },
+       { 0, 14, 2, "EtherStatsPkts65to127Octets"               },
+       { 0, 16, 2, "EtherStatsPkts128to255Octets"              },
+       { 0, 18, 2, "EtherStatsPkts256to511Octets"              },
+       { 0, 20, 2, "EtherStatsPkts512to1023Octets"             },
+       { 0, 22, 2, "EtherStatsPkts1024to1518Octets"            },
+       { 0, 24, 2, "EtherOversizeStats"                        },
+       { 0, 26, 2, "EtherStatsJabbers"                         },
+       { 0, 28, 2, "IfInUcastPkts"                             },
+       { 0, 30, 2, "EtherStatsMulticastPkts"                   },
+       { 0, 32, 2, "EtherStatsBroadcastPkts"                   },
+       { 0, 34, 2, "EtherStatsDropEvents"                      },
+       { 0, 36, 2, "Dot3StatsFCSErrors"                        },
+       { 0, 38, 2, "Dot3StatsSymbolErrors"                     },
+       { 0, 40, 2, "Dot3InPauseFrames"                         },
+       { 0, 42, 2, "Dot3ControlInUnknownOpcodes"               },
+       { 0, 44, 4, "IfOutOctets"                               },
+       { 0, 48, 2, "Dot3StatsSingleCollisionFrames"            },
+       { 0, 50, 2, "Dot3StatMultipleCollisionFrames"           },
+       { 0, 52, 2, "Dot3sDeferredTransmissions"                },
+       { 0, 54, 2, "Dot3StatsLateCollisions"                   },
+       { 0, 56, 2, "EtherStatsCollisions"                      },
+       { 0, 58, 2, "Dot3StatsExcessiveCollisions"              },
+       { 0, 60, 2, "Dot3OutPauseFrames"                        },
+       { 0, 62, 2, "Dot1dBasePortDelayExceededDiscards"        },
+       { 0, 64, 2, "Dot1dTpPortInDiscards"                     },
+       { 0, 66, 2, "IfOutUcastPkts"                            },
+       { 0, 68, 2, "IfOutMulticastPkts"                        },
+       { 0, 70, 2, "IfOutBroadcastPkts"                        },
+};
+
+static int rtl8366rb_get_mib_counter(struct realtek_smi *smi,
+                                    int port,
+                                    struct rtl8366_mib_counter *mib,
+                                    u64 *mibvalue)
+{
+       u32 addr, val;
+       int ret;
+       int i;
+
+       addr = RTL8366RB_MIB_COUNTER_BASE +
+               RTL8366RB_MIB_COUNTER_PORT_OFFSET * (port) +
+               mib->offset;
+
+       /* Writing access counter address first
+        * then ASIC will prepare 64bits counter wait for being retrived
+        */
+       ret = regmap_write(smi->map, addr, 0); /* Write whatever */
+       if (ret)
+               return ret;
+
+       /* Read MIB control register */
+       ret = regmap_read(smi->map, RTL8366RB_MIB_CTRL_REG, &val);
+       if (ret)
+               return -EIO;
+
+       if (val & RTL8366RB_MIB_CTRL_BUSY_MASK)
+               return -EBUSY;
+
+       if (val & RTL8366RB_MIB_CTRL_RESET_MASK)
+               return -EIO;
+
+       /* Read each individual MIB 16 bits at the time */
+       *mibvalue = 0;
+       for (i = mib->length; i > 0; i--) {
+               ret = regmap_read(smi->map, addr + (i - 1), &val);
+               if (ret)
+                       return ret;
+               *mibvalue = (*mibvalue << 16) | (val & 0xFFFF);
+       }
+       return 0;
+}
+
+static u32 rtl8366rb_get_irqmask(struct irq_data *d)
+{
+       int line = irqd_to_hwirq(d);
+       u32 val;
+
+       /* For line interrupts we combine link down in bits
+        * 6..11 with link up in bits 0..5 into one interrupt.
+        */
+       if (line < 12)
+               val = BIT(line) | BIT(line + 6);
+       else
+               val = BIT(line);
+       return val;
+}
+
+static void rtl8366rb_mask_irq(struct irq_data *d)
+{
+       struct realtek_smi *smi = irq_data_get_irq_chip_data(d);
+       int ret;
+
+       ret = regmap_update_bits(smi->map, RTL8366RB_INTERRUPT_MASK_REG,
+                                rtl8366rb_get_irqmask(d), 0);
+       if (ret)
+               dev_err(smi->dev, "could not mask IRQ\n");
+}
+
+static void rtl8366rb_unmask_irq(struct irq_data *d)
+{
+       struct realtek_smi *smi = irq_data_get_irq_chip_data(d);
+       int ret;
+
+       ret = regmap_update_bits(smi->map, RTL8366RB_INTERRUPT_MASK_REG,
+                                rtl8366rb_get_irqmask(d),
+                                rtl8366rb_get_irqmask(d));
+       if (ret)
+               dev_err(smi->dev, "could not unmask IRQ\n");
+}
+
+static irqreturn_t rtl8366rb_irq(int irq, void *data)
+{
+       struct realtek_smi *smi = data;
+       u32 stat;
+       int ret;
+
+       /* This clears the IRQ status register */
+       ret = regmap_read(smi->map, RTL8366RB_INTERRUPT_STATUS_REG,
+                         &stat);
+       if (ret) {
+               dev_err(smi->dev, "can't read interrupt status\n");
+               return IRQ_NONE;
+       }
+       stat &= RTL8366RB_INTERRUPT_VALID;
+       if (!stat)
+               return IRQ_NONE;
+       while (stat) {
+               int line = __ffs(stat);
+               int child_irq;
+
+               stat &= ~BIT(line);
+               /* For line interrupts we combine link down in bits
+                * 6..11 with link up in bits 0..5 into one interrupt.
+                */
+               if (line < 12 && line > 5)
+                       line -= 5;
+               child_irq = irq_find_mapping(smi->irqdomain, line);
+               handle_nested_irq(child_irq);
+       }
+       return IRQ_HANDLED;
+}
+
+static struct irq_chip rtl8366rb_irq_chip = {
+       .name = "RTL8366RB",
+       .irq_mask = rtl8366rb_mask_irq,
+       .irq_unmask = rtl8366rb_unmask_irq,
+};
+
+static int rtl8366rb_irq_map(struct irq_domain *domain, unsigned int irq,
+                            irq_hw_number_t hwirq)
+{
+       irq_set_chip_data(irq, domain->host_data);
+       irq_set_chip_and_handler(irq, &rtl8366rb_irq_chip, handle_simple_irq);
+       irq_set_nested_thread(irq, 1);
+       irq_set_noprobe(irq);
+
+       return 0;
+}
+
+static void rtl8366rb_irq_unmap(struct irq_domain *d, unsigned int irq)
+{
+       irq_set_nested_thread(irq, 0);
+       irq_set_chip_and_handler(irq, NULL, NULL);
+       irq_set_chip_data(irq, NULL);
+}
+
+static const struct irq_domain_ops rtl8366rb_irqdomain_ops = {
+       .map = rtl8366rb_irq_map,
+       .unmap = rtl8366rb_irq_unmap,
+       .xlate  = irq_domain_xlate_onecell,
+};
+
+static int rtl8366rb_setup_cascaded_irq(struct realtek_smi *smi)
+{
+       struct device_node *intc;
+       unsigned long irq_trig;
+       int irq;
+       int ret;
+       u32 val;
+       int i;
+
+       intc = of_get_child_by_name(smi->dev->of_node, "interrupt-controller");
+       if (!intc) {
+               dev_err(smi->dev, "missing child interrupt-controller node\n");
+               return -EINVAL;
+       }
+       /* RB8366RB IRQs cascade off this one */
+       irq = of_irq_get(intc, 0);
+       if (irq <= 0) {
+               dev_err(smi->dev, "failed to get parent IRQ\n");
+               ret = irq ? irq : -EINVAL;
+               goto out_put_node;
+       }
+
+       /* This clears the IRQ status register */
+       ret = regmap_read(smi->map, RTL8366RB_INTERRUPT_STATUS_REG,
+                         &val);
+       if (ret) {
+               dev_err(smi->dev, "can't read interrupt status\n");
+               goto out_put_node;
+       }
+
+       /* Fetch IRQ edge information from the descriptor */
+       irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
+       switch (irq_trig) {
+       case IRQF_TRIGGER_RISING:
+       case IRQF_TRIGGER_HIGH:
+               dev_info(smi->dev, "active high/rising IRQ\n");
+               val = 0;
+               break;
+       case IRQF_TRIGGER_FALLING:
+       case IRQF_TRIGGER_LOW:
+               dev_info(smi->dev, "active low/falling IRQ\n");
+               val = RTL8366RB_INTERRUPT_POLARITY;
+               break;
+       }
+       ret = regmap_update_bits(smi->map, RTL8366RB_INTERRUPT_CONTROL_REG,
+                                RTL8366RB_INTERRUPT_POLARITY,
+                                val);
+       if (ret) {
+               dev_err(smi->dev, "could not configure IRQ polarity\n");
+               goto out_put_node;
+       }
+
+       ret = devm_request_threaded_irq(smi->dev, irq, NULL,
+                                       rtl8366rb_irq, IRQF_ONESHOT,
+                                       "RTL8366RB", smi);
+       if (ret) {
+               dev_err(smi->dev, "unable to request irq: %d\n", ret);
+               goto out_put_node;
+       }
+       smi->irqdomain = irq_domain_add_linear(intc,
+                                              RTL8366RB_NUM_INTERRUPT,
+                                              &rtl8366rb_irqdomain_ops,
+                                              smi);
+       if (!smi->irqdomain) {
+               dev_err(smi->dev, "failed to create IRQ domain\n");
+               ret = -EINVAL;
+               goto out_put_node;
+       }
+       for (i = 0; i < smi->num_ports; i++)
+               irq_set_parent(irq_create_mapping(smi->irqdomain, i), irq);
+
+out_put_node:
+       of_node_put(intc);
+       return ret;
+}
+
+static int rtl8366rb_set_addr(struct realtek_smi *smi)
+{
+       u8 addr[ETH_ALEN];
+       u16 val;
+       int ret;
+
+       eth_random_addr(addr);
+
+       dev_info(smi->dev, "set MAC: %02X:%02X:%02X:%02X:%02X:%02X\n",
+                addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
+       val = addr[0] << 8 | addr[1];
+       ret = regmap_write(smi->map, RTL8366RB_SMAR0, val);
+       if (ret)
+               return ret;
+       val = addr[2] << 8 | addr[3];
+       ret = regmap_write(smi->map, RTL8366RB_SMAR1, val);
+       if (ret)
+               return ret;
+       val = addr[4] << 8 | addr[5];
+       ret = regmap_write(smi->map, RTL8366RB_SMAR2, val);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+/* Found in a vendor driver */
+
+/* Struct for handling the jam tables' entries */
+struct rtl8366rb_jam_tbl_entry {
+       u16 reg;
+       u16 val;
+};
+
+/* For the "version 0" early silicon, appear in most source releases */
+static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_ver_0[] = {
+       {0x000B, 0x0001}, {0x03A6, 0x0100}, {0x03A7, 0x0001}, {0x02D1, 0x3FFF},
+       {0x02D2, 0x3FFF}, {0x02D3, 0x3FFF}, {0x02D4, 0x3FFF}, {0x02D5, 0x3FFF},
+       {0x02D6, 0x3FFF}, {0x02D7, 0x3FFF}, {0x02D8, 0x3FFF}, {0x022B, 0x0688},
+       {0x022C, 0x0FAC}, {0x03D0, 0x4688}, {0x03D1, 0x01F5}, {0x0000, 0x0830},
+       {0x02F9, 0x0200}, {0x02F7, 0x7FFF}, {0x02F8, 0x03FF}, {0x0080, 0x03E8},
+       {0x0081, 0x00CE}, {0x0082, 0x00DA}, {0x0083, 0x0230}, {0xBE0F, 0x2000},
+       {0x0231, 0x422A}, {0x0232, 0x422A}, {0x0233, 0x422A}, {0x0234, 0x422A},
+       {0x0235, 0x422A}, {0x0236, 0x422A}, {0x0237, 0x422A}, {0x0238, 0x422A},
+       {0x0239, 0x422A}, {0x023A, 0x422A}, {0x023B, 0x422A}, {0x023C, 0x422A},
+       {0x023D, 0x422A}, {0x023E, 0x422A}, {0x023F, 0x422A}, {0x0240, 0x422A},
+       {0x0241, 0x422A}, {0x0242, 0x422A}, {0x0243, 0x422A}, {0x0244, 0x422A},
+       {0x0245, 0x422A}, {0x0246, 0x422A}, {0x0247, 0x422A}, {0x0248, 0x422A},
+       {0x0249, 0x0146}, {0x024A, 0x0146}, {0x024B, 0x0146}, {0xBE03, 0xC961},
+       {0x024D, 0x0146}, {0x024E, 0x0146}, {0x024F, 0x0146}, {0x0250, 0x0146},
+       {0xBE64, 0x0226}, {0x0252, 0x0146}, {0x0253, 0x0146}, {0x024C, 0x0146},
+       {0x0251, 0x0146}, {0x0254, 0x0146}, {0xBE62, 0x3FD0}, {0x0084, 0x0320},
+       {0x0255, 0x0146}, {0x0256, 0x0146}, {0x0257, 0x0146}, {0x0258, 0x0146},
+       {0x0259, 0x0146}, {0x025A, 0x0146}, {0x025B, 0x0146}, {0x025C, 0x0146},
+       {0x025D, 0x0146}, {0x025E, 0x0146}, {0x025F, 0x0146}, {0x0260, 0x0146},
+       {0x0261, 0xA23F}, {0x0262, 0x0294}, {0x0263, 0xA23F}, {0x0264, 0x0294},
+       {0x0265, 0xA23F}, {0x0266, 0x0294}, {0x0267, 0xA23F}, {0x0268, 0x0294},
+       {0x0269, 0xA23F}, {0x026A, 0x0294}, {0x026B, 0xA23F}, {0x026C, 0x0294},
+       {0x026D, 0xA23F}, {0x026E, 0x0294}, {0x026F, 0xA23F}, {0x0270, 0x0294},
+       {0x02F5, 0x0048}, {0xBE09, 0x0E00}, {0xBE1E, 0x0FA0}, {0xBE14, 0x8448},
+       {0xBE15, 0x1007}, {0xBE4A, 0xA284}, {0xC454, 0x3F0B}, {0xC474, 0x3F0B},
+       {0xBE48, 0x3672}, {0xBE4B, 0x17A7}, {0xBE4C, 0x0B15}, {0xBE52, 0x0EDD},
+       {0xBE49, 0x8C00}, {0xBE5B, 0x785C}, {0xBE5C, 0x785C}, {0xBE5D, 0x785C},
+       {0xBE61, 0x368A}, {0xBE63, 0x9B84}, {0xC456, 0xCC13}, {0xC476, 0xCC13},
+       {0xBE65, 0x307D}, {0xBE6D, 0x0005}, {0xBE6E, 0xE120}, {0xBE2E, 0x7BAF},
+};
+
+/* This v1 init sequence is from Belkin F5D8235 U-Boot release */
+static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_ver_1[] = {
+       {0x0000, 0x0830}, {0x0001, 0x8000}, {0x0400, 0x8130}, {0xBE78, 0x3C3C},
+       {0x0431, 0x5432}, {0xBE37, 0x0CE4}, {0x02FA, 0xFFDF}, {0x02FB, 0xFFE0},
+       {0xC44C, 0x1585}, {0xC44C, 0x1185}, {0xC44C, 0x1585}, {0xC46C, 0x1585},
+       {0xC46C, 0x1185}, {0xC46C, 0x1585}, {0xC451, 0x2135}, {0xC471, 0x2135},
+       {0xBE10, 0x8140}, {0xBE15, 0x0007}, {0xBE6E, 0xE120}, {0xBE69, 0xD20F},
+       {0xBE6B, 0x0320}, {0xBE24, 0xB000}, {0xBE23, 0xFF51}, {0xBE22, 0xDF20},
+       {0xBE21, 0x0140}, {0xBE20, 0x00BB}, {0xBE24, 0xB800}, {0xBE24, 0x0000},
+       {0xBE24, 0x7000}, {0xBE23, 0xFF51}, {0xBE22, 0xDF60}, {0xBE21, 0x0140},
+       {0xBE20, 0x0077}, {0xBE24, 0x7800}, {0xBE24, 0x0000}, {0xBE2E, 0x7B7A},
+       {0xBE36, 0x0CE4}, {0x02F5, 0x0048}, {0xBE77, 0x2940}, {0x000A, 0x83E0},
+       {0xBE79, 0x3C3C}, {0xBE00, 0x1340},
+};
+
+/* This v2 init sequence is from Belkin F5D8235 U-Boot release */
+static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_ver_2[] = {
+       {0x0450, 0x0000}, {0x0400, 0x8130}, {0x000A, 0x83ED}, {0x0431, 0x5432},
+       {0xC44F, 0x6250}, {0xC46F, 0x6250}, {0xC456, 0x0C14}, {0xC476, 0x0C14},
+       {0xC44C, 0x1C85}, {0xC44C, 0x1885}, {0xC44C, 0x1C85}, {0xC46C, 0x1C85},
+       {0xC46C, 0x1885}, {0xC46C, 0x1C85}, {0xC44C, 0x0885}, {0xC44C, 0x0881},
+       {0xC44C, 0x0885}, {0xC46C, 0x0885}, {0xC46C, 0x0881}, {0xC46C, 0x0885},
+       {0xBE2E, 0x7BA7}, {0xBE36, 0x1000}, {0xBE37, 0x1000}, {0x8000, 0x0001},
+       {0xBE69, 0xD50F}, {0x8000, 0x0000}, {0xBE69, 0xD50F}, {0xBE6E, 0x0320},
+       {0xBE77, 0x2940}, {0xBE78, 0x3C3C}, {0xBE79, 0x3C3C}, {0xBE6E, 0xE120},
+       {0x8000, 0x0001}, {0xBE15, 0x1007}, {0x8000, 0x0000}, {0xBE15, 0x1007},
+       {0xBE14, 0x0448}, {0xBE1E, 0x00A0}, {0xBE10, 0x8160}, {0xBE10, 0x8140},
+       {0xBE00, 0x1340}, {0x0F51, 0x0010},
+};
+
+/* Appears in a DDWRT code dump */
+static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_ver_3[] = {
+       {0x0000, 0x0830}, {0x0400, 0x8130}, {0x000A, 0x83ED}, {0x0431, 0x5432},
+       {0x0F51, 0x0017}, {0x02F5, 0x0048}, {0x02FA, 0xFFDF}, {0x02FB, 0xFFE0},
+       {0xC456, 0x0C14}, {0xC476, 0x0C14}, {0xC454, 0x3F8B}, {0xC474, 0x3F8B},
+       {0xC450, 0x2071}, {0xC470, 0x2071}, {0xC451, 0x226B}, {0xC471, 0x226B},
+       {0xC452, 0xA293}, {0xC472, 0xA293}, {0xC44C, 0x1585}, {0xC44C, 0x1185},
+       {0xC44C, 0x1585}, {0xC46C, 0x1585}, {0xC46C, 0x1185}, {0xC46C, 0x1585},
+       {0xC44C, 0x0185}, {0xC44C, 0x0181}, {0xC44C, 0x0185}, {0xC46C, 0x0185},
+       {0xC46C, 0x0181}, {0xC46C, 0x0185}, {0xBE24, 0xB000}, {0xBE23, 0xFF51},
+       {0xBE22, 0xDF20}, {0xBE21, 0x0140}, {0xBE20, 0x00BB}, {0xBE24, 0xB800},
+       {0xBE24, 0x0000}, {0xBE24, 0x7000}, {0xBE23, 0xFF51}, {0xBE22, 0xDF60},
+       {0xBE21, 0x0140}, {0xBE20, 0x0077}, {0xBE24, 0x7800}, {0xBE24, 0x0000},
+       {0xBE2E, 0x7BA7}, {0xBE36, 0x1000}, {0xBE37, 0x1000}, {0x8000, 0x0001},
+       {0xBE69, 0xD50F}, {0x8000, 0x0000}, {0xBE69, 0xD50F}, {0xBE6B, 0x0320},
+       {0xBE77, 0x2800}, {0xBE78, 0x3C3C}, {0xBE79, 0x3C3C}, {0xBE6E, 0xE120},
+       {0x8000, 0x0001}, {0xBE10, 0x8140}, {0x8000, 0x0000}, {0xBE10, 0x8140},
+       {0xBE15, 0x1007}, {0xBE14, 0x0448}, {0xBE1E, 0x00A0}, {0xBE10, 0x8160},
+       {0xBE10, 0x8140}, {0xBE00, 0x1340}, {0x0450, 0x0000}, {0x0401, 0x0000},
+};
+
+/* Belkin F5D8235 v1, "belkin,f5d8235-v1" */
+static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_f5d8235[] = {
+       {0x0242, 0x02BF}, {0x0245, 0x02BF}, {0x0248, 0x02BF}, {0x024B, 0x02BF},
+       {0x024E, 0x02BF}, {0x0251, 0x02BF}, {0x0254, 0x0A3F}, {0x0256, 0x0A3F},
+       {0x0258, 0x0A3F}, {0x025A, 0x0A3F}, {0x025C, 0x0A3F}, {0x025E, 0x0A3F},
+       {0x0263, 0x007C}, {0x0100, 0x0004}, {0xBE5B, 0x3500}, {0x800E, 0x200F},
+       {0xBE1D, 0x0F00}, {0x8001, 0x5011}, {0x800A, 0xA2F4}, {0x800B, 0x17A3},
+       {0xBE4B, 0x17A3}, {0xBE41, 0x5011}, {0xBE17, 0x2100}, {0x8000, 0x8304},
+       {0xBE40, 0x8304}, {0xBE4A, 0xA2F4}, {0x800C, 0xA8D5}, {0x8014, 0x5500},
+       {0x8015, 0x0004}, {0xBE4C, 0xA8D5}, {0xBE59, 0x0008}, {0xBE09, 0x0E00},
+       {0xBE36, 0x1036}, {0xBE37, 0x1036}, {0x800D, 0x00FF}, {0xBE4D, 0x00FF},
+};
+
+/* DGN3500, "netgear,dgn3500", "netgear,dgn3500b" */
+static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_dgn3500[] = {
+       {0x0000, 0x0830}, {0x0400, 0x8130}, {0x000A, 0x83ED}, {0x0F51, 0x0017},
+       {0x02F5, 0x0048}, {0x02FA, 0xFFDF}, {0x02FB, 0xFFE0}, {0x0450, 0x0000},
+       {0x0401, 0x0000}, {0x0431, 0x0960},
+};
+
+/* This jam table activates "green ethernet", which means low power mode
+ * and is claimed to detect the cable length and not use more power than
+ * necessary, and the ports should enter power saving mode 10 seconds after
+ * a cable is disconnected. Seems to always be the same.
+ */
+static const struct rtl8366rb_jam_tbl_entry rtl8366rb_green_jam[] = {
+       {0xBE78, 0x323C}, {0xBE77, 0x5000}, {0xBE2E, 0x7BA7},
+       {0xBE59, 0x3459}, {0xBE5A, 0x745A}, {0xBE5B, 0x785C},
+       {0xBE5C, 0x785C}, {0xBE6E, 0xE120}, {0xBE79, 0x323C},
+};
+
+/* Function that jams the tables in the proper registers */
+static int rtl8366rb_jam_table(const struct rtl8366rb_jam_tbl_entry *jam_table,
+                              int jam_size, struct realtek_smi *smi,
+                              bool write_dbg)
+{
+       u32 val;
+       int ret;
+       int i;
+
+       for (i = 0; i < jam_size; i++) {
+               if ((jam_table[i].reg & 0xBE00) == 0xBE00) {
+                       ret = regmap_read(smi->map,
+                                         RTL8366RB_PHY_ACCESS_BUSY_REG,
+                                         &val);
+                       if (ret)
+                               return ret;
+                       if (!(val & RTL8366RB_PHY_INT_BUSY)) {
+                               ret = regmap_write(smi->map,
+                                               RTL8366RB_PHY_ACCESS_CTRL_REG,
+                                               RTL8366RB_PHY_CTRL_WRITE);
+                               if (ret)
+                                       return ret;
+                       }
+               }
+               if (write_dbg)
+                       dev_dbg(smi->dev, "jam %04x into register %04x\n",
+                               jam_table[i].val,
+                               jam_table[i].reg);
+               ret = regmap_write(smi->map,
+                                  jam_table[i].reg,
+                                  jam_table[i].val);
+               if (ret)
+                       return ret;
+       }
+       return 0;
+}
+
+static int rtl8366rb_setup(struct dsa_switch *ds)
+{
+       struct realtek_smi *smi = ds->priv;
+       const struct rtl8366rb_jam_tbl_entry *jam_table;
+       struct rtl8366rb *rb;
+       u32 chip_ver = 0;
+       u32 chip_id = 0;
+       int jam_size;
+       u32 val;
+       int ret;
+       int i;
+
+       rb = smi->chip_data;
+
+       ret = regmap_read(smi->map, RTL8366RB_CHIP_ID_REG, &chip_id);
+       if (ret) {
+               dev_err(smi->dev, "unable to read chip id\n");
+               return ret;
+       }
+
+       switch (chip_id) {
+       case RTL8366RB_CHIP_ID_8366:
+               break;
+       default:
+               dev_err(smi->dev, "unknown chip id (%04x)\n", chip_id);
+               return -ENODEV;
+       }
+
+       ret = regmap_read(smi->map, RTL8366RB_CHIP_VERSION_CTRL_REG,
+                         &chip_ver);
+       if (ret) {
+               dev_err(smi->dev, "unable to read chip version\n");
+               return ret;
+       }
+
+       dev_info(smi->dev, "RTL%04x ver %u chip found\n",
+                chip_id, chip_ver & RTL8366RB_CHIP_VERSION_MASK);
+
+       /* Do the init dance using the right jam table */
+       switch (chip_ver) {
+       case 0:
+               jam_table = rtl8366rb_init_jam_ver_0;
+               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_ver_0);
+               break;
+       case 1:
+               jam_table = rtl8366rb_init_jam_ver_1;
+               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_ver_1);
+               break;
+       case 2:
+               jam_table = rtl8366rb_init_jam_ver_2;
+               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_ver_2);
+               break;
+       default:
+               jam_table = rtl8366rb_init_jam_ver_3;
+               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_ver_3);
+               break;
+       }
+
+       /* Special jam tables for special routers
+        * TODO: are these necessary? Maintainers, please test
+        * without them, using just the off-the-shelf tables.
+        */
+       if (of_machine_is_compatible("belkin,f5d8235-v1")) {
+               jam_table = rtl8366rb_init_jam_f5d8235;
+               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_f5d8235);
+       }
+       if (of_machine_is_compatible("netgear,dgn3500") ||
+           of_machine_is_compatible("netgear,dgn3500b")) {
+               jam_table = rtl8366rb_init_jam_dgn3500;
+               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_dgn3500);
+       }
+
+       ret = rtl8366rb_jam_table(jam_table, jam_size, smi, true);
+       if (ret)
+               return ret;
+
+       /* Isolate all user ports so they can only send packets to itself and the CPU port */
+       for (i = 0; i < RTL8366RB_PORT_NUM_CPU; i++) {
+               ret = regmap_write(smi->map, RTL8366RB_PORT_ISO(i),
+                                  RTL8366RB_PORT_ISO_PORTS(BIT(RTL8366RB_PORT_NUM_CPU)) |
+                                  RTL8366RB_PORT_ISO_EN);
+               if (ret)
+                       return ret;
+       }
+       /* CPU port can send packets to all ports */
+       ret = regmap_write(smi->map, RTL8366RB_PORT_ISO(RTL8366RB_PORT_NUM_CPU),
+                          RTL8366RB_PORT_ISO_PORTS(dsa_user_ports(ds)) |
+                          RTL8366RB_PORT_ISO_EN);
+       if (ret)
+               return ret;
+
+       /* Set up the "green ethernet" feature */
+       ret = rtl8366rb_jam_table(rtl8366rb_green_jam,
+                                 ARRAY_SIZE(rtl8366rb_green_jam), smi, false);
+       if (ret)
+               return ret;
+
+       ret = regmap_write(smi->map,
+                          RTL8366RB_GREEN_FEATURE_REG,
+                          (chip_ver == 1) ? 0x0007 : 0x0003);
+       if (ret)
+               return ret;
+
+       /* Vendor driver sets 0x240 in registers 0xc and 0xd (undocumented) */
+       ret = regmap_write(smi->map, 0x0c, 0x240);
+       if (ret)
+               return ret;
+       ret = regmap_write(smi->map, 0x0d, 0x240);
+       if (ret)
+               return ret;
+
+       /* Set some random MAC address */
+       ret = rtl8366rb_set_addr(smi);
+       if (ret)
+               return ret;
+
+       /* Enable CPU port with custom DSA tag 8899.
+        *
+        * If you set RTL8368RB_CPU_NO_TAG (bit 15) in this registers
+        * the custom tag is turned off.
+        */
+       ret = regmap_update_bits(smi->map, RTL8368RB_CPU_CTRL_REG,
+                                0xFFFF,
+                                BIT(smi->cpu_port));
+       if (ret)
+               return ret;
+
+       /* Make sure we default-enable the fixed CPU port */
+       ret = regmap_update_bits(smi->map, RTL8366RB_PECR,
+                                BIT(smi->cpu_port),
+                                0);
+       if (ret)
+               return ret;
+
+       /* Set maximum packet length to 1536 bytes */
+       ret = regmap_update_bits(smi->map, RTL8366RB_SGCR,
+                                RTL8366RB_SGCR_MAX_LENGTH_MASK,
+                                RTL8366RB_SGCR_MAX_LENGTH_1536);
+       if (ret)
+               return ret;
+       for (i = 0; i < RTL8366RB_NUM_PORTS; i++)
+               /* layer 2 size, see rtl8366rb_change_mtu() */
+               rb->max_mtu[i] = 1532;
+
+       /* Disable learning for all ports */
+       ret = regmap_write(smi->map, RTL8366RB_PORT_LEARNDIS_CTRL,
+                          RTL8366RB_PORT_ALL);
+       if (ret)
+               return ret;
+
+       /* Enable auto ageing for all ports */
+       ret = regmap_write(smi->map, RTL8366RB_SECURITY_CTRL, 0);
+       if (ret)
+               return ret;
+
+       /* Port 4 setup: this enables Port 4, usually the WAN port,
+        * common PHY IO mode is apparently mode 0, and this is not what
+        * the port is initialized to. There is no explanation of the
+        * IO modes in the Realtek source code, if your WAN port is
+        * connected to something exotic such as fiber, then this might
+        * be worth experimenting with.
+        */
+       ret = regmap_update_bits(smi->map, RTL8366RB_PMC0,
+                                RTL8366RB_PMC0_P4_IOMODE_MASK,
+                                0 << RTL8366RB_PMC0_P4_IOMODE_SHIFT);
+       if (ret)
+               return ret;
+
+       /* Accept all packets by default, we enable filtering on-demand */
+       ret = regmap_write(smi->map, RTL8366RB_VLAN_INGRESS_CTRL1_REG,
+                          0);
+       if (ret)
+               return ret;
+       ret = regmap_write(smi->map, RTL8366RB_VLAN_INGRESS_CTRL2_REG,
+                          0);
+       if (ret)
+               return ret;
+
+       /* Don't drop packets whose DA has not been learned */
+       ret = regmap_update_bits(smi->map, RTL8366RB_SSCR2,
+                                RTL8366RB_SSCR2_DROP_UNKNOWN_DA, 0);
+       if (ret)
+               return ret;
+
+       /* Set blinking, TODO: make this configurable */
+       ret = regmap_update_bits(smi->map, RTL8366RB_LED_BLINKRATE_REG,
+                                RTL8366RB_LED_BLINKRATE_MASK,
+                                RTL8366RB_LED_BLINKRATE_56MS);
+       if (ret)
+               return ret;
+
+       /* Set up LED activity:
+        * Each port has 4 LEDs, we configure all ports to the same
+        * behaviour (no individual config) but we can set up each
+        * LED separately.
+        */
+       if (smi->leds_disabled) {
+               /* Turn everything off */
+               regmap_update_bits(smi->map,
+                                  RTL8366RB_LED_0_1_CTRL_REG,
+                                  0x0FFF, 0);
+               regmap_update_bits(smi->map,
+                                  RTL8366RB_LED_2_3_CTRL_REG,
+                                  0x0FFF, 0);
+               regmap_update_bits(smi->map,
+                                  RTL8366RB_INTERRUPT_CONTROL_REG,
+                                  RTL8366RB_P4_RGMII_LED,
+                                  0);
+               val = RTL8366RB_LED_OFF;
+       } else {
+               /* TODO: make this configurable per LED */
+               val = RTL8366RB_LED_FORCE;
+       }
+       for (i = 0; i < 4; i++) {
+               ret = regmap_update_bits(smi->map,
+                                        RTL8366RB_LED_CTRL_REG,
+                                        0xf << (i * 4),
+                                        val << (i * 4));
+               if (ret)
+                       return ret;
+       }
+
+       ret = rtl8366_reset_vlan(smi);
+       if (ret)
+               return ret;
+
+       ret = rtl8366rb_setup_cascaded_irq(smi);
+       if (ret)
+               dev_info(smi->dev, "no interrupt support\n");
+
+       ret = realtek_smi_setup_mdio(smi);
+       if (ret) {
+               dev_info(smi->dev, "could not set up MDIO bus\n");
+               return -ENODEV;
+       }
+
+       return 0;
+}
+
+static enum dsa_tag_protocol rtl8366_get_tag_protocol(struct dsa_switch *ds,
+                                                     int port,
+                                                     enum dsa_tag_protocol mp)
+{
+       /* This switch uses the 4 byte protocol A Realtek DSA tag */
+       return DSA_TAG_PROTO_RTL4_A;
+}
+
+static void
+rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int mode,
+                     phy_interface_t interface, struct phy_device *phydev,
+                     int speed, int duplex, bool tx_pause, bool rx_pause)
+{
+       struct realtek_smi *smi = ds->priv;
+       int ret;
+
+       if (port != smi->cpu_port)
+               return;
+
+       dev_dbg(smi->dev, "MAC link up on CPU port (%d)\n", port);
+
+       /* Force the fixed CPU port into 1Gbit mode, no autonegotiation */
+       ret = regmap_update_bits(smi->map, RTL8366RB_MAC_FORCE_CTRL_REG,
+                                BIT(port), BIT(port));
+       if (ret) {
+               dev_err(smi->dev, "failed to force 1Gbit on CPU port\n");
+               return;
+       }
+
+       ret = regmap_update_bits(smi->map, RTL8366RB_PAACR2,
+                                0xFF00U,
+                                RTL8366RB_PAACR_CPU_PORT << 8);
+       if (ret) {
+               dev_err(smi->dev, "failed to set PAACR on CPU port\n");
+               return;
+       }
+
+       /* Enable the CPU port */
+       ret = regmap_update_bits(smi->map, RTL8366RB_PECR, BIT(port),
+                                0);
+       if (ret) {
+               dev_err(smi->dev, "failed to enable the CPU port\n");
+               return;
+       }
+}
+
+static void
+rtl8366rb_mac_link_down(struct dsa_switch *ds, int port, unsigned int mode,
+                       phy_interface_t interface)
+{
+       struct realtek_smi *smi = ds->priv;
+       int ret;
+
+       if (port != smi->cpu_port)
+               return;
+
+       dev_dbg(smi->dev, "MAC link down on CPU port (%d)\n", port);
+
+       /* Disable the CPU port */
+       ret = regmap_update_bits(smi->map, RTL8366RB_PECR, BIT(port),
+                                BIT(port));
+       if (ret) {
+               dev_err(smi->dev, "failed to disable the CPU port\n");
+               return;
+       }
+}
+
+static void rb8366rb_set_port_led(struct realtek_smi *smi,
+                                 int port, bool enable)
+{
+       u16 val = enable ? 0x3f : 0;
+       int ret;
+
+       if (smi->leds_disabled)
+               return;
+
+       switch (port) {
+       case 0:
+               ret = regmap_update_bits(smi->map,
+                                        RTL8366RB_LED_0_1_CTRL_REG,
+                                        0x3F, val);
+               break;
+       case 1:
+               ret = regmap_update_bits(smi->map,
+                                        RTL8366RB_LED_0_1_CTRL_REG,
+                                        0x3F << RTL8366RB_LED_1_OFFSET,
+                                        val << RTL8366RB_LED_1_OFFSET);
+               break;
+       case 2:
+               ret = regmap_update_bits(smi->map,
+                                        RTL8366RB_LED_2_3_CTRL_REG,
+                                        0x3F, val);
+               break;
+       case 3:
+               ret = regmap_update_bits(smi->map,
+                                        RTL8366RB_LED_2_3_CTRL_REG,
+                                        0x3F << RTL8366RB_LED_3_OFFSET,
+                                        val << RTL8366RB_LED_3_OFFSET);
+               break;
+       case 4:
+               ret = regmap_update_bits(smi->map,
+                                        RTL8366RB_INTERRUPT_CONTROL_REG,
+                                        RTL8366RB_P4_RGMII_LED,
+                                        enable ? RTL8366RB_P4_RGMII_LED : 0);
+               break;
+       default:
+               dev_err(smi->dev, "no LED for port %d\n", port);
+               return;
+       }
+       if (ret)
+               dev_err(smi->dev, "error updating LED on port %d\n", port);
+}
+
+static int
+rtl8366rb_port_enable(struct dsa_switch *ds, int port,
+                     struct phy_device *phy)
+{
+       struct realtek_smi *smi = ds->priv;
+       int ret;
+
+       dev_dbg(smi->dev, "enable port %d\n", port);
+       ret = regmap_update_bits(smi->map, RTL8366RB_PECR, BIT(port),
+                                0);
+       if (ret)
+               return ret;
+
+       rb8366rb_set_port_led(smi, port, true);
+       return 0;
+}
+
+static void
+rtl8366rb_port_disable(struct dsa_switch *ds, int port)
+{
+       struct realtek_smi *smi = ds->priv;
+       int ret;
+
+       dev_dbg(smi->dev, "disable port %d\n", port);
+       ret = regmap_update_bits(smi->map, RTL8366RB_PECR, BIT(port),
+                                BIT(port));
+       if (ret)
+               return;
+
+       rb8366rb_set_port_led(smi, port, false);
+}
+
+static int
+rtl8366rb_port_bridge_join(struct dsa_switch *ds, int port,
+                          struct dsa_bridge bridge,
+                          bool *tx_fwd_offload)
+{
+       struct realtek_smi *smi = ds->priv;
+       unsigned int port_bitmap = 0;
+       int ret, i;
+
+       /* Loop over all other ports than the current one */
+       for (i = 0; i < RTL8366RB_PORT_NUM_CPU; i++) {
+               /* Current port handled last */
+               if (i == port)
+                       continue;
+               /* Not on this bridge */
+               if (!dsa_port_offloads_bridge(dsa_to_port(ds, i), &bridge))
+                       continue;
+               /* Join this port to each other port on the bridge */
+               ret = regmap_update_bits(smi->map, RTL8366RB_PORT_ISO(i),
+                                        RTL8366RB_PORT_ISO_PORTS(BIT(port)),
+                                        RTL8366RB_PORT_ISO_PORTS(BIT(port)));
+               if (ret)
+                       dev_err(smi->dev, "failed to join port %d\n", port);
+
+               port_bitmap |= BIT(i);
+       }
+
+       /* Set the bits for the ports we can access */
+       return regmap_update_bits(smi->map, RTL8366RB_PORT_ISO(port),
+                                 RTL8366RB_PORT_ISO_PORTS(port_bitmap),
+                                 RTL8366RB_PORT_ISO_PORTS(port_bitmap));
+}
+
+static void
+rtl8366rb_port_bridge_leave(struct dsa_switch *ds, int port,
+                           struct dsa_bridge bridge)
+{
+       struct realtek_smi *smi = ds->priv;
+       unsigned int port_bitmap = 0;
+       int ret, i;
+
+       /* Loop over all other ports than this one */
+       for (i = 0; i < RTL8366RB_PORT_NUM_CPU; i++) {
+               /* Current port handled last */
+               if (i == port)
+                       continue;
+               /* Not on this bridge */
+               if (!dsa_port_offloads_bridge(dsa_to_port(ds, i), &bridge))
+                       continue;
+               /* Remove this port from any other port on the bridge */
+               ret = regmap_update_bits(smi->map, RTL8366RB_PORT_ISO(i),
+                                        RTL8366RB_PORT_ISO_PORTS(BIT(port)), 0);
+               if (ret)
+                       dev_err(smi->dev, "failed to leave port %d\n", port);
+
+               port_bitmap |= BIT(i);
+       }
+
+       /* Clear the bits for the ports we can not access, leave ourselves */
+       regmap_update_bits(smi->map, RTL8366RB_PORT_ISO(port),
+                          RTL8366RB_PORT_ISO_PORTS(port_bitmap), 0);
+}
+
+/**
+ * rtl8366rb_drop_untagged() - make the switch drop untagged and C-tagged frames
+ * @smi: SMI state container
+ * @port: the port to drop untagged and C-tagged frames on
+ * @drop: whether to drop or pass untagged and C-tagged frames
+ *
+ * Return: zero for success, a negative number on error.
+ */
+static int rtl8366rb_drop_untagged(struct realtek_smi *smi, int port, bool drop)
+{
+       return regmap_update_bits(smi->map, RTL8366RB_VLAN_INGRESS_CTRL1_REG,
+                                 RTL8366RB_VLAN_INGRESS_CTRL1_DROP(port),
+                                 drop ? RTL8366RB_VLAN_INGRESS_CTRL1_DROP(port) : 0);
+}
+
+static int rtl8366rb_vlan_filtering(struct dsa_switch *ds, int port,
+                                   bool vlan_filtering,
+                                   struct netlink_ext_ack *extack)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8366rb *rb;
+       int ret;
+
+       rb = smi->chip_data;
+
+       dev_dbg(smi->dev, "port %d: %s VLAN filtering\n", port,
+               vlan_filtering ? "enable" : "disable");
+
+       /* If the port is not in the member set, the frame will be dropped */
+       ret = regmap_update_bits(smi->map, RTL8366RB_VLAN_INGRESS_CTRL2_REG,
+                                BIT(port), vlan_filtering ? BIT(port) : 0);
+       if (ret)
+               return ret;
+
+       /* If VLAN filtering is enabled and PVID is also enabled, we must
+        * not drop any untagged or C-tagged frames. If we turn off VLAN
+        * filtering on a port, we need to accept any frames.
+        */
+       if (vlan_filtering)
+               ret = rtl8366rb_drop_untagged(smi, port, !rb->pvid_enabled[port]);
+       else
+               ret = rtl8366rb_drop_untagged(smi, port, false);
+
+       return ret;
+}
+
+static int
+rtl8366rb_port_pre_bridge_flags(struct dsa_switch *ds, int port,
+                               struct switchdev_brport_flags flags,
+                               struct netlink_ext_ack *extack)
+{
+       /* We support enabling/disabling learning */
+       if (flags.mask & ~(BR_LEARNING))
+               return -EINVAL;
+
+       return 0;
+}
+
+static int
+rtl8366rb_port_bridge_flags(struct dsa_switch *ds, int port,
+                           struct switchdev_brport_flags flags,
+                           struct netlink_ext_ack *extack)
+{
+       struct realtek_smi *smi = ds->priv;
+       int ret;
+
+       if (flags.mask & BR_LEARNING) {
+               ret = regmap_update_bits(smi->map, RTL8366RB_PORT_LEARNDIS_CTRL,
+                                        BIT(port),
+                                        (flags.val & BR_LEARNING) ? 0 : BIT(port));
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+
+static void
+rtl8366rb_port_stp_state_set(struct dsa_switch *ds, int port, u8 state)
+{
+       struct realtek_smi *smi = ds->priv;
+       u32 val;
+       int i;
+
+       switch (state) {
+       case BR_STATE_DISABLED:
+               val = RTL8366RB_STP_STATE_DISABLED;
+               break;
+       case BR_STATE_BLOCKING:
+       case BR_STATE_LISTENING:
+               val = RTL8366RB_STP_STATE_BLOCKING;
+               break;
+       case BR_STATE_LEARNING:
+               val = RTL8366RB_STP_STATE_LEARNING;
+               break;
+       case BR_STATE_FORWARDING:
+               val = RTL8366RB_STP_STATE_FORWARDING;
+               break;
+       default:
+               dev_err(smi->dev, "unknown bridge state requested\n");
+               return;
+       }
+
+       /* Set the same status for the port on all the FIDs */
+       for (i = 0; i < RTL8366RB_NUM_FIDS; i++) {
+               regmap_update_bits(smi->map, RTL8366RB_STP_STATE_BASE + i,
+                                  RTL8366RB_STP_STATE_MASK(port),
+                                  RTL8366RB_STP_STATE(port, val));
+       }
+}
+
+static void
+rtl8366rb_port_fast_age(struct dsa_switch *ds, int port)
+{
+       struct realtek_smi *smi = ds->priv;
+
+       /* This will age out any learned L2 entries */
+       regmap_update_bits(smi->map, RTL8366RB_SECURITY_CTRL,
+                          BIT(port), BIT(port));
+       /* Restore the normal state of things */
+       regmap_update_bits(smi->map, RTL8366RB_SECURITY_CTRL,
+                          BIT(port), 0);
+}
+
+static int rtl8366rb_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
+{
+       struct realtek_smi *smi = ds->priv;
+       struct rtl8366rb *rb;
+       unsigned int max_mtu;
+       u32 len;
+       int i;
+
+       /* Cache the per-port MTU setting */
+       rb = smi->chip_data;
+       rb->max_mtu[port] = new_mtu;
+
+       /* Roof out the MTU for the entire switch to the greatest
+        * common denominator: the biggest set for any one port will
+        * be the biggest MTU for the switch.
+        *
+        * The first setting, 1522 bytes, is max IP packet 1500 bytes,
+        * plus ethernet header, 1518 bytes, plus CPU tag, 4 bytes.
+        * This function should consider the parameter an SDU, so the
+        * MTU passed for this setting is 1518 bytes. The same logic
+        * of subtracting the DSA tag of 4 bytes apply to the other
+        * settings.
+        */
+       max_mtu = 1518;
+       for (i = 0; i < RTL8366RB_NUM_PORTS; i++) {
+               if (rb->max_mtu[i] > max_mtu)
+                       max_mtu = rb->max_mtu[i];
+       }
+       if (max_mtu <= 1518)
+               len = RTL8366RB_SGCR_MAX_LENGTH_1522;
+       else if (max_mtu > 1518 && max_mtu <= 1532)
+               len = RTL8366RB_SGCR_MAX_LENGTH_1536;
+       else if (max_mtu > 1532 && max_mtu <= 1548)
+               len = RTL8366RB_SGCR_MAX_LENGTH_1552;
+       else
+               len = RTL8366RB_SGCR_MAX_LENGTH_16000;
+
+       return regmap_update_bits(smi->map, RTL8366RB_SGCR,
+                                 RTL8366RB_SGCR_MAX_LENGTH_MASK,
+                                 len);
+}
+
+static int rtl8366rb_max_mtu(struct dsa_switch *ds, int port)
+{
+       /* The max MTU is 16000 bytes, so we subtract the CPU tag
+        * and the max presented to the system is 15996 bytes.
+        */
+       return 15996;
+}
+
+static int rtl8366rb_get_vlan_4k(struct realtek_smi *smi, u32 vid,
+                                struct rtl8366_vlan_4k *vlan4k)
+{
+       u32 data[3];
+       int ret;
+       int i;
+
+       memset(vlan4k, '\0', sizeof(struct rtl8366_vlan_4k));
+
+       if (vid >= RTL8366RB_NUM_VIDS)
+               return -EINVAL;
+
+       /* write VID */
+       ret = regmap_write(smi->map, RTL8366RB_VLAN_TABLE_WRITE_BASE,
+                          vid & RTL8366RB_VLAN_VID_MASK);
+       if (ret)
+               return ret;
+
+       /* write table access control word */
+       ret = regmap_write(smi->map, RTL8366RB_TABLE_ACCESS_CTRL_REG,
+                          RTL8366RB_TABLE_VLAN_READ_CTRL);
+       if (ret)
+               return ret;
+
+       for (i = 0; i < 3; i++) {
+               ret = regmap_read(smi->map,
+                                 RTL8366RB_VLAN_TABLE_READ_BASE + i,
+                                 &data[i]);
+               if (ret)
+                       return ret;
+       }
+
+       vlan4k->vid = vid;
+       vlan4k->untag = (data[1] >> RTL8366RB_VLAN_UNTAG_SHIFT) &
+                       RTL8366RB_VLAN_UNTAG_MASK;
+       vlan4k->member = data[1] & RTL8366RB_VLAN_MEMBER_MASK;
+       vlan4k->fid = data[2] & RTL8366RB_VLAN_FID_MASK;
+
+       return 0;
+}
+
+static int rtl8366rb_set_vlan_4k(struct realtek_smi *smi,
+                                const struct rtl8366_vlan_4k *vlan4k)
+{
+       u32 data[3];
+       int ret;
+       int i;
+
+       if (vlan4k->vid >= RTL8366RB_NUM_VIDS ||
+           vlan4k->member > RTL8366RB_VLAN_MEMBER_MASK ||
+           vlan4k->untag > RTL8366RB_VLAN_UNTAG_MASK ||
+           vlan4k->fid > RTL8366RB_FIDMAX)
+               return -EINVAL;
+
+       data[0] = vlan4k->vid & RTL8366RB_VLAN_VID_MASK;
+       data[1] = (vlan4k->member & RTL8366RB_VLAN_MEMBER_MASK) |
+                 ((vlan4k->untag & RTL8366RB_VLAN_UNTAG_MASK) <<
+                       RTL8366RB_VLAN_UNTAG_SHIFT);
+       data[2] = vlan4k->fid & RTL8366RB_VLAN_FID_MASK;
+
+       for (i = 0; i < 3; i++) {
+               ret = regmap_write(smi->map,
+                                  RTL8366RB_VLAN_TABLE_WRITE_BASE + i,
+                                  data[i]);
+               if (ret)
+                       return ret;
+       }
+
+       /* write table access control word */
+       ret = regmap_write(smi->map, RTL8366RB_TABLE_ACCESS_CTRL_REG,
+                          RTL8366RB_TABLE_VLAN_WRITE_CTRL);
+
+       return ret;
+}
+
+static int rtl8366rb_get_vlan_mc(struct realtek_smi *smi, u32 index,
+                                struct rtl8366_vlan_mc *vlanmc)
+{
+       u32 data[3];
+       int ret;
+       int i;
+
+       memset(vlanmc, '\0', sizeof(struct rtl8366_vlan_mc));
+
+       if (index >= RTL8366RB_NUM_VLANS)
+               return -EINVAL;
+
+       for (i = 0; i < 3; i++) {
+               ret = regmap_read(smi->map,
+                                 RTL8366RB_VLAN_MC_BASE(index) + i,
+                                 &data[i]);
+               if (ret)
+                       return ret;
+       }
+
+       vlanmc->vid = data[0] & RTL8366RB_VLAN_VID_MASK;
+       vlanmc->priority = (data[0] >> RTL8366RB_VLAN_PRIORITY_SHIFT) &
+               RTL8366RB_VLAN_PRIORITY_MASK;
+       vlanmc->untag = (data[1] >> RTL8366RB_VLAN_UNTAG_SHIFT) &
+               RTL8366RB_VLAN_UNTAG_MASK;
+       vlanmc->member = data[1] & RTL8366RB_VLAN_MEMBER_MASK;
+       vlanmc->fid = data[2] & RTL8366RB_VLAN_FID_MASK;
+
+       return 0;
+}
+
+static int rtl8366rb_set_vlan_mc(struct realtek_smi *smi, u32 index,
+                                const struct rtl8366_vlan_mc *vlanmc)
+{
+       u32 data[3];
+       int ret;
+       int i;
+
+       if (index >= RTL8366RB_NUM_VLANS ||
+           vlanmc->vid >= RTL8366RB_NUM_VIDS ||
+           vlanmc->priority > RTL8366RB_PRIORITYMAX ||
+           vlanmc->member > RTL8366RB_VLAN_MEMBER_MASK ||
+           vlanmc->untag > RTL8366RB_VLAN_UNTAG_MASK ||
+           vlanmc->fid > RTL8366RB_FIDMAX)
+               return -EINVAL;
+
+       data[0] = (vlanmc->vid & RTL8366RB_VLAN_VID_MASK) |
+                 ((vlanmc->priority & RTL8366RB_VLAN_PRIORITY_MASK) <<
+                       RTL8366RB_VLAN_PRIORITY_SHIFT);
+       data[1] = (vlanmc->member & RTL8366RB_VLAN_MEMBER_MASK) |
+                 ((vlanmc->untag & RTL8366RB_VLAN_UNTAG_MASK) <<
+                       RTL8366RB_VLAN_UNTAG_SHIFT);
+       data[2] = vlanmc->fid & RTL8366RB_VLAN_FID_MASK;
+
+       for (i = 0; i < 3; i++) {
+               ret = regmap_write(smi->map,
+                                  RTL8366RB_VLAN_MC_BASE(index) + i,
+                                  data[i]);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+
+static int rtl8366rb_get_mc_index(struct realtek_smi *smi, int port, int *val)
+{
+       u32 data;
+       int ret;
+
+       if (port >= smi->num_ports)
+               return -EINVAL;
+
+       ret = regmap_read(smi->map, RTL8366RB_PORT_VLAN_CTRL_REG(port),
+                         &data);
+       if (ret)
+               return ret;
+
+       *val = (data >> RTL8366RB_PORT_VLAN_CTRL_SHIFT(port)) &
+               RTL8366RB_PORT_VLAN_CTRL_MASK;
+
+       return 0;
+}
+
+static int rtl8366rb_set_mc_index(struct realtek_smi *smi, int port, int index)
+{
+       struct rtl8366rb *rb;
+       bool pvid_enabled;
+       int ret;
+
+       rb = smi->chip_data;
+       pvid_enabled = !!index;
+
+       if (port >= smi->num_ports || index >= RTL8366RB_NUM_VLANS)
+               return -EINVAL;
+
+       ret = regmap_update_bits(smi->map, RTL8366RB_PORT_VLAN_CTRL_REG(port),
+                               RTL8366RB_PORT_VLAN_CTRL_MASK <<
+                                       RTL8366RB_PORT_VLAN_CTRL_SHIFT(port),
+                               (index & RTL8366RB_PORT_VLAN_CTRL_MASK) <<
+                                       RTL8366RB_PORT_VLAN_CTRL_SHIFT(port));
+       if (ret)
+               return ret;
+
+       rb->pvid_enabled[port] = pvid_enabled;
+
+       /* If VLAN filtering is enabled and PVID is also enabled, we must
+        * not drop any untagged or C-tagged frames. Make sure to update the
+        * filtering setting.
+        */
+       if (dsa_port_is_vlan_filtering(dsa_to_port(smi->ds, port)))
+               ret = rtl8366rb_drop_untagged(smi, port, !pvid_enabled);
+
+       return ret;
+}
+
+static bool rtl8366rb_is_vlan_valid(struct realtek_smi *smi, unsigned int vlan)
+{
+       unsigned int max = RTL8366RB_NUM_VLANS - 1;
+
+       if (smi->vlan4k_enabled)
+               max = RTL8366RB_NUM_VIDS - 1;
+
+       if (vlan > max)
+               return false;
+
+       return true;
+}
+
+static int rtl8366rb_enable_vlan(struct realtek_smi *smi, bool enable)
+{
+       dev_dbg(smi->dev, "%s VLAN\n", enable ? "enable" : "disable");
+       return regmap_update_bits(smi->map,
+                                 RTL8366RB_SGCR, RTL8366RB_SGCR_EN_VLAN,
+                                 enable ? RTL8366RB_SGCR_EN_VLAN : 0);
+}
+
+static int rtl8366rb_enable_vlan4k(struct realtek_smi *smi, bool enable)
+{
+       dev_dbg(smi->dev, "%s VLAN 4k\n", enable ? "enable" : "disable");
+       return regmap_update_bits(smi->map, RTL8366RB_SGCR,
+                                 RTL8366RB_SGCR_EN_VLAN_4KTB,
+                                 enable ? RTL8366RB_SGCR_EN_VLAN_4KTB : 0);
+}
+
+static int rtl8366rb_phy_read(struct realtek_smi *smi, int phy, int regnum)
+{
+       u32 val;
+       u32 reg;
+       int ret;
+
+       if (phy > RTL8366RB_PHY_NO_MAX)
+               return -EINVAL;
+
+       ret = regmap_write(smi->map, RTL8366RB_PHY_ACCESS_CTRL_REG,
+                          RTL8366RB_PHY_CTRL_READ);
+       if (ret)
+               return ret;
+
+       reg = 0x8000 | (1 << (phy + RTL8366RB_PHY_NO_OFFSET)) | regnum;
+
+       ret = regmap_write(smi->map, reg, 0);
+       if (ret) {
+               dev_err(smi->dev,
+                       "failed to write PHY%d reg %04x @ %04x, ret %d\n",
+                       phy, regnum, reg, ret);
+               return ret;
+       }
+
+       ret = regmap_read(smi->map, RTL8366RB_PHY_ACCESS_DATA_REG, &val);
+       if (ret)
+               return ret;
+
+       dev_dbg(smi->dev, "read PHY%d register 0x%04x @ %08x, val <- %04x\n",
+               phy, regnum, reg, val);
+
+       return val;
+}
+
+static int rtl8366rb_phy_write(struct realtek_smi *smi, int phy, int regnum,
+                              u16 val)
+{
+       u32 reg;
+       int ret;
+
+       if (phy > RTL8366RB_PHY_NO_MAX)
+               return -EINVAL;
+
+       ret = regmap_write(smi->map, RTL8366RB_PHY_ACCESS_CTRL_REG,
+                          RTL8366RB_PHY_CTRL_WRITE);
+       if (ret)
+               return ret;
+
+       reg = 0x8000 | (1 << (phy + RTL8366RB_PHY_NO_OFFSET)) | regnum;
+
+       dev_dbg(smi->dev, "write PHY%d register 0x%04x @ %04x, val -> %04x\n",
+               phy, regnum, reg, val);
+
+       ret = regmap_write(smi->map, reg, val);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+static int rtl8366rb_reset_chip(struct realtek_smi *smi)
+{
+       int timeout = 10;
+       u32 val;
+       int ret;
+
+       realtek_smi_write_reg_noack(smi, RTL8366RB_RESET_CTRL_REG,
+                                   RTL8366RB_CHIP_CTRL_RESET_HW);
+       do {
+               usleep_range(20000, 25000);
+               ret = regmap_read(smi->map, RTL8366RB_RESET_CTRL_REG, &val);
+               if (ret)
+                       return ret;
+
+               if (!(val & RTL8366RB_CHIP_CTRL_RESET_HW))
+                       break;
+       } while (--timeout);
+
+       if (!timeout) {
+               dev_err(smi->dev, "timeout waiting for the switch to reset\n");
+               return -EIO;
+       }
+
+       return 0;
+}
+
+static int rtl8366rb_detect(struct realtek_smi *smi)
+{
+       struct device *dev = smi->dev;
+       int ret;
+       u32 val;
+
+       /* Detect device */
+       ret = regmap_read(smi->map, 0x5c, &val);
+       if (ret) {
+               dev_err(dev, "can't get chip ID (%d)\n", ret);
+               return ret;
+       }
+
+       switch (val) {
+       case 0x6027:
+               dev_info(dev, "found an RTL8366S switch\n");
+               dev_err(dev, "this switch is not yet supported, submit patches!\n");
+               return -ENODEV;
+       case 0x5937:
+               dev_info(dev, "found an RTL8366RB switch\n");
+               smi->cpu_port = RTL8366RB_PORT_NUM_CPU;
+               smi->num_ports = RTL8366RB_NUM_PORTS;
+               smi->num_vlan_mc = RTL8366RB_NUM_VLANS;
+               smi->mib_counters = rtl8366rb_mib_counters;
+               smi->num_mib_counters = ARRAY_SIZE(rtl8366rb_mib_counters);
+               break;
+       default:
+               dev_info(dev, "found an Unknown Realtek switch (id=0x%04x)\n",
+                        val);
+               break;
+       }
+
+       ret = rtl8366rb_reset_chip(smi);
+       if (ret)
+               return ret;
+
+       return 0;
+}
+
+static const struct dsa_switch_ops rtl8366rb_switch_ops = {
+       .get_tag_protocol = rtl8366_get_tag_protocol,
+       .setup = rtl8366rb_setup,
+       .phylink_mac_link_up = rtl8366rb_mac_link_up,
+       .phylink_mac_link_down = rtl8366rb_mac_link_down,
+       .get_strings = rtl8366_get_strings,
+       .get_ethtool_stats = rtl8366_get_ethtool_stats,
+       .get_sset_count = rtl8366_get_sset_count,
+       .port_bridge_join = rtl8366rb_port_bridge_join,
+       .port_bridge_leave = rtl8366rb_port_bridge_leave,
+       .port_vlan_filtering = rtl8366rb_vlan_filtering,
+       .port_vlan_add = rtl8366_vlan_add,
+       .port_vlan_del = rtl8366_vlan_del,
+       .port_enable = rtl8366rb_port_enable,
+       .port_disable = rtl8366rb_port_disable,
+       .port_pre_bridge_flags = rtl8366rb_port_pre_bridge_flags,
+       .port_bridge_flags = rtl8366rb_port_bridge_flags,
+       .port_stp_state_set = rtl8366rb_port_stp_state_set,
+       .port_fast_age = rtl8366rb_port_fast_age,
+       .port_change_mtu = rtl8366rb_change_mtu,
+       .port_max_mtu = rtl8366rb_max_mtu,
+};
+
+static const struct realtek_smi_ops rtl8366rb_smi_ops = {
+       .detect         = rtl8366rb_detect,
+       .get_vlan_mc    = rtl8366rb_get_vlan_mc,
+       .set_vlan_mc    = rtl8366rb_set_vlan_mc,
+       .get_vlan_4k    = rtl8366rb_get_vlan_4k,
+       .set_vlan_4k    = rtl8366rb_set_vlan_4k,
+       .get_mc_index   = rtl8366rb_get_mc_index,
+       .set_mc_index   = rtl8366rb_set_mc_index,
+       .get_mib_counter = rtl8366rb_get_mib_counter,
+       .is_vlan_valid  = rtl8366rb_is_vlan_valid,
+       .enable_vlan    = rtl8366rb_enable_vlan,
+       .enable_vlan4k  = rtl8366rb_enable_vlan4k,
+       .phy_read       = rtl8366rb_phy_read,
+       .phy_write      = rtl8366rb_phy_write,
+};
+
+const struct realtek_smi_variant rtl8366rb_variant = {
+       .ds_ops = &rtl8366rb_switch_ops,
+       .ops = &rtl8366rb_smi_ops,
+       .clk_delay = 10,
+       .cmd_read = 0xa9,
+       .cmd_write = 0xa8,
+       .chip_data_sz = sizeof(struct rtl8366rb),
+};
+EXPORT_SYMBOL_GPL(rtl8366rb_variant);
diff --git a/drivers/net/dsa/rtl8365mb.c b/drivers/net/dsa/rtl8365mb.c
deleted file mode 100644 (file)
index 3b72954..0000000
+++ /dev/null
@@ -1,1987 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Realtek SMI subdriver for the Realtek RTL8365MB-VC ethernet switch.
- *
- * Copyright (C) 2021 Alvin Šipraga <alsi@bang-olufsen.dk>
- * Copyright (C) 2021 Michael Rasmussen <mir@bang-olufsen.dk>
- *
- * The RTL8365MB-VC is a 4+1 port 10/100/1000M switch controller. It includes 4
- * integrated PHYs for the user facing ports, and an extension interface which
- * can be connected to the CPU - or another PHY - via either MII, RMII, or
- * RGMII. The switch is configured via the Realtek Simple Management Interface
- * (SMI), which uses the MDIO/MDC lines.
- *
- * Below is a simplified block diagram of the chip and its relevant interfaces.
- *
- *                          .-----------------------------------.
- *                          |                                   |
- *         UTP <---------------> Giga PHY <-> PCS <-> P0 GMAC   |
- *         UTP <---------------> Giga PHY <-> PCS <-> P1 GMAC   |
- *         UTP <---------------> Giga PHY <-> PCS <-> P2 GMAC   |
- *         UTP <---------------> Giga PHY <-> PCS <-> P3 GMAC   |
- *                          |                                   |
- *     CPU/PHY <-MII/RMII/RGMII--->  Extension  <---> Extension |
- *                          |       interface 1        GMAC 1   |
- *                          |                                   |
- *     SMI driver/ <-MDC/SCL---> Management    ~~~~~~~~~~~~~~   |
- *        EEPROM   <-MDIO/SDA--> interface     ~REALTEK ~~~~~   |
- *                          |                  ~RTL8365MB ~~~   |
- *                          |                  ~GXXXC TAIWAN~   |
- *        GPIO <--------------> Reset          ~~~~~~~~~~~~~~   |
- *                          |                                   |
- *      Interrupt  <----------> Link UP/DOWN events             |
- *      controller          |                                   |
- *                          '-----------------------------------'
- *
- * The driver uses DSA to integrate the 4 user and 1 extension ports into the
- * kernel. Netdevices are created for the user ports, as are PHY devices for
- * their integrated PHYs. The device tree firmware should also specify the link
- * partner of the extension port - either via a fixed-link or other phy-handle.
- * See the device tree bindings for more detailed information. Note that the
- * driver has only been tested with a fixed-link, but in principle it should not
- * matter.
- *
- * NOTE: Currently, only the RGMII interface is implemented in this driver.
- *
- * The interrupt line is asserted on link UP/DOWN events. The driver creates a
- * custom irqchip to handle this interrupt and demultiplex the events by reading
- * the status registers via SMI. Interrupts are then propagated to the relevant
- * PHY device.
- *
- * The EEPROM contains initial register values which the chip will read over I2C
- * upon hardware reset. It is also possible to omit the EEPROM. In both cases,
- * the driver will manually reprogram some registers using jam tables to reach
- * an initial state defined by the vendor driver.
- *
- * This Linux driver is written based on an OS-agnostic vendor driver from
- * Realtek. The reference GPL-licensed sources can be found in the OpenWrt
- * source tree under the name rtl8367c. The vendor driver claims to support a
- * number of similar switch controllers from Realtek, but the only hardware we
- * have is the RTL8365MB-VC. Moreover, there does not seem to be any chip under
- * the name RTL8367C. Although one wishes that the 'C' stood for some kind of
- * common hardware revision, there exist examples of chips with the suffix -VC
- * which are explicitly not supported by the rtl8367c driver and which instead
- * require the rtl8367d vendor driver. With all this uncertainty, the driver has
- * been modestly named rtl8365mb. Future implementors may wish to rename things
- * accordingly.
- *
- * In the same family of chips, some carry up to 8 user ports and up to 2
- * extension ports. Where possible this driver tries to make things generic, but
- * more work must be done to support these configurations. According to
- * documentation from Realtek, the family should include the following chips:
- *
- *  - RTL8363NB
- *  - RTL8363NB-VB
- *  - RTL8363SC
- *  - RTL8363SC-VB
- *  - RTL8364NB
- *  - RTL8364NB-VB
- *  - RTL8365MB-VC
- *  - RTL8366SC
- *  - RTL8367RB-VB
- *  - RTL8367SB
- *  - RTL8367S
- *  - RTL8370MB
- *  - RTL8310SR
- *
- * Some of the register logic for these additional chips has been skipped over
- * while implementing this driver. It is therefore not possible to assume that
- * things will work out-of-the-box for other chips, and a careful review of the
- * vendor driver may be needed to expand support. The RTL8365MB-VC seems to be
- * one of the simpler chips.
- */
-
-#include <linux/bitfield.h>
-#include <linux/bitops.h>
-#include <linux/interrupt.h>
-#include <linux/irqdomain.h>
-#include <linux/mutex.h>
-#include <linux/of_irq.h>
-#include <linux/regmap.h>
-#include <linux/if_bridge.h>
-
-#include "realtek-smi-core.h"
-
-/* Chip-specific data and limits */
-#define RTL8365MB_CHIP_ID_8365MB_VC            0x6367
-#define RTL8365MB_CPU_PORT_NUM_8365MB_VC       6
-#define RTL8365MB_LEARN_LIMIT_MAX_8365MB_VC    2112
-
-/* Family-specific data and limits */
-#define RTL8365MB_PHYADDRMAX   7
-#define RTL8365MB_NUM_PHYREGS  32
-#define RTL8365MB_PHYREGMAX    (RTL8365MB_NUM_PHYREGS - 1)
-#define RTL8365MB_MAX_NUM_PORTS        (RTL8365MB_CPU_PORT_NUM_8365MB_VC + 1)
-
-/* Chip identification registers */
-#define RTL8365MB_CHIP_ID_REG          0x1300
-
-#define RTL8365MB_CHIP_VER_REG         0x1301
-
-#define RTL8365MB_MAGIC_REG            0x13C2
-#define   RTL8365MB_MAGIC_VALUE                0x0249
-
-/* Chip reset register */
-#define RTL8365MB_CHIP_RESET_REG       0x1322
-#define RTL8365MB_CHIP_RESET_SW_MASK   0x0002
-#define RTL8365MB_CHIP_RESET_HW_MASK   0x0001
-
-/* Interrupt polarity register */
-#define RTL8365MB_INTR_POLARITY_REG    0x1100
-#define   RTL8365MB_INTR_POLARITY_MASK 0x0001
-#define   RTL8365MB_INTR_POLARITY_HIGH 0
-#define   RTL8365MB_INTR_POLARITY_LOW  1
-
-/* Interrupt control/status register - enable/check specific interrupt types */
-#define RTL8365MB_INTR_CTRL_REG                        0x1101
-#define RTL8365MB_INTR_STATUS_REG              0x1102
-#define   RTL8365MB_INTR_SLIENT_START_2_MASK   0x1000
-#define   RTL8365MB_INTR_SLIENT_START_MASK     0x0800
-#define   RTL8365MB_INTR_ACL_ACTION_MASK       0x0200
-#define   RTL8365MB_INTR_CABLE_DIAG_FIN_MASK   0x0100
-#define   RTL8365MB_INTR_INTERRUPT_8051_MASK   0x0080
-#define   RTL8365MB_INTR_LOOP_DETECTION_MASK   0x0040
-#define   RTL8365MB_INTR_GREEN_TIMER_MASK      0x0020
-#define   RTL8365MB_INTR_SPECIAL_CONGEST_MASK  0x0010
-#define   RTL8365MB_INTR_SPEED_CHANGE_MASK     0x0008
-#define   RTL8365MB_INTR_LEARN_OVER_MASK       0x0004
-#define   RTL8365MB_INTR_METER_EXCEEDED_MASK   0x0002
-#define   RTL8365MB_INTR_LINK_CHANGE_MASK      0x0001
-#define   RTL8365MB_INTR_ALL_MASK                      \
-               (RTL8365MB_INTR_SLIENT_START_2_MASK |  \
-                RTL8365MB_INTR_SLIENT_START_MASK |    \
-                RTL8365MB_INTR_ACL_ACTION_MASK |      \
-                RTL8365MB_INTR_CABLE_DIAG_FIN_MASK |  \
-                RTL8365MB_INTR_INTERRUPT_8051_MASK |  \
-                RTL8365MB_INTR_LOOP_DETECTION_MASK |  \
-                RTL8365MB_INTR_GREEN_TIMER_MASK |     \
-                RTL8365MB_INTR_SPECIAL_CONGEST_MASK | \
-                RTL8365MB_INTR_SPEED_CHANGE_MASK |    \
-                RTL8365MB_INTR_LEARN_OVER_MASK |      \
-                RTL8365MB_INTR_METER_EXCEEDED_MASK |  \
-                RTL8365MB_INTR_LINK_CHANGE_MASK)
-
-/* Per-port interrupt type status registers */
-#define RTL8365MB_PORT_LINKDOWN_IND_REG                0x1106
-#define   RTL8365MB_PORT_LINKDOWN_IND_MASK     0x07FF
-
-#define RTL8365MB_PORT_LINKUP_IND_REG          0x1107
-#define   RTL8365MB_PORT_LINKUP_IND_MASK       0x07FF
-
-/* PHY indirect access registers */
-#define RTL8365MB_INDIRECT_ACCESS_CTRL_REG                     0x1F00
-#define   RTL8365MB_INDIRECT_ACCESS_CTRL_RW_MASK               0x0002
-#define   RTL8365MB_INDIRECT_ACCESS_CTRL_RW_READ               0
-#define   RTL8365MB_INDIRECT_ACCESS_CTRL_RW_WRITE              1
-#define   RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_MASK              0x0001
-#define   RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_VALUE             1
-#define RTL8365MB_INDIRECT_ACCESS_STATUS_REG                   0x1F01
-#define RTL8365MB_INDIRECT_ACCESS_ADDRESS_REG                  0x1F02
-#define   RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_5_1_MASK    GENMASK(4, 0)
-#define   RTL8365MB_INDIRECT_ACCESS_ADDRESS_PHYNUM_MASK                GENMASK(7, 5)
-#define   RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_9_6_MASK    GENMASK(11, 8)
-#define   RTL8365MB_PHY_BASE                                   0x2000
-#define RTL8365MB_INDIRECT_ACCESS_WRITE_DATA_REG               0x1F03
-#define RTL8365MB_INDIRECT_ACCESS_READ_DATA_REG                        0x1F04
-
-/* PHY OCP address prefix register */
-#define RTL8365MB_GPHY_OCP_MSB_0_REG                   0x1D15
-#define   RTL8365MB_GPHY_OCP_MSB_0_CFG_CPU_OCPADR_MASK 0x0FC0
-#define RTL8365MB_PHY_OCP_ADDR_PREFIX_MASK             0xFC00
-
-/* The PHY OCP addresses of PHY registers 0~31 start here */
-#define RTL8365MB_PHY_OCP_ADDR_PHYREG_BASE             0xA400
-
-/* EXT port interface mode values - used in DIGITAL_INTERFACE_SELECT */
-#define RTL8365MB_EXT_PORT_MODE_DISABLE                0
-#define RTL8365MB_EXT_PORT_MODE_RGMII          1
-#define RTL8365MB_EXT_PORT_MODE_MII_MAC                2
-#define RTL8365MB_EXT_PORT_MODE_MII_PHY                3
-#define RTL8365MB_EXT_PORT_MODE_TMII_MAC       4
-#define RTL8365MB_EXT_PORT_MODE_TMII_PHY       5
-#define RTL8365MB_EXT_PORT_MODE_GMII           6
-#define RTL8365MB_EXT_PORT_MODE_RMII_MAC       7
-#define RTL8365MB_EXT_PORT_MODE_RMII_PHY       8
-#define RTL8365MB_EXT_PORT_MODE_SGMII          9
-#define RTL8365MB_EXT_PORT_MODE_HSGMII         10
-#define RTL8365MB_EXT_PORT_MODE_1000X_100FX    11
-#define RTL8365MB_EXT_PORT_MODE_1000X          12
-#define RTL8365MB_EXT_PORT_MODE_100FX          13
-
-/* EXT port interface mode configuration registers 0~1 */
-#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0                0x1305
-#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG1                0x13C3
-#define RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(_extport)   \
-               (RTL8365MB_DIGITAL_INTERFACE_SELECT_REG0 + \
-                ((_extport) >> 1) * (0x13C3 - 0x1305))
-#define   RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(_extport) \
-               (0xF << (((_extport) % 2)))
-#define   RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_OFFSET(_extport) \
-               (((_extport) % 2) * 4)
-
-/* EXT port RGMII TX/RX delay configuration registers 1~2 */
-#define RTL8365MB_EXT_RGMXF_REG1               0x1307
-#define RTL8365MB_EXT_RGMXF_REG2               0x13C5
-#define RTL8365MB_EXT_RGMXF_REG(_extport)   \
-               (RTL8365MB_EXT_RGMXF_REG1 + \
-                (((_extport) >> 1) * (0x13C5 - 0x1307)))
-#define   RTL8365MB_EXT_RGMXF_RXDELAY_MASK     0x0007
-#define   RTL8365MB_EXT_RGMXF_TXDELAY_MASK     0x0008
-
-/* External port speed values - used in DIGITAL_INTERFACE_FORCE */
-#define RTL8365MB_PORT_SPEED_10M       0
-#define RTL8365MB_PORT_SPEED_100M      1
-#define RTL8365MB_PORT_SPEED_1000M     2
-
-/* EXT port force configuration registers 0~2 */
-#define RTL8365MB_DIGITAL_INTERFACE_FORCE_REG0                 0x1310
-#define RTL8365MB_DIGITAL_INTERFACE_FORCE_REG1                 0x1311
-#define RTL8365MB_DIGITAL_INTERFACE_FORCE_REG2                 0x13C4
-#define RTL8365MB_DIGITAL_INTERFACE_FORCE_REG(_extport)   \
-               (RTL8365MB_DIGITAL_INTERFACE_FORCE_REG0 + \
-                ((_extport) & 0x1) +                     \
-                ((((_extport) >> 1) & 0x1) * (0x13C4 - 0x1310)))
-#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_EN_MASK            0x1000
-#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_NWAY_MASK          0x0080
-#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_TXPAUSE_MASK       0x0040
-#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_RXPAUSE_MASK       0x0020
-#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_LINK_MASK          0x0010
-#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_DUPLEX_MASK                0x0004
-#define   RTL8365MB_DIGITAL_INTERFACE_FORCE_SPEED_MASK         0x0003
-
-/* CPU port mask register - controls which ports are treated as CPU ports */
-#define RTL8365MB_CPU_PORT_MASK_REG    0x1219
-#define   RTL8365MB_CPU_PORT_MASK_MASK 0x07FF
-
-/* CPU control register */
-#define RTL8365MB_CPU_CTRL_REG                 0x121A
-#define   RTL8365MB_CPU_CTRL_TRAP_PORT_EXT_MASK        0x0400
-#define   RTL8365MB_CPU_CTRL_TAG_FORMAT_MASK   0x0200
-#define   RTL8365MB_CPU_CTRL_RXBYTECOUNT_MASK  0x0080
-#define   RTL8365MB_CPU_CTRL_TAG_POSITION_MASK 0x0040
-#define   RTL8365MB_CPU_CTRL_TRAP_PORT_MASK    0x0038
-#define   RTL8365MB_CPU_CTRL_INSERTMODE_MASK   0x0006
-#define   RTL8365MB_CPU_CTRL_EN_MASK           0x0001
-
-/* Maximum packet length register */
-#define RTL8365MB_CFG0_MAX_LEN_REG     0x088C
-#define   RTL8365MB_CFG0_MAX_LEN_MASK  0x3FFF
-
-/* Port learning limit registers */
-#define RTL8365MB_LUT_PORT_LEARN_LIMIT_BASE            0x0A20
-#define RTL8365MB_LUT_PORT_LEARN_LIMIT_REG(_physport) \
-               (RTL8365MB_LUT_PORT_LEARN_LIMIT_BASE + (_physport))
-
-/* Port isolation (forwarding mask) registers */
-#define RTL8365MB_PORT_ISOLATION_REG_BASE              0x08A2
-#define RTL8365MB_PORT_ISOLATION_REG(_physport) \
-               (RTL8365MB_PORT_ISOLATION_REG_BASE + (_physport))
-#define   RTL8365MB_PORT_ISOLATION_MASK                        0x07FF
-
-/* MSTP port state registers - indexed by tree instance */
-#define RTL8365MB_MSTI_CTRL_BASE                       0x0A00
-#define RTL8365MB_MSTI_CTRL_REG(_msti, _physport) \
-               (RTL8365MB_MSTI_CTRL_BASE + ((_msti) << 1) + ((_physport) >> 3))
-#define   RTL8365MB_MSTI_CTRL_PORT_STATE_OFFSET(_physport) ((_physport) << 1)
-#define   RTL8365MB_MSTI_CTRL_PORT_STATE_MASK(_physport) \
-               (0x3 << RTL8365MB_MSTI_CTRL_PORT_STATE_OFFSET((_physport)))
-
-/* MIB counter value registers */
-#define RTL8365MB_MIB_COUNTER_BASE     0x1000
-#define RTL8365MB_MIB_COUNTER_REG(_x)  (RTL8365MB_MIB_COUNTER_BASE + (_x))
-
-/* MIB counter address register */
-#define RTL8365MB_MIB_ADDRESS_REG              0x1004
-#define   RTL8365MB_MIB_ADDRESS_PORT_OFFSET    0x007C
-#define   RTL8365MB_MIB_ADDRESS(_p, _x) \
-               (((RTL8365MB_MIB_ADDRESS_PORT_OFFSET) * (_p) + (_x)) >> 2)
-
-#define RTL8365MB_MIB_CTRL0_REG                        0x1005
-#define   RTL8365MB_MIB_CTRL0_RESET_MASK       0x0002
-#define   RTL8365MB_MIB_CTRL0_BUSY_MASK                0x0001
-
-/* The DSA callback .get_stats64 runs in atomic context, so we are not allowed
- * to block. On the other hand, accessing MIB counters absolutely requires us to
- * block. The solution is thus to schedule work which polls the MIB counters
- * asynchronously and updates some private data, which the callback can then
- * fetch atomically. Three seconds should be a good enough polling interval.
- */
-#define RTL8365MB_STATS_INTERVAL_JIFFIES       (3 * HZ)
-
-enum rtl8365mb_mib_counter_index {
-       RTL8365MB_MIB_ifInOctets,
-       RTL8365MB_MIB_dot3StatsFCSErrors,
-       RTL8365MB_MIB_dot3StatsSymbolErrors,
-       RTL8365MB_MIB_dot3InPauseFrames,
-       RTL8365MB_MIB_dot3ControlInUnknownOpcodes,
-       RTL8365MB_MIB_etherStatsFragments,
-       RTL8365MB_MIB_etherStatsJabbers,
-       RTL8365MB_MIB_ifInUcastPkts,
-       RTL8365MB_MIB_etherStatsDropEvents,
-       RTL8365MB_MIB_ifInMulticastPkts,
-       RTL8365MB_MIB_ifInBroadcastPkts,
-       RTL8365MB_MIB_inMldChecksumError,
-       RTL8365MB_MIB_inIgmpChecksumError,
-       RTL8365MB_MIB_inMldSpecificQuery,
-       RTL8365MB_MIB_inMldGeneralQuery,
-       RTL8365MB_MIB_inIgmpSpecificQuery,
-       RTL8365MB_MIB_inIgmpGeneralQuery,
-       RTL8365MB_MIB_inMldLeaves,
-       RTL8365MB_MIB_inIgmpLeaves,
-       RTL8365MB_MIB_etherStatsOctets,
-       RTL8365MB_MIB_etherStatsUnderSizePkts,
-       RTL8365MB_MIB_etherOversizeStats,
-       RTL8365MB_MIB_etherStatsPkts64Octets,
-       RTL8365MB_MIB_etherStatsPkts65to127Octets,
-       RTL8365MB_MIB_etherStatsPkts128to255Octets,
-       RTL8365MB_MIB_etherStatsPkts256to511Octets,
-       RTL8365MB_MIB_etherStatsPkts512to1023Octets,
-       RTL8365MB_MIB_etherStatsPkts1024to1518Octets,
-       RTL8365MB_MIB_ifOutOctets,
-       RTL8365MB_MIB_dot3StatsSingleCollisionFrames,
-       RTL8365MB_MIB_dot3StatsMultipleCollisionFrames,
-       RTL8365MB_MIB_dot3StatsDeferredTransmissions,
-       RTL8365MB_MIB_dot3StatsLateCollisions,
-       RTL8365MB_MIB_etherStatsCollisions,
-       RTL8365MB_MIB_dot3StatsExcessiveCollisions,
-       RTL8365MB_MIB_dot3OutPauseFrames,
-       RTL8365MB_MIB_ifOutDiscards,
-       RTL8365MB_MIB_dot1dTpPortInDiscards,
-       RTL8365MB_MIB_ifOutUcastPkts,
-       RTL8365MB_MIB_ifOutMulticastPkts,
-       RTL8365MB_MIB_ifOutBroadcastPkts,
-       RTL8365MB_MIB_outOampduPkts,
-       RTL8365MB_MIB_inOampduPkts,
-       RTL8365MB_MIB_inIgmpJoinsSuccess,
-       RTL8365MB_MIB_inIgmpJoinsFail,
-       RTL8365MB_MIB_inMldJoinsSuccess,
-       RTL8365MB_MIB_inMldJoinsFail,
-       RTL8365MB_MIB_inReportSuppressionDrop,
-       RTL8365MB_MIB_inLeaveSuppressionDrop,
-       RTL8365MB_MIB_outIgmpReports,
-       RTL8365MB_MIB_outIgmpLeaves,
-       RTL8365MB_MIB_outIgmpGeneralQuery,
-       RTL8365MB_MIB_outIgmpSpecificQuery,
-       RTL8365MB_MIB_outMldReports,
-       RTL8365MB_MIB_outMldLeaves,
-       RTL8365MB_MIB_outMldGeneralQuery,
-       RTL8365MB_MIB_outMldSpecificQuery,
-       RTL8365MB_MIB_inKnownMulticastPkts,
-       RTL8365MB_MIB_END,
-};
-
-struct rtl8365mb_mib_counter {
-       u32 offset;
-       u32 length;
-       const char *name;
-};
-
-#define RTL8365MB_MAKE_MIB_COUNTER(_offset, _length, _name) \
-               [RTL8365MB_MIB_ ## _name] = { _offset, _length, #_name }
-
-static struct rtl8365mb_mib_counter rtl8365mb_mib_counters[] = {
-       RTL8365MB_MAKE_MIB_COUNTER(0, 4, ifInOctets),
-       RTL8365MB_MAKE_MIB_COUNTER(4, 2, dot3StatsFCSErrors),
-       RTL8365MB_MAKE_MIB_COUNTER(6, 2, dot3StatsSymbolErrors),
-       RTL8365MB_MAKE_MIB_COUNTER(8, 2, dot3InPauseFrames),
-       RTL8365MB_MAKE_MIB_COUNTER(10, 2, dot3ControlInUnknownOpcodes),
-       RTL8365MB_MAKE_MIB_COUNTER(12, 2, etherStatsFragments),
-       RTL8365MB_MAKE_MIB_COUNTER(14, 2, etherStatsJabbers),
-       RTL8365MB_MAKE_MIB_COUNTER(16, 2, ifInUcastPkts),
-       RTL8365MB_MAKE_MIB_COUNTER(18, 2, etherStatsDropEvents),
-       RTL8365MB_MAKE_MIB_COUNTER(20, 2, ifInMulticastPkts),
-       RTL8365MB_MAKE_MIB_COUNTER(22, 2, ifInBroadcastPkts),
-       RTL8365MB_MAKE_MIB_COUNTER(24, 2, inMldChecksumError),
-       RTL8365MB_MAKE_MIB_COUNTER(26, 2, inIgmpChecksumError),
-       RTL8365MB_MAKE_MIB_COUNTER(28, 2, inMldSpecificQuery),
-       RTL8365MB_MAKE_MIB_COUNTER(30, 2, inMldGeneralQuery),
-       RTL8365MB_MAKE_MIB_COUNTER(32, 2, inIgmpSpecificQuery),
-       RTL8365MB_MAKE_MIB_COUNTER(34, 2, inIgmpGeneralQuery),
-       RTL8365MB_MAKE_MIB_COUNTER(36, 2, inMldLeaves),
-       RTL8365MB_MAKE_MIB_COUNTER(38, 2, inIgmpLeaves),
-       RTL8365MB_MAKE_MIB_COUNTER(40, 4, etherStatsOctets),
-       RTL8365MB_MAKE_MIB_COUNTER(44, 2, etherStatsUnderSizePkts),
-       RTL8365MB_MAKE_MIB_COUNTER(46, 2, etherOversizeStats),
-       RTL8365MB_MAKE_MIB_COUNTER(48, 2, etherStatsPkts64Octets),
-       RTL8365MB_MAKE_MIB_COUNTER(50, 2, etherStatsPkts65to127Octets),
-       RTL8365MB_MAKE_MIB_COUNTER(52, 2, etherStatsPkts128to255Octets),
-       RTL8365MB_MAKE_MIB_COUNTER(54, 2, etherStatsPkts256to511Octets),
-       RTL8365MB_MAKE_MIB_COUNTER(56, 2, etherStatsPkts512to1023Octets),
-       RTL8365MB_MAKE_MIB_COUNTER(58, 2, etherStatsPkts1024to1518Octets),
-       RTL8365MB_MAKE_MIB_COUNTER(60, 4, ifOutOctets),
-       RTL8365MB_MAKE_MIB_COUNTER(64, 2, dot3StatsSingleCollisionFrames),
-       RTL8365MB_MAKE_MIB_COUNTER(66, 2, dot3StatsMultipleCollisionFrames),
-       RTL8365MB_MAKE_MIB_COUNTER(68, 2, dot3StatsDeferredTransmissions),
-       RTL8365MB_MAKE_MIB_COUNTER(70, 2, dot3StatsLateCollisions),
-       RTL8365MB_MAKE_MIB_COUNTER(72, 2, etherStatsCollisions),
-       RTL8365MB_MAKE_MIB_COUNTER(74, 2, dot3StatsExcessiveCollisions),
-       RTL8365MB_MAKE_MIB_COUNTER(76, 2, dot3OutPauseFrames),
-       RTL8365MB_MAKE_MIB_COUNTER(78, 2, ifOutDiscards),
-       RTL8365MB_MAKE_MIB_COUNTER(80, 2, dot1dTpPortInDiscards),
-       RTL8365MB_MAKE_MIB_COUNTER(82, 2, ifOutUcastPkts),
-       RTL8365MB_MAKE_MIB_COUNTER(84, 2, ifOutMulticastPkts),
-       RTL8365MB_MAKE_MIB_COUNTER(86, 2, ifOutBroadcastPkts),
-       RTL8365MB_MAKE_MIB_COUNTER(88, 2, outOampduPkts),
-       RTL8365MB_MAKE_MIB_COUNTER(90, 2, inOampduPkts),
-       RTL8365MB_MAKE_MIB_COUNTER(92, 4, inIgmpJoinsSuccess),
-       RTL8365MB_MAKE_MIB_COUNTER(96, 2, inIgmpJoinsFail),
-       RTL8365MB_MAKE_MIB_COUNTER(98, 2, inMldJoinsSuccess),
-       RTL8365MB_MAKE_MIB_COUNTER(100, 2, inMldJoinsFail),
-       RTL8365MB_MAKE_MIB_COUNTER(102, 2, inReportSuppressionDrop),
-       RTL8365MB_MAKE_MIB_COUNTER(104, 2, inLeaveSuppressionDrop),
-       RTL8365MB_MAKE_MIB_COUNTER(106, 2, outIgmpReports),
-       RTL8365MB_MAKE_MIB_COUNTER(108, 2, outIgmpLeaves),
-       RTL8365MB_MAKE_MIB_COUNTER(110, 2, outIgmpGeneralQuery),
-       RTL8365MB_MAKE_MIB_COUNTER(112, 2, outIgmpSpecificQuery),
-       RTL8365MB_MAKE_MIB_COUNTER(114, 2, outMldReports),
-       RTL8365MB_MAKE_MIB_COUNTER(116, 2, outMldLeaves),
-       RTL8365MB_MAKE_MIB_COUNTER(118, 2, outMldGeneralQuery),
-       RTL8365MB_MAKE_MIB_COUNTER(120, 2, outMldSpecificQuery),
-       RTL8365MB_MAKE_MIB_COUNTER(122, 2, inKnownMulticastPkts),
-};
-
-static_assert(ARRAY_SIZE(rtl8365mb_mib_counters) == RTL8365MB_MIB_END);
-
-struct rtl8365mb_jam_tbl_entry {
-       u16 reg;
-       u16 val;
-};
-
-/* Lifted from the vendor driver sources */
-static const struct rtl8365mb_jam_tbl_entry rtl8365mb_init_jam_8365mb_vc[] = {
-       { 0x13EB, 0x15BB }, { 0x1303, 0x06D6 }, { 0x1304, 0x0700 },
-       { 0x13E2, 0x003F }, { 0x13F9, 0x0090 }, { 0x121E, 0x03CA },
-       { 0x1233, 0x0352 }, { 0x1237, 0x00A0 }, { 0x123A, 0x0030 },
-       { 0x1239, 0x0084 }, { 0x0301, 0x1000 }, { 0x1349, 0x001F },
-       { 0x18E0, 0x4004 }, { 0x122B, 0x241C }, { 0x1305, 0xC000 },
-       { 0x13F0, 0x0000 },
-};
-
-static const struct rtl8365mb_jam_tbl_entry rtl8365mb_init_jam_common[] = {
-       { 0x1200, 0x7FCB }, { 0x0884, 0x0003 }, { 0x06EB, 0x0001 },
-       { 0x03Fa, 0x0007 }, { 0x08C8, 0x00C0 }, { 0x0A30, 0x020E },
-       { 0x0800, 0x0000 }, { 0x0802, 0x0000 }, { 0x09DA, 0x0013 },
-       { 0x1D32, 0x0002 },
-};
-
-enum rtl8365mb_stp_state {
-       RTL8365MB_STP_STATE_DISABLED = 0,
-       RTL8365MB_STP_STATE_BLOCKING = 1,
-       RTL8365MB_STP_STATE_LEARNING = 2,
-       RTL8365MB_STP_STATE_FORWARDING = 3,
-};
-
-enum rtl8365mb_cpu_insert {
-       RTL8365MB_CPU_INSERT_TO_ALL = 0,
-       RTL8365MB_CPU_INSERT_TO_TRAPPING = 1,
-       RTL8365MB_CPU_INSERT_TO_NONE = 2,
-};
-
-enum rtl8365mb_cpu_position {
-       RTL8365MB_CPU_POS_AFTER_SA = 0,
-       RTL8365MB_CPU_POS_BEFORE_CRC = 1,
-};
-
-enum rtl8365mb_cpu_format {
-       RTL8365MB_CPU_FORMAT_8BYTES = 0,
-       RTL8365MB_CPU_FORMAT_4BYTES = 1,
-};
-
-enum rtl8365mb_cpu_rxlen {
-       RTL8365MB_CPU_RXLEN_72BYTES = 0,
-       RTL8365MB_CPU_RXLEN_64BYTES = 1,
-};
-
-/**
- * struct rtl8365mb_cpu - CPU port configuration
- * @enable: enable/disable hardware insertion of CPU tag in switch->CPU frames
- * @mask: port mask of ports that parse should parse CPU tags
- * @trap_port: forward trapped frames to this port
- * @insert: CPU tag insertion mode in switch->CPU frames
- * @position: position of CPU tag in frame
- * @rx_length: minimum CPU RX length
- * @format: CPU tag format
- *
- * Represents the CPU tagging and CPU port configuration of the switch. These
- * settings are configurable at runtime.
- */
-struct rtl8365mb_cpu {
-       bool enable;
-       u32 mask;
-       u32 trap_port;
-       enum rtl8365mb_cpu_insert insert;
-       enum rtl8365mb_cpu_position position;
-       enum rtl8365mb_cpu_rxlen rx_length;
-       enum rtl8365mb_cpu_format format;
-};
-
-/**
- * struct rtl8365mb_port - private per-port data
- * @smi: pointer to parent realtek_smi data
- * @index: DSA port index, same as dsa_port::index
- * @stats: link statistics populated by rtl8365mb_stats_poll, ready for atomic
- *         access via rtl8365mb_get_stats64
- * @stats_lock: protect the stats structure during read/update
- * @mib_work: delayed work for polling MIB counters
- */
-struct rtl8365mb_port {
-       struct realtek_smi *smi;
-       unsigned int index;
-       struct rtnl_link_stats64 stats;
-       spinlock_t stats_lock;
-       struct delayed_work mib_work;
-};
-
-/**
- * struct rtl8365mb - private chip-specific driver data
- * @smi: pointer to parent realtek_smi data
- * @irq: registered IRQ or zero
- * @chip_id: chip identifier
- * @chip_ver: chip silicon revision
- * @port_mask: mask of all ports
- * @learn_limit_max: maximum number of L2 addresses the chip can learn
- * @cpu: CPU tagging and CPU port configuration for this chip
- * @mib_lock: prevent concurrent reads of MIB counters
- * @ports: per-port data
- * @jam_table: chip-specific initialization jam table
- * @jam_size: size of the chip's jam table
- *
- * Private data for this driver.
- */
-struct rtl8365mb {
-       struct realtek_smi *smi;
-       int irq;
-       u32 chip_id;
-       u32 chip_ver;
-       u32 port_mask;
-       u32 learn_limit_max;
-       struct rtl8365mb_cpu cpu;
-       struct mutex mib_lock;
-       struct rtl8365mb_port ports[RTL8365MB_MAX_NUM_PORTS];
-       const struct rtl8365mb_jam_tbl_entry *jam_table;
-       size_t jam_size;
-};
-
-static int rtl8365mb_phy_poll_busy(struct realtek_smi *smi)
-{
-       u32 val;
-
-       return regmap_read_poll_timeout(smi->map,
-                                       RTL8365MB_INDIRECT_ACCESS_STATUS_REG,
-                                       val, !val, 10, 100);
-}
-
-static int rtl8365mb_phy_ocp_prepare(struct realtek_smi *smi, int phy,
-                                    u32 ocp_addr)
-{
-       u32 val;
-       int ret;
-
-       /* Set OCP prefix */
-       val = FIELD_GET(RTL8365MB_PHY_OCP_ADDR_PREFIX_MASK, ocp_addr);
-       ret = regmap_update_bits(
-               smi->map, RTL8365MB_GPHY_OCP_MSB_0_REG,
-               RTL8365MB_GPHY_OCP_MSB_0_CFG_CPU_OCPADR_MASK,
-               FIELD_PREP(RTL8365MB_GPHY_OCP_MSB_0_CFG_CPU_OCPADR_MASK, val));
-       if (ret)
-               return ret;
-
-       /* Set PHY register address */
-       val = RTL8365MB_PHY_BASE;
-       val |= FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_ADDRESS_PHYNUM_MASK, phy);
-       val |= FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_5_1_MASK,
-                         ocp_addr >> 1);
-       val |= FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_9_6_MASK,
-                         ocp_addr >> 6);
-       ret = regmap_write(smi->map, RTL8365MB_INDIRECT_ACCESS_ADDRESS_REG,
-                          val);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-static int rtl8365mb_phy_ocp_read(struct realtek_smi *smi, int phy,
-                                 u32 ocp_addr, u16 *data)
-{
-       u32 val;
-       int ret;
-
-       ret = rtl8365mb_phy_poll_busy(smi);
-       if (ret)
-               return ret;
-
-       ret = rtl8365mb_phy_ocp_prepare(smi, phy, ocp_addr);
-       if (ret)
-               return ret;
-
-       /* Execute read operation */
-       val = FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_MASK,
-                        RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_VALUE) |
-             FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_CTRL_RW_MASK,
-                        RTL8365MB_INDIRECT_ACCESS_CTRL_RW_READ);
-       ret = regmap_write(smi->map, RTL8365MB_INDIRECT_ACCESS_CTRL_REG, val);
-       if (ret)
-               return ret;
-
-       ret = rtl8365mb_phy_poll_busy(smi);
-       if (ret)
-               return ret;
-
-       /* Get PHY register data */
-       ret = regmap_read(smi->map, RTL8365MB_INDIRECT_ACCESS_READ_DATA_REG,
-                         &val);
-       if (ret)
-               return ret;
-
-       *data = val & 0xFFFF;
-
-       return 0;
-}
-
-static int rtl8365mb_phy_ocp_write(struct realtek_smi *smi, int phy,
-                                  u32 ocp_addr, u16 data)
-{
-       u32 val;
-       int ret;
-
-       ret = rtl8365mb_phy_poll_busy(smi);
-       if (ret)
-               return ret;
-
-       ret = rtl8365mb_phy_ocp_prepare(smi, phy, ocp_addr);
-       if (ret)
-               return ret;
-
-       /* Set PHY register data */
-       ret = regmap_write(smi->map, RTL8365MB_INDIRECT_ACCESS_WRITE_DATA_REG,
-                          data);
-       if (ret)
-               return ret;
-
-       /* Execute write operation */
-       val = FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_MASK,
-                        RTL8365MB_INDIRECT_ACCESS_CTRL_CMD_VALUE) |
-             FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_CTRL_RW_MASK,
-                        RTL8365MB_INDIRECT_ACCESS_CTRL_RW_WRITE);
-       ret = regmap_write(smi->map, RTL8365MB_INDIRECT_ACCESS_CTRL_REG, val);
-       if (ret)
-               return ret;
-
-       ret = rtl8365mb_phy_poll_busy(smi);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-static int rtl8365mb_phy_read(struct realtek_smi *smi, int phy, int regnum)
-{
-       u32 ocp_addr;
-       u16 val;
-       int ret;
-
-       if (phy > RTL8365MB_PHYADDRMAX)
-               return -EINVAL;
-
-       if (regnum > RTL8365MB_PHYREGMAX)
-               return -EINVAL;
-
-       ocp_addr = RTL8365MB_PHY_OCP_ADDR_PHYREG_BASE + regnum * 2;
-
-       ret = rtl8365mb_phy_ocp_read(smi, phy, ocp_addr, &val);
-       if (ret) {
-               dev_err(smi->dev,
-                       "failed to read PHY%d reg %02x @ %04x, ret %d\n", phy,
-                       regnum, ocp_addr, ret);
-               return ret;
-       }
-
-       dev_dbg(smi->dev, "read PHY%d register 0x%02x @ %04x, val <- %04x\n",
-               phy, regnum, ocp_addr, val);
-
-       return val;
-}
-
-static int rtl8365mb_phy_write(struct realtek_smi *smi, int phy, int regnum,
-                              u16 val)
-{
-       u32 ocp_addr;
-       int ret;
-
-       if (phy > RTL8365MB_PHYADDRMAX)
-               return -EINVAL;
-
-       if (regnum > RTL8365MB_PHYREGMAX)
-               return -EINVAL;
-
-       ocp_addr = RTL8365MB_PHY_OCP_ADDR_PHYREG_BASE + regnum * 2;
-
-       ret = rtl8365mb_phy_ocp_write(smi, phy, ocp_addr, val);
-       if (ret) {
-               dev_err(smi->dev,
-                       "failed to write PHY%d reg %02x @ %04x, ret %d\n", phy,
-                       regnum, ocp_addr, ret);
-               return ret;
-       }
-
-       dev_dbg(smi->dev, "write PHY%d register 0x%02x @ %04x, val -> %04x\n",
-               phy, regnum, ocp_addr, val);
-
-       return 0;
-}
-
-static enum dsa_tag_protocol
-rtl8365mb_get_tag_protocol(struct dsa_switch *ds, int port,
-                          enum dsa_tag_protocol mp)
-{
-       return DSA_TAG_PROTO_RTL8_4;
-}
-
-static int rtl8365mb_ext_config_rgmii(struct realtek_smi *smi, int port,
-                                     phy_interface_t interface)
-{
-       struct device_node *dn;
-       struct dsa_port *dp;
-       int tx_delay = 0;
-       int rx_delay = 0;
-       int ext_port;
-       u32 val;
-       int ret;
-
-       if (port == smi->cpu_port) {
-               ext_port = 1;
-       } else {
-               dev_err(smi->dev, "only one EXT port is currently supported\n");
-               return -EINVAL;
-       }
-
-       dp = dsa_to_port(smi->ds, port);
-       dn = dp->dn;
-
-       /* Set the RGMII TX/RX delay
-        *
-        * The Realtek vendor driver indicates the following possible
-        * configuration settings:
-        *
-        *   TX delay:
-        *     0 = no delay, 1 = 2 ns delay
-        *   RX delay:
-        *     0 = no delay, 7 = maximum delay
-        *     Each step is approximately 0.3 ns, so the maximum delay is about
-        *     2.1 ns.
-        *
-        * The vendor driver also states that this must be configured *before*
-        * forcing the external interface into a particular mode, which is done
-        * in the rtl8365mb_phylink_mac_link_{up,down} functions.
-        *
-        * Only configure an RGMII TX (resp. RX) delay if the
-        * tx-internal-delay-ps (resp. rx-internal-delay-ps) OF property is
-        * specified. We ignore the detail of the RGMII interface mode
-        * (RGMII_{RXID, TXID, etc.}), as this is considered to be a PHY-only
-        * property.
-        */
-       if (!of_property_read_u32(dn, "tx-internal-delay-ps", &val)) {
-               val = val / 1000; /* convert to ns */
-
-               if (val == 0 || val == 2)
-                       tx_delay = val / 2;
-               else
-                       dev_warn(smi->dev,
-                                "EXT port TX delay must be 0 or 2 ns\n");
-       }
-
-       if (!of_property_read_u32(dn, "rx-internal-delay-ps", &val)) {
-               val = DIV_ROUND_CLOSEST(val, 300); /* convert to 0.3 ns step */
-
-               if (val <= 7)
-                       rx_delay = val;
-               else
-                       dev_warn(smi->dev,
-                                "EXT port RX delay must be 0 to 2.1 ns\n");
-       }
-
-       ret = regmap_update_bits(
-               smi->map, RTL8365MB_EXT_RGMXF_REG(ext_port),
-               RTL8365MB_EXT_RGMXF_TXDELAY_MASK |
-                       RTL8365MB_EXT_RGMXF_RXDELAY_MASK,
-               FIELD_PREP(RTL8365MB_EXT_RGMXF_TXDELAY_MASK, tx_delay) |
-                       FIELD_PREP(RTL8365MB_EXT_RGMXF_RXDELAY_MASK, rx_delay));
-       if (ret)
-               return ret;
-
-       ret = regmap_update_bits(
-               smi->map, RTL8365MB_DIGITAL_INTERFACE_SELECT_REG(ext_port),
-               RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_MASK(ext_port),
-               RTL8365MB_EXT_PORT_MODE_RGMII
-                       << RTL8365MB_DIGITAL_INTERFACE_SELECT_MODE_OFFSET(
-                                  ext_port));
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-static int rtl8365mb_ext_config_forcemode(struct realtek_smi *smi, int port,
-                                         bool link, int speed, int duplex,
-                                         bool tx_pause, bool rx_pause)
-{
-       u32 r_tx_pause;
-       u32 r_rx_pause;
-       u32 r_duplex;
-       u32 r_speed;
-       u32 r_link;
-       int ext_port;
-       int val;
-       int ret;
-
-       if (port == smi->cpu_port) {
-               ext_port = 1;
-       } else {
-               dev_err(smi->dev, "only one EXT port is currently supported\n");
-               return -EINVAL;
-       }
-
-       if (link) {
-               /* Force the link up with the desired configuration */
-               r_link = 1;
-               r_rx_pause = rx_pause ? 1 : 0;
-               r_tx_pause = tx_pause ? 1 : 0;
-
-               if (speed == SPEED_1000) {
-                       r_speed = RTL8365MB_PORT_SPEED_1000M;
-               } else if (speed == SPEED_100) {
-                       r_speed = RTL8365MB_PORT_SPEED_100M;
-               } else if (speed == SPEED_10) {
-                       r_speed = RTL8365MB_PORT_SPEED_10M;
-               } else {
-                       dev_err(smi->dev, "unsupported port speed %s\n",
-                               phy_speed_to_str(speed));
-                       return -EINVAL;
-               }
-
-               if (duplex == DUPLEX_FULL) {
-                       r_duplex = 1;
-               } else if (duplex == DUPLEX_HALF) {
-                       r_duplex = 0;
-               } else {
-                       dev_err(smi->dev, "unsupported duplex %s\n",
-                               phy_duplex_to_str(duplex));
-                       return -EINVAL;
-               }
-       } else {
-               /* Force the link down and reset any programmed configuration */
-               r_link = 0;
-               r_tx_pause = 0;
-               r_rx_pause = 0;
-               r_speed = 0;
-               r_duplex = 0;
-       }
-
-       val = FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_EN_MASK, 1) |
-             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_TXPAUSE_MASK,
-                        r_tx_pause) |
-             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_RXPAUSE_MASK,
-                        r_rx_pause) |
-             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_LINK_MASK, r_link) |
-             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_DUPLEX_MASK,
-                        r_duplex) |
-             FIELD_PREP(RTL8365MB_DIGITAL_INTERFACE_FORCE_SPEED_MASK, r_speed);
-       ret = regmap_write(smi->map,
-                          RTL8365MB_DIGITAL_INTERFACE_FORCE_REG(ext_port),
-                          val);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-static bool rtl8365mb_phy_mode_supported(struct dsa_switch *ds, int port,
-                                        phy_interface_t interface)
-{
-       if (dsa_is_user_port(ds, port) &&
-           (interface == PHY_INTERFACE_MODE_NA ||
-            interface == PHY_INTERFACE_MODE_INTERNAL ||
-            interface == PHY_INTERFACE_MODE_GMII))
-               /* Internal PHY */
-               return true;
-       else if (dsa_is_cpu_port(ds, port) &&
-                phy_interface_mode_is_rgmii(interface))
-               /* Extension MAC */
-               return true;
-
-       return false;
-}
-
-static void rtl8365mb_phylink_validate(struct dsa_switch *ds, int port,
-                                      unsigned long *supported,
-                                      struct phylink_link_state *state)
-{
-       struct realtek_smi *smi = ds->priv;
-       __ETHTOOL_DECLARE_LINK_MODE_MASK(mask) = { 0 };
-
-       /* include/linux/phylink.h says:
-        *     When @state->interface is %PHY_INTERFACE_MODE_NA, phylink
-        *     expects the MAC driver to return all supported link modes.
-        */
-       if (state->interface != PHY_INTERFACE_MODE_NA &&
-           !rtl8365mb_phy_mode_supported(ds, port, state->interface)) {
-               dev_err(smi->dev, "phy mode %s is unsupported on port %d\n",
-                       phy_modes(state->interface), port);
-               linkmode_zero(supported);
-               return;
-       }
-
-       phylink_set_port_modes(mask);
-
-       phylink_set(mask, Autoneg);
-       phylink_set(mask, Pause);
-       phylink_set(mask, Asym_Pause);
-
-       phylink_set(mask, 10baseT_Half);
-       phylink_set(mask, 10baseT_Full);
-       phylink_set(mask, 100baseT_Half);
-       phylink_set(mask, 100baseT_Full);
-       phylink_set(mask, 1000baseT_Full);
-
-       linkmode_and(supported, supported, mask);
-       linkmode_and(state->advertising, state->advertising, mask);
-}
-
-static void rtl8365mb_phylink_mac_config(struct dsa_switch *ds, int port,
-                                        unsigned int mode,
-                                        const struct phylink_link_state *state)
-{
-       struct realtek_smi *smi = ds->priv;
-       int ret;
-
-       if (!rtl8365mb_phy_mode_supported(ds, port, state->interface)) {
-               dev_err(smi->dev, "phy mode %s is unsupported on port %d\n",
-                       phy_modes(state->interface), port);
-               return;
-       }
-
-       if (mode != MLO_AN_PHY && mode != MLO_AN_FIXED) {
-               dev_err(smi->dev,
-                       "port %d supports only conventional PHY or fixed-link\n",
-                       port);
-               return;
-       }
-
-       if (phy_interface_mode_is_rgmii(state->interface)) {
-               ret = rtl8365mb_ext_config_rgmii(smi, port, state->interface);
-               if (ret)
-                       dev_err(smi->dev,
-                               "failed to configure RGMII mode on port %d: %d\n",
-                               port, ret);
-               return;
-       }
-
-       /* TODO: Implement MII and RMII modes, which the RTL8365MB-VC also
-        * supports
-        */
-}
-
-static void rtl8365mb_phylink_mac_link_down(struct dsa_switch *ds, int port,
-                                           unsigned int mode,
-                                           phy_interface_t interface)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8365mb_port *p;
-       struct rtl8365mb *mb;
-       int ret;
-
-       mb = smi->chip_data;
-       p = &mb->ports[port];
-       cancel_delayed_work_sync(&p->mib_work);
-
-       if (phy_interface_mode_is_rgmii(interface)) {
-               ret = rtl8365mb_ext_config_forcemode(smi, port, false, 0, 0,
-                                                    false, false);
-               if (ret)
-                       dev_err(smi->dev,
-                               "failed to reset forced mode on port %d: %d\n",
-                               port, ret);
-
-               return;
-       }
-}
-
-static void rtl8365mb_phylink_mac_link_up(struct dsa_switch *ds, int port,
-                                         unsigned int mode,
-                                         phy_interface_t interface,
-                                         struct phy_device *phydev, int speed,
-                                         int duplex, bool tx_pause,
-                                         bool rx_pause)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8365mb_port *p;
-       struct rtl8365mb *mb;
-       int ret;
-
-       mb = smi->chip_data;
-       p = &mb->ports[port];
-       schedule_delayed_work(&p->mib_work, 0);
-
-       if (phy_interface_mode_is_rgmii(interface)) {
-               ret = rtl8365mb_ext_config_forcemode(smi, port, true, speed,
-                                                    duplex, tx_pause,
-                                                    rx_pause);
-               if (ret)
-                       dev_err(smi->dev,
-                               "failed to force mode on port %d: %d\n", port,
-                               ret);
-
-               return;
-       }
-}
-
-static void rtl8365mb_port_stp_state_set(struct dsa_switch *ds, int port,
-                                        u8 state)
-{
-       struct realtek_smi *smi = ds->priv;
-       enum rtl8365mb_stp_state val;
-       int msti = 0;
-
-       switch (state) {
-       case BR_STATE_DISABLED:
-               val = RTL8365MB_STP_STATE_DISABLED;
-               break;
-       case BR_STATE_BLOCKING:
-       case BR_STATE_LISTENING:
-               val = RTL8365MB_STP_STATE_BLOCKING;
-               break;
-       case BR_STATE_LEARNING:
-               val = RTL8365MB_STP_STATE_LEARNING;
-               break;
-       case BR_STATE_FORWARDING:
-               val = RTL8365MB_STP_STATE_FORWARDING;
-               break;
-       default:
-               dev_err(smi->dev, "invalid STP state: %u\n", state);
-               return;
-       }
-
-       regmap_update_bits(smi->map, RTL8365MB_MSTI_CTRL_REG(msti, port),
-                          RTL8365MB_MSTI_CTRL_PORT_STATE_MASK(port),
-                          val << RTL8365MB_MSTI_CTRL_PORT_STATE_OFFSET(port));
-}
-
-static int rtl8365mb_port_set_learning(struct realtek_smi *smi, int port,
-                                      bool enable)
-{
-       struct rtl8365mb *mb = smi->chip_data;
-
-       /* Enable/disable learning by limiting the number of L2 addresses the
-        * port can learn. Realtek documentation states that a limit of zero
-        * disables learning. When enabling learning, set it to the chip's
-        * maximum.
-        */
-       return regmap_write(smi->map, RTL8365MB_LUT_PORT_LEARN_LIMIT_REG(port),
-                           enable ? mb->learn_limit_max : 0);
-}
-
-static int rtl8365mb_port_set_isolation(struct realtek_smi *smi, int port,
-                                       u32 mask)
-{
-       return regmap_write(smi->map, RTL8365MB_PORT_ISOLATION_REG(port), mask);
-}
-
-static int rtl8365mb_mib_counter_read(struct realtek_smi *smi, int port,
-                                     u32 offset, u32 length, u64 *mibvalue)
-{
-       u64 tmpvalue = 0;
-       u32 val;
-       int ret;
-       int i;
-
-       /* The MIB address is an SRAM address. We request a particular address
-        * and then poll the control register before reading the value from some
-        * counter registers.
-        */
-       ret = regmap_write(smi->map, RTL8365MB_MIB_ADDRESS_REG,
-                          RTL8365MB_MIB_ADDRESS(port, offset));
-       if (ret)
-               return ret;
-
-       /* Poll for completion */
-       ret = regmap_read_poll_timeout(smi->map, RTL8365MB_MIB_CTRL0_REG, val,
-                                      !(val & RTL8365MB_MIB_CTRL0_BUSY_MASK),
-                                      10, 100);
-       if (ret)
-               return ret;
-
-       /* Presumably this indicates a MIB counter read failure */
-       if (val & RTL8365MB_MIB_CTRL0_RESET_MASK)
-               return -EIO;
-
-       /* There are four MIB counter registers each holding a 16 bit word of a
-        * MIB counter. Depending on the offset, we should read from the upper
-        * two or lower two registers. In case the MIB counter is 4 words, we
-        * read from all four registers.
-        */
-       if (length == 4)
-               offset = 3;
-       else
-               offset = (offset + 1) % 4;
-
-       /* Read the MIB counter 16 bits at a time */
-       for (i = 0; i < length; i++) {
-               ret = regmap_read(smi->map,
-                                 RTL8365MB_MIB_COUNTER_REG(offset - i), &val);
-               if (ret)
-                       return ret;
-
-               tmpvalue = ((tmpvalue) << 16) | (val & 0xFFFF);
-       }
-
-       /* Only commit the result if no error occurred */
-       *mibvalue = tmpvalue;
-
-       return 0;
-}
-
-static void rtl8365mb_get_ethtool_stats(struct dsa_switch *ds, int port, u64 *data)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8365mb *mb;
-       int ret;
-       int i;
-
-       mb = smi->chip_data;
-
-       mutex_lock(&mb->mib_lock);
-       for (i = 0; i < RTL8365MB_MIB_END; i++) {
-               struct rtl8365mb_mib_counter *mib = &rtl8365mb_mib_counters[i];
-
-               ret = rtl8365mb_mib_counter_read(smi, port, mib->offset,
-                                                mib->length, &data[i]);
-               if (ret) {
-                       dev_err(smi->dev,
-                               "failed to read port %d counters: %d\n", port,
-                               ret);
-                       break;
-               }
-       }
-       mutex_unlock(&mb->mib_lock);
-}
-
-static void rtl8365mb_get_strings(struct dsa_switch *ds, int port, u32 stringset, u8 *data)
-{
-       int i;
-
-       if (stringset != ETH_SS_STATS)
-               return;
-
-       for (i = 0; i < RTL8365MB_MIB_END; i++) {
-               struct rtl8365mb_mib_counter *mib = &rtl8365mb_mib_counters[i];
-
-               strncpy(data + i * ETH_GSTRING_LEN, mib->name, ETH_GSTRING_LEN);
-       }
-}
-
-static int rtl8365mb_get_sset_count(struct dsa_switch *ds, int port, int sset)
-{
-       if (sset != ETH_SS_STATS)
-               return -EOPNOTSUPP;
-
-       return RTL8365MB_MIB_END;
-}
-
-static void rtl8365mb_get_phy_stats(struct dsa_switch *ds, int port,
-                                   struct ethtool_eth_phy_stats *phy_stats)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8365mb_mib_counter *mib;
-       struct rtl8365mb *mb;
-
-       mb = smi->chip_data;
-       mib = &rtl8365mb_mib_counters[RTL8365MB_MIB_dot3StatsSymbolErrors];
-
-       mutex_lock(&mb->mib_lock);
-       rtl8365mb_mib_counter_read(smi, port, mib->offset, mib->length,
-                                  &phy_stats->SymbolErrorDuringCarrier);
-       mutex_unlock(&mb->mib_lock);
-}
-
-static void rtl8365mb_get_mac_stats(struct dsa_switch *ds, int port,
-                                   struct ethtool_eth_mac_stats *mac_stats)
-{
-       u64 cnt[RTL8365MB_MIB_END] = {
-               [RTL8365MB_MIB_ifOutOctets] = 1,
-               [RTL8365MB_MIB_ifOutUcastPkts] = 1,
-               [RTL8365MB_MIB_ifOutMulticastPkts] = 1,
-               [RTL8365MB_MIB_ifOutBroadcastPkts] = 1,
-               [RTL8365MB_MIB_dot3OutPauseFrames] = 1,
-               [RTL8365MB_MIB_ifOutDiscards] = 1,
-               [RTL8365MB_MIB_ifInOctets] = 1,
-               [RTL8365MB_MIB_ifInUcastPkts] = 1,
-               [RTL8365MB_MIB_ifInMulticastPkts] = 1,
-               [RTL8365MB_MIB_ifInBroadcastPkts] = 1,
-               [RTL8365MB_MIB_dot3InPauseFrames] = 1,
-               [RTL8365MB_MIB_dot3StatsSingleCollisionFrames] = 1,
-               [RTL8365MB_MIB_dot3StatsMultipleCollisionFrames] = 1,
-               [RTL8365MB_MIB_dot3StatsFCSErrors] = 1,
-               [RTL8365MB_MIB_dot3StatsDeferredTransmissions] = 1,
-               [RTL8365MB_MIB_dot3StatsLateCollisions] = 1,
-               [RTL8365MB_MIB_dot3StatsExcessiveCollisions] = 1,
-
-       };
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8365mb *mb;
-       int ret;
-       int i;
-
-       mb = smi->chip_data;
-
-       mutex_lock(&mb->mib_lock);
-       for (i = 0; i < RTL8365MB_MIB_END; i++) {
-               struct rtl8365mb_mib_counter *mib = &rtl8365mb_mib_counters[i];
-
-               /* Only fetch required MIB counters (marked = 1 above) */
-               if (!cnt[i])
-                       continue;
-
-               ret = rtl8365mb_mib_counter_read(smi, port, mib->offset,
-                                                mib->length, &cnt[i]);
-               if (ret)
-                       break;
-       }
-       mutex_unlock(&mb->mib_lock);
-
-       /* The RTL8365MB-VC exposes MIB objects, which we have to translate into
-        * IEEE 802.3 Managed Objects. This is not always completely faithful,
-        * but we try out best. See RFC 3635 for a detailed treatment of the
-        * subject.
-        */
-
-       mac_stats->FramesTransmittedOK = cnt[RTL8365MB_MIB_ifOutUcastPkts] +
-                                        cnt[RTL8365MB_MIB_ifOutMulticastPkts] +
-                                        cnt[RTL8365MB_MIB_ifOutBroadcastPkts] +
-                                        cnt[RTL8365MB_MIB_dot3OutPauseFrames] -
-                                        cnt[RTL8365MB_MIB_ifOutDiscards];
-       mac_stats->SingleCollisionFrames =
-               cnt[RTL8365MB_MIB_dot3StatsSingleCollisionFrames];
-       mac_stats->MultipleCollisionFrames =
-               cnt[RTL8365MB_MIB_dot3StatsMultipleCollisionFrames];
-       mac_stats->FramesReceivedOK = cnt[RTL8365MB_MIB_ifInUcastPkts] +
-                                     cnt[RTL8365MB_MIB_ifInMulticastPkts] +
-                                     cnt[RTL8365MB_MIB_ifInBroadcastPkts] +
-                                     cnt[RTL8365MB_MIB_dot3InPauseFrames];
-       mac_stats->FrameCheckSequenceErrors =
-               cnt[RTL8365MB_MIB_dot3StatsFCSErrors];
-       mac_stats->OctetsTransmittedOK = cnt[RTL8365MB_MIB_ifOutOctets] -
-                                        18 * mac_stats->FramesTransmittedOK;
-       mac_stats->FramesWithDeferredXmissions =
-               cnt[RTL8365MB_MIB_dot3StatsDeferredTransmissions];
-       mac_stats->LateCollisions = cnt[RTL8365MB_MIB_dot3StatsLateCollisions];
-       mac_stats->FramesAbortedDueToXSColls =
-               cnt[RTL8365MB_MIB_dot3StatsExcessiveCollisions];
-       mac_stats->OctetsReceivedOK = cnt[RTL8365MB_MIB_ifInOctets] -
-                                     18 * mac_stats->FramesReceivedOK;
-       mac_stats->MulticastFramesXmittedOK =
-               cnt[RTL8365MB_MIB_ifOutMulticastPkts];
-       mac_stats->BroadcastFramesXmittedOK =
-               cnt[RTL8365MB_MIB_ifOutBroadcastPkts];
-       mac_stats->MulticastFramesReceivedOK =
-               cnt[RTL8365MB_MIB_ifInMulticastPkts];
-       mac_stats->BroadcastFramesReceivedOK =
-               cnt[RTL8365MB_MIB_ifInBroadcastPkts];
-}
-
-static void rtl8365mb_get_ctrl_stats(struct dsa_switch *ds, int port,
-                                    struct ethtool_eth_ctrl_stats *ctrl_stats)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8365mb_mib_counter *mib;
-       struct rtl8365mb *mb;
-
-       mb = smi->chip_data;
-       mib = &rtl8365mb_mib_counters[RTL8365MB_MIB_dot3ControlInUnknownOpcodes];
-
-       mutex_lock(&mb->mib_lock);
-       rtl8365mb_mib_counter_read(smi, port, mib->offset, mib->length,
-                                  &ctrl_stats->UnsupportedOpcodesReceived);
-       mutex_unlock(&mb->mib_lock);
-}
-
-static void rtl8365mb_stats_update(struct realtek_smi *smi, int port)
-{
-       u64 cnt[RTL8365MB_MIB_END] = {
-               [RTL8365MB_MIB_ifOutOctets] = 1,
-               [RTL8365MB_MIB_ifOutUcastPkts] = 1,
-               [RTL8365MB_MIB_ifOutMulticastPkts] = 1,
-               [RTL8365MB_MIB_ifOutBroadcastPkts] = 1,
-               [RTL8365MB_MIB_ifOutDiscards] = 1,
-               [RTL8365MB_MIB_ifInOctets] = 1,
-               [RTL8365MB_MIB_ifInUcastPkts] = 1,
-               [RTL8365MB_MIB_ifInMulticastPkts] = 1,
-               [RTL8365MB_MIB_ifInBroadcastPkts] = 1,
-               [RTL8365MB_MIB_etherStatsDropEvents] = 1,
-               [RTL8365MB_MIB_etherStatsCollisions] = 1,
-               [RTL8365MB_MIB_etherStatsFragments] = 1,
-               [RTL8365MB_MIB_etherStatsJabbers] = 1,
-               [RTL8365MB_MIB_dot3StatsFCSErrors] = 1,
-               [RTL8365MB_MIB_dot3StatsLateCollisions] = 1,
-       };
-       struct rtl8365mb *mb = smi->chip_data;
-       struct rtnl_link_stats64 *stats;
-       int ret;
-       int i;
-
-       stats = &mb->ports[port].stats;
-
-       mutex_lock(&mb->mib_lock);
-       for (i = 0; i < RTL8365MB_MIB_END; i++) {
-               struct rtl8365mb_mib_counter *c = &rtl8365mb_mib_counters[i];
-
-               /* Only fetch required MIB counters (marked = 1 above) */
-               if (!cnt[i])
-                       continue;
-
-               ret = rtl8365mb_mib_counter_read(smi, port, c->offset,
-                                                c->length, &cnt[i]);
-               if (ret)
-                       break;
-       }
-       mutex_unlock(&mb->mib_lock);
-
-       /* Don't update statistics if there was an error reading the counters */
-       if (ret)
-               return;
-
-       spin_lock(&mb->ports[port].stats_lock);
-
-       stats->rx_packets = cnt[RTL8365MB_MIB_ifInUcastPkts] +
-                           cnt[RTL8365MB_MIB_ifInMulticastPkts] +
-                           cnt[RTL8365MB_MIB_ifInBroadcastPkts] -
-                           cnt[RTL8365MB_MIB_ifOutDiscards];
-
-       stats->tx_packets = cnt[RTL8365MB_MIB_ifOutUcastPkts] +
-                           cnt[RTL8365MB_MIB_ifOutMulticastPkts] +
-                           cnt[RTL8365MB_MIB_ifOutBroadcastPkts];
-
-       /* if{In,Out}Octets includes FCS - remove it */
-       stats->rx_bytes = cnt[RTL8365MB_MIB_ifInOctets] - 4 * stats->rx_packets;
-       stats->tx_bytes =
-               cnt[RTL8365MB_MIB_ifOutOctets] - 4 * stats->tx_packets;
-
-       stats->rx_dropped = cnt[RTL8365MB_MIB_etherStatsDropEvents];
-       stats->tx_dropped = cnt[RTL8365MB_MIB_ifOutDiscards];
-
-       stats->multicast = cnt[RTL8365MB_MIB_ifInMulticastPkts];
-       stats->collisions = cnt[RTL8365MB_MIB_etherStatsCollisions];
-
-       stats->rx_length_errors = cnt[RTL8365MB_MIB_etherStatsFragments] +
-                                 cnt[RTL8365MB_MIB_etherStatsJabbers];
-       stats->rx_crc_errors = cnt[RTL8365MB_MIB_dot3StatsFCSErrors];
-       stats->rx_errors = stats->rx_length_errors + stats->rx_crc_errors;
-
-       stats->tx_aborted_errors = cnt[RTL8365MB_MIB_ifOutDiscards];
-       stats->tx_window_errors = cnt[RTL8365MB_MIB_dot3StatsLateCollisions];
-       stats->tx_errors = stats->tx_aborted_errors + stats->tx_window_errors;
-
-       spin_unlock(&mb->ports[port].stats_lock);
-}
-
-static void rtl8365mb_stats_poll(struct work_struct *work)
-{
-       struct rtl8365mb_port *p = container_of(to_delayed_work(work),
-                                               struct rtl8365mb_port,
-                                               mib_work);
-       struct realtek_smi *smi = p->smi;
-
-       rtl8365mb_stats_update(smi, p->index);
-
-       schedule_delayed_work(&p->mib_work, RTL8365MB_STATS_INTERVAL_JIFFIES);
-}
-
-static void rtl8365mb_get_stats64(struct dsa_switch *ds, int port,
-                                 struct rtnl_link_stats64 *s)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8365mb_port *p;
-       struct rtl8365mb *mb;
-
-       mb = smi->chip_data;
-       p = &mb->ports[port];
-
-       spin_lock(&p->stats_lock);
-       memcpy(s, &p->stats, sizeof(*s));
-       spin_unlock(&p->stats_lock);
-}
-
-static void rtl8365mb_stats_setup(struct realtek_smi *smi)
-{
-       struct rtl8365mb *mb = smi->chip_data;
-       int i;
-
-       /* Per-chip global mutex to protect MIB counter access, since doing
-        * so requires accessing a series of registers in a particular order.
-        */
-       mutex_init(&mb->mib_lock);
-
-       for (i = 0; i < smi->num_ports; i++) {
-               struct rtl8365mb_port *p = &mb->ports[i];
-
-               if (dsa_is_unused_port(smi->ds, i))
-                       continue;
-
-               /* Per-port spinlock to protect the stats64 data */
-               spin_lock_init(&p->stats_lock);
-
-               /* This work polls the MIB counters and keeps the stats64 data
-                * up-to-date.
-                */
-               INIT_DELAYED_WORK(&p->mib_work, rtl8365mb_stats_poll);
-       }
-}
-
-static void rtl8365mb_stats_teardown(struct realtek_smi *smi)
-{
-       struct rtl8365mb *mb = smi->chip_data;
-       int i;
-
-       for (i = 0; i < smi->num_ports; i++) {
-               struct rtl8365mb_port *p = &mb->ports[i];
-
-               if (dsa_is_unused_port(smi->ds, i))
-                       continue;
-
-               cancel_delayed_work_sync(&p->mib_work);
-       }
-}
-
-static int rtl8365mb_get_and_clear_status_reg(struct realtek_smi *smi, u32 reg,
-                                             u32 *val)
-{
-       int ret;
-
-       ret = regmap_read(smi->map, reg, val);
-       if (ret)
-               return ret;
-
-       return regmap_write(smi->map, reg, *val);
-}
-
-static irqreturn_t rtl8365mb_irq(int irq, void *data)
-{
-       struct realtek_smi *smi = data;
-       unsigned long line_changes = 0;
-       struct rtl8365mb *mb;
-       u32 stat;
-       int line;
-       int ret;
-
-       mb = smi->chip_data;
-
-       ret = rtl8365mb_get_and_clear_status_reg(smi, RTL8365MB_INTR_STATUS_REG,
-                                                &stat);
-       if (ret)
-               goto out_error;
-
-       if (stat & RTL8365MB_INTR_LINK_CHANGE_MASK) {
-               u32 linkdown_ind;
-               u32 linkup_ind;
-               u32 val;
-
-               ret = rtl8365mb_get_and_clear_status_reg(
-                       smi, RTL8365MB_PORT_LINKUP_IND_REG, &val);
-               if (ret)
-                       goto out_error;
-
-               linkup_ind = FIELD_GET(RTL8365MB_PORT_LINKUP_IND_MASK, val);
-
-               ret = rtl8365mb_get_and_clear_status_reg(
-                       smi, RTL8365MB_PORT_LINKDOWN_IND_REG, &val);
-               if (ret)
-                       goto out_error;
-
-               linkdown_ind = FIELD_GET(RTL8365MB_PORT_LINKDOWN_IND_MASK, val);
-
-               line_changes = (linkup_ind | linkdown_ind) & mb->port_mask;
-       }
-
-       if (!line_changes)
-               goto out_none;
-
-       for_each_set_bit(line, &line_changes, smi->num_ports) {
-               int child_irq = irq_find_mapping(smi->irqdomain, line);
-
-               handle_nested_irq(child_irq);
-       }
-
-       return IRQ_HANDLED;
-
-out_error:
-       dev_err(smi->dev, "failed to read interrupt status: %d\n", ret);
-
-out_none:
-       return IRQ_NONE;
-}
-
-static struct irq_chip rtl8365mb_irq_chip = {
-       .name = "rtl8365mb",
-       /* The hardware doesn't support masking IRQs on a per-port basis */
-};
-
-static int rtl8365mb_irq_map(struct irq_domain *domain, unsigned int irq,
-                            irq_hw_number_t hwirq)
-{
-       irq_set_chip_data(irq, domain->host_data);
-       irq_set_chip_and_handler(irq, &rtl8365mb_irq_chip, handle_simple_irq);
-       irq_set_nested_thread(irq, 1);
-       irq_set_noprobe(irq);
-
-       return 0;
-}
-
-static void rtl8365mb_irq_unmap(struct irq_domain *d, unsigned int irq)
-{
-       irq_set_nested_thread(irq, 0);
-       irq_set_chip_and_handler(irq, NULL, NULL);
-       irq_set_chip_data(irq, NULL);
-}
-
-static const struct irq_domain_ops rtl8365mb_irqdomain_ops = {
-       .map = rtl8365mb_irq_map,
-       .unmap = rtl8365mb_irq_unmap,
-       .xlate = irq_domain_xlate_onecell,
-};
-
-static int rtl8365mb_set_irq_enable(struct realtek_smi *smi, bool enable)
-{
-       return regmap_update_bits(smi->map, RTL8365MB_INTR_CTRL_REG,
-                                 RTL8365MB_INTR_LINK_CHANGE_MASK,
-                                 FIELD_PREP(RTL8365MB_INTR_LINK_CHANGE_MASK,
-                                            enable ? 1 : 0));
-}
-
-static int rtl8365mb_irq_enable(struct realtek_smi *smi)
-{
-       return rtl8365mb_set_irq_enable(smi, true);
-}
-
-static int rtl8365mb_irq_disable(struct realtek_smi *smi)
-{
-       return rtl8365mb_set_irq_enable(smi, false);
-}
-
-static int rtl8365mb_irq_setup(struct realtek_smi *smi)
-{
-       struct rtl8365mb *mb = smi->chip_data;
-       struct device_node *intc;
-       u32 irq_trig;
-       int virq;
-       int irq;
-       u32 val;
-       int ret;
-       int i;
-
-       intc = of_get_child_by_name(smi->dev->of_node, "interrupt-controller");
-       if (!intc) {
-               dev_err(smi->dev, "missing child interrupt-controller node\n");
-               return -EINVAL;
-       }
-
-       /* rtl8365mb IRQs cascade off this one */
-       irq = of_irq_get(intc, 0);
-       if (irq <= 0) {
-               if (irq != -EPROBE_DEFER)
-                       dev_err(smi->dev, "failed to get parent irq: %d\n",
-                               irq);
-               ret = irq ? irq : -EINVAL;
-               goto out_put_node;
-       }
-
-       smi->irqdomain = irq_domain_add_linear(intc, smi->num_ports,
-                                              &rtl8365mb_irqdomain_ops, smi);
-       if (!smi->irqdomain) {
-               dev_err(smi->dev, "failed to add irq domain\n");
-               ret = -ENOMEM;
-               goto out_put_node;
-       }
-
-       for (i = 0; i < smi->num_ports; i++) {
-               virq = irq_create_mapping(smi->irqdomain, i);
-               if (!virq) {
-                       dev_err(smi->dev,
-                               "failed to create irq domain mapping\n");
-                       ret = -EINVAL;
-                       goto out_remove_irqdomain;
-               }
-
-               irq_set_parent(virq, irq);
-       }
-
-       /* Configure chip interrupt signal polarity */
-       irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
-       switch (irq_trig) {
-       case IRQF_TRIGGER_RISING:
-       case IRQF_TRIGGER_HIGH:
-               val = RTL8365MB_INTR_POLARITY_HIGH;
-               break;
-       case IRQF_TRIGGER_FALLING:
-       case IRQF_TRIGGER_LOW:
-               val = RTL8365MB_INTR_POLARITY_LOW;
-               break;
-       default:
-               dev_err(smi->dev, "unsupported irq trigger type %u\n",
-                       irq_trig);
-               ret = -EINVAL;
-               goto out_remove_irqdomain;
-       }
-
-       ret = regmap_update_bits(smi->map, RTL8365MB_INTR_POLARITY_REG,
-                                RTL8365MB_INTR_POLARITY_MASK,
-                                FIELD_PREP(RTL8365MB_INTR_POLARITY_MASK, val));
-       if (ret)
-               goto out_remove_irqdomain;
-
-       /* Disable the interrupt in case the chip has it enabled on reset */
-       ret = rtl8365mb_irq_disable(smi);
-       if (ret)
-               goto out_remove_irqdomain;
-
-       /* Clear the interrupt status register */
-       ret = regmap_write(smi->map, RTL8365MB_INTR_STATUS_REG,
-                          RTL8365MB_INTR_ALL_MASK);
-       if (ret)
-               goto out_remove_irqdomain;
-
-       ret = request_threaded_irq(irq, NULL, rtl8365mb_irq, IRQF_ONESHOT,
-                                  "rtl8365mb", smi);
-       if (ret) {
-               dev_err(smi->dev, "failed to request irq: %d\n", ret);
-               goto out_remove_irqdomain;
-       }
-
-       /* Store the irq so that we know to free it during teardown */
-       mb->irq = irq;
-
-       ret = rtl8365mb_irq_enable(smi);
-       if (ret)
-               goto out_free_irq;
-
-       of_node_put(intc);
-
-       return 0;
-
-out_free_irq:
-       free_irq(mb->irq, smi);
-       mb->irq = 0;
-
-out_remove_irqdomain:
-       for (i = 0; i < smi->num_ports; i++) {
-               virq = irq_find_mapping(smi->irqdomain, i);
-               irq_dispose_mapping(virq);
-       }
-
-       irq_domain_remove(smi->irqdomain);
-       smi->irqdomain = NULL;
-
-out_put_node:
-       of_node_put(intc);
-
-       return ret;
-}
-
-static void rtl8365mb_irq_teardown(struct realtek_smi *smi)
-{
-       struct rtl8365mb *mb = smi->chip_data;
-       int virq;
-       int i;
-
-       if (mb->irq) {
-               free_irq(mb->irq, smi);
-               mb->irq = 0;
-       }
-
-       if (smi->irqdomain) {
-               for (i = 0; i < smi->num_ports; i++) {
-                       virq = irq_find_mapping(smi->irqdomain, i);
-                       irq_dispose_mapping(virq);
-               }
-
-               irq_domain_remove(smi->irqdomain);
-               smi->irqdomain = NULL;
-       }
-}
-
-static int rtl8365mb_cpu_config(struct realtek_smi *smi)
-{
-       struct rtl8365mb *mb = smi->chip_data;
-       struct rtl8365mb_cpu *cpu = &mb->cpu;
-       u32 val;
-       int ret;
-
-       ret = regmap_update_bits(smi->map, RTL8365MB_CPU_PORT_MASK_REG,
-                                RTL8365MB_CPU_PORT_MASK_MASK,
-                                FIELD_PREP(RTL8365MB_CPU_PORT_MASK_MASK,
-                                           cpu->mask));
-       if (ret)
-               return ret;
-
-       val = FIELD_PREP(RTL8365MB_CPU_CTRL_EN_MASK, cpu->enable ? 1 : 0) |
-             FIELD_PREP(RTL8365MB_CPU_CTRL_INSERTMODE_MASK, cpu->insert) |
-             FIELD_PREP(RTL8365MB_CPU_CTRL_TAG_POSITION_MASK, cpu->position) |
-             FIELD_PREP(RTL8365MB_CPU_CTRL_RXBYTECOUNT_MASK, cpu->rx_length) |
-             FIELD_PREP(RTL8365MB_CPU_CTRL_TAG_FORMAT_MASK, cpu->format) |
-             FIELD_PREP(RTL8365MB_CPU_CTRL_TRAP_PORT_MASK, cpu->trap_port) |
-             FIELD_PREP(RTL8365MB_CPU_CTRL_TRAP_PORT_EXT_MASK,
-                        cpu->trap_port >> 3);
-       ret = regmap_write(smi->map, RTL8365MB_CPU_CTRL_REG, val);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-static int rtl8365mb_switch_init(struct realtek_smi *smi)
-{
-       struct rtl8365mb *mb = smi->chip_data;
-       int ret;
-       int i;
-
-       /* Do any chip-specific init jam before getting to the common stuff */
-       if (mb->jam_table) {
-               for (i = 0; i < mb->jam_size; i++) {
-                       ret = regmap_write(smi->map, mb->jam_table[i].reg,
-                                          mb->jam_table[i].val);
-                       if (ret)
-                               return ret;
-               }
-       }
-
-       /* Common init jam */
-       for (i = 0; i < ARRAY_SIZE(rtl8365mb_init_jam_common); i++) {
-               ret = regmap_write(smi->map, rtl8365mb_init_jam_common[i].reg,
-                                  rtl8365mb_init_jam_common[i].val);
-               if (ret)
-                       return ret;
-       }
-
-       return 0;
-}
-
-static int rtl8365mb_reset_chip(struct realtek_smi *smi)
-{
-       u32 val;
-
-       realtek_smi_write_reg_noack(smi, RTL8365MB_CHIP_RESET_REG,
-                                   FIELD_PREP(RTL8365MB_CHIP_RESET_HW_MASK,
-                                              1));
-
-       /* Realtek documentation says the chip needs 1 second to reset. Sleep
-        * for 100 ms before accessing any registers to prevent ACK timeouts.
-        */
-       msleep(100);
-       return regmap_read_poll_timeout(smi->map, RTL8365MB_CHIP_RESET_REG, val,
-                                       !(val & RTL8365MB_CHIP_RESET_HW_MASK),
-                                       20000, 1e6);
-}
-
-static int rtl8365mb_setup(struct dsa_switch *ds)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8365mb *mb;
-       int ret;
-       int i;
-
-       mb = smi->chip_data;
-
-       ret = rtl8365mb_reset_chip(smi);
-       if (ret) {
-               dev_err(smi->dev, "failed to reset chip: %d\n", ret);
-               goto out_error;
-       }
-
-       /* Configure switch to vendor-defined initial state */
-       ret = rtl8365mb_switch_init(smi);
-       if (ret) {
-               dev_err(smi->dev, "failed to initialize switch: %d\n", ret);
-               goto out_error;
-       }
-
-       /* Set up cascading IRQs */
-       ret = rtl8365mb_irq_setup(smi);
-       if (ret == -EPROBE_DEFER)
-               return ret;
-       else if (ret)
-               dev_info(smi->dev, "no interrupt support\n");
-
-       /* Configure CPU tagging */
-       ret = rtl8365mb_cpu_config(smi);
-       if (ret)
-               goto out_teardown_irq;
-
-       /* Configure ports */
-       for (i = 0; i < smi->num_ports; i++) {
-               struct rtl8365mb_port *p = &mb->ports[i];
-
-               if (dsa_is_unused_port(smi->ds, i))
-                       continue;
-
-               /* Set up per-port private data */
-               p->smi = smi;
-               p->index = i;
-
-               /* Forward only to the CPU */
-               ret = rtl8365mb_port_set_isolation(smi, i, BIT(smi->cpu_port));
-               if (ret)
-                       goto out_teardown_irq;
-
-               /* Disable learning */
-               ret = rtl8365mb_port_set_learning(smi, i, false);
-               if (ret)
-                       goto out_teardown_irq;
-
-               /* Set the initial STP state of all ports to DISABLED, otherwise
-                * ports will still forward frames to the CPU despite being
-                * administratively down by default.
-                */
-               rtl8365mb_port_stp_state_set(smi->ds, i, BR_STATE_DISABLED);
-       }
-
-       /* Set maximum packet length to 1536 bytes */
-       ret = regmap_update_bits(smi->map, RTL8365MB_CFG0_MAX_LEN_REG,
-                                RTL8365MB_CFG0_MAX_LEN_MASK,
-                                FIELD_PREP(RTL8365MB_CFG0_MAX_LEN_MASK, 1536));
-       if (ret)
-               goto out_teardown_irq;
-
-       ret = realtek_smi_setup_mdio(smi);
-       if (ret) {
-               dev_err(smi->dev, "could not set up MDIO bus\n");
-               goto out_teardown_irq;
-       }
-
-       /* Start statistics counter polling */
-       rtl8365mb_stats_setup(smi);
-
-       return 0;
-
-out_teardown_irq:
-       rtl8365mb_irq_teardown(smi);
-
-out_error:
-       return ret;
-}
-
-static void rtl8365mb_teardown(struct dsa_switch *ds)
-{
-       struct realtek_smi *smi = ds->priv;
-
-       rtl8365mb_stats_teardown(smi);
-       rtl8365mb_irq_teardown(smi);
-}
-
-static int rtl8365mb_get_chip_id_and_ver(struct regmap *map, u32 *id, u32 *ver)
-{
-       int ret;
-
-       /* For some reason we have to write a magic value to an arbitrary
-        * register whenever accessing the chip ID/version registers.
-        */
-       ret = regmap_write(map, RTL8365MB_MAGIC_REG, RTL8365MB_MAGIC_VALUE);
-       if (ret)
-               return ret;
-
-       ret = regmap_read(map, RTL8365MB_CHIP_ID_REG, id);
-       if (ret)
-               return ret;
-
-       ret = regmap_read(map, RTL8365MB_CHIP_VER_REG, ver);
-       if (ret)
-               return ret;
-
-       /* Reset magic register */
-       ret = regmap_write(map, RTL8365MB_MAGIC_REG, 0);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-static int rtl8365mb_detect(struct realtek_smi *smi)
-{
-       struct rtl8365mb *mb = smi->chip_data;
-       u32 chip_id;
-       u32 chip_ver;
-       int ret;
-
-       ret = rtl8365mb_get_chip_id_and_ver(smi->map, &chip_id, &chip_ver);
-       if (ret) {
-               dev_err(smi->dev, "failed to read chip id and version: %d\n",
-                       ret);
-               return ret;
-       }
-
-       switch (chip_id) {
-       case RTL8365MB_CHIP_ID_8365MB_VC:
-               dev_info(smi->dev,
-                        "found an RTL8365MB-VC switch (ver=0x%04x)\n",
-                        chip_ver);
-
-               smi->cpu_port = RTL8365MB_CPU_PORT_NUM_8365MB_VC;
-               smi->num_ports = smi->cpu_port + 1;
-
-               mb->smi = smi;
-               mb->chip_id = chip_id;
-               mb->chip_ver = chip_ver;
-               mb->port_mask = BIT(smi->num_ports) - 1;
-               mb->learn_limit_max = RTL8365MB_LEARN_LIMIT_MAX_8365MB_VC;
-               mb->jam_table = rtl8365mb_init_jam_8365mb_vc;
-               mb->jam_size = ARRAY_SIZE(rtl8365mb_init_jam_8365mb_vc);
-
-               mb->cpu.enable = 1;
-               mb->cpu.mask = BIT(smi->cpu_port);
-               mb->cpu.trap_port = smi->cpu_port;
-               mb->cpu.insert = RTL8365MB_CPU_INSERT_TO_ALL;
-               mb->cpu.position = RTL8365MB_CPU_POS_AFTER_SA;
-               mb->cpu.rx_length = RTL8365MB_CPU_RXLEN_64BYTES;
-               mb->cpu.format = RTL8365MB_CPU_FORMAT_8BYTES;
-
-               break;
-       default:
-               dev_err(smi->dev,
-                       "found an unknown Realtek switch (id=0x%04x, ver=0x%04x)\n",
-                       chip_id, chip_ver);
-               return -ENODEV;
-       }
-
-       return 0;
-}
-
-static const struct dsa_switch_ops rtl8365mb_switch_ops = {
-       .get_tag_protocol = rtl8365mb_get_tag_protocol,
-       .setup = rtl8365mb_setup,
-       .teardown = rtl8365mb_teardown,
-       .phylink_validate = rtl8365mb_phylink_validate,
-       .phylink_mac_config = rtl8365mb_phylink_mac_config,
-       .phylink_mac_link_down = rtl8365mb_phylink_mac_link_down,
-       .phylink_mac_link_up = rtl8365mb_phylink_mac_link_up,
-       .port_stp_state_set = rtl8365mb_port_stp_state_set,
-       .get_strings = rtl8365mb_get_strings,
-       .get_ethtool_stats = rtl8365mb_get_ethtool_stats,
-       .get_sset_count = rtl8365mb_get_sset_count,
-       .get_eth_phy_stats = rtl8365mb_get_phy_stats,
-       .get_eth_mac_stats = rtl8365mb_get_mac_stats,
-       .get_eth_ctrl_stats = rtl8365mb_get_ctrl_stats,
-       .get_stats64 = rtl8365mb_get_stats64,
-};
-
-static const struct realtek_smi_ops rtl8365mb_smi_ops = {
-       .detect = rtl8365mb_detect,
-       .phy_read = rtl8365mb_phy_read,
-       .phy_write = rtl8365mb_phy_write,
-};
-
-const struct realtek_smi_variant rtl8365mb_variant = {
-       .ds_ops = &rtl8365mb_switch_ops,
-       .ops = &rtl8365mb_smi_ops,
-       .clk_delay = 10,
-       .cmd_read = 0xb9,
-       .cmd_write = 0xb8,
-       .chip_data_sz = sizeof(struct rtl8365mb),
-};
-EXPORT_SYMBOL_GPL(rtl8365mb_variant);
diff --git a/drivers/net/dsa/rtl8366.c b/drivers/net/dsa/rtl8366.c
deleted file mode 100644 (file)
index bdb8d8d..0000000
+++ /dev/null
@@ -1,448 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Realtek SMI library helpers for the RTL8366x variants
- * RTL8366RB and RTL8366S
- *
- * Copyright (C) 2017 Linus Walleij <linus.walleij@linaro.org>
- * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
- * Copyright (C) 2010 Antti Seppälä <a.seppala@gmail.com>
- * Copyright (C) 2010 Roman Yeryomin <roman@advem.lv>
- * Copyright (C) 2011 Colin Leitner <colin.leitner@googlemail.com>
- */
-#include <linux/if_bridge.h>
-#include <net/dsa.h>
-
-#include "realtek-smi-core.h"
-
-int rtl8366_mc_is_used(struct realtek_smi *smi, int mc_index, int *used)
-{
-       int ret;
-       int i;
-
-       *used = 0;
-       for (i = 0; i < smi->num_ports; i++) {
-               int index = 0;
-
-               ret = smi->ops->get_mc_index(smi, i, &index);
-               if (ret)
-                       return ret;
-
-               if (mc_index == index) {
-                       *used = 1;
-                       break;
-               }
-       }
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(rtl8366_mc_is_used);
-
-/**
- * rtl8366_obtain_mc() - retrieve or allocate a VLAN member configuration
- * @smi: the Realtek SMI device instance
- * @vid: the VLAN ID to look up or allocate
- * @vlanmc: the pointer will be assigned to a pointer to a valid member config
- * if successful
- * @return: index of a new member config or negative error number
- */
-static int rtl8366_obtain_mc(struct realtek_smi *smi, int vid,
-                            struct rtl8366_vlan_mc *vlanmc)
-{
-       struct rtl8366_vlan_4k vlan4k;
-       int ret;
-       int i;
-
-       /* Try to find an existing member config entry for this VID */
-       for (i = 0; i < smi->num_vlan_mc; i++) {
-               ret = smi->ops->get_vlan_mc(smi, i, vlanmc);
-               if (ret) {
-                       dev_err(smi->dev, "error searching for VLAN MC %d for VID %d\n",
-                               i, vid);
-                       return ret;
-               }
-
-               if (vid == vlanmc->vid)
-                       return i;
-       }
-
-       /* We have no MC entry for this VID, try to find an empty one */
-       for (i = 0; i < smi->num_vlan_mc; i++) {
-               ret = smi->ops->get_vlan_mc(smi, i, vlanmc);
-               if (ret) {
-                       dev_err(smi->dev, "error searching for VLAN MC %d for VID %d\n",
-                               i, vid);
-                       return ret;
-               }
-
-               if (vlanmc->vid == 0 && vlanmc->member == 0) {
-                       /* Update the entry from the 4K table */
-                       ret = smi->ops->get_vlan_4k(smi, vid, &vlan4k);
-                       if (ret) {
-                               dev_err(smi->dev, "error looking for 4K VLAN MC %d for VID %d\n",
-                                       i, vid);
-                               return ret;
-                       }
-
-                       vlanmc->vid = vid;
-                       vlanmc->member = vlan4k.member;
-                       vlanmc->untag = vlan4k.untag;
-                       vlanmc->fid = vlan4k.fid;
-                       ret = smi->ops->set_vlan_mc(smi, i, vlanmc);
-                       if (ret) {
-                               dev_err(smi->dev, "unable to set/update VLAN MC %d for VID %d\n",
-                                       i, vid);
-                               return ret;
-                       }
-
-                       dev_dbg(smi->dev, "created new MC at index %d for VID %d\n",
-                               i, vid);
-                       return i;
-               }
-       }
-
-       /* MC table is full, try to find an unused entry and replace it */
-       for (i = 0; i < smi->num_vlan_mc; i++) {
-               int used;
-
-               ret = rtl8366_mc_is_used(smi, i, &used);
-               if (ret)
-                       return ret;
-
-               if (!used) {
-                       /* Update the entry from the 4K table */
-                       ret = smi->ops->get_vlan_4k(smi, vid, &vlan4k);
-                       if (ret)
-                               return ret;
-
-                       vlanmc->vid = vid;
-                       vlanmc->member = vlan4k.member;
-                       vlanmc->untag = vlan4k.untag;
-                       vlanmc->fid = vlan4k.fid;
-                       ret = smi->ops->set_vlan_mc(smi, i, vlanmc);
-                       if (ret) {
-                               dev_err(smi->dev, "unable to set/update VLAN MC %d for VID %d\n",
-                                       i, vid);
-                               return ret;
-                       }
-                       dev_dbg(smi->dev, "recycled MC at index %i for VID %d\n",
-                               i, vid);
-                       return i;
-               }
-       }
-
-       dev_err(smi->dev, "all VLAN member configurations are in use\n");
-       return -ENOSPC;
-}
-
-int rtl8366_set_vlan(struct realtek_smi *smi, int vid, u32 member,
-                    u32 untag, u32 fid)
-{
-       struct rtl8366_vlan_mc vlanmc;
-       struct rtl8366_vlan_4k vlan4k;
-       int mc;
-       int ret;
-
-       if (!smi->ops->is_vlan_valid(smi, vid))
-               return -EINVAL;
-
-       dev_dbg(smi->dev,
-               "setting VLAN%d 4k members: 0x%02x, untagged: 0x%02x\n",
-               vid, member, untag);
-
-       /* Update the 4K table */
-       ret = smi->ops->get_vlan_4k(smi, vid, &vlan4k);
-       if (ret)
-               return ret;
-
-       vlan4k.member |= member;
-       vlan4k.untag |= untag;
-       vlan4k.fid = fid;
-       ret = smi->ops->set_vlan_4k(smi, &vlan4k);
-       if (ret)
-               return ret;
-
-       dev_dbg(smi->dev,
-               "resulting VLAN%d 4k members: 0x%02x, untagged: 0x%02x\n",
-               vid, vlan4k.member, vlan4k.untag);
-
-       /* Find or allocate a member config for this VID */
-       ret = rtl8366_obtain_mc(smi, vid, &vlanmc);
-       if (ret < 0)
-               return ret;
-       mc = ret;
-
-       /* Update the MC entry */
-       vlanmc.member |= member;
-       vlanmc.untag |= untag;
-       vlanmc.fid = fid;
-
-       /* Commit updates to the MC entry */
-       ret = smi->ops->set_vlan_mc(smi, mc, &vlanmc);
-       if (ret)
-               dev_err(smi->dev, "failed to commit changes to VLAN MC index %d for VID %d\n",
-                       mc, vid);
-       else
-               dev_dbg(smi->dev,
-                       "resulting VLAN%d MC members: 0x%02x, untagged: 0x%02x\n",
-                       vid, vlanmc.member, vlanmc.untag);
-
-       return ret;
-}
-EXPORT_SYMBOL_GPL(rtl8366_set_vlan);
-
-int rtl8366_set_pvid(struct realtek_smi *smi, unsigned int port,
-                    unsigned int vid)
-{
-       struct rtl8366_vlan_mc vlanmc;
-       int mc;
-       int ret;
-
-       if (!smi->ops->is_vlan_valid(smi, vid))
-               return -EINVAL;
-
-       /* Find or allocate a member config for this VID */
-       ret = rtl8366_obtain_mc(smi, vid, &vlanmc);
-       if (ret < 0)
-               return ret;
-       mc = ret;
-
-       ret = smi->ops->set_mc_index(smi, port, mc);
-       if (ret) {
-               dev_err(smi->dev, "set PVID: failed to set MC index %d for port %d\n",
-                       mc, port);
-               return ret;
-       }
-
-       dev_dbg(smi->dev, "set PVID: the PVID for port %d set to %d using existing MC index %d\n",
-               port, vid, mc);
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(rtl8366_set_pvid);
-
-int rtl8366_enable_vlan4k(struct realtek_smi *smi, bool enable)
-{
-       int ret;
-
-       /* To enable 4k VLAN, ordinary VLAN must be enabled first,
-        * but if we disable 4k VLAN it is fine to leave ordinary
-        * VLAN enabled.
-        */
-       if (enable) {
-               /* Make sure VLAN is ON */
-               ret = smi->ops->enable_vlan(smi, true);
-               if (ret)
-                       return ret;
-
-               smi->vlan_enabled = true;
-       }
-
-       ret = smi->ops->enable_vlan4k(smi, enable);
-       if (ret)
-               return ret;
-
-       smi->vlan4k_enabled = enable;
-       return 0;
-}
-EXPORT_SYMBOL_GPL(rtl8366_enable_vlan4k);
-
-int rtl8366_enable_vlan(struct realtek_smi *smi, bool enable)
-{
-       int ret;
-
-       ret = smi->ops->enable_vlan(smi, enable);
-       if (ret)
-               return ret;
-
-       smi->vlan_enabled = enable;
-
-       /* If we turn VLAN off, make sure that we turn off
-        * 4k VLAN as well, if that happened to be on.
-        */
-       if (!enable) {
-               smi->vlan4k_enabled = false;
-               ret = smi->ops->enable_vlan4k(smi, false);
-       }
-
-       return ret;
-}
-EXPORT_SYMBOL_GPL(rtl8366_enable_vlan);
-
-int rtl8366_reset_vlan(struct realtek_smi *smi)
-{
-       struct rtl8366_vlan_mc vlanmc;
-       int ret;
-       int i;
-
-       rtl8366_enable_vlan(smi, false);
-       rtl8366_enable_vlan4k(smi, false);
-
-       /* Clear the 16 VLAN member configurations */
-       vlanmc.vid = 0;
-       vlanmc.priority = 0;
-       vlanmc.member = 0;
-       vlanmc.untag = 0;
-       vlanmc.fid = 0;
-       for (i = 0; i < smi->num_vlan_mc; i++) {
-               ret = smi->ops->set_vlan_mc(smi, i, &vlanmc);
-               if (ret)
-                       return ret;
-       }
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(rtl8366_reset_vlan);
-
-int rtl8366_vlan_add(struct dsa_switch *ds, int port,
-                    const struct switchdev_obj_port_vlan *vlan,
-                    struct netlink_ext_ack *extack)
-{
-       bool untagged = !!(vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED);
-       bool pvid = !!(vlan->flags & BRIDGE_VLAN_INFO_PVID);
-       struct realtek_smi *smi = ds->priv;
-       u32 member = 0;
-       u32 untag = 0;
-       int ret;
-
-       if (!smi->ops->is_vlan_valid(smi, vlan->vid)) {
-               NL_SET_ERR_MSG_MOD(extack, "VLAN ID not valid");
-               return -EINVAL;
-       }
-
-       /* Enable VLAN in the hardware
-        * FIXME: what's with this 4k business?
-        * Just rtl8366_enable_vlan() seems inconclusive.
-        */
-       ret = rtl8366_enable_vlan4k(smi, true);
-       if (ret) {
-               NL_SET_ERR_MSG_MOD(extack, "Failed to enable VLAN 4K");
-               return ret;
-       }
-
-       dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",
-               vlan->vid, port, untagged ? "untagged" : "tagged",
-               pvid ? "PVID" : "no PVID");
-
-       member |= BIT(port);
-
-       if (untagged)
-               untag |= BIT(port);
-
-       ret = rtl8366_set_vlan(smi, vlan->vid, member, untag, 0);
-       if (ret) {
-               dev_err(smi->dev, "failed to set up VLAN %04x", vlan->vid);
-               return ret;
-       }
-
-       if (!pvid)
-               return 0;
-
-       ret = rtl8366_set_pvid(smi, port, vlan->vid);
-       if (ret) {
-               dev_err(smi->dev, "failed to set PVID on port %d to VLAN %04x",
-                       port, vlan->vid);
-               return ret;
-       }
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(rtl8366_vlan_add);
-
-int rtl8366_vlan_del(struct dsa_switch *ds, int port,
-                    const struct switchdev_obj_port_vlan *vlan)
-{
-       struct realtek_smi *smi = ds->priv;
-       int ret, i;
-
-       dev_dbg(smi->dev, "del VLAN %d on port %d\n", vlan->vid, port);
-
-       for (i = 0; i < smi->num_vlan_mc; i++) {
-               struct rtl8366_vlan_mc vlanmc;
-
-               ret = smi->ops->get_vlan_mc(smi, i, &vlanmc);
-               if (ret)
-                       return ret;
-
-               if (vlan->vid == vlanmc.vid) {
-                       /* Remove this port from the VLAN */
-                       vlanmc.member &= ~BIT(port);
-                       vlanmc.untag &= ~BIT(port);
-                       /*
-                        * If no ports are members of this VLAN
-                        * anymore then clear the whole member
-                        * config so it can be reused.
-                        */
-                       if (!vlanmc.member) {
-                               vlanmc.vid = 0;
-                               vlanmc.priority = 0;
-                               vlanmc.fid = 0;
-                       }
-                       ret = smi->ops->set_vlan_mc(smi, i, &vlanmc);
-                       if (ret) {
-                               dev_err(smi->dev,
-                                       "failed to remove VLAN %04x\n",
-                                       vlan->vid);
-                               return ret;
-                       }
-                       break;
-               }
-       }
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(rtl8366_vlan_del);
-
-void rtl8366_get_strings(struct dsa_switch *ds, int port, u32 stringset,
-                        uint8_t *data)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8366_mib_counter *mib;
-       int i;
-
-       if (port >= smi->num_ports)
-               return;
-
-       for (i = 0; i < smi->num_mib_counters; i++) {
-               mib = &smi->mib_counters[i];
-               strncpy(data + i * ETH_GSTRING_LEN,
-                       mib->name, ETH_GSTRING_LEN);
-       }
-}
-EXPORT_SYMBOL_GPL(rtl8366_get_strings);
-
-int rtl8366_get_sset_count(struct dsa_switch *ds, int port, int sset)
-{
-       struct realtek_smi *smi = ds->priv;
-
-       /* We only support SS_STATS */
-       if (sset != ETH_SS_STATS)
-               return 0;
-       if (port >= smi->num_ports)
-               return -EINVAL;
-
-       return smi->num_mib_counters;
-}
-EXPORT_SYMBOL_GPL(rtl8366_get_sset_count);
-
-void rtl8366_get_ethtool_stats(struct dsa_switch *ds, int port, uint64_t *data)
-{
-       struct realtek_smi *smi = ds->priv;
-       int i;
-       int ret;
-
-       if (port >= smi->num_ports)
-               return;
-
-       for (i = 0; i < smi->num_mib_counters; i++) {
-               struct rtl8366_mib_counter *mib;
-               u64 mibvalue = 0;
-
-               mib = &smi->mib_counters[i];
-               ret = smi->ops->get_mib_counter(smi, port, mib, &mibvalue);
-               if (ret) {
-                       dev_err(smi->dev, "error reading MIB counter %s\n",
-                               mib->name);
-               }
-               data[i] = mibvalue;
-       }
-}
-EXPORT_SYMBOL_GPL(rtl8366_get_ethtool_stats);
diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c
deleted file mode 100644 (file)
index 4f8c06d..0000000
+++ /dev/null
@@ -1,1816 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Realtek SMI subdriver for the Realtek RTL8366RB ethernet switch
- *
- * This is a sparsely documented chip, the only viable documentation seems
- * to be a patched up code drop from the vendor that appear in various
- * GPL source trees.
- *
- * Copyright (C) 2017 Linus Walleij <linus.walleij@linaro.org>
- * Copyright (C) 2009-2010 Gabor Juhos <juhosg@openwrt.org>
- * Copyright (C) 2010 Antti Seppälä <a.seppala@gmail.com>
- * Copyright (C) 2010 Roman Yeryomin <roman@advem.lv>
- * Copyright (C) 2011 Colin Leitner <colin.leitner@googlemail.com>
- */
-
-#include <linux/bitops.h>
-#include <linux/etherdevice.h>
-#include <linux/if_bridge.h>
-#include <linux/interrupt.h>
-#include <linux/irqdomain.h>
-#include <linux/irqchip/chained_irq.h>
-#include <linux/of_irq.h>
-#include <linux/regmap.h>
-
-#include "realtek-smi-core.h"
-
-#define RTL8366RB_PORT_NUM_CPU         5
-#define RTL8366RB_NUM_PORTS            6
-#define RTL8366RB_PHY_NO_MAX           4
-#define RTL8366RB_PHY_ADDR_MAX         31
-
-/* Switch Global Configuration register */
-#define RTL8366RB_SGCR                         0x0000
-#define RTL8366RB_SGCR_EN_BC_STORM_CTRL                BIT(0)
-#define RTL8366RB_SGCR_MAX_LENGTH(a)           ((a) << 4)
-#define RTL8366RB_SGCR_MAX_LENGTH_MASK         RTL8366RB_SGCR_MAX_LENGTH(0x3)
-#define RTL8366RB_SGCR_MAX_LENGTH_1522         RTL8366RB_SGCR_MAX_LENGTH(0x0)
-#define RTL8366RB_SGCR_MAX_LENGTH_1536         RTL8366RB_SGCR_MAX_LENGTH(0x1)
-#define RTL8366RB_SGCR_MAX_LENGTH_1552         RTL8366RB_SGCR_MAX_LENGTH(0x2)
-#define RTL8366RB_SGCR_MAX_LENGTH_16000                RTL8366RB_SGCR_MAX_LENGTH(0x3)
-#define RTL8366RB_SGCR_EN_VLAN                 BIT(13)
-#define RTL8366RB_SGCR_EN_VLAN_4KTB            BIT(14)
-
-/* Port Enable Control register */
-#define RTL8366RB_PECR                         0x0001
-
-/* Switch per-port learning disablement register */
-#define RTL8366RB_PORT_LEARNDIS_CTRL           0x0002
-
-/* Security control, actually aging register */
-#define RTL8366RB_SECURITY_CTRL                        0x0003
-
-#define RTL8366RB_SSCR2                                0x0004
-#define RTL8366RB_SSCR2_DROP_UNKNOWN_DA                BIT(0)
-
-/* Port Mode Control registers */
-#define RTL8366RB_PMC0                         0x0005
-#define RTL8366RB_PMC0_SPI                     BIT(0)
-#define RTL8366RB_PMC0_EN_AUTOLOAD             BIT(1)
-#define RTL8366RB_PMC0_PROBE                   BIT(2)
-#define RTL8366RB_PMC0_DIS_BISR                        BIT(3)
-#define RTL8366RB_PMC0_ADCTEST                 BIT(4)
-#define RTL8366RB_PMC0_SRAM_DIAG               BIT(5)
-#define RTL8366RB_PMC0_EN_SCAN                 BIT(6)
-#define RTL8366RB_PMC0_P4_IOMODE_SHIFT         7
-#define RTL8366RB_PMC0_P4_IOMODE_MASK          GENMASK(9, 7)
-#define RTL8366RB_PMC0_P5_IOMODE_SHIFT         10
-#define RTL8366RB_PMC0_P5_IOMODE_MASK          GENMASK(12, 10)
-#define RTL8366RB_PMC0_SDSMODE_SHIFT           13
-#define RTL8366RB_PMC0_SDSMODE_MASK            GENMASK(15, 13)
-#define RTL8366RB_PMC1                         0x0006
-
-/* Port Mirror Control Register */
-#define RTL8366RB_PMCR                         0x0007
-#define RTL8366RB_PMCR_SOURCE_PORT(a)          (a)
-#define RTL8366RB_PMCR_SOURCE_PORT_MASK                0x000f
-#define RTL8366RB_PMCR_MONITOR_PORT(a)         ((a) << 4)
-#define RTL8366RB_PMCR_MONITOR_PORT_MASK       0x00f0
-#define RTL8366RB_PMCR_MIRROR_RX               BIT(8)
-#define RTL8366RB_PMCR_MIRROR_TX               BIT(9)
-#define RTL8366RB_PMCR_MIRROR_SPC              BIT(10)
-#define RTL8366RB_PMCR_MIRROR_ISO              BIT(11)
-
-/* bits 0..7 = port 0, bits 8..15 = port 1 */
-#define RTL8366RB_PAACR0               0x0010
-/* bits 0..7 = port 2, bits 8..15 = port 3 */
-#define RTL8366RB_PAACR1               0x0011
-/* bits 0..7 = port 4, bits 8..15 = port 5 */
-#define RTL8366RB_PAACR2               0x0012
-#define RTL8366RB_PAACR_SPEED_10M      0
-#define RTL8366RB_PAACR_SPEED_100M     1
-#define RTL8366RB_PAACR_SPEED_1000M    2
-#define RTL8366RB_PAACR_FULL_DUPLEX    BIT(2)
-#define RTL8366RB_PAACR_LINK_UP                BIT(4)
-#define RTL8366RB_PAACR_TX_PAUSE       BIT(5)
-#define RTL8366RB_PAACR_RX_PAUSE       BIT(6)
-#define RTL8366RB_PAACR_AN             BIT(7)
-
-#define RTL8366RB_PAACR_CPU_PORT       (RTL8366RB_PAACR_SPEED_1000M | \
-                                        RTL8366RB_PAACR_FULL_DUPLEX | \
-                                        RTL8366RB_PAACR_LINK_UP | \
-                                        RTL8366RB_PAACR_TX_PAUSE | \
-                                        RTL8366RB_PAACR_RX_PAUSE)
-
-/* bits 0..7 = port 0, bits 8..15 = port 1 */
-#define RTL8366RB_PSTAT0               0x0014
-/* bits 0..7 = port 2, bits 8..15 = port 3 */
-#define RTL8366RB_PSTAT1               0x0015
-/* bits 0..7 = port 4, bits 8..15 = port 5 */
-#define RTL8366RB_PSTAT2               0x0016
-
-#define RTL8366RB_POWER_SAVING_REG     0x0021
-
-/* Spanning tree status (STP) control, two bits per port per FID */
-#define RTL8366RB_STP_STATE_BASE       0x0050 /* 0x0050..0x0057 */
-#define RTL8366RB_STP_STATE_DISABLED   0x0
-#define RTL8366RB_STP_STATE_BLOCKING   0x1
-#define RTL8366RB_STP_STATE_LEARNING   0x2
-#define RTL8366RB_STP_STATE_FORWARDING 0x3
-#define RTL8366RB_STP_MASK             GENMASK(1, 0)
-#define RTL8366RB_STP_STATE(port, state) \
-       ((state) << ((port) * 2))
-#define RTL8366RB_STP_STATE_MASK(port) \
-       RTL8366RB_STP_STATE((port), RTL8366RB_STP_MASK)
-
-/* CPU port control reg */
-#define RTL8368RB_CPU_CTRL_REG         0x0061
-#define RTL8368RB_CPU_PORTS_MSK                0x00FF
-/* Disables inserting custom tag length/type 0x8899 */
-#define RTL8368RB_CPU_NO_TAG           BIT(15)
-
-#define RTL8366RB_SMAR0                        0x0070 /* bits 0..15 */
-#define RTL8366RB_SMAR1                        0x0071 /* bits 16..31 */
-#define RTL8366RB_SMAR2                        0x0072 /* bits 32..47 */
-
-#define RTL8366RB_RESET_CTRL_REG               0x0100
-#define RTL8366RB_CHIP_CTRL_RESET_HW           BIT(0)
-#define RTL8366RB_CHIP_CTRL_RESET_SW           BIT(1)
-
-#define RTL8366RB_CHIP_ID_REG                  0x0509
-#define RTL8366RB_CHIP_ID_8366                 0x5937
-#define RTL8366RB_CHIP_VERSION_CTRL_REG                0x050A
-#define RTL8366RB_CHIP_VERSION_MASK            0xf
-
-/* PHY registers control */
-#define RTL8366RB_PHY_ACCESS_CTRL_REG          0x8000
-#define RTL8366RB_PHY_CTRL_READ                        BIT(0)
-#define RTL8366RB_PHY_CTRL_WRITE               0
-#define RTL8366RB_PHY_ACCESS_BUSY_REG          0x8001
-#define RTL8366RB_PHY_INT_BUSY                 BIT(0)
-#define RTL8366RB_PHY_EXT_BUSY                 BIT(4)
-#define RTL8366RB_PHY_ACCESS_DATA_REG          0x8002
-#define RTL8366RB_PHY_EXT_CTRL_REG             0x8010
-#define RTL8366RB_PHY_EXT_WRDATA_REG           0x8011
-#define RTL8366RB_PHY_EXT_RDDATA_REG           0x8012
-
-#define RTL8366RB_PHY_REG_MASK                 0x1f
-#define RTL8366RB_PHY_PAGE_OFFSET              5
-#define RTL8366RB_PHY_PAGE_MASK                        (0xf << 5)
-#define RTL8366RB_PHY_NO_OFFSET                        9
-#define RTL8366RB_PHY_NO_MASK                  (0x1f << 9)
-
-/* VLAN Ingress Control Register 1, one bit per port.
- * bit 0 .. 5 will make the switch drop ingress frames without
- * VID such as untagged or priority-tagged frames for respective
- * port.
- * bit 6 .. 11 will make the switch drop ingress frames carrying
- * a C-tag with VID != 0 for respective port.
- */
-#define RTL8366RB_VLAN_INGRESS_CTRL1_REG       0x037E
-#define RTL8366RB_VLAN_INGRESS_CTRL1_DROP(port)        (BIT((port)) | BIT((port) + 6))
-
-/* VLAN Ingress Control Register 2, one bit per port.
- * bit0 .. bit5 will make the switch drop all ingress frames with
- * a VLAN classification that does not include the port is in its
- * member set.
- */
-#define RTL8366RB_VLAN_INGRESS_CTRL2_REG       0x037f
-
-/* LED control registers */
-#define RTL8366RB_LED_BLINKRATE_REG            0x0430
-#define RTL8366RB_LED_BLINKRATE_MASK           0x0007
-#define RTL8366RB_LED_BLINKRATE_28MS           0x0000
-#define RTL8366RB_LED_BLINKRATE_56MS           0x0001
-#define RTL8366RB_LED_BLINKRATE_84MS           0x0002
-#define RTL8366RB_LED_BLINKRATE_111MS          0x0003
-#define RTL8366RB_LED_BLINKRATE_222MS          0x0004
-#define RTL8366RB_LED_BLINKRATE_446MS          0x0005
-
-#define RTL8366RB_LED_CTRL_REG                 0x0431
-#define RTL8366RB_LED_OFF                      0x0
-#define RTL8366RB_LED_DUP_COL                  0x1
-#define RTL8366RB_LED_LINK_ACT                 0x2
-#define RTL8366RB_LED_SPD1000                  0x3
-#define RTL8366RB_LED_SPD100                   0x4
-#define RTL8366RB_LED_SPD10                    0x5
-#define RTL8366RB_LED_SPD1000_ACT              0x6
-#define RTL8366RB_LED_SPD100_ACT               0x7
-#define RTL8366RB_LED_SPD10_ACT                        0x8
-#define RTL8366RB_LED_SPD100_10_ACT            0x9
-#define RTL8366RB_LED_FIBER                    0xa
-#define RTL8366RB_LED_AN_FAULT                 0xb
-#define RTL8366RB_LED_LINK_RX                  0xc
-#define RTL8366RB_LED_LINK_TX                  0xd
-#define RTL8366RB_LED_MASTER                   0xe
-#define RTL8366RB_LED_FORCE                    0xf
-#define RTL8366RB_LED_0_1_CTRL_REG             0x0432
-#define RTL8366RB_LED_1_OFFSET                 6
-#define RTL8366RB_LED_2_3_CTRL_REG             0x0433
-#define RTL8366RB_LED_3_OFFSET                 6
-
-#define RTL8366RB_MIB_COUNT                    33
-#define RTL8366RB_GLOBAL_MIB_COUNT             1
-#define RTL8366RB_MIB_COUNTER_PORT_OFFSET      0x0050
-#define RTL8366RB_MIB_COUNTER_BASE             0x1000
-#define RTL8366RB_MIB_CTRL_REG                 0x13F0
-#define RTL8366RB_MIB_CTRL_USER_MASK           0x0FFC
-#define RTL8366RB_MIB_CTRL_BUSY_MASK           BIT(0)
-#define RTL8366RB_MIB_CTRL_RESET_MASK          BIT(1)
-#define RTL8366RB_MIB_CTRL_PORT_RESET(_p)      BIT(2 + (_p))
-#define RTL8366RB_MIB_CTRL_GLOBAL_RESET                BIT(11)
-
-#define RTL8366RB_PORT_VLAN_CTRL_BASE          0x0063
-#define RTL8366RB_PORT_VLAN_CTRL_REG(_p)  \
-               (RTL8366RB_PORT_VLAN_CTRL_BASE + (_p) / 4)
-#define RTL8366RB_PORT_VLAN_CTRL_MASK          0xf
-#define RTL8366RB_PORT_VLAN_CTRL_SHIFT(_p)     (4 * ((_p) % 4))
-
-#define RTL8366RB_VLAN_TABLE_READ_BASE         0x018C
-#define RTL8366RB_VLAN_TABLE_WRITE_BASE                0x0185
-
-#define RTL8366RB_TABLE_ACCESS_CTRL_REG                0x0180
-#define RTL8366RB_TABLE_VLAN_READ_CTRL         0x0E01
-#define RTL8366RB_TABLE_VLAN_WRITE_CTRL                0x0F01
-
-#define RTL8366RB_VLAN_MC_BASE(_x)             (0x0020 + (_x) * 3)
-
-#define RTL8366RB_PORT_LINK_STATUS_BASE                0x0014
-#define RTL8366RB_PORT_STATUS_SPEED_MASK       0x0003
-#define RTL8366RB_PORT_STATUS_DUPLEX_MASK      0x0004
-#define RTL8366RB_PORT_STATUS_LINK_MASK                0x0010
-#define RTL8366RB_PORT_STATUS_TXPAUSE_MASK     0x0020
-#define RTL8366RB_PORT_STATUS_RXPAUSE_MASK     0x0040
-#define RTL8366RB_PORT_STATUS_AN_MASK          0x0080
-
-#define RTL8366RB_NUM_VLANS            16
-#define RTL8366RB_NUM_LEDGROUPS                4
-#define RTL8366RB_NUM_VIDS             4096
-#define RTL8366RB_PRIORITYMAX          7
-#define RTL8366RB_NUM_FIDS             8
-#define RTL8366RB_FIDMAX               7
-
-#define RTL8366RB_PORT_1               BIT(0) /* In userspace port 0 */
-#define RTL8366RB_PORT_2               BIT(1) /* In userspace port 1 */
-#define RTL8366RB_PORT_3               BIT(2) /* In userspace port 2 */
-#define RTL8366RB_PORT_4               BIT(3) /* In userspace port 3 */
-#define RTL8366RB_PORT_5               BIT(4) /* In userspace port 4 */
-
-#define RTL8366RB_PORT_CPU             BIT(5) /* CPU port */
-
-#define RTL8366RB_PORT_ALL             (RTL8366RB_PORT_1 |     \
-                                        RTL8366RB_PORT_2 |     \
-                                        RTL8366RB_PORT_3 |     \
-                                        RTL8366RB_PORT_4 |     \
-                                        RTL8366RB_PORT_5 |     \
-                                        RTL8366RB_PORT_CPU)
-
-#define RTL8366RB_PORT_ALL_BUT_CPU     (RTL8366RB_PORT_1 |     \
-                                        RTL8366RB_PORT_2 |     \
-                                        RTL8366RB_PORT_3 |     \
-                                        RTL8366RB_PORT_4 |     \
-                                        RTL8366RB_PORT_5)
-
-#define RTL8366RB_PORT_ALL_EXTERNAL    (RTL8366RB_PORT_1 |     \
-                                        RTL8366RB_PORT_2 |     \
-                                        RTL8366RB_PORT_3 |     \
-                                        RTL8366RB_PORT_4)
-
-#define RTL8366RB_PORT_ALL_INTERNAL     RTL8366RB_PORT_CPU
-
-/* First configuration word per member config, VID and prio */
-#define RTL8366RB_VLAN_VID_MASK                0xfff
-#define RTL8366RB_VLAN_PRIORITY_SHIFT  12
-#define RTL8366RB_VLAN_PRIORITY_MASK   0x7
-/* Second configuration word per member config, member and untagged */
-#define RTL8366RB_VLAN_UNTAG_SHIFT     8
-#define RTL8366RB_VLAN_UNTAG_MASK      0xff
-#define RTL8366RB_VLAN_MEMBER_MASK     0xff
-/* Third config word per member config, STAG currently unused */
-#define RTL8366RB_VLAN_STAG_MBR_MASK   0xff
-#define RTL8366RB_VLAN_STAG_MBR_SHIFT  8
-#define RTL8366RB_VLAN_STAG_IDX_MASK   0x7
-#define RTL8366RB_VLAN_STAG_IDX_SHIFT  5
-#define RTL8366RB_VLAN_FID_MASK                0x7
-
-/* Port ingress bandwidth control */
-#define RTL8366RB_IB_BASE              0x0200
-#define RTL8366RB_IB_REG(pnum)         (RTL8366RB_IB_BASE + (pnum))
-#define RTL8366RB_IB_BDTH_MASK         0x3fff
-#define RTL8366RB_IB_PREIFG            BIT(14)
-
-/* Port egress bandwidth control */
-#define RTL8366RB_EB_BASE              0x02d1
-#define RTL8366RB_EB_REG(pnum)         (RTL8366RB_EB_BASE + (pnum))
-#define RTL8366RB_EB_BDTH_MASK         0x3fff
-#define RTL8366RB_EB_PREIFG_REG                0x02f8
-#define RTL8366RB_EB_PREIFG            BIT(9)
-
-#define RTL8366RB_BDTH_SW_MAX          1048512 /* 1048576? */
-#define RTL8366RB_BDTH_UNIT            64
-#define RTL8366RB_BDTH_REG_DEFAULT     16383
-
-/* QOS */
-#define RTL8366RB_QOS                  BIT(15)
-/* Include/Exclude Preamble and IFG (20 bytes). 0:Exclude, 1:Include. */
-#define RTL8366RB_QOS_DEFAULT_PREIFG   1
-
-/* Interrupt handling */
-#define RTL8366RB_INTERRUPT_CONTROL_REG        0x0440
-#define RTL8366RB_INTERRUPT_POLARITY   BIT(0)
-#define RTL8366RB_P4_RGMII_LED         BIT(2)
-#define RTL8366RB_INTERRUPT_MASK_REG   0x0441
-#define RTL8366RB_INTERRUPT_LINK_CHGALL        GENMASK(11, 0)
-#define RTL8366RB_INTERRUPT_ACLEXCEED  BIT(8)
-#define RTL8366RB_INTERRUPT_STORMEXCEED        BIT(9)
-#define RTL8366RB_INTERRUPT_P4_FIBER   BIT(12)
-#define RTL8366RB_INTERRUPT_P4_UTP     BIT(13)
-#define RTL8366RB_INTERRUPT_VALID      (RTL8366RB_INTERRUPT_LINK_CHGALL | \
-                                        RTL8366RB_INTERRUPT_ACLEXCEED | \
-                                        RTL8366RB_INTERRUPT_STORMEXCEED | \
-                                        RTL8366RB_INTERRUPT_P4_FIBER | \
-                                        RTL8366RB_INTERRUPT_P4_UTP)
-#define RTL8366RB_INTERRUPT_STATUS_REG 0x0442
-#define RTL8366RB_NUM_INTERRUPT                14 /* 0..13 */
-
-/* Port isolation registers */
-#define RTL8366RB_PORT_ISO_BASE                0x0F08
-#define RTL8366RB_PORT_ISO(pnum)       (RTL8366RB_PORT_ISO_BASE + (pnum))
-#define RTL8366RB_PORT_ISO_EN          BIT(0)
-#define RTL8366RB_PORT_ISO_PORTS_MASK  GENMASK(7, 1)
-#define RTL8366RB_PORT_ISO_PORTS(pmask)        ((pmask) << 1)
-
-/* bits 0..5 enable force when cleared */
-#define RTL8366RB_MAC_FORCE_CTRL_REG   0x0F11
-
-#define RTL8366RB_OAM_PARSER_REG       0x0F14
-#define RTL8366RB_OAM_MULTIPLEXER_REG  0x0F15
-
-#define RTL8366RB_GREEN_FEATURE_REG    0x0F51
-#define RTL8366RB_GREEN_FEATURE_MSK    0x0007
-#define RTL8366RB_GREEN_FEATURE_TX     BIT(0)
-#define RTL8366RB_GREEN_FEATURE_RX     BIT(2)
-
-/**
- * struct rtl8366rb - RTL8366RB-specific data
- * @max_mtu: per-port max MTU setting
- * @pvid_enabled: if PVID is set for respective port
- */
-struct rtl8366rb {
-       unsigned int max_mtu[RTL8366RB_NUM_PORTS];
-       bool pvid_enabled[RTL8366RB_NUM_PORTS];
-};
-
-static struct rtl8366_mib_counter rtl8366rb_mib_counters[] = {
-       { 0,  0, 4, "IfInOctets"                                },
-       { 0,  4, 4, "EtherStatsOctets"                          },
-       { 0,  8, 2, "EtherStatsUnderSizePkts"                   },
-       { 0, 10, 2, "EtherFragments"                            },
-       { 0, 12, 2, "EtherStatsPkts64Octets"                    },
-       { 0, 14, 2, "EtherStatsPkts65to127Octets"               },
-       { 0, 16, 2, "EtherStatsPkts128to255Octets"              },
-       { 0, 18, 2, "EtherStatsPkts256to511Octets"              },
-       { 0, 20, 2, "EtherStatsPkts512to1023Octets"             },
-       { 0, 22, 2, "EtherStatsPkts1024to1518Octets"            },
-       { 0, 24, 2, "EtherOversizeStats"                        },
-       { 0, 26, 2, "EtherStatsJabbers"                         },
-       { 0, 28, 2, "IfInUcastPkts"                             },
-       { 0, 30, 2, "EtherStatsMulticastPkts"                   },
-       { 0, 32, 2, "EtherStatsBroadcastPkts"                   },
-       { 0, 34, 2, "EtherStatsDropEvents"                      },
-       { 0, 36, 2, "Dot3StatsFCSErrors"                        },
-       { 0, 38, 2, "Dot3StatsSymbolErrors"                     },
-       { 0, 40, 2, "Dot3InPauseFrames"                         },
-       { 0, 42, 2, "Dot3ControlInUnknownOpcodes"               },
-       { 0, 44, 4, "IfOutOctets"                               },
-       { 0, 48, 2, "Dot3StatsSingleCollisionFrames"            },
-       { 0, 50, 2, "Dot3StatMultipleCollisionFrames"           },
-       { 0, 52, 2, "Dot3sDeferredTransmissions"                },
-       { 0, 54, 2, "Dot3StatsLateCollisions"                   },
-       { 0, 56, 2, "EtherStatsCollisions"                      },
-       { 0, 58, 2, "Dot3StatsExcessiveCollisions"              },
-       { 0, 60, 2, "Dot3OutPauseFrames"                        },
-       { 0, 62, 2, "Dot1dBasePortDelayExceededDiscards"        },
-       { 0, 64, 2, "Dot1dTpPortInDiscards"                     },
-       { 0, 66, 2, "IfOutUcastPkts"                            },
-       { 0, 68, 2, "IfOutMulticastPkts"                        },
-       { 0, 70, 2, "IfOutBroadcastPkts"                        },
-};
-
-static int rtl8366rb_get_mib_counter(struct realtek_smi *smi,
-                                    int port,
-                                    struct rtl8366_mib_counter *mib,
-                                    u64 *mibvalue)
-{
-       u32 addr, val;
-       int ret;
-       int i;
-
-       addr = RTL8366RB_MIB_COUNTER_BASE +
-               RTL8366RB_MIB_COUNTER_PORT_OFFSET * (port) +
-               mib->offset;
-
-       /* Writing access counter address first
-        * then ASIC will prepare 64bits counter wait for being retrived
-        */
-       ret = regmap_write(smi->map, addr, 0); /* Write whatever */
-       if (ret)
-               return ret;
-
-       /* Read MIB control register */
-       ret = regmap_read(smi->map, RTL8366RB_MIB_CTRL_REG, &val);
-       if (ret)
-               return -EIO;
-
-       if (val & RTL8366RB_MIB_CTRL_BUSY_MASK)
-               return -EBUSY;
-
-       if (val & RTL8366RB_MIB_CTRL_RESET_MASK)
-               return -EIO;
-
-       /* Read each individual MIB 16 bits at the time */
-       *mibvalue = 0;
-       for (i = mib->length; i > 0; i--) {
-               ret = regmap_read(smi->map, addr + (i - 1), &val);
-               if (ret)
-                       return ret;
-               *mibvalue = (*mibvalue << 16) | (val & 0xFFFF);
-       }
-       return 0;
-}
-
-static u32 rtl8366rb_get_irqmask(struct irq_data *d)
-{
-       int line = irqd_to_hwirq(d);
-       u32 val;
-
-       /* For line interrupts we combine link down in bits
-        * 6..11 with link up in bits 0..5 into one interrupt.
-        */
-       if (line < 12)
-               val = BIT(line) | BIT(line + 6);
-       else
-               val = BIT(line);
-       return val;
-}
-
-static void rtl8366rb_mask_irq(struct irq_data *d)
-{
-       struct realtek_smi *smi = irq_data_get_irq_chip_data(d);
-       int ret;
-
-       ret = regmap_update_bits(smi->map, RTL8366RB_INTERRUPT_MASK_REG,
-                                rtl8366rb_get_irqmask(d), 0);
-       if (ret)
-               dev_err(smi->dev, "could not mask IRQ\n");
-}
-
-static void rtl8366rb_unmask_irq(struct irq_data *d)
-{
-       struct realtek_smi *smi = irq_data_get_irq_chip_data(d);
-       int ret;
-
-       ret = regmap_update_bits(smi->map, RTL8366RB_INTERRUPT_MASK_REG,
-                                rtl8366rb_get_irqmask(d),
-                                rtl8366rb_get_irqmask(d));
-       if (ret)
-               dev_err(smi->dev, "could not unmask IRQ\n");
-}
-
-static irqreturn_t rtl8366rb_irq(int irq, void *data)
-{
-       struct realtek_smi *smi = data;
-       u32 stat;
-       int ret;
-
-       /* This clears the IRQ status register */
-       ret = regmap_read(smi->map, RTL8366RB_INTERRUPT_STATUS_REG,
-                         &stat);
-       if (ret) {
-               dev_err(smi->dev, "can't read interrupt status\n");
-               return IRQ_NONE;
-       }
-       stat &= RTL8366RB_INTERRUPT_VALID;
-       if (!stat)
-               return IRQ_NONE;
-       while (stat) {
-               int line = __ffs(stat);
-               int child_irq;
-
-               stat &= ~BIT(line);
-               /* For line interrupts we combine link down in bits
-                * 6..11 with link up in bits 0..5 into one interrupt.
-                */
-               if (line < 12 && line > 5)
-                       line -= 5;
-               child_irq = irq_find_mapping(smi->irqdomain, line);
-               handle_nested_irq(child_irq);
-       }
-       return IRQ_HANDLED;
-}
-
-static struct irq_chip rtl8366rb_irq_chip = {
-       .name = "RTL8366RB",
-       .irq_mask = rtl8366rb_mask_irq,
-       .irq_unmask = rtl8366rb_unmask_irq,
-};
-
-static int rtl8366rb_irq_map(struct irq_domain *domain, unsigned int irq,
-                            irq_hw_number_t hwirq)
-{
-       irq_set_chip_data(irq, domain->host_data);
-       irq_set_chip_and_handler(irq, &rtl8366rb_irq_chip, handle_simple_irq);
-       irq_set_nested_thread(irq, 1);
-       irq_set_noprobe(irq);
-
-       return 0;
-}
-
-static void rtl8366rb_irq_unmap(struct irq_domain *d, unsigned int irq)
-{
-       irq_set_nested_thread(irq, 0);
-       irq_set_chip_and_handler(irq, NULL, NULL);
-       irq_set_chip_data(irq, NULL);
-}
-
-static const struct irq_domain_ops rtl8366rb_irqdomain_ops = {
-       .map = rtl8366rb_irq_map,
-       .unmap = rtl8366rb_irq_unmap,
-       .xlate  = irq_domain_xlate_onecell,
-};
-
-static int rtl8366rb_setup_cascaded_irq(struct realtek_smi *smi)
-{
-       struct device_node *intc;
-       unsigned long irq_trig;
-       int irq;
-       int ret;
-       u32 val;
-       int i;
-
-       intc = of_get_child_by_name(smi->dev->of_node, "interrupt-controller");
-       if (!intc) {
-               dev_err(smi->dev, "missing child interrupt-controller node\n");
-               return -EINVAL;
-       }
-       /* RB8366RB IRQs cascade off this one */
-       irq = of_irq_get(intc, 0);
-       if (irq <= 0) {
-               dev_err(smi->dev, "failed to get parent IRQ\n");
-               ret = irq ? irq : -EINVAL;
-               goto out_put_node;
-       }
-
-       /* This clears the IRQ status register */
-       ret = regmap_read(smi->map, RTL8366RB_INTERRUPT_STATUS_REG,
-                         &val);
-       if (ret) {
-               dev_err(smi->dev, "can't read interrupt status\n");
-               goto out_put_node;
-       }
-
-       /* Fetch IRQ edge information from the descriptor */
-       irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
-       switch (irq_trig) {
-       case IRQF_TRIGGER_RISING:
-       case IRQF_TRIGGER_HIGH:
-               dev_info(smi->dev, "active high/rising IRQ\n");
-               val = 0;
-               break;
-       case IRQF_TRIGGER_FALLING:
-       case IRQF_TRIGGER_LOW:
-               dev_info(smi->dev, "active low/falling IRQ\n");
-               val = RTL8366RB_INTERRUPT_POLARITY;
-               break;
-       }
-       ret = regmap_update_bits(smi->map, RTL8366RB_INTERRUPT_CONTROL_REG,
-                                RTL8366RB_INTERRUPT_POLARITY,
-                                val);
-       if (ret) {
-               dev_err(smi->dev, "could not configure IRQ polarity\n");
-               goto out_put_node;
-       }
-
-       ret = devm_request_threaded_irq(smi->dev, irq, NULL,
-                                       rtl8366rb_irq, IRQF_ONESHOT,
-                                       "RTL8366RB", smi);
-       if (ret) {
-               dev_err(smi->dev, "unable to request irq: %d\n", ret);
-               goto out_put_node;
-       }
-       smi->irqdomain = irq_domain_add_linear(intc,
-                                              RTL8366RB_NUM_INTERRUPT,
-                                              &rtl8366rb_irqdomain_ops,
-                                              smi);
-       if (!smi->irqdomain) {
-               dev_err(smi->dev, "failed to create IRQ domain\n");
-               ret = -EINVAL;
-               goto out_put_node;
-       }
-       for (i = 0; i < smi->num_ports; i++)
-               irq_set_parent(irq_create_mapping(smi->irqdomain, i), irq);
-
-out_put_node:
-       of_node_put(intc);
-       return ret;
-}
-
-static int rtl8366rb_set_addr(struct realtek_smi *smi)
-{
-       u8 addr[ETH_ALEN];
-       u16 val;
-       int ret;
-
-       eth_random_addr(addr);
-
-       dev_info(smi->dev, "set MAC: %02X:%02X:%02X:%02X:%02X:%02X\n",
-                addr[0], addr[1], addr[2], addr[3], addr[4], addr[5]);
-       val = addr[0] << 8 | addr[1];
-       ret = regmap_write(smi->map, RTL8366RB_SMAR0, val);
-       if (ret)
-               return ret;
-       val = addr[2] << 8 | addr[3];
-       ret = regmap_write(smi->map, RTL8366RB_SMAR1, val);
-       if (ret)
-               return ret;
-       val = addr[4] << 8 | addr[5];
-       ret = regmap_write(smi->map, RTL8366RB_SMAR2, val);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-/* Found in a vendor driver */
-
-/* Struct for handling the jam tables' entries */
-struct rtl8366rb_jam_tbl_entry {
-       u16 reg;
-       u16 val;
-};
-
-/* For the "version 0" early silicon, appear in most source releases */
-static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_ver_0[] = {
-       {0x000B, 0x0001}, {0x03A6, 0x0100}, {0x03A7, 0x0001}, {0x02D1, 0x3FFF},
-       {0x02D2, 0x3FFF}, {0x02D3, 0x3FFF}, {0x02D4, 0x3FFF}, {0x02D5, 0x3FFF},
-       {0x02D6, 0x3FFF}, {0x02D7, 0x3FFF}, {0x02D8, 0x3FFF}, {0x022B, 0x0688},
-       {0x022C, 0x0FAC}, {0x03D0, 0x4688}, {0x03D1, 0x01F5}, {0x0000, 0x0830},
-       {0x02F9, 0x0200}, {0x02F7, 0x7FFF}, {0x02F8, 0x03FF}, {0x0080, 0x03E8},
-       {0x0081, 0x00CE}, {0x0082, 0x00DA}, {0x0083, 0x0230}, {0xBE0F, 0x2000},
-       {0x0231, 0x422A}, {0x0232, 0x422A}, {0x0233, 0x422A}, {0x0234, 0x422A},
-       {0x0235, 0x422A}, {0x0236, 0x422A}, {0x0237, 0x422A}, {0x0238, 0x422A},
-       {0x0239, 0x422A}, {0x023A, 0x422A}, {0x023B, 0x422A}, {0x023C, 0x422A},
-       {0x023D, 0x422A}, {0x023E, 0x422A}, {0x023F, 0x422A}, {0x0240, 0x422A},
-       {0x0241, 0x422A}, {0x0242, 0x422A}, {0x0243, 0x422A}, {0x0244, 0x422A},
-       {0x0245, 0x422A}, {0x0246, 0x422A}, {0x0247, 0x422A}, {0x0248, 0x422A},
-       {0x0249, 0x0146}, {0x024A, 0x0146}, {0x024B, 0x0146}, {0xBE03, 0xC961},
-       {0x024D, 0x0146}, {0x024E, 0x0146}, {0x024F, 0x0146}, {0x0250, 0x0146},
-       {0xBE64, 0x0226}, {0x0252, 0x0146}, {0x0253, 0x0146}, {0x024C, 0x0146},
-       {0x0251, 0x0146}, {0x0254, 0x0146}, {0xBE62, 0x3FD0}, {0x0084, 0x0320},
-       {0x0255, 0x0146}, {0x0256, 0x0146}, {0x0257, 0x0146}, {0x0258, 0x0146},
-       {0x0259, 0x0146}, {0x025A, 0x0146}, {0x025B, 0x0146}, {0x025C, 0x0146},
-       {0x025D, 0x0146}, {0x025E, 0x0146}, {0x025F, 0x0146}, {0x0260, 0x0146},
-       {0x0261, 0xA23F}, {0x0262, 0x0294}, {0x0263, 0xA23F}, {0x0264, 0x0294},
-       {0x0265, 0xA23F}, {0x0266, 0x0294}, {0x0267, 0xA23F}, {0x0268, 0x0294},
-       {0x0269, 0xA23F}, {0x026A, 0x0294}, {0x026B, 0xA23F}, {0x026C, 0x0294},
-       {0x026D, 0xA23F}, {0x026E, 0x0294}, {0x026F, 0xA23F}, {0x0270, 0x0294},
-       {0x02F5, 0x0048}, {0xBE09, 0x0E00}, {0xBE1E, 0x0FA0}, {0xBE14, 0x8448},
-       {0xBE15, 0x1007}, {0xBE4A, 0xA284}, {0xC454, 0x3F0B}, {0xC474, 0x3F0B},
-       {0xBE48, 0x3672}, {0xBE4B, 0x17A7}, {0xBE4C, 0x0B15}, {0xBE52, 0x0EDD},
-       {0xBE49, 0x8C00}, {0xBE5B, 0x785C}, {0xBE5C, 0x785C}, {0xBE5D, 0x785C},
-       {0xBE61, 0x368A}, {0xBE63, 0x9B84}, {0xC456, 0xCC13}, {0xC476, 0xCC13},
-       {0xBE65, 0x307D}, {0xBE6D, 0x0005}, {0xBE6E, 0xE120}, {0xBE2E, 0x7BAF},
-};
-
-/* This v1 init sequence is from Belkin F5D8235 U-Boot release */
-static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_ver_1[] = {
-       {0x0000, 0x0830}, {0x0001, 0x8000}, {0x0400, 0x8130}, {0xBE78, 0x3C3C},
-       {0x0431, 0x5432}, {0xBE37, 0x0CE4}, {0x02FA, 0xFFDF}, {0x02FB, 0xFFE0},
-       {0xC44C, 0x1585}, {0xC44C, 0x1185}, {0xC44C, 0x1585}, {0xC46C, 0x1585},
-       {0xC46C, 0x1185}, {0xC46C, 0x1585}, {0xC451, 0x2135}, {0xC471, 0x2135},
-       {0xBE10, 0x8140}, {0xBE15, 0x0007}, {0xBE6E, 0xE120}, {0xBE69, 0xD20F},
-       {0xBE6B, 0x0320}, {0xBE24, 0xB000}, {0xBE23, 0xFF51}, {0xBE22, 0xDF20},
-       {0xBE21, 0x0140}, {0xBE20, 0x00BB}, {0xBE24, 0xB800}, {0xBE24, 0x0000},
-       {0xBE24, 0x7000}, {0xBE23, 0xFF51}, {0xBE22, 0xDF60}, {0xBE21, 0x0140},
-       {0xBE20, 0x0077}, {0xBE24, 0x7800}, {0xBE24, 0x0000}, {0xBE2E, 0x7B7A},
-       {0xBE36, 0x0CE4}, {0x02F5, 0x0048}, {0xBE77, 0x2940}, {0x000A, 0x83E0},
-       {0xBE79, 0x3C3C}, {0xBE00, 0x1340},
-};
-
-/* This v2 init sequence is from Belkin F5D8235 U-Boot release */
-static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_ver_2[] = {
-       {0x0450, 0x0000}, {0x0400, 0x8130}, {0x000A, 0x83ED}, {0x0431, 0x5432},
-       {0xC44F, 0x6250}, {0xC46F, 0x6250}, {0xC456, 0x0C14}, {0xC476, 0x0C14},
-       {0xC44C, 0x1C85}, {0xC44C, 0x1885}, {0xC44C, 0x1C85}, {0xC46C, 0x1C85},
-       {0xC46C, 0x1885}, {0xC46C, 0x1C85}, {0xC44C, 0x0885}, {0xC44C, 0x0881},
-       {0xC44C, 0x0885}, {0xC46C, 0x0885}, {0xC46C, 0x0881}, {0xC46C, 0x0885},
-       {0xBE2E, 0x7BA7}, {0xBE36, 0x1000}, {0xBE37, 0x1000}, {0x8000, 0x0001},
-       {0xBE69, 0xD50F}, {0x8000, 0x0000}, {0xBE69, 0xD50F}, {0xBE6E, 0x0320},
-       {0xBE77, 0x2940}, {0xBE78, 0x3C3C}, {0xBE79, 0x3C3C}, {0xBE6E, 0xE120},
-       {0x8000, 0x0001}, {0xBE15, 0x1007}, {0x8000, 0x0000}, {0xBE15, 0x1007},
-       {0xBE14, 0x0448}, {0xBE1E, 0x00A0}, {0xBE10, 0x8160}, {0xBE10, 0x8140},
-       {0xBE00, 0x1340}, {0x0F51, 0x0010},
-};
-
-/* Appears in a DDWRT code dump */
-static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_ver_3[] = {
-       {0x0000, 0x0830}, {0x0400, 0x8130}, {0x000A, 0x83ED}, {0x0431, 0x5432},
-       {0x0F51, 0x0017}, {0x02F5, 0x0048}, {0x02FA, 0xFFDF}, {0x02FB, 0xFFE0},
-       {0xC456, 0x0C14}, {0xC476, 0x0C14}, {0xC454, 0x3F8B}, {0xC474, 0x3F8B},
-       {0xC450, 0x2071}, {0xC470, 0x2071}, {0xC451, 0x226B}, {0xC471, 0x226B},
-       {0xC452, 0xA293}, {0xC472, 0xA293}, {0xC44C, 0x1585}, {0xC44C, 0x1185},
-       {0xC44C, 0x1585}, {0xC46C, 0x1585}, {0xC46C, 0x1185}, {0xC46C, 0x1585},
-       {0xC44C, 0x0185}, {0xC44C, 0x0181}, {0xC44C, 0x0185}, {0xC46C, 0x0185},
-       {0xC46C, 0x0181}, {0xC46C, 0x0185}, {0xBE24, 0xB000}, {0xBE23, 0xFF51},
-       {0xBE22, 0xDF20}, {0xBE21, 0x0140}, {0xBE20, 0x00BB}, {0xBE24, 0xB800},
-       {0xBE24, 0x0000}, {0xBE24, 0x7000}, {0xBE23, 0xFF51}, {0xBE22, 0xDF60},
-       {0xBE21, 0x0140}, {0xBE20, 0x0077}, {0xBE24, 0x7800}, {0xBE24, 0x0000},
-       {0xBE2E, 0x7BA7}, {0xBE36, 0x1000}, {0xBE37, 0x1000}, {0x8000, 0x0001},
-       {0xBE69, 0xD50F}, {0x8000, 0x0000}, {0xBE69, 0xD50F}, {0xBE6B, 0x0320},
-       {0xBE77, 0x2800}, {0xBE78, 0x3C3C}, {0xBE79, 0x3C3C}, {0xBE6E, 0xE120},
-       {0x8000, 0x0001}, {0xBE10, 0x8140}, {0x8000, 0x0000}, {0xBE10, 0x8140},
-       {0xBE15, 0x1007}, {0xBE14, 0x0448}, {0xBE1E, 0x00A0}, {0xBE10, 0x8160},
-       {0xBE10, 0x8140}, {0xBE00, 0x1340}, {0x0450, 0x0000}, {0x0401, 0x0000},
-};
-
-/* Belkin F5D8235 v1, "belkin,f5d8235-v1" */
-static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_f5d8235[] = {
-       {0x0242, 0x02BF}, {0x0245, 0x02BF}, {0x0248, 0x02BF}, {0x024B, 0x02BF},
-       {0x024E, 0x02BF}, {0x0251, 0x02BF}, {0x0254, 0x0A3F}, {0x0256, 0x0A3F},
-       {0x0258, 0x0A3F}, {0x025A, 0x0A3F}, {0x025C, 0x0A3F}, {0x025E, 0x0A3F},
-       {0x0263, 0x007C}, {0x0100, 0x0004}, {0xBE5B, 0x3500}, {0x800E, 0x200F},
-       {0xBE1D, 0x0F00}, {0x8001, 0x5011}, {0x800A, 0xA2F4}, {0x800B, 0x17A3},
-       {0xBE4B, 0x17A3}, {0xBE41, 0x5011}, {0xBE17, 0x2100}, {0x8000, 0x8304},
-       {0xBE40, 0x8304}, {0xBE4A, 0xA2F4}, {0x800C, 0xA8D5}, {0x8014, 0x5500},
-       {0x8015, 0x0004}, {0xBE4C, 0xA8D5}, {0xBE59, 0x0008}, {0xBE09, 0x0E00},
-       {0xBE36, 0x1036}, {0xBE37, 0x1036}, {0x800D, 0x00FF}, {0xBE4D, 0x00FF},
-};
-
-/* DGN3500, "netgear,dgn3500", "netgear,dgn3500b" */
-static const struct rtl8366rb_jam_tbl_entry rtl8366rb_init_jam_dgn3500[] = {
-       {0x0000, 0x0830}, {0x0400, 0x8130}, {0x000A, 0x83ED}, {0x0F51, 0x0017},
-       {0x02F5, 0x0048}, {0x02FA, 0xFFDF}, {0x02FB, 0xFFE0}, {0x0450, 0x0000},
-       {0x0401, 0x0000}, {0x0431, 0x0960},
-};
-
-/* This jam table activates "green ethernet", which means low power mode
- * and is claimed to detect the cable length and not use more power than
- * necessary, and the ports should enter power saving mode 10 seconds after
- * a cable is disconnected. Seems to always be the same.
- */
-static const struct rtl8366rb_jam_tbl_entry rtl8366rb_green_jam[] = {
-       {0xBE78, 0x323C}, {0xBE77, 0x5000}, {0xBE2E, 0x7BA7},
-       {0xBE59, 0x3459}, {0xBE5A, 0x745A}, {0xBE5B, 0x785C},
-       {0xBE5C, 0x785C}, {0xBE6E, 0xE120}, {0xBE79, 0x323C},
-};
-
-/* Function that jams the tables in the proper registers */
-static int rtl8366rb_jam_table(const struct rtl8366rb_jam_tbl_entry *jam_table,
-                              int jam_size, struct realtek_smi *smi,
-                              bool write_dbg)
-{
-       u32 val;
-       int ret;
-       int i;
-
-       for (i = 0; i < jam_size; i++) {
-               if ((jam_table[i].reg & 0xBE00) == 0xBE00) {
-                       ret = regmap_read(smi->map,
-                                         RTL8366RB_PHY_ACCESS_BUSY_REG,
-                                         &val);
-                       if (ret)
-                               return ret;
-                       if (!(val & RTL8366RB_PHY_INT_BUSY)) {
-                               ret = regmap_write(smi->map,
-                                               RTL8366RB_PHY_ACCESS_CTRL_REG,
-                                               RTL8366RB_PHY_CTRL_WRITE);
-                               if (ret)
-                                       return ret;
-                       }
-               }
-               if (write_dbg)
-                       dev_dbg(smi->dev, "jam %04x into register %04x\n",
-                               jam_table[i].val,
-                               jam_table[i].reg);
-               ret = regmap_write(smi->map,
-                                  jam_table[i].reg,
-                                  jam_table[i].val);
-               if (ret)
-                       return ret;
-       }
-       return 0;
-}
-
-static int rtl8366rb_setup(struct dsa_switch *ds)
-{
-       struct realtek_smi *smi = ds->priv;
-       const struct rtl8366rb_jam_tbl_entry *jam_table;
-       struct rtl8366rb *rb;
-       u32 chip_ver = 0;
-       u32 chip_id = 0;
-       int jam_size;
-       u32 val;
-       int ret;
-       int i;
-
-       rb = smi->chip_data;
-
-       ret = regmap_read(smi->map, RTL8366RB_CHIP_ID_REG, &chip_id);
-       if (ret) {
-               dev_err(smi->dev, "unable to read chip id\n");
-               return ret;
-       }
-
-       switch (chip_id) {
-       case RTL8366RB_CHIP_ID_8366:
-               break;
-       default:
-               dev_err(smi->dev, "unknown chip id (%04x)\n", chip_id);
-               return -ENODEV;
-       }
-
-       ret = regmap_read(smi->map, RTL8366RB_CHIP_VERSION_CTRL_REG,
-                         &chip_ver);
-       if (ret) {
-               dev_err(smi->dev, "unable to read chip version\n");
-               return ret;
-       }
-
-       dev_info(smi->dev, "RTL%04x ver %u chip found\n",
-                chip_id, chip_ver & RTL8366RB_CHIP_VERSION_MASK);
-
-       /* Do the init dance using the right jam table */
-       switch (chip_ver) {
-       case 0:
-               jam_table = rtl8366rb_init_jam_ver_0;
-               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_ver_0);
-               break;
-       case 1:
-               jam_table = rtl8366rb_init_jam_ver_1;
-               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_ver_1);
-               break;
-       case 2:
-               jam_table = rtl8366rb_init_jam_ver_2;
-               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_ver_2);
-               break;
-       default:
-               jam_table = rtl8366rb_init_jam_ver_3;
-               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_ver_3);
-               break;
-       }
-
-       /* Special jam tables for special routers
-        * TODO: are these necessary? Maintainers, please test
-        * without them, using just the off-the-shelf tables.
-        */
-       if (of_machine_is_compatible("belkin,f5d8235-v1")) {
-               jam_table = rtl8366rb_init_jam_f5d8235;
-               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_f5d8235);
-       }
-       if (of_machine_is_compatible("netgear,dgn3500") ||
-           of_machine_is_compatible("netgear,dgn3500b")) {
-               jam_table = rtl8366rb_init_jam_dgn3500;
-               jam_size = ARRAY_SIZE(rtl8366rb_init_jam_dgn3500);
-       }
-
-       ret = rtl8366rb_jam_table(jam_table, jam_size, smi, true);
-       if (ret)
-               return ret;
-
-       /* Isolate all user ports so they can only send packets to itself and the CPU port */
-       for (i = 0; i < RTL8366RB_PORT_NUM_CPU; i++) {
-               ret = regmap_write(smi->map, RTL8366RB_PORT_ISO(i),
-                                  RTL8366RB_PORT_ISO_PORTS(BIT(RTL8366RB_PORT_NUM_CPU)) |
-                                  RTL8366RB_PORT_ISO_EN);
-               if (ret)
-                       return ret;
-       }
-       /* CPU port can send packets to all ports */
-       ret = regmap_write(smi->map, RTL8366RB_PORT_ISO(RTL8366RB_PORT_NUM_CPU),
-                          RTL8366RB_PORT_ISO_PORTS(dsa_user_ports(ds)) |
-                          RTL8366RB_PORT_ISO_EN);
-       if (ret)
-               return ret;
-
-       /* Set up the "green ethernet" feature */
-       ret = rtl8366rb_jam_table(rtl8366rb_green_jam,
-                                 ARRAY_SIZE(rtl8366rb_green_jam), smi, false);
-       if (ret)
-               return ret;
-
-       ret = regmap_write(smi->map,
-                          RTL8366RB_GREEN_FEATURE_REG,
-                          (chip_ver == 1) ? 0x0007 : 0x0003);
-       if (ret)
-               return ret;
-
-       /* Vendor driver sets 0x240 in registers 0xc and 0xd (undocumented) */
-       ret = regmap_write(smi->map, 0x0c, 0x240);
-       if (ret)
-               return ret;
-       ret = regmap_write(smi->map, 0x0d, 0x240);
-       if (ret)
-               return ret;
-
-       /* Set some random MAC address */
-       ret = rtl8366rb_set_addr(smi);
-       if (ret)
-               return ret;
-
-       /* Enable CPU port with custom DSA tag 8899.
-        *
-        * If you set RTL8368RB_CPU_NO_TAG (bit 15) in this registers
-        * the custom tag is turned off.
-        */
-       ret = regmap_update_bits(smi->map, RTL8368RB_CPU_CTRL_REG,
-                                0xFFFF,
-                                BIT(smi->cpu_port));
-       if (ret)
-               return ret;
-
-       /* Make sure we default-enable the fixed CPU port */
-       ret = regmap_update_bits(smi->map, RTL8366RB_PECR,
-                                BIT(smi->cpu_port),
-                                0);
-       if (ret)
-               return ret;
-
-       /* Set maximum packet length to 1536 bytes */
-       ret = regmap_update_bits(smi->map, RTL8366RB_SGCR,
-                                RTL8366RB_SGCR_MAX_LENGTH_MASK,
-                                RTL8366RB_SGCR_MAX_LENGTH_1536);
-       if (ret)
-               return ret;
-       for (i = 0; i < RTL8366RB_NUM_PORTS; i++)
-               /* layer 2 size, see rtl8366rb_change_mtu() */
-               rb->max_mtu[i] = 1532;
-
-       /* Disable learning for all ports */
-       ret = regmap_write(smi->map, RTL8366RB_PORT_LEARNDIS_CTRL,
-                          RTL8366RB_PORT_ALL);
-       if (ret)
-               return ret;
-
-       /* Enable auto ageing for all ports */
-       ret = regmap_write(smi->map, RTL8366RB_SECURITY_CTRL, 0);
-       if (ret)
-               return ret;
-
-       /* Port 4 setup: this enables Port 4, usually the WAN port,
-        * common PHY IO mode is apparently mode 0, and this is not what
-        * the port is initialized to. There is no explanation of the
-        * IO modes in the Realtek source code, if your WAN port is
-        * connected to something exotic such as fiber, then this might
-        * be worth experimenting with.
-        */
-       ret = regmap_update_bits(smi->map, RTL8366RB_PMC0,
-                                RTL8366RB_PMC0_P4_IOMODE_MASK,
-                                0 << RTL8366RB_PMC0_P4_IOMODE_SHIFT);
-       if (ret)
-               return ret;
-
-       /* Accept all packets by default, we enable filtering on-demand */
-       ret = regmap_write(smi->map, RTL8366RB_VLAN_INGRESS_CTRL1_REG,
-                          0);
-       if (ret)
-               return ret;
-       ret = regmap_write(smi->map, RTL8366RB_VLAN_INGRESS_CTRL2_REG,
-                          0);
-       if (ret)
-               return ret;
-
-       /* Don't drop packets whose DA has not been learned */
-       ret = regmap_update_bits(smi->map, RTL8366RB_SSCR2,
-                                RTL8366RB_SSCR2_DROP_UNKNOWN_DA, 0);
-       if (ret)
-               return ret;
-
-       /* Set blinking, TODO: make this configurable */
-       ret = regmap_update_bits(smi->map, RTL8366RB_LED_BLINKRATE_REG,
-                                RTL8366RB_LED_BLINKRATE_MASK,
-                                RTL8366RB_LED_BLINKRATE_56MS);
-       if (ret)
-               return ret;
-
-       /* Set up LED activity:
-        * Each port has 4 LEDs, we configure all ports to the same
-        * behaviour (no individual config) but we can set up each
-        * LED separately.
-        */
-       if (smi->leds_disabled) {
-               /* Turn everything off */
-               regmap_update_bits(smi->map,
-                                  RTL8366RB_LED_0_1_CTRL_REG,
-                                  0x0FFF, 0);
-               regmap_update_bits(smi->map,
-                                  RTL8366RB_LED_2_3_CTRL_REG,
-                                  0x0FFF, 0);
-               regmap_update_bits(smi->map,
-                                  RTL8366RB_INTERRUPT_CONTROL_REG,
-                                  RTL8366RB_P4_RGMII_LED,
-                                  0);
-               val = RTL8366RB_LED_OFF;
-       } else {
-               /* TODO: make this configurable per LED */
-               val = RTL8366RB_LED_FORCE;
-       }
-       for (i = 0; i < 4; i++) {
-               ret = regmap_update_bits(smi->map,
-                                        RTL8366RB_LED_CTRL_REG,
-                                        0xf << (i * 4),
-                                        val << (i * 4));
-               if (ret)
-                       return ret;
-       }
-
-       ret = rtl8366_reset_vlan(smi);
-       if (ret)
-               return ret;
-
-       ret = rtl8366rb_setup_cascaded_irq(smi);
-       if (ret)
-               dev_info(smi->dev, "no interrupt support\n");
-
-       ret = realtek_smi_setup_mdio(smi);
-       if (ret) {
-               dev_info(smi->dev, "could not set up MDIO bus\n");
-               return -ENODEV;
-       }
-
-       return 0;
-}
-
-static enum dsa_tag_protocol rtl8366_get_tag_protocol(struct dsa_switch *ds,
-                                                     int port,
-                                                     enum dsa_tag_protocol mp)
-{
-       /* This switch uses the 4 byte protocol A Realtek DSA tag */
-       return DSA_TAG_PROTO_RTL4_A;
-}
-
-static void
-rtl8366rb_mac_link_up(struct dsa_switch *ds, int port, unsigned int mode,
-                     phy_interface_t interface, struct phy_device *phydev,
-                     int speed, int duplex, bool tx_pause, bool rx_pause)
-{
-       struct realtek_smi *smi = ds->priv;
-       int ret;
-
-       if (port != smi->cpu_port)
-               return;
-
-       dev_dbg(smi->dev, "MAC link up on CPU port (%d)\n", port);
-
-       /* Force the fixed CPU port into 1Gbit mode, no autonegotiation */
-       ret = regmap_update_bits(smi->map, RTL8366RB_MAC_FORCE_CTRL_REG,
-                                BIT(port), BIT(port));
-       if (ret) {
-               dev_err(smi->dev, "failed to force 1Gbit on CPU port\n");
-               return;
-       }
-
-       ret = regmap_update_bits(smi->map, RTL8366RB_PAACR2,
-                                0xFF00U,
-                                RTL8366RB_PAACR_CPU_PORT << 8);
-       if (ret) {
-               dev_err(smi->dev, "failed to set PAACR on CPU port\n");
-               return;
-       }
-
-       /* Enable the CPU port */
-       ret = regmap_update_bits(smi->map, RTL8366RB_PECR, BIT(port),
-                                0);
-       if (ret) {
-               dev_err(smi->dev, "failed to enable the CPU port\n");
-               return;
-       }
-}
-
-static void
-rtl8366rb_mac_link_down(struct dsa_switch *ds, int port, unsigned int mode,
-                       phy_interface_t interface)
-{
-       struct realtek_smi *smi = ds->priv;
-       int ret;
-
-       if (port != smi->cpu_port)
-               return;
-
-       dev_dbg(smi->dev, "MAC link down on CPU port (%d)\n", port);
-
-       /* Disable the CPU port */
-       ret = regmap_update_bits(smi->map, RTL8366RB_PECR, BIT(port),
-                                BIT(port));
-       if (ret) {
-               dev_err(smi->dev, "failed to disable the CPU port\n");
-               return;
-       }
-}
-
-static void rb8366rb_set_port_led(struct realtek_smi *smi,
-                                 int port, bool enable)
-{
-       u16 val = enable ? 0x3f : 0;
-       int ret;
-
-       if (smi->leds_disabled)
-               return;
-
-       switch (port) {
-       case 0:
-               ret = regmap_update_bits(smi->map,
-                                        RTL8366RB_LED_0_1_CTRL_REG,
-                                        0x3F, val);
-               break;
-       case 1:
-               ret = regmap_update_bits(smi->map,
-                                        RTL8366RB_LED_0_1_CTRL_REG,
-                                        0x3F << RTL8366RB_LED_1_OFFSET,
-                                        val << RTL8366RB_LED_1_OFFSET);
-               break;
-       case 2:
-               ret = regmap_update_bits(smi->map,
-                                        RTL8366RB_LED_2_3_CTRL_REG,
-                                        0x3F, val);
-               break;
-       case 3:
-               ret = regmap_update_bits(smi->map,
-                                        RTL8366RB_LED_2_3_CTRL_REG,
-                                        0x3F << RTL8366RB_LED_3_OFFSET,
-                                        val << RTL8366RB_LED_3_OFFSET);
-               break;
-       case 4:
-               ret = regmap_update_bits(smi->map,
-                                        RTL8366RB_INTERRUPT_CONTROL_REG,
-                                        RTL8366RB_P4_RGMII_LED,
-                                        enable ? RTL8366RB_P4_RGMII_LED : 0);
-               break;
-       default:
-               dev_err(smi->dev, "no LED for port %d\n", port);
-               return;
-       }
-       if (ret)
-               dev_err(smi->dev, "error updating LED on port %d\n", port);
-}
-
-static int
-rtl8366rb_port_enable(struct dsa_switch *ds, int port,
-                     struct phy_device *phy)
-{
-       struct realtek_smi *smi = ds->priv;
-       int ret;
-
-       dev_dbg(smi->dev, "enable port %d\n", port);
-       ret = regmap_update_bits(smi->map, RTL8366RB_PECR, BIT(port),
-                                0);
-       if (ret)
-               return ret;
-
-       rb8366rb_set_port_led(smi, port, true);
-       return 0;
-}
-
-static void
-rtl8366rb_port_disable(struct dsa_switch *ds, int port)
-{
-       struct realtek_smi *smi = ds->priv;
-       int ret;
-
-       dev_dbg(smi->dev, "disable port %d\n", port);
-       ret = regmap_update_bits(smi->map, RTL8366RB_PECR, BIT(port),
-                                BIT(port));
-       if (ret)
-               return;
-
-       rb8366rb_set_port_led(smi, port, false);
-}
-
-static int
-rtl8366rb_port_bridge_join(struct dsa_switch *ds, int port,
-                          struct dsa_bridge bridge,
-                          bool *tx_fwd_offload)
-{
-       struct realtek_smi *smi = ds->priv;
-       unsigned int port_bitmap = 0;
-       int ret, i;
-
-       /* Loop over all other ports than the current one */
-       for (i = 0; i < RTL8366RB_PORT_NUM_CPU; i++) {
-               /* Current port handled last */
-               if (i == port)
-                       continue;
-               /* Not on this bridge */
-               if (!dsa_port_offloads_bridge(dsa_to_port(ds, i), &bridge))
-                       continue;
-               /* Join this port to each other port on the bridge */
-               ret = regmap_update_bits(smi->map, RTL8366RB_PORT_ISO(i),
-                                        RTL8366RB_PORT_ISO_PORTS(BIT(port)),
-                                        RTL8366RB_PORT_ISO_PORTS(BIT(port)));
-               if (ret)
-                       dev_err(smi->dev, "failed to join port %d\n", port);
-
-               port_bitmap |= BIT(i);
-       }
-
-       /* Set the bits for the ports we can access */
-       return regmap_update_bits(smi->map, RTL8366RB_PORT_ISO(port),
-                                 RTL8366RB_PORT_ISO_PORTS(port_bitmap),
-                                 RTL8366RB_PORT_ISO_PORTS(port_bitmap));
-}
-
-static void
-rtl8366rb_port_bridge_leave(struct dsa_switch *ds, int port,
-                           struct dsa_bridge bridge)
-{
-       struct realtek_smi *smi = ds->priv;
-       unsigned int port_bitmap = 0;
-       int ret, i;
-
-       /* Loop over all other ports than this one */
-       for (i = 0; i < RTL8366RB_PORT_NUM_CPU; i++) {
-               /* Current port handled last */
-               if (i == port)
-                       continue;
-               /* Not on this bridge */
-               if (!dsa_port_offloads_bridge(dsa_to_port(ds, i), &bridge))
-                       continue;
-               /* Remove this port from any other port on the bridge */
-               ret = regmap_update_bits(smi->map, RTL8366RB_PORT_ISO(i),
-                                        RTL8366RB_PORT_ISO_PORTS(BIT(port)), 0);
-               if (ret)
-                       dev_err(smi->dev, "failed to leave port %d\n", port);
-
-               port_bitmap |= BIT(i);
-       }
-
-       /* Clear the bits for the ports we can not access, leave ourselves */
-       regmap_update_bits(smi->map, RTL8366RB_PORT_ISO(port),
-                          RTL8366RB_PORT_ISO_PORTS(port_bitmap), 0);
-}
-
-/**
- * rtl8366rb_drop_untagged() - make the switch drop untagged and C-tagged frames
- * @smi: SMI state container
- * @port: the port to drop untagged and C-tagged frames on
- * @drop: whether to drop or pass untagged and C-tagged frames
- *
- * Return: zero for success, a negative number on error.
- */
-static int rtl8366rb_drop_untagged(struct realtek_smi *smi, int port, bool drop)
-{
-       return regmap_update_bits(smi->map, RTL8366RB_VLAN_INGRESS_CTRL1_REG,
-                                 RTL8366RB_VLAN_INGRESS_CTRL1_DROP(port),
-                                 drop ? RTL8366RB_VLAN_INGRESS_CTRL1_DROP(port) : 0);
-}
-
-static int rtl8366rb_vlan_filtering(struct dsa_switch *ds, int port,
-                                   bool vlan_filtering,
-                                   struct netlink_ext_ack *extack)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8366rb *rb;
-       int ret;
-
-       rb = smi->chip_data;
-
-       dev_dbg(smi->dev, "port %d: %s VLAN filtering\n", port,
-               vlan_filtering ? "enable" : "disable");
-
-       /* If the port is not in the member set, the frame will be dropped */
-       ret = regmap_update_bits(smi->map, RTL8366RB_VLAN_INGRESS_CTRL2_REG,
-                                BIT(port), vlan_filtering ? BIT(port) : 0);
-       if (ret)
-               return ret;
-
-       /* If VLAN filtering is enabled and PVID is also enabled, we must
-        * not drop any untagged or C-tagged frames. If we turn off VLAN
-        * filtering on a port, we need to accept any frames.
-        */
-       if (vlan_filtering)
-               ret = rtl8366rb_drop_untagged(smi, port, !rb->pvid_enabled[port]);
-       else
-               ret = rtl8366rb_drop_untagged(smi, port, false);
-
-       return ret;
-}
-
-static int
-rtl8366rb_port_pre_bridge_flags(struct dsa_switch *ds, int port,
-                               struct switchdev_brport_flags flags,
-                               struct netlink_ext_ack *extack)
-{
-       /* We support enabling/disabling learning */
-       if (flags.mask & ~(BR_LEARNING))
-               return -EINVAL;
-
-       return 0;
-}
-
-static int
-rtl8366rb_port_bridge_flags(struct dsa_switch *ds, int port,
-                           struct switchdev_brport_flags flags,
-                           struct netlink_ext_ack *extack)
-{
-       struct realtek_smi *smi = ds->priv;
-       int ret;
-
-       if (flags.mask & BR_LEARNING) {
-               ret = regmap_update_bits(smi->map, RTL8366RB_PORT_LEARNDIS_CTRL,
-                                        BIT(port),
-                                        (flags.val & BR_LEARNING) ? 0 : BIT(port));
-               if (ret)
-                       return ret;
-       }
-
-       return 0;
-}
-
-static void
-rtl8366rb_port_stp_state_set(struct dsa_switch *ds, int port, u8 state)
-{
-       struct realtek_smi *smi = ds->priv;
-       u32 val;
-       int i;
-
-       switch (state) {
-       case BR_STATE_DISABLED:
-               val = RTL8366RB_STP_STATE_DISABLED;
-               break;
-       case BR_STATE_BLOCKING:
-       case BR_STATE_LISTENING:
-               val = RTL8366RB_STP_STATE_BLOCKING;
-               break;
-       case BR_STATE_LEARNING:
-               val = RTL8366RB_STP_STATE_LEARNING;
-               break;
-       case BR_STATE_FORWARDING:
-               val = RTL8366RB_STP_STATE_FORWARDING;
-               break;
-       default:
-               dev_err(smi->dev, "unknown bridge state requested\n");
-               return;
-       }
-
-       /* Set the same status for the port on all the FIDs */
-       for (i = 0; i < RTL8366RB_NUM_FIDS; i++) {
-               regmap_update_bits(smi->map, RTL8366RB_STP_STATE_BASE + i,
-                                  RTL8366RB_STP_STATE_MASK(port),
-                                  RTL8366RB_STP_STATE(port, val));
-       }
-}
-
-static void
-rtl8366rb_port_fast_age(struct dsa_switch *ds, int port)
-{
-       struct realtek_smi *smi = ds->priv;
-
-       /* This will age out any learned L2 entries */
-       regmap_update_bits(smi->map, RTL8366RB_SECURITY_CTRL,
-                          BIT(port), BIT(port));
-       /* Restore the normal state of things */
-       regmap_update_bits(smi->map, RTL8366RB_SECURITY_CTRL,
-                          BIT(port), 0);
-}
-
-static int rtl8366rb_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
-{
-       struct realtek_smi *smi = ds->priv;
-       struct rtl8366rb *rb;
-       unsigned int max_mtu;
-       u32 len;
-       int i;
-
-       /* Cache the per-port MTU setting */
-       rb = smi->chip_data;
-       rb->max_mtu[port] = new_mtu;
-
-       /* Roof out the MTU for the entire switch to the greatest
-        * common denominator: the biggest set for any one port will
-        * be the biggest MTU for the switch.
-        *
-        * The first setting, 1522 bytes, is max IP packet 1500 bytes,
-        * plus ethernet header, 1518 bytes, plus CPU tag, 4 bytes.
-        * This function should consider the parameter an SDU, so the
-        * MTU passed for this setting is 1518 bytes. The same logic
-        * of subtracting the DSA tag of 4 bytes apply to the other
-        * settings.
-        */
-       max_mtu = 1518;
-       for (i = 0; i < RTL8366RB_NUM_PORTS; i++) {
-               if (rb->max_mtu[i] > max_mtu)
-                       max_mtu = rb->max_mtu[i];
-       }
-       if (max_mtu <= 1518)
-               len = RTL8366RB_SGCR_MAX_LENGTH_1522;
-       else if (max_mtu > 1518 && max_mtu <= 1532)
-               len = RTL8366RB_SGCR_MAX_LENGTH_1536;
-       else if (max_mtu > 1532 && max_mtu <= 1548)
-               len = RTL8366RB_SGCR_MAX_LENGTH_1552;
-       else
-               len = RTL8366RB_SGCR_MAX_LENGTH_16000;
-
-       return regmap_update_bits(smi->map, RTL8366RB_SGCR,
-                                 RTL8366RB_SGCR_MAX_LENGTH_MASK,
-                                 len);
-}
-
-static int rtl8366rb_max_mtu(struct dsa_switch *ds, int port)
-{
-       /* The max MTU is 16000 bytes, so we subtract the CPU tag
-        * and the max presented to the system is 15996 bytes.
-        */
-       return 15996;
-}
-
-static int rtl8366rb_get_vlan_4k(struct realtek_smi *smi, u32 vid,
-                                struct rtl8366_vlan_4k *vlan4k)
-{
-       u32 data[3];
-       int ret;
-       int i;
-
-       memset(vlan4k, '\0', sizeof(struct rtl8366_vlan_4k));
-
-       if (vid >= RTL8366RB_NUM_VIDS)
-               return -EINVAL;
-
-       /* write VID */
-       ret = regmap_write(smi->map, RTL8366RB_VLAN_TABLE_WRITE_BASE,
-                          vid & RTL8366RB_VLAN_VID_MASK);
-       if (ret)
-               return ret;
-
-       /* write table access control word */
-       ret = regmap_write(smi->map, RTL8366RB_TABLE_ACCESS_CTRL_REG,
-                          RTL8366RB_TABLE_VLAN_READ_CTRL);
-       if (ret)
-               return ret;
-
-       for (i = 0; i < 3; i++) {
-               ret = regmap_read(smi->map,
-                                 RTL8366RB_VLAN_TABLE_READ_BASE + i,
-                                 &data[i]);
-               if (ret)
-                       return ret;
-       }
-
-       vlan4k->vid = vid;
-       vlan4k->untag = (data[1] >> RTL8366RB_VLAN_UNTAG_SHIFT) &
-                       RTL8366RB_VLAN_UNTAG_MASK;
-       vlan4k->member = data[1] & RTL8366RB_VLAN_MEMBER_MASK;
-       vlan4k->fid = data[2] & RTL8366RB_VLAN_FID_MASK;
-
-       return 0;
-}
-
-static int rtl8366rb_set_vlan_4k(struct realtek_smi *smi,
-                                const struct rtl8366_vlan_4k *vlan4k)
-{
-       u32 data[3];
-       int ret;
-       int i;
-
-       if (vlan4k->vid >= RTL8366RB_NUM_VIDS ||
-           vlan4k->member > RTL8366RB_VLAN_MEMBER_MASK ||
-           vlan4k->untag > RTL8366RB_VLAN_UNTAG_MASK ||
-           vlan4k->fid > RTL8366RB_FIDMAX)
-               return -EINVAL;
-
-       data[0] = vlan4k->vid & RTL8366RB_VLAN_VID_MASK;
-       data[1] = (vlan4k->member & RTL8366RB_VLAN_MEMBER_MASK) |
-                 ((vlan4k->untag & RTL8366RB_VLAN_UNTAG_MASK) <<
-                       RTL8366RB_VLAN_UNTAG_SHIFT);
-       data[2] = vlan4k->fid & RTL8366RB_VLAN_FID_MASK;
-
-       for (i = 0; i < 3; i++) {
-               ret = regmap_write(smi->map,
-                                  RTL8366RB_VLAN_TABLE_WRITE_BASE + i,
-                                  data[i]);
-               if (ret)
-                       return ret;
-       }
-
-       /* write table access control word */
-       ret = regmap_write(smi->map, RTL8366RB_TABLE_ACCESS_CTRL_REG,
-                          RTL8366RB_TABLE_VLAN_WRITE_CTRL);
-
-       return ret;
-}
-
-static int rtl8366rb_get_vlan_mc(struct realtek_smi *smi, u32 index,
-                                struct rtl8366_vlan_mc *vlanmc)
-{
-       u32 data[3];
-       int ret;
-       int i;
-
-       memset(vlanmc, '\0', sizeof(struct rtl8366_vlan_mc));
-
-       if (index >= RTL8366RB_NUM_VLANS)
-               return -EINVAL;
-
-       for (i = 0; i < 3; i++) {
-               ret = regmap_read(smi->map,
-                                 RTL8366RB_VLAN_MC_BASE(index) + i,
-                                 &data[i]);
-               if (ret)
-                       return ret;
-       }
-
-       vlanmc->vid = data[0] & RTL8366RB_VLAN_VID_MASK;
-       vlanmc->priority = (data[0] >> RTL8366RB_VLAN_PRIORITY_SHIFT) &
-               RTL8366RB_VLAN_PRIORITY_MASK;
-       vlanmc->untag = (data[1] >> RTL8366RB_VLAN_UNTAG_SHIFT) &
-               RTL8366RB_VLAN_UNTAG_MASK;
-       vlanmc->member = data[1] & RTL8366RB_VLAN_MEMBER_MASK;
-       vlanmc->fid = data[2] & RTL8366RB_VLAN_FID_MASK;
-
-       return 0;
-}
-
-static int rtl8366rb_set_vlan_mc(struct realtek_smi *smi, u32 index,
-                                const struct rtl8366_vlan_mc *vlanmc)
-{
-       u32 data[3];
-       int ret;
-       int i;
-
-       if (index >= RTL8366RB_NUM_VLANS ||
-           vlanmc->vid >= RTL8366RB_NUM_VIDS ||
-           vlanmc->priority > RTL8366RB_PRIORITYMAX ||
-           vlanmc->member > RTL8366RB_VLAN_MEMBER_MASK ||
-           vlanmc->untag > RTL8366RB_VLAN_UNTAG_MASK ||
-           vlanmc->fid > RTL8366RB_FIDMAX)
-               return -EINVAL;
-
-       data[0] = (vlanmc->vid & RTL8366RB_VLAN_VID_MASK) |
-                 ((vlanmc->priority & RTL8366RB_VLAN_PRIORITY_MASK) <<
-                       RTL8366RB_VLAN_PRIORITY_SHIFT);
-       data[1] = (vlanmc->member & RTL8366RB_VLAN_MEMBER_MASK) |
-                 ((vlanmc->untag & RTL8366RB_VLAN_UNTAG_MASK) <<
-                       RTL8366RB_VLAN_UNTAG_SHIFT);
-       data[2] = vlanmc->fid & RTL8366RB_VLAN_FID_MASK;
-
-       for (i = 0; i < 3; i++) {
-               ret = regmap_write(smi->map,
-                                  RTL8366RB_VLAN_MC_BASE(index) + i,
-                                  data[i]);
-               if (ret)
-                       return ret;
-       }
-
-       return 0;
-}
-
-static int rtl8366rb_get_mc_index(struct realtek_smi *smi, int port, int *val)
-{
-       u32 data;
-       int ret;
-
-       if (port >= smi->num_ports)
-               return -EINVAL;
-
-       ret = regmap_read(smi->map, RTL8366RB_PORT_VLAN_CTRL_REG(port),
-                         &data);
-       if (ret)
-               return ret;
-
-       *val = (data >> RTL8366RB_PORT_VLAN_CTRL_SHIFT(port)) &
-               RTL8366RB_PORT_VLAN_CTRL_MASK;
-
-       return 0;
-}
-
-static int rtl8366rb_set_mc_index(struct realtek_smi *smi, int port, int index)
-{
-       struct rtl8366rb *rb;
-       bool pvid_enabled;
-       int ret;
-
-       rb = smi->chip_data;
-       pvid_enabled = !!index;
-
-       if (port >= smi->num_ports || index >= RTL8366RB_NUM_VLANS)
-               return -EINVAL;
-
-       ret = regmap_update_bits(smi->map, RTL8366RB_PORT_VLAN_CTRL_REG(port),
-                               RTL8366RB_PORT_VLAN_CTRL_MASK <<
-                                       RTL8366RB_PORT_VLAN_CTRL_SHIFT(port),
-                               (index & RTL8366RB_PORT_VLAN_CTRL_MASK) <<
-                                       RTL8366RB_PORT_VLAN_CTRL_SHIFT(port));
-       if (ret)
-               return ret;
-
-       rb->pvid_enabled[port] = pvid_enabled;
-
-       /* If VLAN filtering is enabled and PVID is also enabled, we must
-        * not drop any untagged or C-tagged frames. Make sure to update the
-        * filtering setting.
-        */
-       if (dsa_port_is_vlan_filtering(dsa_to_port(smi->ds, port)))
-               ret = rtl8366rb_drop_untagged(smi, port, !pvid_enabled);
-
-       return ret;
-}
-
-static bool rtl8366rb_is_vlan_valid(struct realtek_smi *smi, unsigned int vlan)
-{
-       unsigned int max = RTL8366RB_NUM_VLANS - 1;
-
-       if (smi->vlan4k_enabled)
-               max = RTL8366RB_NUM_VIDS - 1;
-
-       if (vlan > max)
-               return false;
-
-       return true;
-}
-
-static int rtl8366rb_enable_vlan(struct realtek_smi *smi, bool enable)
-{
-       dev_dbg(smi->dev, "%s VLAN\n", enable ? "enable" : "disable");
-       return regmap_update_bits(smi->map,
-                                 RTL8366RB_SGCR, RTL8366RB_SGCR_EN_VLAN,
-                                 enable ? RTL8366RB_SGCR_EN_VLAN : 0);
-}
-
-static int rtl8366rb_enable_vlan4k(struct realtek_smi *smi, bool enable)
-{
-       dev_dbg(smi->dev, "%s VLAN 4k\n", enable ? "enable" : "disable");
-       return regmap_update_bits(smi->map, RTL8366RB_SGCR,
-                                 RTL8366RB_SGCR_EN_VLAN_4KTB,
-                                 enable ? RTL8366RB_SGCR_EN_VLAN_4KTB : 0);
-}
-
-static int rtl8366rb_phy_read(struct realtek_smi *smi, int phy, int regnum)
-{
-       u32 val;
-       u32 reg;
-       int ret;
-
-       if (phy > RTL8366RB_PHY_NO_MAX)
-               return -EINVAL;
-
-       ret = regmap_write(smi->map, RTL8366RB_PHY_ACCESS_CTRL_REG,
-                          RTL8366RB_PHY_CTRL_READ);
-       if (ret)
-               return ret;
-
-       reg = 0x8000 | (1 << (phy + RTL8366RB_PHY_NO_OFFSET)) | regnum;
-
-       ret = regmap_write(smi->map, reg, 0);
-       if (ret) {
-               dev_err(smi->dev,
-                       "failed to write PHY%d reg %04x @ %04x, ret %d\n",
-                       phy, regnum, reg, ret);
-               return ret;
-       }
-
-       ret = regmap_read(smi->map, RTL8366RB_PHY_ACCESS_DATA_REG, &val);
-       if (ret)
-               return ret;
-
-       dev_dbg(smi->dev, "read PHY%d register 0x%04x @ %08x, val <- %04x\n",
-               phy, regnum, reg, val);
-
-       return val;
-}
-
-static int rtl8366rb_phy_write(struct realtek_smi *smi, int phy, int regnum,
-                              u16 val)
-{
-       u32 reg;
-       int ret;
-
-       if (phy > RTL8366RB_PHY_NO_MAX)
-               return -EINVAL;
-
-       ret = regmap_write(smi->map, RTL8366RB_PHY_ACCESS_CTRL_REG,
-                          RTL8366RB_PHY_CTRL_WRITE);
-       if (ret)
-               return ret;
-
-       reg = 0x8000 | (1 << (phy + RTL8366RB_PHY_NO_OFFSET)) | regnum;
-
-       dev_dbg(smi->dev, "write PHY%d register 0x%04x @ %04x, val -> %04x\n",
-               phy, regnum, reg, val);
-
-       ret = regmap_write(smi->map, reg, val);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-static int rtl8366rb_reset_chip(struct realtek_smi *smi)
-{
-       int timeout = 10;
-       u32 val;
-       int ret;
-
-       realtek_smi_write_reg_noack(smi, RTL8366RB_RESET_CTRL_REG,
-                                   RTL8366RB_CHIP_CTRL_RESET_HW);
-       do {
-               usleep_range(20000, 25000);
-               ret = regmap_read(smi->map, RTL8366RB_RESET_CTRL_REG, &val);
-               if (ret)
-                       return ret;
-
-               if (!(val & RTL8366RB_CHIP_CTRL_RESET_HW))
-                       break;
-       } while (--timeout);
-
-       if (!timeout) {
-               dev_err(smi->dev, "timeout waiting for the switch to reset\n");
-               return -EIO;
-       }
-
-       return 0;
-}
-
-static int rtl8366rb_detect(struct realtek_smi *smi)
-{
-       struct device *dev = smi->dev;
-       int ret;
-       u32 val;
-
-       /* Detect device */
-       ret = regmap_read(smi->map, 0x5c, &val);
-       if (ret) {
-               dev_err(dev, "can't get chip ID (%d)\n", ret);
-               return ret;
-       }
-
-       switch (val) {
-       case 0x6027:
-               dev_info(dev, "found an RTL8366S switch\n");
-               dev_err(dev, "this switch is not yet supported, submit patches!\n");
-               return -ENODEV;
-       case 0x5937:
-               dev_info(dev, "found an RTL8366RB switch\n");
-               smi->cpu_port = RTL8366RB_PORT_NUM_CPU;
-               smi->num_ports = RTL8366RB_NUM_PORTS;
-               smi->num_vlan_mc = RTL8366RB_NUM_VLANS;
-               smi->mib_counters = rtl8366rb_mib_counters;
-               smi->num_mib_counters = ARRAY_SIZE(rtl8366rb_mib_counters);
-               break;
-       default:
-               dev_info(dev, "found an Unknown Realtek switch (id=0x%04x)\n",
-                        val);
-               break;
-       }
-
-       ret = rtl8366rb_reset_chip(smi);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-
-static const struct dsa_switch_ops rtl8366rb_switch_ops = {
-       .get_tag_protocol = rtl8366_get_tag_protocol,
-       .setup = rtl8366rb_setup,
-       .phylink_mac_link_up = rtl8366rb_mac_link_up,
-       .phylink_mac_link_down = rtl8366rb_mac_link_down,
-       .get_strings = rtl8366_get_strings,
-       .get_ethtool_stats = rtl8366_get_ethtool_stats,
-       .get_sset_count = rtl8366_get_sset_count,
-       .port_bridge_join = rtl8366rb_port_bridge_join,
-       .port_bridge_leave = rtl8366rb_port_bridge_leave,
-       .port_vlan_filtering = rtl8366rb_vlan_filtering,
-       .port_vlan_add = rtl8366_vlan_add,
-       .port_vlan_del = rtl8366_vlan_del,
-       .port_enable = rtl8366rb_port_enable,
-       .port_disable = rtl8366rb_port_disable,
-       .port_pre_bridge_flags = rtl8366rb_port_pre_bridge_flags,
-       .port_bridge_flags = rtl8366rb_port_bridge_flags,
-       .port_stp_state_set = rtl8366rb_port_stp_state_set,
-       .port_fast_age = rtl8366rb_port_fast_age,
-       .port_change_mtu = rtl8366rb_change_mtu,
-       .port_max_mtu = rtl8366rb_max_mtu,
-};
-
-static const struct realtek_smi_ops rtl8366rb_smi_ops = {
-       .detect         = rtl8366rb_detect,
-       .get_vlan_mc    = rtl8366rb_get_vlan_mc,
-       .set_vlan_mc    = rtl8366rb_set_vlan_mc,
-       .get_vlan_4k    = rtl8366rb_get_vlan_4k,
-       .set_vlan_4k    = rtl8366rb_set_vlan_4k,
-       .get_mc_index   = rtl8366rb_get_mc_index,
-       .set_mc_index   = rtl8366rb_set_mc_index,
-       .get_mib_counter = rtl8366rb_get_mib_counter,
-       .is_vlan_valid  = rtl8366rb_is_vlan_valid,
-       .enable_vlan    = rtl8366rb_enable_vlan,
-       .enable_vlan4k  = rtl8366rb_enable_vlan4k,
-       .phy_read       = rtl8366rb_phy_read,
-       .phy_write      = rtl8366rb_phy_write,
-};
-
-const struct realtek_smi_variant rtl8366rb_variant = {
-       .ds_ops = &rtl8366rb_switch_ops,
-       .ops = &rtl8366rb_smi_ops,
-       .clk_delay = 10,
-       .cmd_read = 0xa9,
-       .cmd_write = 0xa8,
-       .chip_data_sz = sizeof(struct rtl8366rb),
-};
-EXPORT_SYMBOL_GPL(rtl8366rb_variant);