]> git.baikalelectronics.ru Git - kernel.git/commitdiff
media: v4l: vsp1: Fix uif null pointer access
authorBiju Das <biju.das.jz@bp.renesas.com>
Mon, 1 Mar 2021 12:08:28 +0000 (13:08 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Mar 2021 10:40:29 +0000 (11:40 +0100)
RZ/G2L SoC has no UIF. This patch fixes null pointer access, when UIF
module is not used.

Fixes: b5a8cabde2d5a("media: v4l: vsp1: Integrate DISCOM in display pipeline")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/vsp1/vsp1_drm.c

index f6d2f47a4058fa28ed82febbe3e5b51776090279..06f74d410973eb3284142f66c261305404deda61 100644 (file)
@@ -462,9 +462,9 @@ static int vsp1_du_pipeline_setup_inputs(struct vsp1_device *vsp1,
         * make sure it is present in the pipeline's list of entities if it
         * wasn't already.
         */
-       if (!use_uif) {
+       if (drm_pipe->uif && !use_uif) {
                drm_pipe->uif->pipe = NULL;
-       } else if (!drm_pipe->uif->pipe) {
+       } else if (drm_pipe->uif && !drm_pipe->uif->pipe) {
                drm_pipe->uif->pipe = pipe;
                list_add_tail(&drm_pipe->uif->list_pipe, &pipe->entities);
        }