]> git.baikalelectronics.ru Git - kernel.git/commitdiff
lib/test_bitmap: name EXP_BYTES properly
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 5 Dec 2019 00:53:13 +0000 (16:53 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 5 Dec 2019 03:44:14 +0000 (19:44 -0800)
EXP_BYTES has been wrongly named.  It's a size of the exp array in bits.

While here, go ahead and rename to EXP1_IN_BITS to avoid double renaming
when exp will be renamed to exp1 in the next patch

Link: http://lkml.kernel.org/r/20191022172922.61232-4-andriy.shevchenko@linux.intel.com
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: Yury Norov <yury.norov@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/test_bitmap.c

index d2fa94e45a46ddc400fef47ae5365a2069cababb..38f923411ada376cbeb4aaf8487a3c0368dc3ed2 100644 (file)
@@ -374,17 +374,17 @@ static void __init test_bitmap_parselist_user(void)
        __test_bitmap_parselist(1);
 }
 
-#define EXP_BYTES      (sizeof(exp) * 8)
+#define EXP1_IN_BITS   (sizeof(exp) * 8)
 
 static void __init test_bitmap_arr32(void)
 {
        unsigned int nbits, next_bit;
-       u32 arr[sizeof(exp) / 4];
-       DECLARE_BITMAP(bmap2, EXP_BYTES);
+       u32 arr[EXP1_IN_BITS / 32];
+       DECLARE_BITMAP(bmap2, EXP1_IN_BITS);
 
        memset(arr, 0xa5, sizeof(arr));
 
-       for (nbits = 0; nbits < EXP_BYTES; ++nbits) {
+       for (nbits = 0; nbits < EXP1_IN_BITS; ++nbits) {
                bitmap_to_arr32(arr, exp, nbits);
                bitmap_from_arr32(bmap2, arr, nbits);
                expect_eq_bitmap(bmap2, exp, nbits);
@@ -396,7 +396,7 @@ static void __init test_bitmap_arr32(void)
                                " tail is not safely cleared: %d\n",
                                nbits, next_bit);
 
-               if (nbits < EXP_BYTES - 32)
+               if (nbits < EXP1_IN_BITS - 32)
                        expect_eq_uint(arr[DIV_ROUND_UP(nbits, 32)],
                                                                0xa5a5a5a5);
        }