]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: systemport: Fix an error handling path in bcm_sysport_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 15 May 2022 17:01:56 +0000 (19:01 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 17 May 2022 08:38:52 +0000 (10:38 +0200)
if devm_clk_get_optional() fails, we still need to go through the error
handling path.

Add the missing goto.

Fixes: 6cbd0f3bbaa0b ("net: systemport: Manage Wake-on-LAN clock")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/99d70634a81c229885ae9e4ee69b2035749f7edc.1652634040.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/broadcom/bcmsysport.c

index 60dde29974bfea53f8092fda078f348d36c6a6ef..df51be3cbe06906550c627c3265657fc1828a92a 100644 (file)
@@ -2585,8 +2585,10 @@ static int bcm_sysport_probe(struct platform_device *pdev)
                device_set_wakeup_capable(&pdev->dev, 1);
 
        priv->wol_clk = devm_clk_get_optional(&pdev->dev, "sw_sysportwol");
-       if (IS_ERR(priv->wol_clk))
-               return PTR_ERR(priv->wol_clk);
+       if (IS_ERR(priv->wol_clk)) {
+               ret = PTR_ERR(priv->wol_clk);
+               goto err_deregister_fixed_link;
+       }
 
        /* Set the needed headroom once and for all */
        BUILD_BUG_ON(sizeof(struct bcm_tsb) != 8);