]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate
authorJonathan Liu <net147@gmail.com>
Tue, 9 Jan 2018 02:03:22 +0000 (13:03 +1100)
committerMaxime Ripard <maxime.ripard@free-electrons.com>
Thu, 11 Jan 2018 12:25:23 +0000 (13:25 +0100)
best_div is set to i which corresponds to rate halving when it should be
set to j which corresponds to the divider.

Fixes: 6c088b7a3095 ("drm/sun4i: Add HDMI support")
Signed-off-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180109020323.11852-3-net147@gmail.com
drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c

index 4d235e5ea31c085fac3e6a6fd6fb372eb79a042b..88eeeaf3463864d8f59fe5114c0e946d3a79469c 100644 (file)
@@ -105,7 +105,7 @@ static int sun4i_tmds_determine_rate(struct clk_hw *hw,
                                if (!best_parent || abs(rate - rounded / i) <
                                    abs(rate - best_parent / best_div)) {
                                        best_parent = rounded;
-                                       best_div = i;
+                                       best_div = j;
                                }
                        }
                }