]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: tun: Remove redundant assignment to ret
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 28 Apr 2021 09:57:32 +0000 (17:57 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 28 Apr 2021 20:58:58 +0000 (13:58 -0700)
Variable 'ret' is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

drivers/net/tun.c:3008:2: warning: Value stored to 'ret' is never read
[clang-analyzer-deadcode.DeadStores]

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1619603852-114996-1-git-send-email-yang.lee@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/tun.c

index 36443d506b67b7af841d5a23120caae2630e4695..84f832806313697f2586a84e6aa3ca63f072fe67 100644 (file)
@@ -3008,7 +3008,6 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
                return open_related_ns(&net->ns, get_net_ns);
        }
 
-       ret = 0;
        rtnl_lock();
 
        tun = tun_get(tfile);