net: sched: cls_u32: use bitwise & rather than logical && on n->flags

Currently n->flags is being operated on by a logical && operator rather
than a bitwise & operator. This looks incorrect as these should be bit
flag operations. Fix this.

Detected by CoverityScan, CID#1460398 ("Logical vs. bitwise operator")

Fixes: 565820d9b2bd ("net: sched: cls_u32: call block callbacks for offload")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c
index 86145867b42463844fb4b68f141d831c38851770..2737b71854c97a6315c498ec5c143de854d695d1 100644 (file)
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -572,7 +572,7 @@ static int u32_replace_hw_knode(struct tcf_proto *tp, struct tc_u_knode *n,
                n->flags |= TCA_CLS_FLAGS_IN_HW;
        }
 
-       if (skip_sw && !(n->flags && TCA_CLS_FLAGS_IN_HW))
+       if (skip_sw && !(n->flags & TCA_CLS_FLAGS_IN_HW))
                return -EINVAL;
 
        return 0;