]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ARM: 9208/1: entry: add .ltorg directive to keep literals in range
authorArd Biesheuvel <ardb@kernel.org>
Tue, 31 May 2022 08:49:24 +0000 (09:49 +0100)
committerRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thu, 14 Jul 2022 12:19:51 +0000 (13:19 +0100)
LKP reports a build issue on Clang, related to a literal load of
__current issued through the ldr_va macro. This turns out to be due to
the fact that group relocations are disabled when CONFIG_COMPILE_TEST=y,
which means that the ldr_va macro resolves to a pair of LDR
instructions, the first one being a literal load issued too far from its
literal pool.

Due to the introduction of a couple of new uses of this macro in commit
508074607c7b95b2 ("ARM: 9195/1: entry: avoid explicit literal loads"),
the literal pools end up getting rearranged in a way that causes the
literal for __current to go out of range. Let's fix this up by putting a
.ltorg directive in a suitable place in the code.

Link: https://lore.kernel.org/all/202205290805.1vZLAr36-lkp@intel.com/
Fixes: 508074607c7b95b2 ("ARM: 9195/1: entry: avoid explicit literal loads")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
arch/arm/kernel/entry-common.S

index 7aa3ded4af9292d006e2346efa554187467aa393..6a447ac67d80df7d8e79b60ad7e0d13d6076785d 100644 (file)
@@ -302,6 +302,7 @@ local_restart:
        b       ret_fast_syscall
 #endif
 ENDPROC(vector_swi)
+       .ltorg
 
        /*
         * This is the really slow path.  We're going to be doing