]> git.baikalelectronics.ru Git - kernel.git/commitdiff
can: ctucanfd: remove PCI module debug parameters
authorPavel Pisa <pisa@cmp.felk.cvut.cz>
Sun, 24 Apr 2022 16:28:08 +0000 (18:28 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Mon, 2 May 2022 07:24:41 +0000 (09:24 +0200)
This patch removes the PCI module debug parameters, which are not
needed anymore, to make both checkpatch.pl and patchwork happy.

Link: https://lore.kernel.org/all/1fd684bcf5ddb0346aad234072f54e976a5210fb.1650816929.git.pisa@cmp.felk.cvut.cz
Signed-off-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
[mkl: split into separate patches]
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/ctucanfd/ctucanfd_pci.c

index c37a4248053342bcf8a8644d48a611d0baa9bd80..8f2956a8ae43306ef56dded916b1ac92e4b9035a 100644 (file)
 #define CTUCAN_WITHOUT_CTUCAN_ID  0
 #define CTUCAN_WITH_CTUCAN_ID     1
 
-static bool use_msi = true;
-module_param(use_msi, bool, 0444);
-MODULE_PARM_DESC(use_msi, "PCIe implementation use MSI interrupts. Default: 1 (yes)");
-
-static bool pci_use_second = true;
-module_param(pci_use_second, bool, 0444);
-MODULE_PARM_DESC(pci_use_second, "Use the second CAN core on PCIe card. Default: 1 (yes)");
-
 struct ctucan_pci_board_data {
        void __iomem *bar0_base;
        void __iomem *cra_base;
@@ -117,13 +109,11 @@ static int ctucan_pci_probe(struct pci_dev *pdev,
                goto err_disable_device;
        }
 
-       if (use_msi) {
-               ret = pci_enable_msi(pdev);
-               if (!ret) {
-                       dev_info(dev, "MSI enabled\n");
-                       pci_set_master(pdev);
-                       msi_ok = 1;
-               }
+       ret = pci_enable_msi(pdev);
+       if (!ret) {
+               dev_info(dev, "MSI enabled\n");
+               pci_set_master(pdev);
+               msi_ok = 1;
        }
 
        dev_info(dev, "ctucan BAR0 0x%08llx 0x%08llx\n",
@@ -184,7 +174,7 @@ static int ctucan_pci_probe(struct pci_dev *pdev,
 
        core_i++;
 
-       while (pci_use_second && (core_i < num_cores)) {
+       while (core_i < num_cores) {
                addr += 0x4000;
                ret = ctucan_probe_common(dev, addr, irq, ntxbufs, 100000000,
                                          0, ctucan_pci_set_drvdata);