net/mlx5: IPsec, Fix esp modify function attribute

The function mlx5_fpga_esp_validate_xfrm_attrs is wrongly used
with negative negation as zero value indicates success but it
used as failure return value instead.

Fix by remove the unary not negation operator.

Fixes: 0583150d18d2 ("net/mlx5: Add flow-steering commands for FPGA IPSec implementation")
Signed-off-by: Raed Salem <raeds@mellanox.com>
Reviewed-by: Boris Pismenny <borisp@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c b/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c
index e4ec0e03c289490f2c96f93e5a73757e51d3deef..4ed4d4d8e073304070671eef6fc488943feaec01 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/fpga/ipsec.c
@@ -1478,7 +1478,7 @@ int mlx5_fpga_esp_modify_xfrm(struct mlx5_accel_esp_xfrm *xfrm,
        if (!memcmp(&xfrm->attrs, attrs, sizeof(xfrm->attrs)))
                return 0;
 
-       if (!mlx5_fpga_esp_validate_xfrm_attrs(mdev, attrs)) {
+       if (mlx5_fpga_esp_validate_xfrm_attrs(mdev, attrs)) {
                mlx5_core_warn(mdev, "Tried to create an esp with unsupported attrs\n");
                return -EOPNOTSUPP;
        }