]> git.baikalelectronics.ru Git - kernel.git/commitdiff
Revert "gdrom: fix a memory leak bug"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 3 May 2021 11:56:53 +0000 (13:56 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 May 2021 15:33:30 +0000 (17:33 +0200)
This reverts commit 7b89babc4ca6e715ad624927c4ccf3d9f17c231a.

Because of recent interactions with developers from @umn.edu, all
commits from them have been recently re-reviewed to ensure if they were
correct or not.

Upon review, this commit was found to be incorrect for the reasons
below, so it must be reverted.  It will be fixed up "correctly" in a
later kernel change.

Because of this, all submissions from this group must be reverted from
the kernel tree and will need to be re-reviewed again to determine if
they actually are a valid fix.  Until that work is complete, remove this
change to ensure that no problems are being introduced into the
codebase.

Cc: Wenwen Wang <wang6495@umn.edu>
Cc: Peter Rosin <peda@axentia.se>
Cc: Jens Axboe <axboe@kernel.dk>
Fixes: 7b89babc4ca6 ("gdrom: fix a memory leak bug")
Cc: stable <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210503115736.2104747-27-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/cdrom/gdrom.c

index 742b4a0932e3da962c802ed10703440ec7ccd00b..7f681320c7d3f6e5c16b9d7ccdbb1d421d331cbb 100644 (file)
@@ -862,7 +862,6 @@ static void __exit exit_gdrom(void)
        platform_device_unregister(pd);
        platform_driver_unregister(&gdrom_driver);
        kfree(gd.toc);
-       kfree(gd.cd_info);
 }
 
 module_init(init_gdrom);