]> git.baikalelectronics.ru Git - kernel.git/commitdiff
PCI: altera-msi: Remove redundant dev_err call in altera_msi_probe()
authorChen Hui <clare.chenhui@huawei.com>
Fri, 9 Apr 2021 07:57:48 +0000 (15:57 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Wed, 14 Apr 2021 16:45:11 +0000 (17:45 +0100)
There is a error message within devm_ioremap_resource()
already, so remove the dev_err() call to avoid redundant
error message.

Link: https://lore.kernel.org/r/20210409075748.226141-1-clare.chenhui@huawei.com
Signed-off-by: Chen Hui <clare.chenhui@huawei.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Ley Foon Tan <ley.foon.tan@intel.com>
drivers/pci/controller/pcie-altera-msi.c

index 42691dd8ebef3bba69cf0e766683e8e3cf447710..98aa1dccc6e6858bec085f65b1c02b64c162e68e 100644 (file)
@@ -236,10 +236,8 @@ static int altera_msi_probe(struct platform_device *pdev)
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
                                           "vector_slave");
        msi->vector_base = devm_ioremap_resource(&pdev->dev, res);
-       if (IS_ERR(msi->vector_base)) {
-               dev_err(&pdev->dev, "failed to map vector_slave memory\n");
+       if (IS_ERR(msi->vector_base))
                return PTR_ERR(msi->vector_base);
-       }
 
        msi->vector_phy = res->start;