]> git.baikalelectronics.ru Git - kernel.git/commitdiff
md/raid5-ppl: Drop unused argument from ppl_handle_flush_request()
authorLogan Gunthorpe <logang@deltatee.com>
Wed, 8 Jun 2022 16:27:48 +0000 (10:27 -0600)
committerJens Axboe <axboe@kernel.dk>
Tue, 2 Aug 2022 23:14:31 +0000 (17:14 -0600)
ppl_handle_flush_request() takes an struct r5log argument but doesn't
use it. It has no buisiness taking this argument as it is only used
by raid5-cache and has no way to derference it anyway. Remove
the argument.

No functional changes intended.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Song Liu <song@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/raid5-log.h
drivers/md/raid5-ppl.c

index 270ced4f770f29e917ccabbaa151ee895f352dba..c8332502669e5612f8628dcd13d8fe33cfa7b505 100644 (file)
@@ -41,7 +41,7 @@ void ppl_write_stripe_run(struct r5conf *conf);
 void ppl_stripe_write_finished(struct stripe_head *sh);
 int ppl_modify_log(struct r5conf *conf, struct md_rdev *rdev, bool add);
 void ppl_quiesce(struct r5conf *conf, int quiesce);
-int ppl_handle_flush_request(struct r5l_log *log, struct bio *bio);
+int ppl_handle_flush_request(struct bio *bio);
 extern struct md_sysfs_entry ppl_write_hint;
 
 static inline bool raid5_has_log(struct r5conf *conf)
@@ -108,7 +108,7 @@ static inline int log_handle_flush_request(struct r5conf *conf, struct bio *bio)
        if (conf->log)
                ret = r5l_handle_flush_request(conf->log, bio);
        else if (raid5_has_ppl(conf))
-               ret = ppl_handle_flush_request(conf->log, bio);
+               ret = ppl_handle_flush_request(bio);
 
        return ret;
 }
index 98988cb26295e3a78210cb72ac539c08eab73589..31b9157bc9ae92a0d83ad7126ebfa1e6b2b56023 100644 (file)
@@ -679,7 +679,7 @@ void ppl_quiesce(struct r5conf *conf, int quiesce)
        }
 }
 
-int ppl_handle_flush_request(struct r5l_log *log, struct bio *bio)
+int ppl_handle_flush_request(struct bio *bio)
 {
        if (bio->bi_iter.bi_size == 0) {
                bio_endio(bio);