media: tuners: qt1010: replace BUG_ON with a regular error

[ Upstream commit ee630b29ea44d1851bb6c903f400956604834463 ]

BUG_ON is unnecessary here, and in addition it confuses smatch.
Replacing this with an error return help resolve this smatch
warning:

drivers/media/tuners/qt1010.c:350 qt1010_init() error: buffer overflow 'i2c_data' 34 <= 34

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/media/tuners/qt1010.c b/drivers/media/tuners/qt1010.c
index 60931367b82ca7abc52dbd9994a5b6e24ea5fcdf..48fc79cd402733aec6d3fdef8a99eb2327cd9eee 100644 (file)
--- a/drivers/media/tuners/qt1010.c
+++ b/drivers/media/tuners/qt1010.c
@@ -345,11 +345,12 @@ static int qt1010_init(struct dvb_frontend *fe)
                        else
                                valptr = &tmpval;
 
-                       BUG_ON(i >= ARRAY_SIZE(i2c_data) - 1);
-
-                       err = qt1010_init_meas1(priv, i2c_data[i+1].reg,
-                                               i2c_data[i].reg,
-                                               i2c_data[i].val, valptr);
+                       if (i >= ARRAY_SIZE(i2c_data) - 1)
+                               err = -EIO;
+                       else
+                               err = qt1010_init_meas1(priv, i2c_data[i + 1].reg,
+                                                       i2c_data[i].reg,
+                                                       i2c_data[i].val, valptr);
                        i++;
                        break;
                }