]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: ipa: fix page free in ipa_endpoint_trans_release()
authorAlex Elder <elder@linaro.org>
Thu, 26 May 2022 15:23:13 +0000 (10:23 -0500)
committerJakub Kicinski <kuba@kernel.org>
Sat, 28 May 2022 01:29:50 +0000 (18:29 -0700)
Currently the (possibly compound) page used for receive buffers are
freed using __free_pages().  But according to this comment above the
definition of that function, that's wrong:
    If you want to use the page's reference count to decide when
    to free the allocation, you should allocate a compound page,
    and use put_page() instead of __free_pages().

Convert the call to __free_pages() in ipa_endpoint_trans_release()
to use put_page() instead.

Fixes: dba332f083142 ("net: ipa: define per-endpoint receive buffer size")
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/ipa_endpoint.c

index 385aa63ab4bbc62213db766ab9352774b33443c5..e92aa9447f6e7b3f4fc6669368c844b9681778c8 100644 (file)
@@ -1418,11 +1418,8 @@ void ipa_endpoint_trans_release(struct ipa_endpoint *endpoint,
        } else {
                struct page *page = trans->data;
 
-               if (page) {
-                       u32 buffer_size = endpoint->config.rx.buffer_size;
-
-                       __free_pages(page, get_order(buffer_size));
-               }
+               if (page)
+                       put_page(page);
        }
 }