]> git.baikalelectronics.ru Git - kernel.git/commitdiff
usb: musb: Fix missing of_node_put() in omap2430_probe
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 9 Mar 2022 11:10:33 +0000 (11:10 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 21 Apr 2022 17:20:28 +0000 (19:20 +0200)
The device_node pointer is returned by of_parse_phandle() with refcount
incremented. We should use of_node_put() on it when done.

Fixes: 55793d272587 ("usb: musb: omap2430: Don't use omap_get_control_dev()")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220309111033.24487-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/musb/omap2430.c

index d2b7e613eb34f0df4cac9a5250016430fb64b62b..f571a65ae6ee231a0385a8d8efeff18bf56ba9a0 100644 (file)
@@ -362,6 +362,7 @@ static int omap2430_probe(struct platform_device *pdev)
        control_node = of_parse_phandle(np, "ctrl-module", 0);
        if (control_node) {
                control_pdev = of_find_device_by_node(control_node);
+               of_node_put(control_node);
                if (!control_pdev) {
                        dev_err(&pdev->dev, "Failed to get control device\n");
                        ret = -EINVAL;