]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: qla2xxx: Turn off multi-queue for 8G adapters
authorQuinn Tran <qutran@marvell.com>
Thu, 16 Jun 2022 05:35:01 +0000 (22:35 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 17 Jun 2022 01:59:53 +0000 (21:59 -0400)
For 8G adapters, multi-queue was enabled accidentally. Make sure
multi-queue is not enabled.

Link: https://lore.kernel.org/r/20220616053508.27186-5-njavali@marvell.com
Cc: stable@vger.kernel.org
Signed-off-by: Quinn Tran <qutran@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_def.h
drivers/scsi/qla2xxx/qla_isr.c

index 74d4234e5a312fc5dd88ac95b7aec3b371ab48c0..89cb6c24258dc539c99c807190f78497d5c712fb 100644 (file)
@@ -4273,8 +4273,8 @@ struct qla_hw_data {
 #define IS_OEM_001(ha)          ((ha)->device_type & DT_OEM_001)
 #define HAS_EXTENDED_IDS(ha)    ((ha)->device_type & DT_EXTENDED_IDS)
 #define IS_CT6_SUPPORTED(ha)   ((ha)->device_type & DT_CT6_SUPPORTED)
-#define IS_MQUE_CAPABLE(ha)    ((ha)->mqenable || IS_QLA83XX(ha) || \
-                               IS_QLA27XX(ha) || IS_QLA28XX(ha))
+#define IS_MQUE_CAPABLE(ha)    (IS_QLA83XX(ha) || IS_QLA27XX(ha) || \
+                                IS_QLA28XX(ha))
 #define IS_BIDI_CAPABLE(ha) \
     (IS_QLA25XX(ha) || IS_QLA2031(ha) || IS_QLA27XX(ha) || IS_QLA28XX(ha))
 /* Bit 21 of fw_attributes decides the MCTP capabilities */
index 9af9b35edc27e2f0bbba7c6b3cf4847a27b22055..24f9a3b116d8366144184de22255c1f1ae7e0e66 100644 (file)
@@ -4430,16 +4430,12 @@ msix_register_fail:
        }
 
        /* Enable MSI-X vector for response queue update for queue 0 */
-       if (IS_QLA83XX(ha) || IS_QLA27XX(ha) || IS_QLA28XX(ha)) {
-               if (ha->msixbase && ha->mqiobase &&
-                   (ha->max_rsp_queues > 1 || ha->max_req_queues > 1 ||
-                    ql2xmqsupport))
-                       ha->mqenable = 1;
-       } else
-               if (ha->mqiobase &&
-                   (ha->max_rsp_queues > 1 || ha->max_req_queues > 1 ||
-                    ql2xmqsupport))
-                       ha->mqenable = 1;
+       if (IS_MQUE_CAPABLE(ha) &&
+           (ha->msixbase && ha->mqiobase && ha->max_qpairs))
+               ha->mqenable = 1;
+       else
+               ha->mqenable = 0;
+
        ql_dbg(ql_dbg_multiq, vha, 0xc005,
            "mqiobase=%p, max_rsp_queues=%d, max_req_queues=%d.\n",
            ha->mqiobase, ha->max_rsp_queues, ha->max_req_queues);