]> git.baikalelectronics.ru Git - kernel.git/commitdiff
cxl/pmem: Use size_add() against integer overflow
authorYu Zhe <yuzhe@nfschina.com>
Tue, 27 Sep 2022 07:02:47 +0000 (15:02 +0800)
committerDan Williams <dan.j.williams@intel.com>
Thu, 3 Nov 2022 18:20:46 +0000 (11:20 -0700)
"struct_size() + n" may cause a integer overflow,
use size_add() to handle it.

Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
Link: https://lore.kernel.org/r/20220927070247.23148-1-yuzhe@nfschina.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/pmem.c

index 115a7b79f343960fcb562074bb51b6b245a8e2a0..0bac05d804bc5fa5a8f1046f28c31beeedfc0832 100644 (file)
@@ -148,7 +148,7 @@ static int cxl_pmem_set_config_data(struct cxl_dev_state *cxlds,
                return -EINVAL;
 
        /* 4-byte status follows the input data in the payload */
-       if (struct_size(cmd, in_buf, cmd->in_length) + 4 > buf_len)
+       if (size_add(struct_size(cmd, in_buf, cmd->in_length), 4) > buf_len)
                return -EINVAL;
 
        set_lsa =