]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: hns3: clean up some incorrect variable types in hclge_dbg_dump_tm_map()
authorYonglong Liu <liuyonglong@huawei.com>
Tue, 9 Feb 2021 02:41:51 +0000 (10:41 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 9 Feb 2021 23:34:07 +0000 (15:34 -0800)
queue_id, qset_id and other IDs are unsigned type, so modify
the corresponding local variables' type in hclge_dbg_dump_tm_map()
from signed to unsigned. kstrtouint() and the print format should
be updated as well.

Signed-off-by: Yonglong Liu <liuyonglong@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c

index 113efd4ae157b19a00d45c705e1fccaa088deeb1..a0a33c02ce25b278d8da96ef19f27a77c0e609e8 100644 (file)
@@ -696,17 +696,16 @@ static void hclge_dbg_dump_tm_map(struct hclge_dev *hdev,
        u32 qset_mapping[HCLGE_BP_EXT_GRP_NUM];
        struct hclge_qs_to_pri_link_cmd *map;
        struct hclge_tqp_tx_queue_tc_cmd *tc;
+       u16 group_id, queue_id, qset_id;
        enum hclge_opcode_type cmd;
+       u8 grp_num, pri_id, tc_id;
        struct hclge_desc desc;
-       int queue_id, group_id;
-       int tc_id, qset_id;
-       int pri_id, ret;
        u16 qs_id_l;
        u16 qs_id_h;
-       u8 grp_num;
+       int ret;
        u32 i;
 
-       ret = kstrtouint(cmd_buf, 0, &queue_id);
+       ret = kstrtou16(cmd_buf, 0, &queue_id);
        queue_id = (ret != 0) ? 0 : queue_id;
 
        cmd = HCLGE_OPC_TM_NQ_TO_QS_LINK;
@@ -754,7 +753,7 @@ static void hclge_dbg_dump_tm_map(struct hclge_dev *hdev,
        tc_id = tc->tc_id & 0x7;
 
        dev_info(&hdev->pdev->dev, "queue_id | qset_id | pri_id | tc_id\n");
-       dev_info(&hdev->pdev->dev, "%04d     | %04d    | %02d     | %02d\n",
+       dev_info(&hdev->pdev->dev, "%04u     | %04u    | %02u     | %02u\n",
                 queue_id, qset_id, pri_id, tc_id);
 
        if (!hnae3_dev_dcb_supported(hdev)) {