]> git.baikalelectronics.ru Git - kernel.git/commitdiff
usb: core: Remove redundant vmap checks
authorKees Cook <keescook@chromium.org>
Tue, 29 Oct 2019 21:34:23 +0000 (14:34 -0700)
committerChristoph Hellwig <hch@lst.de>
Thu, 31 Oct 2019 13:40:43 +0000 (06:40 -0700)
Now that the vmap area checks are being performed in the DMA
infrastructure directly, there is no need to repeat them in USB.

Signed-off-by: Kees Cook <keescook@chromium.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/usb/core/hcd.c

index f225eaa98ff8ead2b22e9a1d29ce79263519c593..281568d464f97d2ffed2618207b3e8737f7e413e 100644 (file)
@@ -1410,10 +1410,7 @@ int usb_hcd_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
                if (hcd->self.uses_pio_for_control)
                        return ret;
                if (hcd_uses_dma(hcd)) {
-                       if (is_vmalloc_addr(urb->setup_packet)) {
-                               WARN_ONCE(1, "setup packet is not dma capable\n");
-                               return -EAGAIN;
-                       } else if (object_is_on_stack(urb->setup_packet)) {
+                       if (object_is_on_stack(urb->setup_packet)) {
                                WARN_ONCE(1, "setup packet is on stack\n");
                                return -EAGAIN;
                        }
@@ -1479,9 +1476,6 @@ int usb_hcd_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
                                        ret = -EAGAIN;
                                else
                                        urb->transfer_flags |= URB_DMA_MAP_PAGE;
-                       } else if (is_vmalloc_addr(urb->transfer_buffer)) {
-                               WARN_ONCE(1, "transfer buffer not dma capable\n");
-                               ret = -EAGAIN;
                        } else if (object_is_on_stack(urb->transfer_buffer)) {
                                WARN_ONCE(1, "transfer buffer is on stack\n");
                                ret = -EAGAIN;