]> git.baikalelectronics.ru Git - kernel.git/commitdiff
regulator: tps65217-regulator: Use the returned value of tps65217_reg_read()
authorLee Jones <lee.jones@linaro.org>
Fri, 26 Jun 2020 06:57:35 +0000 (07:57 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 26 Jun 2020 14:34:22 +0000 (15:34 +0100)
Until now the aforementioned return value has been ignored.
Previous and current calls to tps65217_reg_read() return
instantly when the value is not 0, so let's do that.

Fixes the following W=1 warning:

 drivers/regulator/tps65217-regulator.c: In function ‘tps65217_regulator_probe’:
 drivers/regulator/tps65217-regulator.c:227:9: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
 227 | int i, ret;
 | ^~~

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Cc: Russ Dill <Russ.Dill@ti.com>
Cc: Keerthy <j-keerthy@ti.com>
Cc: AnilKumar Ch <anilkumar@ti.com>
Cc: linux-omap@vger.kernel.org
Link: https://lore.kernel.org/r/20200626065738.93412-7-lee.jones@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/tps65217-regulator.c

index f2d3a4a9f3e77ddd8bea118fd0abaf5b4218601b..3f5ea029e2e3fa0ac4c19cc5119c075c61cbe030 100644 (file)
@@ -254,6 +254,9 @@ static int tps65217_regulator_probe(struct platform_device *pdev)
 
                /* Store default strobe info */
                ret = tps65217_reg_read(tps, regulators[i].bypass_reg, &val);
+               if (ret)
+                       return ret;
+
                tps->strobes[i] = val & regulators[i].bypass_mask;
        }