]> git.baikalelectronics.ru Git - kernel.git/commitdiff
coresight: etm4x: Fix unused function warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 13 Dec 2019 22:31:07 +0000 (15:31 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jan 2020 14:38:28 +0000 (15:38 +0100)
Some of the newly added code in the etm4x driver is inside of an #ifdef,
and some other code is outside of it, leading to a harmless warning when
CONFIG_CPU_PM is disabled:

drivers/hwtracing/coresight/coresight-etm4x.c:68:13: error: 'etm4_os_lock' defined but not used [-Werror=unused-function]
 static void etm4_os_lock(struct etmv4_drvdata *drvdata)
             ^~~~~~~~~~~~

To avoid the warning and simplify the the #ifdef checks, use
IS_ENABLED() instead, so the compiler can drop the unused functions
without complaining.

Fixes: ae0761b2bf59 ("coresight: etm4x: Save/restore state across CPU low power states")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[Fixed capital 'f' in title]
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Link: https://lore.kernel.org/r/20191213223107.1484-2-mathieu.poirier@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwtracing/coresight/coresight-etm4x.c

index dc3f507e7562d016c4e27a5d78f7ffecb8ab6542..a90d757f704319e36832e8cafa270e7967ebabcd 100644 (file)
@@ -1132,7 +1132,6 @@ static void etm4_init_trace_id(struct etmv4_drvdata *drvdata)
        drvdata->trcid = coresight_get_trace_id(drvdata->cpu);
 }
 
-#ifdef CONFIG_CPU_PM
 static int etm4_cpu_save(struct etmv4_drvdata *drvdata)
 {
        int i, ret = 0;
@@ -1402,17 +1401,17 @@ static struct notifier_block etm4_cpu_pm_nb = {
 
 static int etm4_cpu_pm_register(void)
 {
-       return cpu_pm_register_notifier(&etm4_cpu_pm_nb);
+       if (IS_ENABLED(CONFIG_CPU_PM))
+               return cpu_pm_register_notifier(&etm4_cpu_pm_nb);
+
+       return 0;
 }
 
 static void etm4_cpu_pm_unregister(void)
 {
-       cpu_pm_unregister_notifier(&etm4_cpu_pm_nb);
+       if (IS_ENABLED(CONFIG_CPU_PM))
+               cpu_pm_unregister_notifier(&etm4_cpu_pm_nb);
 }
-#else
-static int etm4_cpu_pm_register(void) { return 0; }
-static void etm4_cpu_pm_unregister(void) { }
-#endif
 
 static int etm4_probe(struct amba_device *adev, const struct amba_id *id)
 {