]> git.baikalelectronics.ru Git - kernel.git/commitdiff
ethernet: ucc_geth: remove unused read of temoder field
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Tue, 19 Jan 2021 15:07:46 +0000 (16:07 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 21 Jan 2021 20:19:54 +0000 (12:19 -0800)
In theory, such a read-after-write might be required by the hardware,
but nothing in the data sheet suggests that to be the case. The name
test also suggests that it's some debug leftover.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/ucc_geth.c

index 6d853f018d53133d47fa5a6236174a64a1f5f370..d4b775870f4e9d6abe844ddbcfb7d5f3d2fedf91 100644 (file)
@@ -2359,7 +2359,6 @@ static int ucc_geth_startup(struct ucc_geth_private *ugeth)
        u32 init_enet_pram_offset, cecr_subblock, command;
        u32 ifstat, i, j, size, l2qt, l3qt;
        u16 temoder = UCC_GETH_TEMODER_INIT;
-       u16 test;
        u8 function_code = 0;
        u8 __iomem *endOfRing;
        u8 numThreadsRxNumerical, numThreadsTxNumerical;
@@ -2667,8 +2666,6 @@ static int ucc_geth_startup(struct ucc_geth_private *ugeth)
        temoder |= ((ug_info->numQueuesTx - 1) << TEMODER_NUM_OF_QUEUES_SHIFT);
        out_be16(&ugeth->p_tx_glbl_pram->temoder, temoder);
 
-       test = in_be16(&ugeth->p_tx_glbl_pram->temoder);
-
        /* Function code register value to be used later */
        function_code = UCC_BMR_BO_BE | UCC_BMR_GBL;
        /* Required for QE */