]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/amd/display: fix signedness bug in execute_synaptics_rc_command()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 26 Jul 2022 15:15:31 +0000 (18:15 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Jul 2022 20:05:16 +0000 (16:05 -0400)
The "ret" variable needs to be signed for the error handling to work.

Fixes: ae6e0042d9e2 ("drm/amd/display: Add Synaptics Fifo Reset Workaround")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c

index d66e3cd64ebd09f19ce6b3003bb933d20fd927eb..a0154a5f718327f4812f5b4d8ddd96426401731e 100644 (file)
@@ -569,7 +569,7 @@ static bool execute_synaptics_rc_command(struct drm_dp_aux *aux,
        unsigned char rc_cmd = 0;
        unsigned char rc_result = 0xFF;
        unsigned char i = 0;
-       uint8_t ret = 0;
+       int ret;
 
        if (is_write_cmd) {
                // write rc data