]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/amdgpu: keep mmhub clock gating being enabled during s2idle suspend
authorPrike Liang <Prike.Liang@amd.com>
Tue, 19 Apr 2022 09:22:34 +0000 (17:22 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 27 Apr 2022 21:38:02 +0000 (17:38 -0400)
Without MMHUB clock gating being enabled then MMHUB will not disconnect
from DF and will result in DF C-state entry can't be accessed during S2idle
suspend, and eventually s0ix entry will be blocked.

Signed-off-by: Prike Liang <Prike.Liang@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c

index 5228421b0f724745f111737d6a79f418cb2f595c..7c956cf21bc7ceab131a1e1d56a5430294fd09a9 100644 (file)
@@ -1151,6 +1151,16 @@ static int gmc_v10_0_set_clockgating_state(void *handle,
        int r;
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
+       /*
+        * The issue mmhub can't disconnect from DF with MMHUB clock gating being disabled
+        * is a new problem observed at DF 3.0.3, however with the same suspend sequence not
+        * seen any issue on the DF 3.0.2 series platform.
+        */
+       if (adev->in_s0ix && adev->ip_versions[DF_HWIP][0] > IP_VERSION(3, 0, 2)) {
+               dev_dbg(adev->dev, "keep mmhub clock gating being enabled for s0ix\n");
+               return 0;
+       }
+
        r = adev->mmhub.funcs->set_clockgating(adev, state);
        if (r)
                return r;