drm/i915/guc: Workaround reset G2H is received after schedule done G2H

If the context is reset as a result of the request cancellation the
context reset G2H is received after schedule disable done G2H which is
the wrong order. The schedule disable done G2H release the waiting
request cancellation code which resubmits the context. This races
with the context reset G2H which also wants to resubmit the context but
in this case it really should be a NOP as request cancellation code owns
the resubmit. Use some clever tricks of checking the context state to
seal this race until the GuC firmware is fixed.

v2:
 (Checkpatch)
  - Fix typos
v3:
 (Daniele)
  - State that is a bug in the GuC firmware

Fixes: 62eaf0ae217d ("drm/i915/guc: Support request cancellation")
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
Cc: <stable@vger.kernel.org>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210909164744.31249-7-matthew.brost@intel.com

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 31bbfe5479aebbd755758cb6f7f582faa1cec81d..f9e3725b94c18b6e312a08d704e616a2f41f1082 100644 (file)
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -833,17 +833,33 @@ __unwind_incomplete_requests(struct intel_context *ce)
 static void __guc_reset_context(struct intel_context *ce, bool stalled)
 {
        struct i915_request *rq;
+       unsigned long flags;
        u32 head;
+       bool skip = false;
 
        intel_context_get(ce);
 
        /*
-        * GuC will implicitly mark the context as non-schedulable
-        * when it sends the reset notification. Make sure our state
-        * reflects this change. The context will be marked enabled
-        * on resubmission.
+        * GuC will implicitly mark the context as non-schedulable when it sends
+        * the reset notification. Make sure our state reflects this change. The
+        * context will be marked enabled on resubmission.
+        *
+        * XXX: If the context is reset as a result of the request cancellation
+        * this G2H is received after the schedule disable complete G2H which is
+        * wrong as this creates a race between the request cancellation code
+        * re-submitting the context and this G2H handler. This is a bug in the
+        * GuC but can be worked around in the meantime but converting this to a
+        * NOP if a pending enable is in flight as this indicates that a request
+        * cancellation has occurred.
         */
-       clr_context_enabled(ce);
+       spin_lock_irqsave(&ce->guc_state.lock, flags);
+       if (likely(!context_pending_enable(ce)))
+               clr_context_enabled(ce);
+       else
+               skip = true;
+       spin_unlock_irqrestore(&ce->guc_state.lock, flags);
+       if (unlikely(skip))
+               goto out_put;
 
        rq = intel_context_find_active_request(ce);
        if (!rq) {
@@ -862,6 +878,7 @@ static void __guc_reset_context(struct intel_context *ce, bool stalled)
 out_replay:
        guc_reset_state(ce, head, stalled);
        __unwind_incomplete_requests(ce);
+out_put:
        intel_context_put(ce);
 }
 
@@ -1598,6 +1615,13 @@ static void guc_context_cancel_request(struct intel_context *ce,
                        guc_reset_state(ce, intel_ring_wrap(ce->ring, rq->head),
                                        true);
                }
+
+               /*
+                * XXX: Racey if context is reset, see comment in
+                * __guc_reset_context().
+                */
+               flush_work(&ce_to_guc(ce)->ct.requests.worker);
+
                guc_context_unblock(ce);
        }
 }
@@ -2712,7 +2736,12 @@ static void guc_handle_context_reset(struct intel_guc *guc,
 {
        trace_intel_context_reset(ce);
 
-       if (likely(!intel_context_is_banned(ce))) {
+       /*
+        * XXX: Racey if request cancellation has occurred, see comment in
+        * __guc_reset_context().
+        */
+       if (likely(!intel_context_is_banned(ce) &&
+                  !context_blocked(ce))) {
                capture_error_state(guc, ce);
                guc_context_replay(ce);
        }