]> git.baikalelectronics.ru Git - kernel.git/commitdiff
nvme: add comment for unaligned "fake" nqn
authorLinjun Bao <meljbao@gmail.com>
Thu, 11 Aug 2022 07:40:24 +0000 (15:40 +0800)
committerChristoph Hellwig <hch@lst.de>
Mon, 19 Sep 2022 09:33:53 +0000 (11:33 +0200)
Current "fake" nqn field is "nqn.2014.08.org.nvmexpress:", it is
not aligned with the canonical version for history reasons.

Signed-off-by: Linjun Bao <meljbao@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvme/host/core.c

index af367b22871b1f71ae803165d3978d1f87f1f800..1128816646958a51ec331825b92b4b21ca5f1989 100644 (file)
@@ -2704,7 +2704,11 @@ static void nvme_init_subnqn(struct nvme_subsystem *subsys, struct nvme_ctrl *ct
                        dev_warn(ctrl->device, "missing or invalid SUBNQN field.\n");
        }
 
-       /* Generate a "fake" NQN per Figure 254 in NVMe 1.3 + ECN 001 */
+       /*
+        * Generate a "fake" NQN similar to the one in Section 4.5 of the NVMe
+        * Base Specification 2.0.  It is slightly different from the format
+        * specified there due to historic reasons, and we can't change it now.
+        */
        off = snprintf(subsys->subnqn, NVMF_NQN_SIZE,
                        "nqn.2014.08.org.nvmexpress:%04x%04x",
                        le16_to_cpu(id->vid), le16_to_cpu(id->ssvid));