netfilter: nf_tables: allow up to 64 bytes in the set element data area

[ e4fa54f92314004dca22482ac9f769ae0b21bf20 ]

So far, the set elements could store up to 128-bits in the data area.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h
index ba5f97f5c490e646e9d4fc4550939c67b149af86..a8cc2750990f90bbdb305df7c9d9f1e339912de1 100644 (file)
--- a/include/net/netfilter/nf_tables.h
+++ b/include/net/netfilter/nf_tables.h
@@ -239,6 +239,10 @@ struct nft_set_elem {
                u32             buf[NFT_DATA_VALUE_MAXLEN / sizeof(u32)];
                struct nft_data val;
        } key;
+       union {
+               u32             buf[NFT_DATA_VALUE_MAXLEN / sizeof(u32)];
+               struct nft_data val;
+       } data;
        void                    *priv;
 };
 

diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c
index 13a8a78b8ee8bc43ee3b9448326c701ec6c94830..8648b3ced622160176077a3cadec30966d2f7b0d 100644 (file)
--- a/net/netfilter/nf_tables_api.c
+++ b/net/netfilter/nf_tables_api.c
@@ -4310,6 +4310,25 @@ static int nft_setelem_parse_key(struct nft_ctx *ctx, struct nft_set *set,
        return 0;
 }
 
+static int nft_setelem_parse_data(struct nft_ctx *ctx, struct nft_set *set,
+                                 struct nft_data_desc *desc,
+                                 struct nft_data *data,
+                                 struct nlattr *attr)
+{
+       int err;
+
+       err = nft_data_init(ctx, data, NFT_DATA_VALUE_MAXLEN, desc, attr);
+       if (err < 0)
+               return err;
+
+       if (desc->type != NFT_DATA_VERDICT && desc->len != set->dlen) {
+               nft_data_release(data, desc->type);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
 static int nft_get_set_elem(struct nft_ctx *ctx, struct nft_set *set,
                            const struct nlattr *attr)
 {
@@ -4536,7 +4555,6 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set,
        struct nft_object *obj = NULL;
        struct nft_userdata *udata;
        struct nft_data_desc desc;
-       struct nft_data data;
        enum nft_registers dreg;
        struct nft_trans *trans;
        u32 flags = 0;
@@ -4629,15 +4647,11 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set,
        }
 
        if (nla[NFTA_SET_ELEM_DATA] != NULL) {
-               err = nft_data_init(ctx, &data, sizeof(data), &desc,
-                                   nla[NFTA_SET_ELEM_DATA]);
+               err = nft_setelem_parse_data(ctx, set, &desc, &elem.data.val,
+                                            nla[NFTA_SET_ELEM_DATA]);
                if (err < 0)
                        goto err2;
 
-               err = -EINVAL;
-               if (set->dtype != NFT_DATA_VERDICT && desc.len != set->dlen)
-                       goto err3;
-
                dreg = nft_type_to_reg(set->dtype);
                list_for_each_entry(binding, &set->bindings, list) {
                        struct nft_ctx bind_ctx = {
@@ -4651,14 +4665,14 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set,
                                continue;
 
                        err = nft_validate_register_store(&bind_ctx, dreg,
-                                                         &data,
+                                                         &elem.data.val,
                                                          desc.type, desc.len);
                        if (err < 0)
                                goto err3;
 
                        if (desc.type == NFT_DATA_VERDICT &&
-                           (data.verdict.code == NFT_GOTO ||
-                            data.verdict.code == NFT_JUMP))
+                           (elem.data.val.verdict.code == NFT_GOTO ||
+                            elem.data.val.verdict.code == NFT_JUMP))
                                nft_validate_state_update(ctx->net,
                                                          NFT_VALIDATE_NEED);
                }
@@ -4679,8 +4693,9 @@ static int nft_add_set_elem(struct nft_ctx *ctx, struct nft_set *set,
        }
 
        err = -ENOMEM;
-       elem.priv = nft_set_elem_init(set, &tmpl, elem.key.val.data, data.data,
-                                     timeout, expiration, GFP_KERNEL);
+       elem.priv = nft_set_elem_init(set, &tmpl, elem.key.val.data,
+                                     elem.data.val.data, timeout, expiration,
+                                     GFP_KERNEL);
        if (elem.priv == NULL)
                goto err3;
 
@@ -4746,7 +4761,7 @@ err4:
        kfree(elem.priv);
 err3:
        if (nla[NFTA_SET_ELEM_DATA] != NULL)
-               nft_data_release(&data, desc.type);
+               nft_data_release(&elem.data.val, desc.type);
 err2:
        nft_data_release(&elem.key.val, NFT_DATA_VALUE);
 err1: