]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/mlx5e: Fix wrong private flag usage causing checksum disable
authorShay Agroskin <shayag@mellanox.com>
Sun, 6 Jan 2019 15:55:59 +0000 (17:55 +0200)
committerSaeed Mahameed <saeedm@mellanox.com>
Fri, 25 Jan 2019 20:00:28 +0000 (12:00 -0800)
MLX5E_PFLAG_* definitions were changed from bitmask to enumerated
values. However, in mlx5e_open_rq(), the proper API (MLX5E_GET_PFLAG macro)
was not used to read the flag value of MLX5E_PFLAG_RX_NO_CSUM_COMPLETE.
Fixed it.

Fixes: 8d6344c4a56c ("net/mlx5e: Improve ethtool private-flags code structure")
Signed-off-by: Shay Agroskin <shayag@mellanox.com>
Reviewed-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index 8cfd2ec7c0a209afe424eca2a7be3301cf79223f..01819e5c9975dbc43db13f84822ee5da1f0d5caf 100644 (file)
@@ -950,7 +950,7 @@ static int mlx5e_open_rq(struct mlx5e_channel *c,
        if (params->rx_dim_enabled)
                __set_bit(MLX5E_RQ_STATE_AM, &c->rq.state);
 
-       if (params->pflags & MLX5E_PFLAG_RX_NO_CSUM_COMPLETE)
+       if (MLX5E_GET_PFLAG(params, MLX5E_PFLAG_RX_NO_CSUM_COMPLETE))
                __set_bit(MLX5E_RQ_STATE_NO_CSUM_COMPLETE, &c->rq.state);
 
        return 0;