netdevsim: fib: Fix reference count leak on route deletion failure

As part of FIB offload simulation, netdevsim stores IPv4 and IPv6 routes
and holds a reference on FIB info structures that in turn hold a
reference on the associated nexthop device(s).

In the unlikely case where we are unable to allocate memory to process a
route deletion request, netdevsim will not release the reference from
the associated FIB info structure, thereby preventing the associated
nexthop device(s) from ever being removed [1].

Fix this by scheduling a work item that will flush netdevsim's FIB table
upon route deletion failure. This will cause netdevsim to release its
reference from all the FIB info structures in its table.

Reported by Lucas Leong of Trend Micro Zero Day Initiative.

Fixes: 56f51c8d9d8b ("netdevsim: fib: Perform the route programming in a non-atomic context")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Amit Cohen <amcohen@nvidia.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
index c8f398f5bc5b8825777e928a8e3e7f2a9c8778eb..57371c697d5cfae43b0f4d126672c78417fb8361 100644 (file)
--- a/drivers/net/netdevsim/fib.c
+++ b/drivers/net/netdevsim/fib.c
@@ -54,6 +54,7 @@ struct nsim_fib_data {
        struct rhashtable nexthop_ht;
        struct devlink *devlink;
        struct work_struct fib_event_work;
+       struct work_struct fib_flush_work;
        struct list_head fib_event_queue;
        spinlock_t fib_event_queue_lock; /* Protects fib event queue list */
        struct mutex nh_lock; /* Protects NH HT */
@@ -978,7 +979,7 @@ static int nsim_fib_event_schedule_work(struct nsim_fib_data *data,
 
        fib_event = kzalloc(sizeof(*fib_event), GFP_ATOMIC);
        if (!fib_event)
-               return NOTIFY_BAD;
+               goto err_fib_event_alloc;
 
        fib_event->data = data;
        fib_event->event = event;
@@ -1006,6 +1007,9 @@ static int nsim_fib_event_schedule_work(struct nsim_fib_data *data,
 
 err_fib_prepare_event:
        kfree(fib_event);
+err_fib_event_alloc:
+       if (event == FIB_EVENT_ENTRY_DEL)
+               schedule_work(&data->fib_flush_work);
        return NOTIFY_BAD;
 }
 
@@ -1483,6 +1487,24 @@ static void nsim_fib_event_work(struct work_struct *work)
        mutex_unlock(&data->fib_lock);
 }
 
+static void nsim_fib_flush_work(struct work_struct *work)
+{
+       struct nsim_fib_data *data = container_of(work, struct nsim_fib_data,
+                                                 fib_flush_work);
+       struct nsim_fib_rt *fib_rt, *fib_rt_tmp;
+
+       /* Process pending work. */
+       flush_work(&data->fib_event_work);
+
+       mutex_lock(&data->fib_lock);
+       list_for_each_entry_safe(fib_rt, fib_rt_tmp, &data->fib_rt_list, list) {
+               rhashtable_remove_fast(&data->fib_rt_ht, &fib_rt->ht_node,
+                                      nsim_fib_rt_ht_params);
+               nsim_fib_rt_free(fib_rt, data);
+       }
+       mutex_unlock(&data->fib_lock);
+}
+
 static int
 nsim_fib_debugfs_init(struct nsim_fib_data *data, struct nsim_dev *nsim_dev)
 {
@@ -1541,6 +1563,7 @@ struct nsim_fib_data *nsim_fib_create(struct devlink *devlink,
                goto err_rhashtable_nexthop_destroy;
 
        INIT_WORK(&data->fib_event_work, nsim_fib_event_work);
+       INIT_WORK(&data->fib_flush_work, nsim_fib_flush_work);
        INIT_LIST_HEAD(&data->fib_event_queue);
        spin_lock_init(&data->fib_event_queue_lock);
 
@@ -1587,6 +1610,7 @@ struct nsim_fib_data *nsim_fib_create(struct devlink *devlink,
 err_nexthop_nb_unregister:
        unregister_nexthop_notifier(devlink_net(devlink), &data->nexthop_nb);
 err_rhashtable_fib_destroy:
+       cancel_work_sync(&data->fib_flush_work);
        flush_work(&data->fib_event_work);
        rhashtable_free_and_destroy(&data->fib_rt_ht, nsim_fib_rt_free,
                                    data);
@@ -1616,6 +1640,7 @@ void nsim_fib_destroy(struct devlink *devlink, struct nsim_fib_data *data)
                                            NSIM_RESOURCE_IPV4_FIB);
        unregister_fib_notifier(devlink_net(devlink), &data->fib_nb);
        unregister_nexthop_notifier(devlink_net(devlink), &data->nexthop_nb);
+       cancel_work_sync(&data->fib_flush_work);
        flush_work(&data->fib_event_work);
        rhashtable_free_and_destroy(&data->fib_rt_ht, nsim_fib_rt_free,
                                    data);