mm: merge pte_mkhuge() call into arch_make_huge_pte()

Each call into pte_mkhuge() is invariably followed by
arch_make_huge_pte().  Instead arch_make_huge_pte() can accommodate
pte_mkhuge() at the beginning.  This updates generic fallback stub for
arch_make_huge_pte() and available platforms definitions.  This makes huge
pte creation much cleaner and easier to follow.

Link: https://lkml.kernel.org/r/1643860669-26307-1-git-send-email-anshuman.khandual@arm.com
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@samba.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c
index ffb9c229610ab5ee0825f1c604f72799bd7296e1..228226c5fa8094ffd340f9fa86b00888111220a2 100644 (file)
--- a/arch/arm64/mm/hugetlbpage.c
+++ b/arch/arm64/mm/hugetlbpage.c
@@ -347,6 +347,7 @@ pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, vm_flags_t flags)
 {
        size_t pagesize = 1UL << shift;
 
+       entry = pte_mkhuge(entry);
        if (pagesize == CONT_PTE_SIZE) {
                entry = pte_mkcont(entry);
        } else if (pagesize == CONT_PMD_SIZE) {

diff --git a/arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h b/arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h
index 64b6c608eca433b37271cb4d03975264e109504c..de092b04ee1a1292b6352c74888291e179f5b0ae 100644 (file)
--- a/arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h
+++ b/arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h
@@ -71,9 +71,9 @@ static inline pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, vm_flags
        size_t size = 1UL << shift;
 
        if (size == SZ_16K)
-               return __pte(pte_val(entry) & ~_PAGE_HUGE);
+               return __pte(pte_val(entry) | _PAGE_SPS);
        else
-               return entry;
+               return __pte(pte_val(entry) | _PAGE_SPS | _PAGE_HUGE);
 }
 #define arch_make_huge_pte arch_make_huge_pte
 #endif

diff --git a/arch/sparc/mm/hugetlbpage.c b/arch/sparc/mm/hugetlbpage.c
index 0f49fada20938c11087cb1811bd06156407d6bbc..d8e0e3c7038d06d381dd783a5c43905c5d5bc68a 100644 (file)
--- a/arch/sparc/mm/hugetlbpage.c
+++ b/arch/sparc/mm/hugetlbpage.c
@@ -181,6 +181,7 @@ pte_t arch_make_huge_pte(pte_t entry, unsigned int shift, vm_flags_t flags)
 {
        pte_t pte;
 
+       entry = pte_mkhuge(entry);
        pte = hugepage_shift_to_tte(entry, shift);
 
 #ifdef CONFIG_SPARC64

diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
index d1897a69c5406835b62635b82ce18768ebdc598f..52c462390aee374497a8f7feb635366cba992fc3 100644 (file)
--- a/include/linux/hugetlb.h
+++ b/include/linux/hugetlb.h
@@ -754,7 +754,7 @@ static inline void arch_clear_hugepage_flags(struct page *page) { }
 static inline pte_t arch_make_huge_pte(pte_t entry, unsigned int shift,
                                       vm_flags_t flags)
 {
-       return entry;
+       return pte_mkhuge(entry);
 }
 #endif
 

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index f294db835f4bc46b737cc363ec99e7579ad3fde4..a404af0b49a050d361dcf297ec1124404da9f2ca 100644 (file)
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -4637,7 +4637,6 @@ static pte_t make_huge_pte(struct vm_area_struct *vma, struct page *page,
                                           vma->vm_page_prot));
        }
        entry = pte_mkyoung(entry);
-       entry = pte_mkhuge(entry);
        entry = arch_make_huge_pte(entry, shift, vma->vm_flags);
 
        return entry;
@@ -6171,7 +6170,7 @@ unsigned long hugetlb_change_protection(struct vm_area_struct *vma,
                        unsigned int shift = huge_page_shift(hstate_vma(vma));
 
                        old_pte = huge_ptep_modify_prot_start(vma, address, ptep);
-                       pte = pte_mkhuge(huge_pte_modify(old_pte, newprot));
+                       pte = huge_pte_modify(old_pte, newprot);
                        pte = arch_make_huge_pte(pte, shift, vma->vm_flags);
                        huge_ptep_modify_prot_commit(vma, address, ptep, old_pte, pte);
                        pages++;

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 4165304d35471b3174d24d63ea63eceb0dc67c58..d0b14dd73adcdc619990ca11277b0a29e62a604f 100644 (file)
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -118,7 +118,6 @@ static int vmap_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end,
                if (size != PAGE_SIZE) {
                        pte_t entry = pfn_pte(pfn, prot);
 
-                       entry = pte_mkhuge(entry);
                        entry = arch_make_huge_pte(entry, ilog2(size), 0);
                        set_huge_pte_at(&init_mm, addr, pte, entry);
                        pfn += PFN_DOWN(size);