]> git.baikalelectronics.ru Git - kernel.git/commitdiff
dpaa2-mac: remove a comment regarding pause settings
authorIoana Ciornei <ioana.ciornei@nxp.com>
Fri, 8 Jan 2021 09:07:27 +0000 (11:07 +0200)
committerJakub Kicinski <kuba@kernel.org>
Sun, 10 Jan 2021 00:21:30 +0000 (16:21 -0800)
The MC firmware takes these PAUSE/ASYM_PAUSE flags provided by the
driver, transforms them back into rx/tx pause enablement status and
applies them to hardware. We are not losing information by this
transformation, thus remove the comment.

Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c

index 3869c38f397911bd1a77d9196c7363fe944e168a..69ad869446cfcdbe2f3dc61451ebd7529630844b 100644 (file)
@@ -181,9 +181,6 @@ static void dpaa2_mac_link_up(struct phylink_config *config,
        else if (duplex == DUPLEX_FULL)
                dpmac_state->options &= ~DPMAC_LINK_OPT_HALF_DUPLEX;
 
-       /* This is lossy; the firmware really should take the pause
-        * enablement status rather than pause/asym pause status.
-        */
        if (rx_pause)
                dpmac_state->options |= DPMAC_LINK_OPT_PAUSE;
        else