]> git.baikalelectronics.ru Git - kernel.git/commitdiff
scsi: target: Remove incorrect zero blocks WRITE_SAME check
authorMike Christie <michael.christie@oracle.com>
Tue, 28 Jun 2022 20:02:26 +0000 (15:02 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 7 Jul 2022 20:53:52 +0000 (16:53 -0400)
We use WSNZ=1 so if we get a WRITE_SAME with zero logical blocks we are
supposed to fail it. We do this check and failure in target_core_sbc.c
before calling into the backend, so we can remove the incorrect check in
target_core_file.

Link: https://lore.kernel.org/r/20220628200230.15052-2-michael.christie@oracle.com
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_file.c

index e68f1cc8ef98bd56098bdad6680576a4e6167b5b..4aba25166b9707a8f2c3c5ece9bb21d1f98fcdec 100644 (file)
@@ -438,10 +438,6 @@ fd_execute_write_same(struct se_cmd *cmd)
        unsigned int len = 0, i;
        ssize_t ret;
 
-       if (!nolb) {
-               target_complete_cmd(cmd, SAM_STAT_GOOD);
-               return 0;
-       }
        if (cmd->prot_op) {
                pr_err("WRITE_SAME: Protection information with FILEIO"
                       " backends not supported\n");