]> git.baikalelectronics.ru Git - kernel.git/commitdiff
blk-cgroup: delete rcu_read_lock_held() WARN_ON_ONCE()
authorJens Axboe <axboe@kernel.dk>
Wed, 18 May 2022 22:32:00 +0000 (16:32 -0600)
committerJens Axboe <axboe@kernel.dk>
Wed, 18 May 2022 22:32:00 +0000 (16:32 -0600)
A previous commit got rid of unnecessary rcu_read_lock() inside the
IRQ disabling queue_lock, but this debug statement was left. It's now
firing since we are indeed not inside a RCU read lock, but we don't
need to be as we're still preempt safe.

Get rid of the check, as we have a lockdep assert for holding the
queue lock right after it anyway.

Link: https://lore.kernel.org/linux-block/46253c48-81cb-0787-20ad-9133afdd9e21@samsung.com/
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Fixes: 77c570a1ea85 ("blk-cgroup: Remove unnecessary rcu_read_lock/unlock()")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-cgroup.c

index 0676cf7a41b51bad49c44358419b9dd8aeb312f7..40161a3f68d04abbed2facae6099108d93290603 100644 (file)
@@ -298,7 +298,6 @@ static struct blkcg_gq *blkg_create(struct blkcg *blkcg,
        struct blkcg_gq *blkg;
        int i, ret;
 
-       WARN_ON_ONCE(!rcu_read_lock_held());
        lockdep_assert_held(&q->queue_lock);
 
        /* request_queue is dying, do not create/recreate a blkg */