]> git.baikalelectronics.ru Git - kernel.git/commitdiff
media: i2c: video-i2c: Replace constants with proper names
authorMoses Christopher Bollavarapu <mosescb.dev@gmail.com>
Tue, 19 Apr 2022 20:20:50 +0000 (22:20 +0200)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Tue, 17 May 2022 07:16:31 +0000 (09:16 +0200)
Acc to MLX90640 datasheet:
 - 0x0400 represents the start of RAM address
 - 0x2400 represents the start of EEPROM address

Reference: https://www.melexis.com/-/media/files/documents\
           /datasheets/mlx90640-datasheet-melexis.pdf

Signed-off-by: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/video-i2c.c

index b3fe9a507f7f438793d2746d96ab3d00c4ccad0e..1d5f48329cb2ae0190c8d9f95c9a9d1c6cc4a51b 100644 (file)
 /* Temperature register */
 #define AMG88XX_REG_T01L       0x80
 
+/* RAM */
+#define MLX90640_RAM_START_ADDR                0x0400
+
+/* EEPROM */
+#define MLX90640_EEPROM_START_ADDR     0x2400
+
 /* Control register */
 #define MLX90640_REG_CTL1              0x800d
 #define MLX90640_REG_CTL1_MASK         0x0380
@@ -149,7 +155,7 @@ static int mlx90640_nvram_read(void *priv, unsigned int offset, void *val,
 {
        struct video_i2c_data *data = priv;
 
-       return regmap_bulk_read(data->regmap, 0x2400 + offset, val, bytes);
+       return regmap_bulk_read(data->regmap, MLX90640_EEPROM_START_ADDR + offset, val, bytes);
 }
 
 static struct nvmem_config mlx90640_nvram_config = {
@@ -168,7 +174,7 @@ static int amg88xx_xfer(struct video_i2c_data *data, char *buf)
 
 static int mlx90640_xfer(struct video_i2c_data *data, char *buf)
 {
-       return regmap_bulk_read(data->regmap, 0x400, buf,
+       return regmap_bulk_read(data->regmap, MLX90640_RAM_START_ADDR, buf,
                                data->chip->buffer_size);
 }