]> git.baikalelectronics.ru Git - kernel.git/commitdiff
tty: Fix width of unsigned long bitfield padding
authorPeter Hurley <peter@hurleysoftware.com>
Wed, 24 Sep 2014 10:26:21 +0000 (06:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Sep 2014 10:17:25 +0000 (12:17 +0200)
Commit 1c70f2cf581a16838ee292bb6d2e07a1778a18d1,
'tty: Serialize tcflow() with other tty flow control changes' and
commit 393a0396b977f3a3e22fe31336363ef8b6821ac0,
'tty: Workaround Alpha non-atomic byte storage in tty_struct' work around
compiler bugs and non-atomic storage on multiple arches by padding
bitfields out to the declared type which is unsigned long. However, the
width varies by arch.

Pad bitfields to actual width of unsigned long (which is BITS_PER_LONG).

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/tty.h

index 546e9455789565086eda452842296931d3a82283..5171ef8f7b850c8375cf5c410fdea4d9843bd303 100644 (file)
@@ -264,11 +264,11 @@ struct tty_struct {
        struct winsize winsize;         /* winsize_mutex */
        unsigned long stopped:1,        /* flow_lock */
                      flow_stopped:1,
-                     unused:62;
+                     unused:BITS_PER_LONG - 2;
        int hw_stopped;
        unsigned long ctrl_status:8,    /* ctrl_lock */
                      packet:1,
-                     unused_ctrl:55;
+                     unused_ctrl:BITS_PER_LONG - 9;
        unsigned int receive_room;      /* Bytes free for queue */
        int flow_change;