]> git.baikalelectronics.ru Git - kernel.git/commitdiff
KVM: s390: Fix memory access error detection
authorChristian Borntraeger <borntraeger@de.ibm.com>
Mon, 20 Jan 2014 11:34:13 +0000 (12:34 +0100)
committerChristian Borntraeger <borntraeger@de.ibm.com>
Mon, 20 Jan 2014 11:34:13 +0000 (12:34 +0100)
Seems that commit 52564109227f50a410e6f52e80e7970035294278
(KVM: s390: Removed SIE_INTERCEPT_UCONTROL) lost a hunk when we
reworked our patch queue to rework the async_fp code. We now
ignore faults on the sie instruction (guest accesses non-existing
memory) instead of sending a fault into the guest. This leads to
hang situations with the old virtio transport that checks for
descriptor memory after guest memory. Instead of bailing out this
code now goes wild...
Lets re-add the check.

Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
arch/s390/kvm/kvm-s390.c

index 1bb1ddaf93c0d76554aa86bb6e45332edecce1fd..7635c00a1479428b295e044d57e514abdce86b3d 100644 (file)
@@ -738,6 +738,10 @@ static int vcpu_post_run(struct kvm_vcpu *vcpu, int exit_reason)
                                                current->thread.gmap_addr;
                vcpu->run->s390_ucontrol.pgm_code = 0x10;
                rc = -EREMOTE;
+       } else {
+               VCPU_EVENT(vcpu, 3, "%s", "fault in sie instruction");
+               trace_kvm_s390_sie_fault(vcpu);
+               rc = kvm_s390_inject_program_int(vcpu, PGM_ADDRESSING);
        }
 
        memcpy(&vcpu->run->s.regs.gprs[14], &vcpu->arch.sie_block->gg14, 16);