]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dp83822: disable rx error interrupt
authorEnguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com>
Thu, 23 Jun 2022 13:46:45 +0000 (15:46 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 24 Jun 2022 23:33:22 +0000 (16:33 -0700)
Some RX errors, notably when disconnecting the cable, increase the RCSR
register. Once half full (0x7fff), an interrupt flood is generated. I
measured ~3k/s interrupts even after the RX errors transfer was
stopped.

Since we don't read and clear the RCSR register, we should disable this
interrupt.

Fixes: 60ce3f0822f5 ("net: phy: DP83822 initial driver submission")
Signed-off-by: Enguerrand de Ribaucourt <enguerrand.de-ribaucourt@savoirfairelinux.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/dp83822.c

index 95ef507053a667fbdc9f8373c815c9d900eb2a0e..8549e0e356c9b42226003c0f02a734192b9d5e18 100644 (file)
@@ -229,8 +229,7 @@ static int dp83822_config_intr(struct phy_device *phydev)
                if (misr_status < 0)
                        return misr_status;
 
-               misr_status |= (DP83822_RX_ERR_HF_INT_EN |
-                               DP83822_LINK_STAT_INT_EN |
+               misr_status |= (DP83822_LINK_STAT_INT_EN |
                                DP83822_ENERGY_DET_INT_EN |
                                DP83822_LINK_QUAL_INT_EN);