]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net/mlx5e: Lag, Fix fib_info pointer assignment
authorVlad Buslov <vladbu@nvidia.com>
Mon, 18 Apr 2022 14:32:54 +0000 (17:32 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 4 May 2022 07:00:04 +0000 (00:00 -0700)
Referenced change incorrectly sets single path fib_info even when LAG is
not active. Fix it by moving call to mlx5_lag_fib_set() into conditional
that verifies LAG state.

Fixes: 5274cab100ba ("net/mlx5e: Lag, Only handle events from highest priority multipath entry")
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Reviewed-by: Maor Dickman <maord@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/lag/mp.c

index bc77aba97ac1d554b26ca4113754e9eb8cdb9ca8..9a5884e8a8bf507dacc7b8dc1f788f7f16f0c99e 100644 (file)
@@ -149,9 +149,9 @@ static void mlx5_lag_fib_route_event(struct mlx5_lag *ldev,
 
                        i++;
                        mlx5_lag_set_port_affinity(ldev, i);
+                       mlx5_lag_fib_set(mp, fi);
                }
 
-               mlx5_lag_fib_set(mp, fi);
                return;
        }