]> git.baikalelectronics.ru Git - kernel.git/commitdiff
USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static
authorTom Rix <trix@redhat.com>
Tue, 19 Apr 2022 14:06:25 +0000 (10:06 -0400)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Apr 2022 11:43:35 +0000 (12:43 +0100)
Smatch reports this issue
sr9800.h:166:53: warning: symbol 'SR9800_BULKIN_SIZE' was not declared. Should it be static?

Global variables should not be defined in header files.
This only works because sr9800.h in only included by sr9800.c
Change the storage-class specifier to static.
And since it does not change add type qualifier const.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/sr9800.h

index 18f670251275a6ab2dc1e8d6ad3f10a3679ace3f..952e6f7c03211b595f48f22e3af0adc6c9fb73c2 100644 (file)
 #define SR9800_MAX_BULKIN_24K          6
 #define SR9800_MAX_BULKIN_32K          7
 
-struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = {
+static const struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = {
        /* 2k */
        {2048, 0x8000, 0x8001},
        /* 4k */