]> git.baikalelectronics.ru Git - kernel.git/commitdiff
iio: dac: ad5446: Use put_unaligned_be24()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 21 Apr 2020 00:31:25 +0000 (03:31 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 3 May 2020 08:47:19 +0000 (09:47 +0100)
This makes the driver code slightly easier to read.

Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Michael Hennerich <Michael.Hennerich@analog.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/dac/ad5446.c

index 61c670f7fc5f13d76d440f7b0ffd14cf9ed8ea85..9884e29b19b752d6a62e00714346fd5d593a49b9 100644 (file)
@@ -21,6 +21,8 @@
 #include <linux/iio/iio.h>
 #include <linux/iio/sysfs.h>
 
+#include <asm/unaligned.h>
+
 #define MODE_PWRDWN_1k         0x1
 #define MODE_PWRDWN_100k       0x2
 #define MODE_PWRDWN_TRISTATE   0x3
@@ -302,9 +304,7 @@ static int ad5660_write(struct ad5446_state *st, unsigned val)
        struct spi_device *spi = to_spi_device(st->dev);
        uint8_t data[3];
 
-       data[0] = (val >> 16) & 0xFF;
-       data[1] = (val >> 8) & 0xFF;
-       data[2] = val & 0xFF;
+       put_unaligned_be24(val, &data[0]);
 
        return spi_write(spi, data, sizeof(data));
 }