]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: phy: xgmiitorgmii: Fix refcount leak in xgmiitorgmii_probe
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 29 Dec 2022 06:29:25 +0000 (10:29 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 18 Jan 2023 10:41:57 +0000 (11:41 +0100)
[ Upstream commit d039535850ee47079d59527e96be18d8e0daa84b ]

of_phy_find_device() return device node with refcount incremented.
Call put_device() to relese it when not needed anymore.

Fixes: 8e8c330ad34d ("net: phy: xgmiitorgmii: Check phy_driver ready before accessing")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/phy/xilinx_gmii2rgmii.c

index 151c2a3f0b3a353d0aa76d1bb0cce177bcbb595f..7a78dfdfa5bddfd9b912e171dfe321f858796697 100644 (file)
@@ -82,6 +82,7 @@ static int xgmiitorgmii_probe(struct mdio_device *mdiodev)
 
        if (!priv->phy_dev->drv) {
                dev_info(dev, "Attached phy not ready\n");
+               put_device(&priv->phy_dev->mdio.dev);
                return -EPROBE_DEFER;
        }