s390/smp: cleanup control register update routines

Get rid of duplicate code and redundant data.

Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Alexander Gordeev <agordeev@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>

diff --git a/arch/s390/include/asm/ctl_reg.h b/arch/s390/include/asm/ctl_reg.h
index c800199a376b01fe9dbf8a5789ad3a80e4867da7..82388da3f95ff0257e929ed51e81314c582229c9 100644 (file)
--- a/arch/s390/include/asm/ctl_reg.h
+++ b/arch/s390/include/asm/ctl_reg.h
@@ -74,8 +74,17 @@ static __always_inline void __ctl_clear_bit(unsigned int cr, unsigned int bit)
        __ctl_load(reg, cr, cr);
 }
 
-void smp_ctl_set_bit(int cr, int bit);
-void smp_ctl_clear_bit(int cr, int bit);
+void smp_ctl_set_clear_bit(int cr, int bit, bool set);
+
+static inline void ctl_set_bit(int cr, int bit)
+{
+       smp_ctl_set_clear_bit(cr, bit, true);
+}
+
+static inline void ctl_clear_bit(int cr, int bit)
+{
+       smp_ctl_set_clear_bit(cr, bit, false);
+}
 
 union ctlreg0 {
        unsigned long val;
@@ -130,8 +139,5 @@ union ctlreg15 {
        };
 };
 
-#define ctl_set_bit(cr, bit) smp_ctl_set_bit(cr, bit)
-#define ctl_clear_bit(cr, bit) smp_ctl_clear_bit(cr, bit)
-
 #endif /* __ASSEMBLY__ */
 #endif /* __ASM_CTL_REG_H */

diff --git a/arch/s390/kernel/smp.c b/arch/s390/kernel/smp.c
index b7e56fabe38748c171594846ba0d5f7a5488d1d4..cc6971a09aaf15c9e4d1f078f836e96ad8ab166d 100644 (file)
--- a/arch/s390/kernel/smp.c
+++ b/arch/s390/kernel/smp.c
@@ -577,39 +577,27 @@ static void smp_ctl_bit_callback(void *info)
 }
 
 static DEFINE_SPINLOCK(ctl_lock);
-static unsigned long ctlreg;
 
-/*
- * Set a bit in a control register of all cpus
- */
-void smp_ctl_set_bit(int cr, int bit)
+void smp_ctl_set_clear_bit(int cr, int bit, bool set)
 {
-       struct ec_creg_mask_parms parms = { 1UL << bit, -1UL, cr };
-
-       spin_lock(&ctl_lock);
-       memcpy_absolute(&ctlreg, &S390_lowcore.cregs_save_area[cr], sizeof(ctlreg));
-       __set_bit(bit, &ctlreg);
-       memcpy_absolute(&S390_lowcore.cregs_save_area[cr], &ctlreg, sizeof(ctlreg));
-       spin_unlock(&ctl_lock);
-       on_each_cpu(smp_ctl_bit_callback, &parms, 1);
-}
-EXPORT_SYMBOL(smp_ctl_set_bit);
-
-/*
- * Clear a bit in a control register of all cpus
- */
-void smp_ctl_clear_bit(int cr, int bit)
-{
-       struct ec_creg_mask_parms parms = { 0, ~(1UL << bit), cr };
+       struct ec_creg_mask_parms parms = { .cr = cr, };
+       u64 ctlreg;
 
+       if (set) {
+               parms.orval = 1UL << bit;
+               parms.andval = -1UL;
+       } else {
+               parms.orval = 0;
+               parms.andval = ~(1UL << bit);
+       }
        spin_lock(&ctl_lock);
        memcpy_absolute(&ctlreg, &S390_lowcore.cregs_save_area[cr], sizeof(ctlreg));
-       __clear_bit(bit, &ctlreg);
+       ctlreg = (ctlreg & parms.andval) | parms.orval;
        memcpy_absolute(&S390_lowcore.cregs_save_area[cr], &ctlreg, sizeof(ctlreg));
        spin_unlock(&ctl_lock);
        on_each_cpu(smp_ctl_bit_callback, &parms, 1);
 }
-EXPORT_SYMBOL(smp_ctl_clear_bit);
+EXPORT_SYMBOL(smp_ctl_set_clear_bit);
 
 #ifdef CONFIG_CRASH_DUMP