PCI: exynos: Correct generic PHY usage

The proper initialization for generic PHYs is to call first phy_init(),
then phy_power_on().

While touching this, remove the phy_reset() call. It is just a left-over
from the obsoleted Exynos5440 support and the current exynos-pcie PHY
driver doesn't even support this function. It is also rarely used by other
drivers.

Link: https://lore.kernel.org/r/20220628220409.26545-2-m.szyprowski@samsung.com
Reported-by: Bjorn Helgaas <helgaas@kernel.org>
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
index 2ede426e3295fc6f30de6c8b51df8a1ef3b35efe..3786946cb09e85c8aba9fe15b95b0dac4f766ea7 100644 (file)
--- a/drivers/pci/controller/dwc/pci-exynos.c
+++ b/drivers/pci/controller/dwc/pci-exynos.c
@@ -258,9 +258,8 @@ static int exynos_pcie_host_init(struct dw_pcie_rp *pp)
 
        exynos_pcie_assert_core_reset(ep);
 
-       phy_reset(ep->phy);
-       phy_power_on(ep->phy);
        phy_init(ep->phy);
+       phy_power_on(ep->phy);
 
        exynos_pcie_deassert_core_reset(ep);
        exynos_pcie_enable_irq_pulse(ep);