]> git.baikalelectronics.ru Git - kernel.git/commitdiff
idr: fix RCU lockdep splat in idr_get_next()
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Tue, 8 Jun 2010 00:09:45 +0000 (17:09 -0700)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 23 Jun 2010 13:50:45 +0000 (06:50 -0700)
Convert to rcu_dereference_raw() given that many callers may have many
different locking models.

Located-by: Miles Lane <miles.lane@gmail.com>
Tested-by: Miles Lane <miles.lane@gmail.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
lib/idr.c

index c1a2069017614e6f95a7c2a892fcca1c9c2a7ff1..7f1a4f0acf50e280f5505779bd90f2dda1b97960 100644 (file)
--- a/lib/idr.c
+++ b/lib/idr.c
@@ -602,7 +602,7 @@ void *idr_get_next(struct idr *idp, int *nextidp)
        /* find first ent */
        n = idp->layers * IDR_BITS;
        max = 1 << n;
-       p = rcu_dereference(idp->top);
+       p = rcu_dereference_raw(idp->top);
        if (!p)
                return NULL;
 
@@ -610,7 +610,7 @@ void *idr_get_next(struct idr *idp, int *nextidp)
                while (n > 0 && p) {
                        n -= IDR_BITS;
                        *paa++ = p;
-                       p = rcu_dereference(p->ary[(id >> n) & IDR_MASK]);
+                       p = rcu_dereference_raw(p->ary[(id >> n) & IDR_MASK]);
                }
 
                if (p) {