]> git.baikalelectronics.ru Git - kernel.git/commitdiff
net: dsa: lan9303: fix reset on probe
authorMans Rullgard <mans@mansr.com>
Wed, 9 Feb 2022 14:54:54 +0000 (14:54 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 11 Feb 2022 22:22:20 +0000 (14:22 -0800)
The reset input to the LAN9303 chip is active low, and devicetree
gpio handles reflect this.  Therefore, the gpio should be requested
with an initial state of high in order for the reset signal to be
asserted.  Other uses of the gpio already use the correct polarity.

Fixes: 3bbb5663f4fc ("net: dsa: add new DSA switch driver for the SMSC-LAN9303")
Signed-off-by: Mans Rullgard <mans@mansr.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fianelil <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220209145454.19749-1-mans@mansr.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/lan9303-core.c

index d55784d19fa4d80326d3de0735806950144f02c9..873a5588171bf32eb3de16439d0ab44700cf99cc 100644 (file)
@@ -1310,7 +1310,7 @@ static int lan9303_probe_reset_gpio(struct lan9303 *chip,
                                     struct device_node *np)
 {
        chip->reset_gpio = devm_gpiod_get_optional(chip->dev, "reset",
-                                                  GPIOD_OUT_LOW);
+                                                  GPIOD_OUT_HIGH);
        if (IS_ERR(chip->reset_gpio))
                return PTR_ERR(chip->reset_gpio);