]> git.baikalelectronics.ru Git - kernel.git/commitdiff
selftests/powerpc: Fix "no_handler" EBB selftest
authorAthira Rajeev <atrajeev@linux.vnet.ibm.com>
Tue, 25 May 2021 13:51:42 +0000 (09:51 -0400)
committerMichael Ellerman <mpe@ellerman.id.au>
Wed, 16 Jun 2021 14:09:11 +0000 (00:09 +1000)
The "no_handler_test" in ebb selftests attempts to read the PMU
registers twice via helper function "dump_ebb_state". First dump is
just before closing of event and the second invocation is done after
closing of the event. The original intention of second
dump_ebb_state was to dump the state of registers at the end of
the test when the counters are frozen. But this will be achieved
with the first call itself since sample period is set to low value
and PMU will be frozen by then. Hence patch removes the
dump which was done before closing of the event.

Reported-by: Shirisha Ganta <shirisha.ganta1@ibm.com>
Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Tested-by: Nageswara R Sastry <rnsastry@linux.ibm.com <mailto:rnsastry@linux.ibm.com>>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1621950703-1532-2-git-send-email-atrajeev@linux.vnet.ibm.com
tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c

index fc5bf4870d8e65f4cf582fbcd69cf42eae3a5571..01e827c31169dbea8f892aa807df882862008389 100644 (file)
@@ -50,8 +50,6 @@ static int no_handler_test(void)
 
        event_close(&event);
 
-       dump_ebb_state();
-
        /* The real test is that we never took an EBB at 0x0 */
 
        return 0;