]> git.baikalelectronics.ru Git - kernel.git/commitdiff
amt: fix wrong return type of amt_send_membership_update()
authorTaehee Yoo <ap420073@gmail.com>
Sun, 9 Jan 2022 16:37:02 +0000 (16:37 +0000)
committerJakub Kicinski <kuba@kernel.org>
Mon, 10 Jan 2022 00:36:12 +0000 (16:36 -0800)
amt_send_membership_update() would return -1 but it's return type is bool.
So, it should be used TRUE instead of -1.

Fixes: 19284cc854b3 ("amt: add data plane of amt interface")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Link: https://lore.kernel.org/r/20220109163702.6331-1-ap420073@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/amt.c

index b732ee9a50ef948bd4fe30a32f9870ceb2ba0517..d3a9dda6c7286beb624644199c4ba3bde8087bd6 100644 (file)
@@ -1106,7 +1106,7 @@ static bool amt_send_membership_query(struct amt_dev *amt,
        rt = ip_route_output_key(amt->net, &fl4);
        if (IS_ERR(rt)) {
                netdev_dbg(amt->dev, "no route to %pI4\n", &tunnel->ip4);
-               return -1;
+               return true;
        }
 
        amtmq           = skb_push(skb, sizeof(*amtmq));