]> git.baikalelectronics.ru Git - kernel.git/commitdiff
drm/bridge: tc358767: Move bridge ops setup into tc_probe_edp_bridge_endpoint()
authorMarek Vasut <marex@denx.de>
Tue, 29 Mar 2022 08:50:12 +0000 (10:50 +0200)
committerRobert Foss <robert.foss@linaro.org>
Thu, 31 Mar 2022 13:59:10 +0000 (15:59 +0200)
The bridge ops are specific to the bridge configuration, move them
into tc_probe_edp_bridge_endpoint() to permit cleaner addition of
DSI-to-DPI mode. No functional change.

Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Tested-by: Lucas Stach <l.stach@pengutronix.de> # In both DPI to eDP and DSI to DPI mode.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220329085015.39159-9-marex@denx.de
drivers/gpu/drm/bridge/tc358767.c

index 1f4b962502c7c302049f16c6016dfeaae194ad03..470f3e9c76fcd5f397c73a7bc4c555e47de2ed9f 100644 (file)
@@ -1613,6 +1613,11 @@ static int tc_probe_edp_bridge_endpoint(struct tc_data *tc)
                tc->bridge.type = DRM_MODE_CONNECTOR_DisplayPort;
        }
 
+       tc->bridge.funcs = &tc_edp_bridge_funcs;
+       if (tc->hpd_pin >= 0)
+               tc->bridge.ops |= DRM_BRIDGE_OP_DETECT;
+       tc->bridge.ops |= DRM_BRIDGE_OP_EDID;
+
        return ret;
 }
 
@@ -1742,11 +1747,6 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
        if (ret)
                return ret;
 
-       tc->bridge.funcs = &tc_edp_bridge_funcs;
-       if (tc->hpd_pin >= 0)
-               tc->bridge.ops |= DRM_BRIDGE_OP_DETECT;
-       tc->bridge.ops |= DRM_BRIDGE_OP_EDID;
-
        tc->bridge.of_node = dev->of_node;
        drm_bridge_add(&tc->bridge);